)]}'
{"octavia/controller/worker/v2/tasks/amphora_driver_tasks.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"30e887038d181a706adfbeed65af0f268f654a18","unresolved":true,"context_lines":[{"line_number":272,"context_line":"                host_routes \u003d subnet_arg.get(\u0027host_routes\u0027)"},{"line_number":273,"context_line":"                if host_routes:"},{"line_number":274,"context_line":"                    subnet_arg[\u0027host_routes\u0027] \u003d ["},{"line_number":275,"context_line":"                        data_models.HostRoute(*hr)"},{"line_number":276,"context_line":"                        for hr in host_routes"},{"line_number":277,"context_line":"                    ]"},{"line_number":278,"context_line":"                fixed_ips.append(data_models.Subnet(**subnet_arg, **ip))"}],"source_content_type":"text/x-python","patch_set":1,"id":"68ef88ab_842f6a36","line":275,"range":{"start_line":275,"start_character":46,"end_line":275,"end_character":49},"updated":"2021-03-22 23:50:01.000000000","message":"This looks like it should be **hr based on below code","commit_id":"8d8dadd2ada9730d5528a36353e10cfdf0d5fcf3"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"eb2af16fd45f30cb821b0daaa333027b72d1403a","unresolved":true,"context_lines":[{"line_number":272,"context_line":"                host_routes \u003d subnet_arg.get(\u0027host_routes\u0027)"},{"line_number":273,"context_line":"                if host_routes:"},{"line_number":274,"context_line":"                    subnet_arg[\u0027host_routes\u0027] \u003d ["},{"line_number":275,"context_line":"                        data_models.HostRoute(*hr)"},{"line_number":276,"context_line":"                        for hr in host_routes"},{"line_number":277,"context_line":"                    ]"},{"line_number":278,"context_line":"                fixed_ips.append(data_models.Subnet(**subnet_arg, **ip))"}],"source_content_type":"text/x-python","patch_set":1,"id":"aab07762_743b7a37","line":275,"range":{"start_line":275,"start_character":46,"end_line":275,"end_character":49},"in_reply_to":"68ef88ab_842f6a36","updated":"2021-03-23 08:01:07.000000000","message":"Hmmm... I was too lazy to write the unit tests that would have caught it :/\nSo I\u0027m now adding the tests, Thanks Brian!","commit_id":"8d8dadd2ada9730d5528a36353e10cfdf0d5fcf3"}],"octavia/tests/unit/controller/worker/v2/tasks/test_amphora_driver_tasks.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"00ba6b510807029e0625c73fa8e2628764b7a694","unresolved":true,"context_lines":[{"line_number":441,"context_line":"                                     network_data_models.Port(**port_mock))"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        call_args \u003d mock_driver.post_network_plug.call_args[0]"},{"line_number":444,"context_line":"        port_arg \u003d call_args[1]"},{"line_number":445,"context_line":"        subnet_arg \u003d port_arg.fixed_ips[0].subnet"},{"line_number":446,"context_line":"        self.assertEqual(2, len(subnet_arg.host_routes))"},{"line_number":447,"context_line":"        for hr1, hr2 in zip(host_routes, subnet_arg.host_routes):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fbcc19fe_9eced431","line":444,"updated":"2021-03-23 16:40:35.000000000","message":"nit: since call_args is never used except here can this just be:\n\nport_arg \u003d mock_driver.post_network_plug.call_args[0][1]","commit_id":"d0ec3aaf23eba0ffc8fe7bc86b51d4857e0cc507"}]}