)]}'
{"octavia/common/config.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a7a01b85bd2e498c525c88a97f15bfdab43bcaae","unresolved":true,"context_lines":[{"line_number":609,"context_line":"               default\u003d\u0027publicURL\u0027,"},{"line_number":610,"context_line":"               help\u003d\u0027The endpoint_type to be used for barbican service.\u0027),"},{"line_number":611,"context_line":"    cfg.StrOpt(\u0027ca_certificates_file\u0027,"},{"line_number":612,"context_line":"               help\u003d_(\u0027CA certificates file path for the Barbican API\u0027)),"},{"line_number":613,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":614,"context_line":"                default\u003dFalse,"},{"line_number":615,"context_line":"                help\u003d_(\u0027Disable certificate validation on SSL connections \u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a4bede7_4cb46891","line":612,"updated":"2021-04-01 18:08:54.000000000","message":"This option is never mentioned in the etc/octavia.conf example file. I\u0027d be fine with an update of that separately as it looks like there are other differences in help text strings that could probably all be updated at once.","commit_id":"8bef15b520235d839d22346a09a1a562049a7448"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c81a71dae9ad5fbec121d259e7fce9ab2bcde01a","unresolved":true,"context_lines":[{"line_number":609,"context_line":"               default\u003d\u0027publicURL\u0027,"},{"line_number":610,"context_line":"               help\u003d\u0027The endpoint_type to be used for barbican service.\u0027),"},{"line_number":611,"context_line":"    cfg.StrOpt(\u0027ca_certificates_file\u0027,"},{"line_number":612,"context_line":"               help\u003d_(\u0027CA certificates file path for the Barbican API\u0027)),"},{"line_number":613,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":614,"context_line":"                default\u003dFalse,"},{"line_number":615,"context_line":"                help\u003d_(\u0027Disable certificate validation on SSL connections \u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"db274315_9f6d491c","line":612,"in_reply_to":"3a4bede7_4cb46891","updated":"2021-04-01 23:10:44.000000000","message":"Yeah, I think we should update the example etc/octavia.conf for this setting as well.\n\nOne other thing to note is this is used for other certificate backends than just Barbican. It will be used for castellan/Vault as well. So we should keep this generic. Maybe:\n\n\"CA certificates file path for the secure store endpoint.\" ???\n\nReally this whole section is a mess IMO, it blurs the line with the certificate manager settings in a bad way and is poorly documented.","commit_id":"8bef15b520235d839d22346a09a1a562049a7448"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a61bb709336e2c5f935b9c4c7b7590101b9d4b6","unresolved":true,"context_lines":[{"line_number":604,"context_line":"                                  \u0027in the keystone catalog.\u0027)),"},{"line_number":605,"context_line":"    cfg.StrOpt(\u0027region_name\u0027,"},{"line_number":606,"context_line":"               help\u003d\u0027Region in Identity service catalog to use for \u0027"},{"line_number":607,"context_line":"                    \u0027communication with the barbican service.\u0027),"},{"line_number":608,"context_line":"    cfg.StrOpt(\u0027endpoint_type\u0027,"},{"line_number":609,"context_line":"               default\u003d\u0027publicURL\u0027,"},{"line_number":610,"context_line":"               help\u003d\u0027The endpoint_type to be used for barbican service.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"c65debd9_35e6c99d","line":607,"range":{"start_line":607,"start_character":44,"end_line":607,"end_character":52},"updated":"2021-04-05 19:39:04.000000000","message":"Since you used \u0027key manager\u0027 below, this and right below should change.","commit_id":"ee0da827b163c15796bf2f19b0785bc0259d5128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1aaf7a17d91c1ac921d23412120618378263042d","unresolved":true,"context_lines":[{"line_number":604,"context_line":"                                  \u0027in the keystone catalog.\u0027)),"},{"line_number":605,"context_line":"    cfg.StrOpt(\u0027region_name\u0027,"},{"line_number":606,"context_line":"               help\u003d\u0027Region in Identity service catalog to use for \u0027"},{"line_number":607,"context_line":"                    \u0027communication with the barbican service.\u0027),"},{"line_number":608,"context_line":"    cfg.StrOpt(\u0027endpoint_type\u0027,"},{"line_number":609,"context_line":"               default\u003d\u0027publicURL\u0027,"},{"line_number":610,"context_line":"               help\u003d\u0027The endpoint_type to be used for barbican service.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"71b383e6_e1170456","line":607,"range":{"start_line":607,"start_character":44,"end_line":607,"end_character":52},"in_reply_to":"c65debd9_35e6c99d","updated":"2021-04-06 16:15:57.000000000","message":"Maybe this should be opened as a bug since this is not related to this change.","commit_id":"ee0da827b163c15796bf2f19b0785bc0259d5128"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5a61bb709336e2c5f935b9c4c7b7590101b9d4b6","unresolved":true,"context_lines":[{"line_number":613,"context_line":"                      \u0027(such as Barbican).\u0027)),"},{"line_number":614,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":615,"context_line":"                default\u003dFalse,"},{"line_number":616,"context_line":"                help\u003d_(\u0027Disable certificate validation on SSL connections \u0027)),"},{"line_number":617,"context_line":"]"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"house_keeping_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"88a8b9a7_1d608132","line":616,"range":{"start_line":616,"start_character":73,"end_line":616,"end_character":74},"updated":"2021-04-05 19:39:04.000000000","message":"nit: should be a period","commit_id":"ee0da827b163c15796bf2f19b0785bc0259d5128"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1aaf7a17d91c1ac921d23412120618378263042d","unresolved":true,"context_lines":[{"line_number":613,"context_line":"                      \u0027(such as Barbican).\u0027)),"},{"line_number":614,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":615,"context_line":"                default\u003dFalse,"},{"line_number":616,"context_line":"                help\u003d_(\u0027Disable certificate validation on SSL connections \u0027)),"},{"line_number":617,"context_line":"]"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"house_keeping_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"877a1eca_f51f562a","line":616,"range":{"start_line":616,"start_character":73,"end_line":616,"end_character":74},"in_reply_to":"88a8b9a7_1d608132","updated":"2021-04-06 16:15:57.000000000","message":"Maybe this should be opened as a bug since this is not related to this change.","commit_id":"ee0da827b163c15796bf2f19b0785bc0259d5128"}]}