)]}'
{"id":"openstack%2Foctavia~784387","triplet_id":"openstack%2Foctavia~master~I5780ee09e47486fc617c2bf8bdf693e95c98d5bc","project":"openstack/octavia","branch":"master","hashtags":[],"change_id":"I5780ee09e47486fc617c2bf8bdf693e95c98d5bc","subject":"Mark [health_manager]/heartbeat_key as a required config option","status":"NEW","created":"2021-04-01 12:31:13.000000000","updated":"2021-04-08 11:36:40.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4ee829c99e0721987f808d5d5f89512c47bd51c6","_number":784387,"virtual_id_number":784387,"owner":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-04-01 18:04:25.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-01 17:59:23.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2021-04-01 18:04:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-08 09:22:37.000000000","updated_by":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"reviewer":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"state":"CC"}],"messages":[{"id":"a6af45fcc7e62f3af36a6a5b458122ba310be273","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2021-04-01 12:31:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c851dfb1e2a04cc0e05288770a8be552ab36b92c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-01 18:04:25.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f88a76e344bf412db96246f57b9dc5bb : FAILURE in 9m 31s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9062253769f944e7a1696a22c75a5a9e : FAILURE in 6m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b2aeda3b50c046058fa6fa1f5ef6a5c6 : SUCCESS in 7m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3efcf1f1bd8940bc840281699be1cb36 : FAILURE in 7m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/35a1268f795046f6b996c746396bfbd8 : FAILURE in 8m 14s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/766d10445e2c4192b2d78814006a7649 : FAILURE in 6m 21s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d9ca851dacd14a36b9b60852f6e03dc0 : SUCCESS in 12m 51s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/77a123fa9967499ca245dc4dc7985da7 : SUCCESS in 7m 01s\n- octavia-tox-py37-tips https://zuul.opendev.org/t/openstack/build/bfa95e18c1d64ed3a343b66ee0a43d6f : FAILURE in 11m 47s\n- octavia-tox-functional-py37-tips https://zuul.opendev.org/t/openstack/build/c389e34b30ae430fb7d97be4eed5877b : FAILURE in 7m 42s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/054951196b0f499d862743a3b75c99c7 : SUCCESS in 6m 19s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/b0da8d94ccc94bfeb75da63e5d9b7350 : FAILURE in 7m 24s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/4bad7c107adf484580a2961c25bb6b35 : SUCCESS in 1h 23m 14s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/89f617638c5349639b588af5e693dad8 : SUCCESS in 2h 05m 11s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/877953dd9dfe4411a92509bae05d0898 : SUCCESS in 51m 22s\n- octavia-v2-dsvm-spare-pool https://zuul.opendev.org/t/openstack/build/f623022edca3480d9bb4b96ae8ae8772 : SUCCESS in 1h 10m 47s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/f22a651af4a34605b3708c9e5d6375e4 : SUCCESS in 48m 55s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/ac7c51d7ea59437e8910ce699b05c962 : SUCCESS in 1h 10m 25s\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/e606b4e0981f4ee785989994e0f0b974 : SUCCESS in 1h 32m 24s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/df11ff916b35473c8d0d111024a7eebb : FAILURE in 1h 03m 59s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/6da3142761854e06a0cf6dcd83dce60c : SUCCESS in 2h 16m 01s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2 https://zuul.opendev.org/t/openstack/build/ec04781b530b4f61b9b3bd0dc9b8ba4a : SUCCESS in 2h 23m 37s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2-no-jobboard https://zuul.opendev.org/t/openstack/build/ca8efdec54b14fbaa98d78738f685481 : SUCCESS in 1h 56m 35s (non-voting)\n- octavia-v2-dsvm-scenario-centos-8 https://zuul.opendev.org/t/openstack/build/76eff83a1bca4ceeb6f880e6c570f9ac : FAILURE in 41m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a429839dbf627d9b8e7fac76e23cafcd6d8549ba","author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"date":"2021-04-08 09:22:37.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"f3ac8134a4bdb1137057bc726b475302cdcbef56","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2021-04-08 09:26:08.000000000","message":"Patch Set 1:\n\nCurrently broken, I need to update all the unit tests that use octavia config to add the new required option there :/","accounts_in_message":[],"_revision_number":1},{"id":"4ee829c99e0721987f808d5d5f89512c47bd51c6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-08 11:36:40.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bea52f7d10bc4ead9310d8b0f470a78d : FAILURE in 6m 31s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/837cf7a5b58645999d3f66e58fe3c567 : FAILURE in 6m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d3e1aa8254aa4272af7cf6278d590f8e : SUCCESS in 6m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/62ba0733be2d4748826c06e90c9a72da : FAILURE in 5m 52s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6b407b9153c344058729f79bca242fb6 : FAILURE in 5m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c8763ce3619b4d91b5fbfd67f782bcd8 : FAILURE in 5m 49s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3e95abc043c44c1eac4e1491fd75632b : SUCCESS in 16m 10s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6ba70e20d37d4ff184932a98dc11df5b : SUCCESS in 7m 51s\n- octavia-tox-py37-tips https://zuul.opendev.org/t/openstack/build/6422af1e2fbb47b4b786058ee5b8b8a1 : FAILURE in 6m 31s\n- octavia-tox-functional-py37-tips https://zuul.opendev.org/t/openstack/build/c990427fd8f849ea8899bd59bac2dc41 : FAILURE in 12m 49s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/2c35f98813eb4ba9a51e72dea534af44 : SUCCESS in 5m 35s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/9ed1d94303844534beebdd4f58e8e695 : FAILURE in 6m 04s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/f518b8b5c7604c8695eef074c13d977f : SUCCESS in 1h 17m 19s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/68f45b8615e44056b171980ae867dfba : SUCCESS in 1h 34m 31s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/d30b0b8a1e1e4487b918b9a562c98b2c : SUCCESS in 45m 53s\n- octavia-v2-dsvm-spare-pool https://zuul.opendev.org/t/openstack/build/8d2b759fa135499481867fc0f0048c5f : SUCCESS in 41m 25s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/f2a7dd0011d94b7b83a5ffdc93e30f90 : SUCCESS in 51m 12s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/a8a86d0d1e0642cda4ff5784dd102a11 : FAILURE in 40m 30s\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/9dd255060c9b4a43bbe77f344df7e0db : SUCCESS in 1h 26m 22s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/0ff52794e7fc4e9d9ce623e1803456de : FAILURE in 40m 01s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/e61813f6ddb94c61afc2fc5adc4b93b0 : SUCCESS in 2h 07m 56s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2 https://zuul.opendev.org/t/openstack/build/b7d3f9eb121c48d7ba74cde014d63961 : SUCCESS in 1h 48m 17s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2-no-jobboard https://zuul.opendev.org/t/openstack/build/b0ead47b33c14f7fa9d149152eb5fd6e : SUCCESS in 1h 47m 42s (non-voting)\n- octavia-v2-dsvm-scenario-centos-8 https://zuul.opendev.org/t/openstack/build/5a2c0b9d68cc4bed980fb53e99ddcbdb : FAILURE in 30m 56s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6ca3c1cb7040a6ce9c33ea555f6d747efde55f1d","revisions":{"6ca3c1cb7040a6ce9c33ea555f6d747efde55f1d":{"kind":"REWORK","_number":1,"created":"2021-04-01 12:31:13.000000000","uploader":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"ref":"refs/changes/87/784387/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/87/784387/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/87/784387/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/87/784387/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/87/784387/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/87/784387/1"}}},"commit":{"parents":[{"commit":"c4c5c0b82a9ad08884782a505b63468899d4570d","subject":"Merge \"Update master for stable/wallaby\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/c4c5c0b82a9ad08884782a505b63468899d4570d"}]}],"author":{"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","date":"2021-04-01 08:57:24.000000000","tz":120},"committer":{"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","date":"2021-04-01 12:30:38.000000000","tz":120},"subject":"Mark [health_manager]/heartbeat_key as a required config option","message":"Mark [health_manager]/heartbeat_key as a required config option\n\n[health_manager]/heartbeat_key was not required and doesn\u0027t have any\ndefault value. So in case that setting was missing from the\nconfiguration file, the key was defaulted to None which triggers 2\nissues: security issue because the key is weak, and functional issue\nbecause a bug prevents using None as an encryption key for communication\nbetween the amphora-agent and the health-manager.\n\nChange-Id: I5780ee09e47486fc617c2bf8bdf693e95c98d5bc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/6ca3c1cb7040a6ce9c33ea555f6d747efde55f1d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/6ca3c1cb7040a6ce9c33ea555f6d747efde55f1d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}