)]}'
{"doc/source/user/guides/basic-cookbook.rst":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9782815ba7122cb110140bbc4899606578c694ce","unresolved":true,"context_lines":[{"line_number":841,"context_line":"health monitor, failed servers are not removed from the pool. This can lead to"},{"line_number":842,"context_line":"service disruption for web clients."},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"See also the command, `loadbalancer healthmonitor create \u003chttps://docs.openstack.org/python-openstackclient/latest/cli/plugin-commands/octavia.html#loadbalancer-healthmonitor-create\u003e`_."},{"line_number":845,"context_line":""},{"line_number":846,"context_line":".. _all-health-monitors:"},{"line_number":847,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"42fc2e2a_9c9750d2","line":844,"range":{"start_line":844,"start_character":58,"end_line":844,"end_character":181},"updated":"2021-04-23 21:38:22.000000000","message":"I think this should point to our docs: https://docs.openstack.org/python-octaviaclient/latest/cli/index.html#loadbalancer-healthmonitor-create\n\nThe openstackclient docs are pulling in our documentation and may break this path by changes in the openstack client documentation. With it pointing directly to the source docs, this link is less likely to break.","commit_id":"4da00a12e3e834a55dc5e1a94f3699dc112fe3cc"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"4defdd27d97ec82d237eeb9e1a2a3babf2e34747","unresolved":false,"context_lines":[{"line_number":841,"context_line":"health monitor, failed servers are not removed from the pool. This can lead to"},{"line_number":842,"context_line":"service disruption for web clients."},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"See also the command, `loadbalancer healthmonitor create \u003chttps://docs.openstack.org/python-openstackclient/latest/cli/plugin-commands/octavia.html#loadbalancer-healthmonitor-create\u003e`_."},{"line_number":845,"context_line":""},{"line_number":846,"context_line":".. _all-health-monitors:"},{"line_number":847,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"4f93a6a4_4e2f6c28","line":844,"range":{"start_line":844,"start_character":58,"end_line":844,"end_character":181},"in_reply_to":"42fc2e2a_9c9750d2","updated":"2021-04-26 15:45:21.000000000","message":"Ack","commit_id":"4da00a12e3e834a55dc5e1a94f3699dc112fe3cc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7a384ddd4d81c20e9605517b72aaa1f295d3b423","unresolved":true,"context_lines":[{"line_number":848,"context_line":"Configuration arguments for all health monitors"},{"line_number":849,"context_line":"-----------------------------------------------"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"*All* health monitor types for Octavia require the following configurable"},{"line_number":852,"context_line":"arguments:"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"* ``delay``: Number of seconds to wait between health checks."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5197d288_d239de76","line":851,"range":{"start_line":851,"start_character":0,"end_line":851,"end_character":5},"updated":"2021-04-23 20:33:48.000000000","message":"nit: not sure this needs to be in italics, but just my opinion.","commit_id":"4da00a12e3e834a55dc5e1a94f3699dc112fe3cc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9782815ba7122cb110140bbc4899606578c694ce","unresolved":true,"context_lines":[{"line_number":848,"context_line":"Configuration arguments for all health monitors"},{"line_number":849,"context_line":"-----------------------------------------------"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"*All* health monitor types for Octavia require the following configurable"},{"line_number":852,"context_line":"arguments:"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"* ``delay``: Number of seconds to wait between health checks."}],"source_content_type":"text/x-rst","patch_set":3,"id":"b77a36c0_a4ab8fe7","line":851,"range":{"start_line":851,"start_character":0,"end_line":851,"end_character":5},"in_reply_to":"5197d288_d239de76","updated":"2021-04-23 21:38:22.000000000","message":"Yeah, I agree. We should limit the use of italics.\nIt\u0027s a slippery slope to comic sans, lol.","commit_id":"4da00a12e3e834a55dc5e1a94f3699dc112fe3cc"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"4defdd27d97ec82d237eeb9e1a2a3babf2e34747","unresolved":false,"context_lines":[{"line_number":848,"context_line":"Configuration arguments for all health monitors"},{"line_number":849,"context_line":"-----------------------------------------------"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"*All* health monitor types for Octavia require the following configurable"},{"line_number":852,"context_line":"arguments:"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"* ``delay``: Number of seconds to wait between health checks."}],"source_content_type":"text/x-rst","patch_set":3,"id":"f520d92b_9346faa3","line":851,"range":{"start_line":851,"start_character":0,"end_line":851,"end_character":5},"in_reply_to":"b77a36c0_a4ab8fe7","updated":"2021-04-26 15:45:21.000000000","message":"Ack","commit_id":"4da00a12e3e834a55dc5e1a94f3699dc112fe3cc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9782815ba7122cb110140bbc4899606578c694ce","unresolved":true,"context_lines":[{"line_number":876,"context_line":"  check. By default this is just \"200\"."},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"For a complete list of configuration arguments for Octavia health monitors, see"},{"line_number":879,"context_line":"the command, `loadbalancer healthmonitor create \u003chttps://docs.openstack.org/python-openstackclient/latest/cli/plugin-commands/octavia.html#loadbalancer-healthmonitor-create\u003e`_."},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"Please keep the following best practices in mind when writing the code that"},{"line_number":882,"context_line":"generates the health check in your web application:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6a25e87c_744e40c9","line":879,"range":{"start_line":879,"start_character":49,"end_line":879,"end_character":172},"updated":"2021-04-23 21:38:22.000000000","message":"Again, I would recommend linking to our docs: https://docs.openstack.org/python-octaviaclient/latest/cli/index.html#loadbalancer-healthmonitor-create","commit_id":"4da00a12e3e834a55dc5e1a94f3699dc112fe3cc"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"4defdd27d97ec82d237eeb9e1a2a3babf2e34747","unresolved":false,"context_lines":[{"line_number":876,"context_line":"  check. By default this is just \"200\"."},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"For a complete list of configuration arguments for Octavia health monitors, see"},{"line_number":879,"context_line":"the command, `loadbalancer healthmonitor create \u003chttps://docs.openstack.org/python-openstackclient/latest/cli/plugin-commands/octavia.html#loadbalancer-healthmonitor-create\u003e`_."},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"Please keep the following best practices in mind when writing the code that"},{"line_number":882,"context_line":"generates the health check in your web application:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c90ae2e1_927acfc9","line":879,"range":{"start_line":879,"start_character":49,"end_line":879,"end_character":172},"in_reply_to":"6a25e87c_744e40c9","updated":"2021-04-26 15:45:21.000000000","message":"Ack","commit_id":"4da00a12e3e834a55dc5e1a94f3699dc112fe3cc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7e1e7a02a48134d5a8185652c50bdc28e8092ca0","unresolved":true,"context_lines":[{"line_number":829,"context_line":"Health Monitor Best Practices"},{"line_number":830,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":831,"context_line":"An Octavia health monitor is a process that does periodic health checks on each"},{"line_number":832,"context_line":"back-end member server to pre-emptively detect failed servers and temporarily"},{"line_number":833,"context_line":"pull them out of the pool."},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"If the health monitor detects a failed server, it removes the server"}],"source_content_type":"text/x-rst","patch_set":4,"id":"2aa4b8fe_2f4b1977","line":832,"range":{"start_line":832,"start_character":9,"end_line":832,"end_character":22},"updated":"2021-05-03 19:58:47.000000000","message":"I wonder if always just using the word \u0027member\u0027 and not \u0027server\u0027 is better, as it implies a more generic object, and is the name used in Octavia, i.e. \u0027pool member\u0027.  Plus it might not be a server at all, but maybe a pod 😊  Would apply below as well.\n\nI\u0027d see what Michael thinks before changing it.","commit_id":"fcee1b14d9f63ce1441ca7c1b0767d729d33dc1b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"96c3ae02fb834cde0fbbb1c80682977c35fb680b","unresolved":true,"context_lines":[{"line_number":829,"context_line":"Health Monitor Best Practices"},{"line_number":830,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":831,"context_line":"An Octavia health monitor is a process that does periodic health checks on each"},{"line_number":832,"context_line":"back-end member server to pre-emptively detect failed servers and temporarily"},{"line_number":833,"context_line":"pull them out of the pool."},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"If the health monitor detects a failed server, it removes the server"}],"source_content_type":"text/x-rst","patch_set":4,"id":"56839e94_70750c10","line":832,"range":{"start_line":832,"start_character":9,"end_line":832,"end_character":22},"in_reply_to":"2aa4b8fe_2f4b1977","updated":"2021-05-03 22:12:52.000000000","message":"Yeah, you are right. A member could point to www.redhat.com and be fine too.\nFor me, the key is to have the \"member\" word, which is consistent across our API and docs.\nAdding \"server\", is not perfect, but a nit and not critical IMO.","commit_id":"fcee1b14d9f63ce1441ca7c1b0767d729d33dc1b"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"418eef262b49a92dc6a2c5ae47f32b186eaddf31","unresolved":true,"context_lines":[{"line_number":865,"context_line":"------------------------------------------------"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"In addition to the arguments listed earlier in :ref:`all-health-monitors`, HTTP"},{"line_number":868,"context_line":"health monitor types *also* require the following arguments, which are set by"},{"line_number":869,"context_line":"default:"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"* ``url-path``: Path part of the URL that should be retrieved from the back-end"}],"source_content_type":"text/x-rst","patch_set":5,"id":"580f6ae3_0028bf69","line":868,"range":{"start_line":868,"start_character":28,"end_line":868,"end_character":35},"updated":"2021-07-02 19:58:36.000000000","message":"probably nit: it seems strange to say \"require\" while they all have default value.","commit_id":"a26494bfcb6f95a390af890d6d2bd054769a4136"}]}