)]}'
{"octavia/controller/worker/v2/controller_worker.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a137bb815e565170e03c0490f7ae65e2a5fadb3b","unresolved":true,"context_lines":[{"line_number":455,"context_line":"            LOG.warning(\u0027Failed to fetch %s %s from DB. Retrying for up to \u0027"},{"line_number":456,"context_line":"                        \u002760 seconds.\u0027, \u0027l7member\u0027,"},{"line_number":457,"context_line":"                        member[constants.MEMBER_ID])"},{"line_number":458,"context_line":"            raise db_exceptions.NoResultFound"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        pool \u003d db_member.pool"},{"line_number":461,"context_line":"        load_balancer \u003d pool.load_balancer"}],"source_content_type":"text/x-python","patch_set":1,"id":"a0171483_1510cb3e","line":458,"updated":"2021-05-03 19:18:36.000000000","message":"The warning and code looks similar to the other methods here.  I\u0027m assuming the 60 seconds is based on the tenacity values wrapping this and probably correct based on the default values, but might be incorrect if they were changed.  It\u0027s only a nit but would be better to dynamically calculate throughout the file.","commit_id":"cd272ae5a948c22e26b0ea678ea452f559e14d62"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"08d28bfbf9c0732a55cee4b550c0dcc03e7b7c09","unresolved":true,"context_lines":[{"line_number":455,"context_line":"            LOG.warning(\u0027Failed to fetch %s %s from DB. Retrying for up to \u0027"},{"line_number":456,"context_line":"                        \u002760 seconds.\u0027, \u0027l7member\u0027,"},{"line_number":457,"context_line":"                        member[constants.MEMBER_ID])"},{"line_number":458,"context_line":"            raise db_exceptions.NoResultFound"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        pool \u003d db_member.pool"},{"line_number":461,"context_line":"        load_balancer \u003d pool.load_balancer"}],"source_content_type":"text/x-python","patch_set":1,"id":"f6c9e0d2_b45028d3","line":458,"in_reply_to":"a0171483_1510cb3e","updated":"2021-05-05 10:53:04.000000000","message":"Good catch, but I would do this in a separate commit for all file at once.","commit_id":"cd272ae5a948c22e26b0ea678ea452f559e14d62"}],"octavia/tests/unit/controller/worker/v2/test_controller_worker.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a137bb815e565170e03c0490f7ae65e2a5fadb3b","unresolved":true,"context_lines":[{"line_number":1052,"context_line":"            constants.L7POLICY_ID: L7POLICY_ID,"},{"line_number":1053,"context_line":"            constants.LISTENER_ID: LISTENER_ID"},{"line_number":1054,"context_line":"        }"},{"line_number":1055,"context_line":"        mock_l7policy_repo_get.side_effect \u003d [None, _l7policy_mock]"},{"line_number":1056,"context_line":"        cw.create_l7policy(l7policy_mock)"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"        (cw.services_controller.run_poster."}],"source_content_type":"text/x-python","patch_set":1,"id":"960b098b_12fb35ba","line":1055,"updated":"2021-05-03 19:18:36.000000000","message":"With my testing hat on I\u0027d say it would be better to have a test that triggers a failure, but again, this is what most of the other tests are doing.\n\nIs it worth doing an assertRaises type test?","commit_id":"cd272ae5a948c22e26b0ea678ea452f559e14d62"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3ad9e2838d8e43ce704f247f1a1be79ab3c034dd","unresolved":true,"context_lines":[{"line_number":1052,"context_line":"            constants.L7POLICY_ID: L7POLICY_ID,"},{"line_number":1053,"context_line":"            constants.LISTENER_ID: LISTENER_ID"},{"line_number":1054,"context_line":"        }"},{"line_number":1055,"context_line":"        mock_l7policy_repo_get.side_effect \u003d [None, _l7policy_mock]"},{"line_number":1056,"context_line":"        cw.create_l7policy(l7policy_mock)"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"        (cw.services_controller.run_poster."}],"source_content_type":"text/x-python","patch_set":1,"id":"b4dd27ca_2098ec6a","line":1055,"in_reply_to":"960b098b_12fb35ba","updated":"2021-05-04 07:05:07.000000000","message":"hmm, L7PolicyRepository.get returns either a models.L7Policy object or None\nIt should not throw an exception, and if it does, the exception would have to be handled in def get() and tested in the file that tests *Repository classes","commit_id":"cd272ae5a948c22e26b0ea678ea452f559e14d62"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"be0063ca1d61e24d43e372c531e359304548587b","unresolved":true,"context_lines":[{"line_number":1052,"context_line":"            constants.L7POLICY_ID: L7POLICY_ID,"},{"line_number":1053,"context_line":"            constants.LISTENER_ID: LISTENER_ID"},{"line_number":1054,"context_line":"        }"},{"line_number":1055,"context_line":"        mock_l7policy_repo_get.side_effect \u003d [None, _l7policy_mock]"},{"line_number":1056,"context_line":"        cw.create_l7policy(l7policy_mock)"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"        (cw.services_controller.run_poster."}],"source_content_type":"text/x-python","patch_set":1,"id":"a6908458_c2e13cd0","line":1055,"in_reply_to":"b4dd27ca_2098ec6a","updated":"2021-05-04 14:01:06.000000000","message":"I was thinking of the case where the .get() returns None enough times to trigger the exception in create_l7policy() since the object is never found.  It shouldn\u0027t stop this change, just thinking out loud for code coverage.","commit_id":"cd272ae5a948c22e26b0ea678ea452f559e14d62"}]}