)]}'
{"octavia/controller/worker/v1/tasks/database_tasks.py":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"dc54cdbc8428e3331c4803df5c8790d7e5bc8840","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        notification.send_listener_end_notification("},{"line_number":285,"context_line":"            ctx,"},{"line_number":286,"context_line":"            listener.to_dict(),"},{"line_number":287,"context_line":"            constants.DELETED).notify()"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def revert(self, listener, *args, **kwargs):"},{"line_number":290,"context_line":"        \"\"\"Mark the listener ERROR since the listener didn\u0027t delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"9321f7a7_6c13c6ca","line":287,"updated":"2021-08-04 11:47:56.000000000","message":"i am not sure put the code here is a good idea. from the code[0], we always call amphora_drvier_task first , if the task failed, this will trigger  taskflow revert, taksflow  will  not execute this code. this will cause user can not receive end message.\n\n[0]: https://github.com/openstack/octavia/blob/master/octavia/controller/worker/v1/flows/listener_flows.py#L65","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":33408,"name":"Pierre-Yves Jourel","email":"pierre-yves.jourel@ovhcloud.com","username":"PYJ"},"change_message_id":"aa63251b2333c0bc2be92bd1b1af7046e2a3ed3c","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        notification.send_listener_end_notification("},{"line_number":285,"context_line":"            ctx,"},{"line_number":286,"context_line":"            listener.to_dict(),"},{"line_number":287,"context_line":"            constants.DELETED).notify()"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def revert(self, listener, *args, **kwargs):"},{"line_number":290,"context_line":"        \"\"\"Mark the listener ERROR since the listener didn\u0027t delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"93cfff39_f7297f29","line":287,"in_reply_to":"9321f7a7_6c13c6ca","updated":"2021-08-04 12:59:19.000000000","message":"If the task failed, the listener is still available. So you don\u0027t need to notify the deletion. Because it\u0027s a fail, no?","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"ef6eb8fb6829bcbbc606deb0fd76fb3415862734","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        notification.send_listener_end_notification("},{"line_number":285,"context_line":"            ctx,"},{"line_number":286,"context_line":"            listener.to_dict(),"},{"line_number":287,"context_line":"            constants.DELETED).notify()"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def revert(self, listener, *args, **kwargs):"},{"line_number":290,"context_line":"        \"\"\"Mark the listener ERROR since the listener didn\u0027t delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"d90d2d9e_1fd4ac01","line":287,"in_reply_to":"93cfff39_f7297f29","updated":"2021-08-05 06:08:52.000000000","message":"i think you should send notification with error queue. if failed, octavia set listener to error status, but 3rd apps don\u0027t receive the message, they think the listener status is still actvie.","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"}],"octavia/controller/worker/v2/tasks/database_tasks.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"aefdbb2c227d2f196a2ed66bd44a61257edb6217","unresolved":true,"context_lines":[{"line_number":260,"context_line":"        )"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        ctx \u003d context.Context("},{"line_number":263,"context_line":"            project_id\u003ddb_pool[constants.PROJECT_ID],"},{"line_number":264,"context_line":"            check_admin\u003dFalse)"},{"line_number":265,"context_line":"        ctx.notification \u003d notification.MemberDelete(ctx)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8a5630b5_883f0267","line":263,"range":{"start_line":263,"start_character":23,"end_line":263,"end_character":30},"updated":"2021-08-04 06:45:09.000000000","message":"in amphorav2, db_pool is not a dict but an object\n\nthere are a bunch of errors in the amphorav2 job: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_943/803362/1/check/octavia-v2-dsvm-scenario-amphora-v2/943b75c/controller/logs/screen-o-cw.txt","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":33408,"name":"Pierre-Yves Jourel","email":"pierre-yves.jourel@ovhcloud.com","username":"PYJ"},"change_message_id":"aa63251b2333c0bc2be92bd1b1af7046e2a3ed3c","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        )"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        ctx \u003d context.Context("},{"line_number":263,"context_line":"            project_id\u003ddb_pool[constants.PROJECT_ID],"},{"line_number":264,"context_line":"            check_admin\u003dFalse)"},{"line_number":265,"context_line":"        ctx.notification \u003d notification.MemberDelete(ctx)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a16b4ae_e4c16a79","line":263,"range":{"start_line":263,"start_character":23,"end_line":263,"end_character":30},"in_reply_to":"8a5630b5_883f0267","updated":"2021-08-04 12:59:19.000000000","message":"Ack","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"aefdbb2c227d2f196a2ed66bd44a61257edb6217","unresolved":true,"context_lines":[{"line_number":309,"context_line":"        )"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        ctx \u003d context.Context("},{"line_number":312,"context_line":"            project_id\u003ddb_listener[constants.PROJECT_ID],"},{"line_number":313,"context_line":"            check_admin\u003dFalse)"},{"line_number":314,"context_line":"        ctx.notification \u003d notification.ListenerDelete(ctx)"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba1a5f21_3885256e","line":312,"range":{"start_line":312,"start_character":23,"end_line":312,"end_character":34},"updated":"2021-08-04 06:45:09.000000000","message":"same","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":33408,"name":"Pierre-Yves Jourel","email":"pierre-yves.jourel@ovhcloud.com","username":"PYJ"},"change_message_id":"aa63251b2333c0bc2be92bd1b1af7046e2a3ed3c","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        )"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        ctx \u003d context.Context("},{"line_number":312,"context_line":"            project_id\u003ddb_listener[constants.PROJECT_ID],"},{"line_number":313,"context_line":"            check_admin\u003dFalse)"},{"line_number":314,"context_line":"        ctx.notification \u003d notification.ListenerDelete(ctx)"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ae369c2_4bdb4cf9","line":312,"range":{"start_line":312,"start_character":23,"end_line":312,"end_character":34},"in_reply_to":"ba1a5f21_3885256e","updated":"2021-08-04 12:59:19.000000000","message":"Ack","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"aefdbb2c227d2f196a2ed66bd44a61257edb6217","unresolved":true,"context_lines":[{"line_number":1269,"context_line":"                                           id\u003dloadbalancer[\u0027loadbalancer_id\u0027])"},{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":"        ctx \u003d context.Context("},{"line_number":1272,"context_line":"            project_id\u003ddb_lb[constants.PROJECT_ID],"},{"line_number":1273,"context_line":"            check_admin\u003dFalse)"},{"line_number":1274,"context_line":"        ctx.notification \u003d notification.LoadBalancerDelete(ctx)"},{"line_number":1275,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2dc125a1_09b8f018","line":1272,"range":{"start_line":1272,"start_character":23,"end_line":1272,"end_character":28},"updated":"2021-08-04 06:45:09.000000000","message":"same","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":33408,"name":"Pierre-Yves Jourel","email":"pierre-yves.jourel@ovhcloud.com","username":"PYJ"},"change_message_id":"aa63251b2333c0bc2be92bd1b1af7046e2a3ed3c","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"                                           id\u003dloadbalancer[\u0027loadbalancer_id\u0027])"},{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":"        ctx \u003d context.Context("},{"line_number":1272,"context_line":"            project_id\u003ddb_lb[constants.PROJECT_ID],"},{"line_number":1273,"context_line":"            check_admin\u003dFalse)"},{"line_number":1274,"context_line":"        ctx.notification \u003d notification.LoadBalancerDelete(ctx)"},{"line_number":1275,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c4ec0f53_3788dba7","line":1272,"range":{"start_line":1272,"start_character":23,"end_line":1272,"end_character":28},"in_reply_to":"2dc125a1_09b8f018","updated":"2021-08-04 12:59:19.000000000","message":"Ack","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"aefdbb2c227d2f196a2ed66bd44a61257edb6217","unresolved":true,"context_lines":[{"line_number":1952,"context_line":"        LOG.debug(\"Mark ACTIVE in DB for health monitor id: %s\","},{"line_number":1953,"context_line":"                  health_mon[constants.HEALTHMONITOR_ID])"},{"line_number":1954,"context_line":""},{"line_number":1955,"context_line":"        print(health_mon)"},{"line_number":1956,"context_line":""},{"line_number":1957,"context_line":"        pool \u003d self.pool_repo.get("},{"line_number":1958,"context_line":"            db_apis.get_session(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"594af60d_81aa89b9","line":1955,"range":{"start_line":1955,"start_character":8,"end_line":1955,"end_character":13},"updated":"2021-08-04 06:45:09.000000000","message":"needs to be removed","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":33408,"name":"Pierre-Yves Jourel","email":"pierre-yves.jourel@ovhcloud.com","username":"PYJ"},"change_message_id":"aa63251b2333c0bc2be92bd1b1af7046e2a3ed3c","unresolved":false,"context_lines":[{"line_number":1952,"context_line":"        LOG.debug(\"Mark ACTIVE in DB for health monitor id: %s\","},{"line_number":1953,"context_line":"                  health_mon[constants.HEALTHMONITOR_ID])"},{"line_number":1954,"context_line":""},{"line_number":1955,"context_line":"        print(health_mon)"},{"line_number":1956,"context_line":""},{"line_number":1957,"context_line":"        pool \u003d self.pool_repo.get("},{"line_number":1958,"context_line":"            db_apis.get_session(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1bbf2f32_8a832c45","line":1955,"range":{"start_line":1955,"start_character":8,"end_line":1955,"end_character":13},"in_reply_to":"594af60d_81aa89b9","updated":"2021-08-04 12:59:19.000000000","message":"Ack","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"aefdbb2c227d2f196a2ed66bd44a61257edb6217","unresolved":true,"context_lines":[{"line_number":1961,"context_line":"        db_health_mon \u003d self.health_mon_repo.get("},{"line_number":1962,"context_line":"            db_apis.get_session(), id\u003dhealth_mon[constants.HEALTHMONITOR_ID])"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"        print(pool[constants.LOAD_BALANCER_ID])"},{"line_number":1965,"context_line":""},{"line_number":1966,"context_line":"        ctx \u003d context.Context("},{"line_number":1967,"context_line":"            project_id\u003dpool[constants.PROJECT_ID],"}],"source_content_type":"text/x-python","patch_set":1,"id":"aa9a9077_882245b4","line":1964,"range":{"start_line":1964,"start_character":8,"end_line":1964,"end_character":13},"updated":"2021-08-04 06:45:09.000000000","message":"needs to be removed","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":33408,"name":"Pierre-Yves Jourel","email":"pierre-yves.jourel@ovhcloud.com","username":"PYJ"},"change_message_id":"aa63251b2333c0bc2be92bd1b1af7046e2a3ed3c","unresolved":false,"context_lines":[{"line_number":1961,"context_line":"        db_health_mon \u003d self.health_mon_repo.get("},{"line_number":1962,"context_line":"            db_apis.get_session(), id\u003dhealth_mon[constants.HEALTHMONITOR_ID])"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"        print(pool[constants.LOAD_BALANCER_ID])"},{"line_number":1965,"context_line":""},{"line_number":1966,"context_line":"        ctx \u003d context.Context("},{"line_number":1967,"context_line":"            project_id\u003dpool[constants.PROJECT_ID],"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb0ee558_596349b4","line":1964,"range":{"start_line":1964,"start_character":8,"end_line":1964,"end_character":13},"in_reply_to":"aa9a9077_882245b4","updated":"2021-08-04 12:59:19.000000000","message":"Ack","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"aefdbb2c227d2f196a2ed66bd44a61257edb6217","unresolved":true,"context_lines":[{"line_number":1966,"context_line":"        ctx \u003d context.Context("},{"line_number":1967,"context_line":"            project_id\u003dpool[constants.PROJECT_ID],"},{"line_number":1968,"context_line":"            check_admin\u003dFalse)"},{"line_number":1969,"context_line":"        current_state \u003d db_health_mon[constants.PROVISIONING_STATUS]"},{"line_number":1970,"context_line":"        if current_state \u003d\u003d constants.PENDING_CREATE:"},{"line_number":1971,"context_line":"            ctx.notification \u003d notification.MonitorCreate(ctx)"},{"line_number":1972,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"021b72b9_d013d75a","line":1969,"range":{"start_line":1969,"start_character":24,"end_line":1969,"end_character":37},"updated":"2021-08-04 06:45:09.000000000","message":"same","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"},{"author":{"_account_id":33408,"name":"Pierre-Yves Jourel","email":"pierre-yves.jourel@ovhcloud.com","username":"PYJ"},"change_message_id":"aa63251b2333c0bc2be92bd1b1af7046e2a3ed3c","unresolved":false,"context_lines":[{"line_number":1966,"context_line":"        ctx \u003d context.Context("},{"line_number":1967,"context_line":"            project_id\u003dpool[constants.PROJECT_ID],"},{"line_number":1968,"context_line":"            check_admin\u003dFalse)"},{"line_number":1969,"context_line":"        current_state \u003d db_health_mon[constants.PROVISIONING_STATUS]"},{"line_number":1970,"context_line":"        if current_state \u003d\u003d constants.PENDING_CREATE:"},{"line_number":1971,"context_line":"            ctx.notification \u003d notification.MonitorCreate(ctx)"},{"line_number":1972,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"425ea4c0_0de4fa7b","line":1969,"range":{"start_line":1969,"start_character":24,"end_line":1969,"end_character":37},"in_reply_to":"021b72b9_d013d75a","updated":"2021-08-04 12:59:19.000000000","message":"Ack","commit_id":"6ff6cd0974c447a4055caa7fe67199711ce32fa1"}]}