)]}'
{"etc/octavia.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"522f71e7fee79d7e27fcff45df17549f0e91ea83","unresolved":true,"context_lines":[{"line_number":577,"context_line":"# Nova supports: anti-affinity and soft-anti-affinity"},{"line_number":578,"context_line":"# anti_affinity_policy \u003d anti-affinity"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"[cinder]"},{"line_number":581,"context_line":"# The name of the cinder service in the keystone catalog"},{"line_number":582,"context_line":"# service_name \u003d"},{"line_number":583,"context_line":"# Custom cinder endpoint if override is necessary"}],"source_content_type":"text/plain","patch_set":1,"id":"e8424eed_3b89d5a3","side":"PARENT","line":580,"updated":"2021-08-11 00:25:38.000000000","message":"This cannot be removed.\nhttps://github.com/openstack/octavia/blob/master/octavia/common/config.py#L700","commit_id":"7e264e1f21ee396d046e0df0c1a4f4218039e4aa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fabf9fe70c70d888093c9f6fbb4ac04c063efa59","unresolved":false,"context_lines":[{"line_number":577,"context_line":"# Nova supports: anti-affinity and soft-anti-affinity"},{"line_number":578,"context_line":"# anti_affinity_policy \u003d anti-affinity"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"[cinder]"},{"line_number":581,"context_line":"# The name of the cinder service in the keystone catalog"},{"line_number":582,"context_line":"# service_name \u003d"},{"line_number":583,"context_line":"# Custom cinder endpoint if override is necessary"}],"source_content_type":"text/plain","patch_set":1,"id":"6e8c2d21_35771ff7","side":"PARENT","line":580,"in_reply_to":"2b162238_e8250890","updated":"2021-08-11 05:57:47.000000000","message":"Done","commit_id":"7e264e1f21ee396d046e0df0c1a4f4218039e4aa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ef8087253d9c03f6e9709dd607c30d879ab10051","unresolved":true,"context_lines":[{"line_number":577,"context_line":"# Nova supports: anti-affinity and soft-anti-affinity"},{"line_number":578,"context_line":"# anti_affinity_policy \u003d anti-affinity"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"[cinder]"},{"line_number":581,"context_line":"# The name of the cinder service in the keystone catalog"},{"line_number":582,"context_line":"# service_name \u003d"},{"line_number":583,"context_line":"# Custom cinder endpoint if override is necessary"}],"source_content_type":"text/plain","patch_set":1,"id":"2b162238_e8250890","side":"PARENT","line":580,"in_reply_to":"e8424eed_3b89d5a3","updated":"2021-08-11 00:43:39.000000000","message":"It seems this is missing from octavia.opts.list_opt and that is why this is not rendered by oslo-config-generator.\n\nhttps://review.opendev.org/c/openstack/octavia/+/804180","commit_id":"7e264e1f21ee396d046e0df0c1a4f4218039e4aa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"988d5fb9f8d15937c6fa375c9a1b60fc08fdb2e9","unresolved":true,"context_lines":[{"line_number":724,"context_line":"# List of enabled provider agents."},{"line_number":725,"context_line":"# enabled_provider_agents \u003d"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"[healthcheck]"},{"line_number":728,"context_line":"# WARNING: Enabling the \u0027detailed\u0027 setting will expose sensitive details about"},{"line_number":729,"context_line":"#          the API process. Do not enabled this unless you are sure it will"},{"line_number":730,"context_line":"#          not pose a security risk to your API instances."}],"source_content_type":"text/plain","patch_set":1,"id":"c564b311_87692014","side":"PARENT","line":727,"updated":"2021-08-11 00:45:39.000000000","message":"This should be also rendered.","commit_id":"7e264e1f21ee396d046e0df0c1a4f4218039e4aa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fabf9fe70c70d888093c9f6fbb4ac04c063efa59","unresolved":false,"context_lines":[{"line_number":724,"context_line":"# List of enabled provider agents."},{"line_number":725,"context_line":"# enabled_provider_agents \u003d"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"[healthcheck]"},{"line_number":728,"context_line":"# WARNING: Enabling the \u0027detailed\u0027 setting will expose sensitive details about"},{"line_number":729,"context_line":"#          the API process. Do not enabled this unless you are sure it will"},{"line_number":730,"context_line":"#          not pose a security risk to your API instances."}],"source_content_type":"text/plain","patch_set":1,"id":"715733ee_681777d1","side":"PARENT","line":727,"in_reply_to":"c564b311_87692014","updated":"2021-08-11 05:57:47.000000000","message":"Done","commit_id":"7e264e1f21ee396d046e0df0c1a4f4218039e4aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"63d725fbe6ebc42a8721ac67499d2f93779ff685","unresolved":true,"context_lines":[{"line_number":262,"context_line":"# TLSv1.1 - \u003cNo description provided\u003e"},{"line_number":263,"context_line":"# TLSv1.2 - \u003cNo description provided\u003e"},{"line_number":264,"context_line":"# TLS.CLIENT - \u003cNo description provided\u003e"},{"line_number":265,"context_line":"# TLS.SERVER - \u003cNo description provided\u003e"},{"line_number":266,"context_line":"#agent_tls_protocol \u003d TLSv1.2"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"# List of log server ip and port pairs for Administrative logs."}],"source_content_type":"text/plain","patch_set":1,"id":"796631a2_fd0107b1","line":265,"updated":"2021-08-11 00:27:15.000000000","message":"This enumeration rendered wrong.","commit_id":"c7b540ab74e850242e1fce6fcb27f92f6ccab8c7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2890d097dcd9f8af7d5f5a959c2bf85e73e2fbd5","unresolved":true,"context_lines":[{"line_number":262,"context_line":"# TLSv1.1 - \u003cNo description provided\u003e"},{"line_number":263,"context_line":"# TLSv1.2 - \u003cNo description provided\u003e"},{"line_number":264,"context_line":"# TLS.CLIENT - \u003cNo description provided\u003e"},{"line_number":265,"context_line":"# TLS.SERVER - \u003cNo description provided\u003e"},{"line_number":266,"context_line":"#agent_tls_protocol \u003d TLSv1.2"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"# List of log server ip and port pairs for Administrative logs."}],"source_content_type":"text/plain","patch_set":1,"id":"54cd71bd_6f126e65","line":265,"in_reply_to":"433dbd05_7d111477","updated":"2021-08-11 15:20:50.000000000","message":"Actually, no, three of those listed there are invalid settings.","commit_id":"c7b540ab74e850242e1fce6fcb27f92f6ccab8c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5190181d6c8054932733b05b2003f924b3303d13","unresolved":true,"context_lines":[{"line_number":262,"context_line":"# TLSv1.1 - \u003cNo description provided\u003e"},{"line_number":263,"context_line":"# TLSv1.2 - \u003cNo description provided\u003e"},{"line_number":264,"context_line":"# TLS.CLIENT - \u003cNo description provided\u003e"},{"line_number":265,"context_line":"# TLS.SERVER - \u003cNo description provided\u003e"},{"line_number":266,"context_line":"#agent_tls_protocol \u003d TLSv1.2"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"# List of log server ip and port pairs for Administrative logs."}],"source_content_type":"text/plain","patch_set":1,"id":"802592b1_93b15c23","line":265,"in_reply_to":"54cd71bd_6f126e65","updated":"2021-08-11 15:28:09.000000000","message":"Ah ok so TLS, TLS.CLIENT and TLS.SERVER should be removed. right ?\n\nI tested this locally but I can reproduce the same issu.\n\n\u003e\u003e\u003e import ssl\n\u003e\u003e\u003e [p[9:].replace(\u0027_\u0027, \u0027.\u0027) for p in ssl._PROTOCOL_NAMES.values()]\n[\u0027TLS\u0027, \u0027TLSv1\u0027, \u0027TLSv1.1\u0027, \u0027TLSv1.2\u0027, \u0027TLS.CLIENT\u0027, \u0027TLS.SERVER\u0027]\n\u003e\u003e\u003e exit()\n\nThis looks like a bug in the current logic to generate allowed values, IMO.","commit_id":"c7b540ab74e850242e1fce6fcb27f92f6ccab8c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4692d9c743123af8368b7f4a663dfc6f965b193b","unresolved":true,"context_lines":[{"line_number":262,"context_line":"# TLSv1.1 - \u003cNo description provided\u003e"},{"line_number":263,"context_line":"# TLSv1.2 - \u003cNo description provided\u003e"},{"line_number":264,"context_line":"# TLS.CLIENT - \u003cNo description provided\u003e"},{"line_number":265,"context_line":"# TLS.SERVER - \u003cNo description provided\u003e"},{"line_number":266,"context_line":"#agent_tls_protocol \u003d TLSv1.2"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"# List of log server ip and port pairs for Administrative logs."}],"source_content_type":"text/plain","patch_set":1,"id":"433dbd05_7d111477","line":265,"in_reply_to":"796631a2_fd0107b1","updated":"2021-08-11 06:03:11.000000000","message":"This is \"correctly\" rendered. If we want to put description then we should pass not list of values but list of (\u003cvalue\u003e, \u003cdescription\u003e) tuple to choices.\n\nhttps://github.com/openstack/octavia/blob/7e264e1f21ee396d046e0df0c1a4f4218039e4aa/octavia/common/config.py#L45-L47\n\nExmple:\nhttps://github.com/openstack/nova/blob/84b61790763f91e12eebb96d955e2f83abc00d56/nova/conf/servicegroup.py#L21-L24","commit_id":"c7b540ab74e850242e1fce6fcb27f92f6ccab8c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0c57e75859bfb3602c8c0b11c0ff49efc0f39e2e","unresolved":true,"context_lines":[{"line_number":262,"context_line":"# TLSv1.1 - \u003cNo description provided\u003e"},{"line_number":263,"context_line":"# TLSv1.2 - \u003cNo description provided\u003e"},{"line_number":264,"context_line":"# TLS.CLIENT - \u003cNo description provided\u003e"},{"line_number":265,"context_line":"# TLS.SERVER - \u003cNo description provided\u003e"},{"line_number":266,"context_line":"#agent_tls_protocol \u003d TLSv1.2"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"# List of log server ip and port pairs for Administrative logs."}],"source_content_type":"text/plain","patch_set":1,"id":"9b1f8574_a965e54f","line":265,"in_reply_to":"802592b1_93b15c23","updated":"2021-08-11 16:09:38.000000000","message":"I have proposed a fix here https://review.opendev.org/c/openstack/octavia/+/804270","commit_id":"c7b540ab74e850242e1fce6fcb27f92f6ccab8c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"11c5c2878047476cc519d7258adb3401a720bc09","unresolved":true,"context_lines":[{"line_number":182,"context_line":"# is used only when API audit is enabled."},{"line_number":183,"context_line":"# ignore_req_list \u003d"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"[audit_middleware_notifications]"},{"line_number":186,"context_line":"# Note: This section comes from openstack/keystonemiddleware"},{"line_number":187,"context_line":"# It is included here for documentation convenience and may be out of date"},{"line_number":188,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"a96cd396_a093e40a","side":"PARENT","line":185,"range":{"start_line":185,"start_character":1,"end_line":185,"end_character":31},"updated":"2021-08-12 02:05:23.000000000","message":"This should not be removed.","commit_id":"bce74bbc556c22e7f3b9e7c63f3b34665aa225d6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a6fea9e68e67137257d59ea8b04a3e1802f51126","unresolved":true,"context_lines":[{"line_number":182,"context_line":"# is used only when API audit is enabled."},{"line_number":183,"context_line":"# ignore_req_list \u003d"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"[audit_middleware_notifications]"},{"line_number":186,"context_line":"# Note: This section comes from openstack/keystonemiddleware"},{"line_number":187,"context_line":"# It is included here for documentation convenience and may be out of date"},{"line_number":188,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"9e8c82d3_e72a5435","side":"PARENT","line":185,"range":{"start_line":185,"start_character":1,"end_line":185,"end_character":31},"in_reply_to":"a96cd396_a093e40a","updated":"2021-08-12 02:22:00.000000000","message":"We need https://review.opendev.org/c/openstack/keystonemiddleware/+/804316 to include these parameters.","commit_id":"bce74bbc556c22e7f3b9e7c63f3b34665aa225d6"}]}