)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"944a1ac7dc83d3fb385539fa94afc9d0518e8874","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"418df32d_8df90917","updated":"2022-05-16 06:07:45.000000000","message":"@Gregory @Michael\n\nThis has been pending on review for a while. I\u0027d appreciate your feedback.","commit_id":"b5c9f3a7b0ddfd17b45b02b4071e95f6a5f13aa2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2f4f529ceee08ac6c492386213d93aff330db3c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8a241c91_87049a21","updated":"2022-06-02 20:04:40.000000000","message":"LGTM","commit_id":"0059f05aeb8b7bd1fb83d45148a9926d9dafaae0"}],"octavia/common/config.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"034fe592b5fdd12a305d30b5ed17d23bed47d67f","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    \u0027neutronclient.v2_0.client\u003dINFO\u0027,"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"TLS_PROTOCOL_CHOICES \u003d ["},{"line_number":46,"context_line":"    p[9:].replace(\u0027_\u0027, \u0027.\u0027) for p in ssl._PROTOCOL_NAMES.values()]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"core_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"f0262c95_4b042b30","side":"PARENT","line":45,"updated":"2021-08-11 16:08:52.000000000","message":"This is used only to get choices for agent_tls_protocol. For the other part constants defined in octavia.common.constants or octavia_lib.common.constants are used. I don\u0027t see any benefit of having this implementation here, TBH.","commit_id":"7e264e1f21ee396d046e0df0c1a4f4218039e4aa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c97f1f5af9087570b2b4533f735922a0a58a5d3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \u0027neutronclient.v2_0.client\u003dINFO\u0027,"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"TLS_PROTOCOL_CHOICES \u003d ["},{"line_number":46,"context_line":"    p[9:].replace(\u0027_\u0027, \u0027.\u0027) for p in ssl._PROTOCOL_NAMES.values()]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"core_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"946e4b65_d74c832e","side":"PARENT","line":45,"in_reply_to":"f0262c95_4b042b30","updated":"2022-05-16 06:08:05.000000000","message":"Done","commit_id":"7e264e1f21ee396d046e0df0c1a4f4218039e4aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a5d4880f854868f049870fcc6f5237bd41c7d646","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                      \"amphora agent.\"),"},{"line_number":166,"context_line":"               choices\u003d[lib_consts.TLS_VERSION_1,"},{"line_number":167,"context_line":"                        lib_consts.TLS_VERSION_1_1,"},{"line_number":168,"context_line":"                        lib_consts.TLS_VERSION_1_2]),"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    # Logging setup"},{"line_number":171,"context_line":"    cfg.ListOpt(\u0027admin_log_targets\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"db37efc6_a6ee14f4","line":168,"updated":"2022-05-31 15:31:38.000000000","message":"1_3 should probably be in this list too. Frankly I would make a \"VALID_TLS_VERSIONS\" in octavia-lib constants so this can be updated more easily over time.","commit_id":"b5c9f3a7b0ddfd17b45b02b4071e95f6a5f13aa2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3037dbff8a74dd4bf7b80b71d51d1427076ddc7a","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                      \"amphora agent.\"),"},{"line_number":166,"context_line":"               choices\u003d[lib_consts.TLS_VERSION_1,"},{"line_number":167,"context_line":"                        lib_consts.TLS_VERSION_1_1,"},{"line_number":168,"context_line":"                        lib_consts.TLS_VERSION_1_2]),"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    # Logging setup"},{"line_number":171,"context_line":"    cfg.ListOpt(\u0027admin_log_targets\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dacea826_cdcc4ac3","line":168,"in_reply_to":"db37efc6_a6ee14f4","updated":"2022-06-01 01:11:05.000000000","message":"I noticed we alreday have the TLS_ALL_VERSIONS constants to define list of all tls versions, so replaced this list by that constants. This effectively adds TLS1.3 as well as SSLv3.\n\nI\u0027d agree with moving this to octavia-lib but I\u0027d leave that for follow-up because it would make backport difficult.","commit_id":"b5c9f3a7b0ddfd17b45b02b4071e95f6a5f13aa2"}]}