)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ccdcc13cd48f7fad5baa40ef76b853a6634489ff","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In the database, timeout_client_data, timeout_member_connect,"},{"line_number":10,"context_line":"timeout_member_data, timeout_tcp_inspect have an integer type with"},{"line_number":11,"context_line":"a maximum size of 2147483647. Now MAX_TIMEOUT in API does not exceed"},{"line_number":12,"context_line":"this value."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Story: 2009193"},{"line_number":15,"context_line":"Task: 43248"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"782223c1_f966ce00","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":10},"updated":"2021-09-10 12:52:56.000000000","message":"could you be more explicit about this new value in the commit message (24 days or 2073600000 sec)?","commit_id":"be6e30bd8c20de10b80869b371abb84be460c86d"},{"author":{"_account_id":31754,"name":"Roman Goncharov","email":"gadzhet007@gmail.com","username":"gadzhet"},"change_message_id":"8b93cd2c450a900eadc756f5942da3c63961813c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In the database, timeout_client_data, timeout_member_connect,"},{"line_number":10,"context_line":"timeout_member_data, timeout_tcp_inspect have an integer type with"},{"line_number":11,"context_line":"a maximum size of 2147483647. Now MAX_TIMEOUT in API does not exceed"},{"line_number":12,"context_line":"this value."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Story: 2009193"},{"line_number":15,"context_line":"Task: 43248"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7c3bc05e_beeabd02","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":10},"in_reply_to":"782223c1_f966ce00","updated":"2021-09-13 15:37:28.000000000","message":"Done","commit_id":"be6e30bd8c20de10b80869b371abb84be460c86d"}],"octavia/common/constants.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ccdcc13cd48f7fad5baa40ef76b853a6634489ff","unresolved":false,"context_lines":[{"line_number":233,"context_line":"MAX_HM_RETRIES \u003d 10"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"# 24 days:   days  d    h    m    ms"},{"line_number":236,"context_line":"MAX_TIMEOUT \u003d 24 * 24 * 60 * 60 * 1000"},{"line_number":237,"context_line":"MIN_TIMEOUT \u003d 0"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"DEFAULT_TIMEOUT_CLIENT_DATA \u003d 50000"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfeeed67_ffa7327d","line":236,"range":{"start_line":236,"start_character":14,"end_line":236,"end_character":16},"updated":"2021-09-10 12:52:56.000000000","message":"Yeah I believe that nobody will complain about this change","commit_id":"be6e30bd8c20de10b80869b371abb84be460c86d"}],"octavia/tests/functional/api/v2/test_listener.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ccdcc13cd48f7fad5baa40ef76b853a6634489ff","unresolved":true,"context_lines":[{"line_number":688,"context_line":"            \u0027timeout_tcp_inspect\u0027: 1,"},{"line_number":689,"context_line":"        }"},{"line_number":690,"context_line":"        for field in optionals.items():"},{"line_number":691,"context_line":"            optionals.update({field[0]: 2147483648})"},{"line_number":692,"context_line":"            resp \u003d self.test_create(response_status\u003d400, **optionals).json"},{"line_number":693,"context_line":"            optionals.update({field[0]: 1})"},{"line_number":694,"context_line":"            fault \u003d resp.get(\u0027faultstring\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"330bb316_4283c0ed","line":691,"range":{"start_line":691,"start_character":40,"end_line":691,"end_character":50},"updated":"2021-09-10 12:52:56.000000000","message":"we can keep using constants.MAX_TIMEOUT + 1 (I like to use constants as much as possible)","commit_id":"be6e30bd8c20de10b80869b371abb84be460c86d"},{"author":{"_account_id":31754,"name":"Roman Goncharov","email":"gadzhet007@gmail.com","username":"gadzhet"},"change_message_id":"8b93cd2c450a900eadc756f5942da3c63961813c","unresolved":false,"context_lines":[{"line_number":688,"context_line":"            \u0027timeout_tcp_inspect\u0027: 1,"},{"line_number":689,"context_line":"        }"},{"line_number":690,"context_line":"        for field in optionals.items():"},{"line_number":691,"context_line":"            optionals.update({field[0]: 2147483648})"},{"line_number":692,"context_line":"            resp \u003d self.test_create(response_status\u003d400, **optionals).json"},{"line_number":693,"context_line":"            optionals.update({field[0]: 1})"},{"line_number":694,"context_line":"            fault \u003d resp.get(\u0027faultstring\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb0656a9_6fbf4d71","line":691,"range":{"start_line":691,"start_character":40,"end_line":691,"end_character":50},"in_reply_to":"330bb316_4283c0ed","updated":"2021-09-13 15:37:28.000000000","message":"I prefer to use constants less often to pay more attention to tests. That way sometimes new bugs or places left untested are found.\nGot it, I\u0027ll return the constant.","commit_id":"be6e30bd8c20de10b80869b371abb84be460c86d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ccdcc13cd48f7fad5baa40ef76b853a6634489ff","unresolved":true,"context_lines":[{"line_number":697,"context_line":"                    field[0]), fault)"},{"line_number":698,"context_line":"            self.assertIn("},{"line_number":699,"context_line":"                \u0027Value should be lower or equal to {0}\u0027.format("},{"line_number":700,"context_line":"                    2073600000), fault)"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    def test_create_with_timeouts_too_low(self):"},{"line_number":703,"context_line":"        optionals \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"20ddaa00_db642c5c","line":700,"range":{"start_line":700,"start_character":20,"end_line":700,"end_character":30},"updated":"2021-09-10 12:52:56.000000000","message":"constants.MAX_TIMEOUT","commit_id":"be6e30bd8c20de10b80869b371abb84be460c86d"},{"author":{"_account_id":31754,"name":"Roman Goncharov","email":"gadzhet007@gmail.com","username":"gadzhet"},"change_message_id":"8b93cd2c450a900eadc756f5942da3c63961813c","unresolved":false,"context_lines":[{"line_number":697,"context_line":"                    field[0]), fault)"},{"line_number":698,"context_line":"            self.assertIn("},{"line_number":699,"context_line":"                \u0027Value should be lower or equal to {0}\u0027.format("},{"line_number":700,"context_line":"                    2073600000), fault)"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    def test_create_with_timeouts_too_low(self):"},{"line_number":703,"context_line":"        optionals \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfb64b93_379bd0a4","line":700,"range":{"start_line":700,"start_character":20,"end_line":700,"end_character":30},"in_reply_to":"20ddaa00_db642c5c","updated":"2021-09-13 15:37:28.000000000","message":"Done","commit_id":"be6e30bd8c20de10b80869b371abb84be460c86d"}]}