)]}'
{"octavia/amphorae/backends/utils/ip_advertisement.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4f96f8f710631b80b49711d773121c885c058de3","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    source_mac \u003d garp_socket.getsockname()[4]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    garp_msg \u003d ["},{"line_number":53,"context_line":"        struct.pack(\u0027!h\u0027, 1),                 # Hardware type ethernet"},{"line_number":54,"context_line":"        struct.pack(\u0027!h\u0027, 0x0800),            # Protocol type IPv4"},{"line_number":55,"context_line":"        struct.pack(\u0027!B\u0027, 6),                 # Hardware size"},{"line_number":56,"context_line":"        struct.pack(\u0027!B\u0027, 4),                 # Protocol size"}],"source_content_type":"text/x-python","patch_set":1,"id":"e851ffb3_7f87cd0e","line":53,"updated":"2021-09-17 15:14:49.000000000","message":"This is silly, but if it works....","commit_id":"ba5b4a7fb514d1e8c9cf03c03c356aad31acdf6a"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"aa55aed971c9ba90b2e259f313026803879e8c59","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    source_mac \u003d garp_socket.getsockname()[4]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    garp_msg \u003d ["},{"line_number":53,"context_line":"        struct.pack(\u0027!h\u0027, 1),                 # Hardware type ethernet"},{"line_number":54,"context_line":"        struct.pack(\u0027!h\u0027, 0x0800),            # Protocol type IPv4"},{"line_number":55,"context_line":"        struct.pack(\u0027!B\u0027, 6),                 # Hardware size"},{"line_number":56,"context_line":"        struct.pack(\u0027!B\u0027, 4),                 # Protocol size"}],"source_content_type":"text/x-python","patch_set":1,"id":"efe48f94_f88ca803","line":53,"in_reply_to":"e851ffb3_7f87cd0e","updated":"2021-09-17 18:13:15.000000000","message":"Yeah honestly I\u0027m surprised it wasn\u0027t complaining before, these are literally FUNCTIONS in that module, which I thought was always a no-no to import directly like that. This does fix the error.","commit_id":"ba5b4a7fb514d1e8c9cf03c03c356aad31acdf6a"}],"octavia/controller/worker/v2/controller_worker.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b2f916e60038a9e7fccc1d7d45e733bb8c1092e8","unresolved":true,"context_lines":[{"line_number":1082,"context_line":"                    provider_utils.db_loadbalancer_to_provider_loadbalancer("},{"line_number":1083,"context_line":"                        lb).to_dict())"},{"line_number":1084,"context_line":"            else:"},{"line_number":1085,"context_line":"                provider_lb_dict \u003d lb"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"            provider_lb_dict[constants.FLAVOR] \u003d flavor"},{"line_number":1088,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bfedb42e_f16a7da4","line":1085,"updated":"2021-09-17 18:18:15.000000000","message":"I tried to just fix the pylint error without changing logic, but honestly I don\u0027t understand how the LB could evaluate \"false\" here, it\u0027s either None (which would have bailed out of the function already) or it is a model object, which I don\u0027t believe can evaluate false under any conditions. I don\u0027t think this branch can ever execute.","commit_id":"ba5b4a7fb514d1e8c9cf03c03c356aad31acdf6a"}]}