)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e7caa9e1d3089e4d0a90eb2667d5942574f4d3d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"171d8afd_5d66f5c9","updated":"2021-11-04 20:40:54.000000000","message":"Consensus is we should stick with the 200 response in the code.\nLGTM","commit_id":"e342ce706124a1c1cd5f94379f6c977c535511fb"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fab421d192b76ca0b5610fb7f763d80dd14e8617","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"63b8e4d8_b5e7ab4f","updated":"2021-11-03 09:07:54.000000000","message":"Hm, it seems like in case of Kuryr we have return codes hidden behind openstacksdk, but please ping me on the patch changing them so we can run Kuryr tests on it.","commit_id":"e342ce706124a1c1cd5f94379f6c977c535511fb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"61e1cd9605bfc72ab3c42129dd0b7862b27b6a2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"179e9f05_6f4f7c76","updated":"2021-11-02 18:40:53.000000000","message":"I would argue that the code is wrong here.\nThose put calls are all asynchronous, so should be returning 202.","commit_id":"e342ce706124a1c1cd5f94379f6c977c535511fb"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"3603eaa2cf84c7f36c39b79bbc11852f1be9915a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"81702f5e_e4719f1b","updated":"2023-03-01 12:52:35.000000000","message":"It seems Omer is right with his comment.","commit_id":"e342ce706124a1c1cd5f94379f6c977c535511fb"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d5a37d9ae47240c07afa8e19616783de693e60a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66985666_82dd6069","updated":"2022-09-29 14:54:57.000000000","message":"Should api-ref/source/v2/quota.inc be updated as well?","commit_id":"e342ce706124a1c1cd5f94379f6c977c535511fb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0a4feeacb81f7db25bedce8d6e256e7fb5dfef83","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8c1f085f_06151bd4","in_reply_to":"179e9f05_6f4f7c76","updated":"2021-11-02 19:42:40.000000000","message":"Just to make sure I understand it well, do you mean that we should update the code to return 202 instead of 200, for these calls?","commit_id":"e342ce706124a1c1cd5f94379f6c977c535511fb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fbdfff9e4a2251f650a378d42e1404da12b2e4fc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e7348805_18312587","in_reply_to":"8c1f085f_06151bd4","updated":"2021-11-02 23:54:54.000000000","message":"Yeah, that is what I am questioning. These PUT calls are asynchronous calls, for example update listener will go into a PENDING state and require a driver call and updates to the amphora instances when a TLS certificate is updated.\nMuch like the create calls are async and return 202 because of it.\n\nThe API reference is supposed to be the single-point-of-truth and in this case I think it may be right and the code wrong.","commit_id":"e342ce706124a1c1cd5f94379f6c977c535511fb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d1aafd21c2a4a3b7ee4250491d091a06587257ad","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aaecfed3_333d0b81","in_reply_to":"e7348805_18312587","updated":"2021-11-03 02:03:59.000000000","message":"Changing the return code will break some SDKs, which check current return code. Example given: https://github.com/ovh/gophercloud/blob/master/openstack/loadbalancer/v2/l7policies/requests.go#L222\n\nI guess they\u0027ll have to add 202 and when done we\u0027ll be able to change Octavia API.","commit_id":"e342ce706124a1c1cd5f94379f6c977c535511fb"}],"api-ref/source/v2/member.inc":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d5a37d9ae47240c07afa8e19616783de693e60a5","unresolved":true,"context_lines":[{"line_number":379,"context_line":"deletions for members missing from the provided list. If this were set in the"},{"line_number":380,"context_line":"above example, the member \u0027192.0.2.15:80\u0027 would have remained in the pool."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"If the request is valid, the service returns the ``Accepted (202)``"},{"line_number":383,"context_line":"response code. To confirm the updates, check that the member provisioning"},{"line_number":384,"context_line":"statuses are ``ACTIVE`` for new or updated members, and that any unspecified"},{"line_number":385,"context_line":"members were correctly deleted. If the statuses are ``PENDING_UPDATE`` or"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"b204d66c_ab9e45e8","line":382,"range":{"start_line":382,"start_character":49,"end_line":382,"end_character":67},"updated":"2022-09-29 14:54:57.000000000","message":"That should be ``Successful (200)`` too.","commit_id":"e342ce706124a1c1cd5f94379f6c977c535511fb"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d5a37d9ae47240c07afa8e19616783de693e60a5","unresolved":true,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":".. rest_status_code:: success ../http-status.yaml"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"   - 202"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":".. rest_status_code:: error ../http-status.yaml"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"f4ba2a4c_32cf786a","line":390,"range":{"start_line":390,"start_character":5,"end_line":390,"end_character":8},"updated":"2022-09-29 14:54:57.000000000","message":"200","commit_id":"e342ce706124a1c1cd5f94379f6c977c535511fb"}]}