)]}'
{"id":"openstack%2Foctavia~818093","triplet_id":"openstack%2Foctavia~stable%2Ftrain~I48b0f5a773209b1c1b056d71c0da05d6fd82ca73","project":"openstack/octavia","branch":"stable/train","attention_set":{},"removed_from_attention_set":{"29244":{"account":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"last_update":"2021-12-02 11:41:38.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I48b0f5a773209b1c1b056d71c0da05d6fd82ca73","subject":"Fix LB set in ERROR too early in the revert flow","status":"MERGED","created":"2021-11-16 14:21:46.000000000","updated":"2021-12-02 11:44:29.000000000","submitted":"2021-12-02 11:41:38.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"818093","meta_rev_id":"f216d36d61d82ce904a797bbbca553ee45fe518a","_number":818093,"virtual_id_number":818093,"owner":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-12-02 11:41:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":2,"date":"2021-12-01 22:05:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-12-02 09:13:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-12-02 09:13:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-16 17:09:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-12-01 22:05:26.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2021-12-02 09:13:37.000000000","updated_by":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"reviewer":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"state":"REVIEWER"}],"messages":[{"id":"719587b671d232b260f8d8eef24b679af5f35b0c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2021-11-16 14:21:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"83bc1b8c7d3886d90d7b1e30e92719eea5d4ab91","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-16 17:09:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7fd300f0cb2e4926a395be3ae87f96f6 : SUCCESS in 12m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/68472d4428b34d51ab726dfda1716f04 : SUCCESS in 6m 35s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/3b33116217a2418491223a2230eb7bb6 : SUCCESS in 5m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dbeb925b8af44ea3890bb377750cd38e : SUCCESS in 6m 32s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/96800bf0803c4b92a8e704d0c6e2b669 : SUCCESS in 7m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/584ef900f9ab431ea9872706442ff9cd : SUCCESS in 11m 51s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/782512505733474da8858347225a0df8 : SUCCESS in 6m 29s\n- octavia-tox-py37-tips https://zuul.opendev.org/t/openstack/build/cbfe76da35284503be2307d91cbd2f72 : SUCCESS in 7m 16s\n- octavia-tox-functional-py37-tips https://zuul.opendev.org/t/openstack/build/ecf9a9176c6448deb0832140ae38fce8 : SUCCESS in 8m 06s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/7deeeddebff64af0afe5df76698c01ba : SUCCESS in 7m 54s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/cb1776440f8d429f8187a334dd020d27 : SUCCESS in 8m 59s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/1c0fadfa6907401180ceb0593230348f : SUCCESS in 1h 02m 48s\n- octavia-v2-dsvm-noop-py2-api https://zuul.opendev.org/t/openstack/build/1963c63e32064610830736c1d31ec458 : SUCCESS in 1h 26m 57s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/478c4e4083a1470c9888ceb7898e0767 : SUCCESS in 1h 56m 29s\n- octavia-v2-dsvm-py2-scenario https://zuul.opendev.org/t/openstack/build/c0fccd350fb042d48c12a61d2e5028b2 : TIMED_OUT in 2h 40m 53s (non-voting)\n- octavia-v2-dsvm-py2-scenario-centos-7 https://zuul.opendev.org/t/openstack/build/4e45a65db4f0433187310756b64644e5 : FAILURE in 16m 23s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/0264a72239fc4366a3ca92d834196c7d : RETRY_LIMIT in 11m 26s (non-voting)\n- octavia-v2-dsvm-py2-scenario-two-node https://zuul.opendev.org/t/openstack/build/87918d3be88946f68429a95f367e8162 : RETRY_LIMIT in 8m 04s (non-voting)\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/54696a7b72394a2f8324494d53a072c9 : SUCCESS in 41m 56s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2 https://zuul.opendev.org/t/openstack/build/3d4519d7deeb4838b27a90668dcbe49b : SUCCESS in 2h 30m 48s (non-voting)\n- octavia-v2-act-stdby-iptables-dsvm-scenario https://zuul.opendev.org/t/openstack/build/fe2a3dd40521496fa681d4a47b52b438 : FAILURE in 31m 21s (non-voting)\n- octavia-v2-act-stdby-iptables-dsvm-py2-scenario https://zuul.opendev.org/t/openstack/build/b4a79a6fe129430f9e7d01bbfaa73b8c : FAILURE in 34m 34s (non-voting)\n- octavia-v2-act-stdby-iptables-dsvm-py2-scenario-centos-7 https://zuul.opendev.org/t/openstack/build/c1f65c1b2e1d45aca3d1aab5bffa9bdf : FAILURE in 13m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"35addfdbb4b154d611703dda080f84e064c1e4c7","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2021-12-01 22:05:26.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"eb675366e58eea77821dee0017c5f37a0c564def","author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"date":"2021-12-02 09:13:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"37934ba68f4ca0143e625eff12e9ed09c18affaf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 09:17:06.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"de1c72cc8670c4edf8e96e13bc1f5702474d44ca","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 11:41:38.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/da8cf861149945129e5f3b304174f3cc : SUCCESS in 6m 28s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/29b32f838c424b43817c8fb48a9fccda : SUCCESS in 5m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/af820c1ba4094e8caf33ec41d92f23a2 : SUCCESS in 5m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8cb86f0ee65c4cd4a30a5aef50646d3b : SUCCESS in 6m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1cfb029e125744f080598377bb12f0a0 : SUCCESS in 11m 18s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a791e15019e6415397a3f318643064d1 : SUCCESS in 5m 21s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/a6a213f2bdd04192bdd58462db132161 : SUCCESS in 7m 31s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/f2a0a417a76e4f258ff53dccd3ace051 : SUCCESS in 7m 12s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/33932a9313944edc93e106fdd61e9cfd : SUCCESS in 1h 01m 34s\n- octavia-v2-dsvm-noop-py2-api https://zuul.opendev.org/t/openstack/build/52c0ae6b9da349098d45f70879a70da1 : SUCCESS in 1h 16m 58s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/acf9586e029f4e1e8d731367b3c5429c : SUCCESS in 1h 50m 15s","accounts_in_message":[],"_revision_number":1},{"id":"71fede2501b863b641400f1faae44c90caecf798","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 11:41:38.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"f216d36d61d82ce904a797bbbca553ee45fe518a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-02 11:44:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/65aa9f8facac45ff9d529b2e3c3a2748 : SUCCESS in 1m 12s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8b6e5a098efe4e5a900dd8cc09cf4f05 : SUCCESS in 2m 01s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1ad32d7cae56a093b0f1673d54957f370324a224","revisions":{"1ad32d7cae56a093b0f1673d54957f370324a224":{"kind":"REWORK","_number":1,"created":"2021-11-16 14:21:46.000000000","uploader":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"ref":"refs/changes/93/818093/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/93/818093/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/93/818093/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/93/818093/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/93/818093/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/93/818093/1"}}},"commit":{"parents":[{"commit":"e117cda1774996a61af8aacf09b7779d64e29ae6","subject":"Merge \"Fix periodic image builder jobs\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/e117cda1774996a61af8aacf09b7779d64e29ae6"}]}],"author":{"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","date":"2021-10-28 20:13:26.000000000","tz":120},"committer":{"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","date":"2021-11-16 14:06:31.000000000","tz":60},"subject":"Fix LB set in ERROR too early in the revert flow","message":"Fix LB set in ERROR too early in the revert flow\n\nWhen an error occurs in a flow, the provisioning status of the load\nbalancer should be set to ERROR in the revert method of the first task\nof the flow. This update acts as an unlock of the LB object and cannot\noccur in any other revert method because the API might consider the LB\nas mutable before finishing a task/flow.\n\nRemove all occurrences of mark_loadbalancer_prov_status_error calls in\nrevert method of tasks that are not specifically designed for unlocking\nthe load balancers. Add a LoadBalancerToErrorOnRevertTask task in the\namphora failover flow to prevent a LB to be in an immutable state.\n\nStory 2009651\nTask 43810\nStory 2009652\nTask 43811\n\nNote for stable/train: the code of the amphorav2 is not updated in this\nbackport, the source files exist in train but the feature was added\nussuri. Backporting this patch creates many merge conflicts and doesn\u0027t\nprovide anything for train users.\n\nConflicts:\n\toctavia/controller/worker/v1/tasks/database_tasks.py\n\toctavia/controller/worker/v2/flows/amphora_flows.py\n\toctavia/controller/worker/v2/tasks/amphora_driver_tasks.py\n\toctavia/controller/worker/v2/tasks/database_tasks.py\n\toctavia/tests/unit/controller/worker/v2/flows/test_amphora_flows.py\n\toctavia/tests/unit/controller/worker/v2/tasks/test_amphora_driver_tasks.py\n\toctavia/tests/unit/controller/worker/v2/tasks/test_database_tasks.py\n\nChange-Id: I48b0f5a773209b1c1b056d71c0da05d6fd82ca73\n(cherry picked from commit 4b8b198fecee802e1031c014f811eb766329a1a0)\n(cherry picked from commit 4039d35ce221b58490d4aa5b3497e29dbf7664ac)\n(cherry picked from commit 844f1348ea3d83f9fb5f920b64c9234dbdf9948d)\n(cherry picked from commit cf2a8bdf88d544e47d2aa2e43388aeb3de99e21b)\n(cherry picked from commit 95690e251d5c89db63e9a81abc6f71ff5d1cf183)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/1ad32d7cae56a093b0f1673d54957f370324a224"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/1ad32d7cae56a093b0f1673d54957f370324a224"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}