)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6adba0536fc14b3196e79efebb0bd46488610cb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"52fe6494_6594e1e4","updated":"2021-11-17 15:44:42.000000000","message":"This will need a release note in addition to the fix commented in the patch.","commit_id":"0d3aafb9ccf2c2bead2ceae46f2e0e88e200e88c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"594caf0e5496ebc97e71ba4820782aeb51561099","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0f975966_e5d0194e","updated":"2022-02-22 18:02:27.000000000","message":"LGTM","commit_id":"9ac5c71cec97e92703af41910229417086df3011"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"26568da19588378e521bb2836b5c5f5e59776d53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c603283_45dbf9aa","updated":"2021-12-09 12:48:57.000000000","message":"recheck","commit_id":"9ac5c71cec97e92703af41910229417086df3011"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"6960a37dc283d86d36d313f553dc5269ca34878f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a6db64f0_5d9d7007","updated":"2021-11-19 12:09:00.000000000","message":"recheck","commit_id":"9ac5c71cec97e92703af41910229417086df3011"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ef3b112f33d71ea5c4ba8dc5d9a1ef77aa1c9665","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"14c02314_72c5b75e","updated":"2022-07-11 16:43:52.000000000","message":"LGTM","commit_id":"d340a1de50b55a73f0e3a4d398ee735b0ccc128b"}],"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6adba0536fc14b3196e79efebb0bd46488610cb4","unresolved":true,"context_lines":[{"line_number":564,"context_line":"                    amp, listener_id, name, ignore\u003d(404,)) \u003d\u003d md5sum:"},{"line_number":565,"context_line":"                return"},{"line_number":566,"context_line":"            else:"},{"line_number":567,"context_line":"                self.clients[amp.api_version].delete_cert_pem("},{"line_number":568,"context_line":"                    amp, listener_id, name)"},{"line_number":569,"context_line":"        except exc.NotFound:"},{"line_number":570,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"75beceb0_93ac5cd7","line":567,"updated":"2021-11-17 15:44:42.000000000","message":"This will cause an additional round trip to the amphora.\nIt would be better to just add O_TRUNC to this line:\nhttps://github.com/openstack/octavia/blob/f48141f43b4856b88092335daf04301add9f7250/octavia/amphorae/backends/agent/api_server/loadbalancer.py#L388","commit_id":"0d3aafb9ccf2c2bead2ceae46f2e0e88e200e88c"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"7b951bddbb9a59e0e665b66d3a9ce50720bc58f3","unresolved":false,"context_lines":[{"line_number":564,"context_line":"                    amp, listener_id, name, ignore\u003d(404,)) \u003d\u003d md5sum:"},{"line_number":565,"context_line":"                return"},{"line_number":566,"context_line":"            else:"},{"line_number":567,"context_line":"                self.clients[amp.api_version].delete_cert_pem("},{"line_number":568,"context_line":"                    amp, listener_id, name)"},{"line_number":569,"context_line":"        except exc.NotFound:"},{"line_number":570,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"4a95cc0e_a51133ac","line":567,"in_reply_to":"75beceb0_93ac5cd7","updated":"2021-11-18 12:01:44.000000000","message":"Done","commit_id":"0d3aafb9ccf2c2bead2ceae46f2e0e88e200e88c"}],"releasenotes/notes/fix-listener-update-certs-failed-315c66f4806e76c8.yaml":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"da80ff9f7826d0e0b56e5c220625305aa3be99ff","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix update listener certs failed. this fix may need to update the code"},{"line_number":5,"context_line":"    in amphoreas to make it work."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bd9222ab_06f1980e","line":5,"range":{"start_line":4,"start_character":38,"end_line":5,"end_character":33},"updated":"2022-03-01 14:31:47.000000000","message":"The sentence should start with capital T and the plural of amphora is amphorae (or amphoras). IMO you should rather describe that the fix ensures that an existing certificate gets overwritten properly.","commit_id":"9ac5c71cec97e92703af41910229417086df3011"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"32e101f8505f2cd682a3b31fc5bfbf76d9a61bf4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix update listener certs failed. this fix may need to update the code"},{"line_number":5,"context_line":"    in amphoreas to make it work."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ed18bd8a_190b763e","line":5,"range":{"start_line":4,"start_character":38,"end_line":5,"end_character":33},"in_reply_to":"bd9222ab_06f1980e","updated":"2022-03-11 02:12:59.000000000","message":"Ack","commit_id":"9ac5c71cec97e92703af41910229417086df3011"}]}
