)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c60a32179eaaffb72ac471f5e3be820e5dcb4fed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3dfbfb3_7ec0680b","updated":"2021-12-21 07:39:45.000000000","message":"Can you also add a release note for this bug?\n\nCR-1 because of the missing release note\n\nAfter more testing it seems that this function is broken when using UDP listenes, it will require a followup patch","commit_id":"d0f07e22b0298c4784871d7baac7a7cebfc6c92b"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"d8ab32f37339c6c7192c4feacd385bc9c68420c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dfaabb13_e74c3c88","in_reply_to":"c3dfbfb3_7ec0680b","updated":"2021-12-21 08:51:19.000000000","message":"Added release notes.","commit_id":"d0f07e22b0298c4784871d7baac7a7cebfc6c92b"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"012b25867be6a2008732e80a576e08675bcc997e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d5d9fe57_457312a6","updated":"2021-12-21 17:40:50.000000000","message":"The path of the release note is not correct, it should be in the releasenotes/notes/ directory,\n\nsee: https://review.opendev.org/plugins/gitiles/openstack/octavia/+/refs/changes/41/822041/3/releasenotes","commit_id":"4a1017b19451014cd62f574a21b14173225838f2"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ffcecb29e4a807702831bd4a8b6573d7878edda6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"52deeb3e_17627fee","updated":"2022-09-05 06:35:55.000000000","message":"recheck recreating CI results","commit_id":"67c5b95e9c499d278988f2efc08cadeaf8e91eac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"dc5942056d977fcf5a22b595fc96e05ade946086","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9ebd5b96_84e0080a","updated":"2023-02-10 01:50:37.000000000","message":"LGTM","commit_id":"33a3d4744c5945f1f99615d85ce26fc63257e09c"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0fa5e9f8c6ed131fb97b8fad255cd2c7fa7b528e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7f460b82_1830308e","updated":"2023-01-16 11:22:18.000000000","message":"Sorry for kinda taking over the patch, but it had a merge conflict","commit_id":"33a3d4744c5945f1f99615d85ce26fc63257e09c"}],"octavia/amphorae/backends/agent/api_server/amphora_info.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c60a32179eaaffb72ac471f5e3be820e5dcb4fed","unresolved":true,"context_lines":[{"line_number":44,"context_line":"            body.update(extend_body)"},{"line_number":45,"context_line":"        return webob.Response(json\u003dbody)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def compile_amphora_details(self, extend_lvs_driver\u003dNone):"},{"line_number":48,"context_line":"        haproxy_loadbalancer_list \u003d sorted(util.get_loadbalancers())"},{"line_number":49,"context_line":"        haproxy_listener_list \u003d sorted(util.get_listeners())"},{"line_number":50,"context_line":"        extend_body \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"edab1388_c1c96653","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":31},"updated":"2021-12-21 07:39:45.000000000","message":"I\u0027m curious: do you use this endpoint? it is not called in the current code.","commit_id":"d0f07e22b0298c4784871d7baac7a7cebfc6c92b"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"7ece1c1ce6bb92e1e3105da6ed155a89355c400f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            body.update(extend_body)"},{"line_number":45,"context_line":"        return webob.Response(json\u003dbody)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def compile_amphora_details(self, extend_lvs_driver\u003dNone):"},{"line_number":48,"context_line":"        haproxy_loadbalancer_list \u003d sorted(util.get_loadbalancers())"},{"line_number":49,"context_line":"        haproxy_listener_list \u003d sorted(util.get_listeners())"},{"line_number":50,"context_line":"        extend_body \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"2996449c_dbc9fd32","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":31},"in_reply_to":"bb7c2302_66a16877","updated":"2022-11-24 12:55:35.000000000","message":"Done","commit_id":"d0f07e22b0298c4784871d7baac7a7cebfc6c92b"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"d8ab32f37339c6c7192c4feacd385bc9c68420c0","unresolved":true,"context_lines":[{"line_number":44,"context_line":"            body.update(extend_body)"},{"line_number":45,"context_line":"        return webob.Response(json\u003dbody)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def compile_amphora_details(self, extend_lvs_driver\u003dNone):"},{"line_number":48,"context_line":"        haproxy_loadbalancer_list \u003d sorted(util.get_loadbalancers())"},{"line_number":49,"context_line":"        haproxy_listener_list \u003d sorted(util.get_listeners())"},{"line_number":50,"context_line":"        extend_body \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bb7c2302_66a16877","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":31},"in_reply_to":"edab1388_c1c96653","updated":"2021-12-21 08:51:19.000000000","message":"I was debugging some amphoras and tried to get information about the state of them, used the following endpoint \u0027/1.0/details\u0027 and was wondering about the haproxy_count that was the reason I stumbled over that bug.","commit_id":"d0f07e22b0298c4784871d7baac7a7cebfc6c92b"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c60a32179eaaffb72ac471f5e3be820e5dcb4fed","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                \u0027networks\u0027: self._get_networks(),"},{"line_number":69,"context_line":"                \u0027active\u0027: True,"},{"line_number":70,"context_line":"                \u0027haproxy_count\u0027:"},{"line_number":71,"context_line":"                    self._count_haproxy_processes(haproxy_loadbalancer_list),"},{"line_number":72,"context_line":"                \u0027cpu\u0027: {"},{"line_number":73,"context_line":"                    \u0027total\u0027: cpu[\u0027total\u0027],"},{"line_number":74,"context_line":"                    \u0027user\u0027: cpu[\u0027user\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"358a4dee_cf8f3fa3","line":71,"range":{"start_line":71,"start_character":25,"end_line":71,"end_character":49},"updated":"2021-12-21 07:39:45.000000000","message":"do you think there\u0027s a way to add test coverage for this?\n(at least ensuring that we are calling _count_haproxy_process with a list of LBs instead of a list of listeners)","commit_id":"d0f07e22b0298c4784871d7baac7a7cebfc6c92b"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"7ece1c1ce6bb92e1e3105da6ed155a89355c400f","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                \u0027networks\u0027: self._get_networks(),"},{"line_number":69,"context_line":"                \u0027active\u0027: True,"},{"line_number":70,"context_line":"                \u0027haproxy_count\u0027:"},{"line_number":71,"context_line":"                    self._count_haproxy_processes(haproxy_loadbalancer_list),"},{"line_number":72,"context_line":"                \u0027cpu\u0027: {"},{"line_number":73,"context_line":"                    \u0027total\u0027: cpu[\u0027total\u0027],"},{"line_number":74,"context_line":"                    \u0027user\u0027: cpu[\u0027user\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"4d3f489f_7e09f02e","line":71,"range":{"start_line":71,"start_character":25,"end_line":71,"end_character":49},"in_reply_to":"2329101c_a6584c5e","updated":"2022-11-24 12:55:35.000000000","message":"Help with the testing part would be appreciated :)","commit_id":"d0f07e22b0298c4784871d7baac7a7cebfc6c92b"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"d8ab32f37339c6c7192c4feacd385bc9c68420c0","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                \u0027networks\u0027: self._get_networks(),"},{"line_number":69,"context_line":"                \u0027active\u0027: True,"},{"line_number":70,"context_line":"                \u0027haproxy_count\u0027:"},{"line_number":71,"context_line":"                    self._count_haproxy_processes(haproxy_loadbalancer_list),"},{"line_number":72,"context_line":"                \u0027cpu\u0027: {"},{"line_number":73,"context_line":"                    \u0027total\u0027: cpu[\u0027total\u0027],"},{"line_number":74,"context_line":"                    \u0027user\u0027: cpu[\u0027user\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"78bf5d4d_52047064","line":71,"range":{"start_line":71,"start_character":25,"end_line":71,"end_character":49},"in_reply_to":"358a4dee_cf8f3fa3","updated":"2021-12-21 08:51:19.000000000","message":"I am not really a developer, do you have anything in mind that could be implemented for that?","commit_id":"d0f07e22b0298c4784871d7baac7a7cebfc6c92b"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"41e77056df97963af9e3e36f7788696237ccb0df","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                \u0027networks\u0027: self._get_networks(),"},{"line_number":69,"context_line":"                \u0027active\u0027: True,"},{"line_number":70,"context_line":"                \u0027haproxy_count\u0027:"},{"line_number":71,"context_line":"                    self._count_haproxy_processes(haproxy_loadbalancer_list),"},{"line_number":72,"context_line":"                \u0027cpu\u0027: {"},{"line_number":73,"context_line":"                    \u0027total\u0027: cpu[\u0027total\u0027],"},{"line_number":74,"context_line":"                    \u0027user\u0027: cpu[\u0027user\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"2329101c_a6584c5e","line":71,"range":{"start_line":71,"start_character":25,"end_line":71,"end_character":49},"in_reply_to":"78bf5d4d_52047064","updated":"2021-12-21 17:46:09.000000000","message":"the test for this function is at https://opendev.org/openstack/octavia/src/branch/master/octavia/tests/unit/amphorae/backends/agent/api_server/test_amphora_info.py#L129\n\nI think we would need to add a mock for util.get_loadbalancers with a dummy random value (ex: a list of n IDs), then ensure that the parameter that is passed to _count_haproxy_processes is this parameter and not the return value of get_listeners, we can also check that haproxy_count is equal to the length of this list. I can help to modify the test if you need.","commit_id":"d0f07e22b0298c4784871d7baac7a7cebfc6c92b"}],"releasenotes/notes/fix-amphora-haproxy-count-b1b1df43a7150926.yaml":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"7644e84c5a3f96d80a7c31c456194159dc91770e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix amphora haproxy_count to return the number of"},{"line_number":5,"context_line":"    haproxy processes that are running."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6f1b9f77_24a3870a","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"updated":"2022-12-28 13:44:41.000000000","message":"Nit: I think it should be \"Fixed\"","commit_id":"d7516198e78e2be949ce1677d7976ed3ab1e3af6"}]}