)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"98dc5a51ebfa6f9a7e01a878a03324ecd45ff4bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d78b67ff_82dfc21b","updated":"2022-03-31 13:02:35.000000000","message":"Added to storyboard on https://storyboard.openstack.org/#!/story/2009953","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"7364a3e3636e055f831eac0c6728cf12f28356c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5475d15a_3ae9bba4","updated":"2022-03-29 12:16:21.000000000","message":"Can we merge this?","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"19bf7caf65f590c9544ff7be610feb2223584e48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a60dd83_f945a930","updated":"2022-03-31 12:50:49.000000000","message":"Feels like a regression in HAproxy to enforce that in a minor version.","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"676509d070e9b914ae3b5728383f5763107870fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a05b8a7_4694b1e0","updated":"2022-03-29 12:31:50.000000000","message":"I\u0027m on Xena","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"21c5bbea70ff3c5e8278abda4f834aa67c3037a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6d8b0b2_d3087b00","updated":"2022-02-21 17:45:51.000000000","message":"LGTM","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"c7af62047f19832dd675d4e9efa5db1c8168c091","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f521fe5_47c97f49","updated":"2022-03-31 12:49:01.000000000","message":"Note to self, NFV repo has updated version of HAproxy from 2.2.21 which has changed the behavior. When running the older version 2.2.1 the Ping healthcheck worked fine.\n\nWhen upgraded to 2.2.21 the Ping healthcheck fails because it uses external-check-command with a wrapper bash script for ping, but this requires insecure-fork-wanted to be set so the pool will be down.\n\n[ALERT] 089/123837 (1878) : Failed to fork process for external health check (likely caused by missing \u0027insecure-fork-wanted\u0027): Resource temporarily unavailable. Aborting.","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"85916b6a5eff79775a6962d5d88e58a65ec9d91b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"603dc6dc_75f3bd95","updated":"2022-03-31 13:08:44.000000000","message":"Thanks! It makes sense to disable ICMP PING healthcheck, either way the issue was discovered because a customer used that and we resolved it by changing to TCP.","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b996801c74c698ca031e99fb2b8788d45e8535f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5836506d_b2608ca3","updated":"2022-03-31 13:09:39.000000000","message":"We would not have recommended it either, however thinking about it disabling the Ping healthcheck causes other issues, like it should not be available in UI/dashboards to be selected etc but that\u0027s another thing.","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0e32b10bc52e8282870369810aca1281c4f482f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"efaa6326_7b3fcb97","updated":"2022-02-21 10:28:46.000000000","message":"would be great to have this backported as well, we are checking out the tagged release and setting DIB_REPOREF_amphora_agent when building our amphora images","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f6ee6c2a63d587430164881a35362e987c69e445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a548859b_c2bdf635","in_reply_to":"5475d15a_3ae9bba4","updated":"2022-03-29 12:22:19.000000000","message":"Yes, I need to ping a core review\n\nIn a previous comment, you mentioned that you would like to have this commit backported, are you on wallaby or xena?","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3b06eab87f56c45d608876ccee3a020a6e6d7440","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe901d3e_3abe8f63","in_reply_to":"9f521fe5_47c97f49","updated":"2022-03-31 13:06:22.000000000","message":"That\u0027s interesting.\nI know that we don\u0027t recommend using ICMP/Ping for the health checks.\n\nThere\u0027s a config option that administrators can use to disable it: [api]/allow_ping_health_monitors\n(and Red Hat used to carry a downstream patch to set it to False by default)\n\nThere are some tests for PING HM in octavia-tempest-plugin but it doesn\u0027t seem that we are evaluating the results (status of members) of those pings.\n\nDo you really see a benefit of using PING HM instead of TCP/HTTP HMs?","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3b06eab87f56c45d608876ccee3a020a6e6d7440","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f8895ea_1df31172","in_reply_to":"d78b67ff_82dfc21b","updated":"2022-03-31 13:06:22.000000000","message":"Thanks!","commit_id":"cc18c1e1b513b02559cd57ce36a6aedc76a606c1"}]}