)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e34d6163_354047cf","updated":"2022-03-03 18:48:04.000000000","message":"I have a handful of comments, but I think the general direction here is ok.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"71c1c120bbd1f51119e8279a291c15eed0f08ff7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"88ab3d70_01ee63c5","updated":"2022-03-03 16:35:06.000000000","message":"Thanks for putting up the spec!","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"0b410ec165cb3e372aa78305bbd1e10bb85b3c28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5e79218e_5fc57521","updated":"2022-03-03 19:27:56.000000000","message":"Thanks for reviewing it. I can answer some of the questions and leave the rest for Adam :) ","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"}],"doc/source/contributor/index.rst":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"4d64d5cc5893c60fc15831fa709230d6fa25e330","unresolved":true,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   specs/version1.1/*"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Version 11.0 (zed)"},{"line_number":94,"context_line":"``````````````````"},{"line_number":95,"context_line":".. toctree::"},{"line_number":96,"context_line":"   :glob:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1dafc4c5_3891b888","line":93,"range":{"start_line":93,"start_character":13,"end_line":93,"end_character":18},"updated":"2023-03-01 13:22:04.000000000","message":"That would need to get updated at least.","commit_id":"ae7a50468ce8e3f64ea27b444e08e13e0d7c87b5"}],"specs/version11.0/allowed-address-groups.rst":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":true,"context_lines":[{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Continue to use only `allowed_cidrs` for access control."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"42383dcc_30a2dcd4","line":40,"updated":"2022-03-03 18:48:04.000000000","message":"Another alternative could be to implement \"allowed_cidrs_groups\" in Octavia.\nI.e. reusable groups, per project, across LBs.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b732a4ebf4a61aa4f82e29b0e1e162cb88ff5244","unresolved":true,"context_lines":[{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Continue to use only `allowed_cidrs` for access control."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"656c65e0_8ea984af","line":40,"in_reply_to":"08034717_aec40b71","updated":"2022-03-03 20:13:16.000000000","message":"Yes, same. Then they are shareable even outside of Octavia. For example, we have users that utilize them for VMs already as well.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"0b410ec165cb3e372aa78305bbd1e10bb85b3c28","unresolved":true,"context_lines":[{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Continue to use only `allowed_cidrs` for access control."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"08034717_aec40b71","line":40,"in_reply_to":"42383dcc_30a2dcd4","updated":"2022-03-03 19:27:56.000000000","message":"Makes sense. But since Octavia already can talk to Neutron and the latter has the address group feature implemented, personally I\u0027d prefer reusing it.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":true,"context_lines":[{"line_number":43,"context_line":"Data model impact"},{"line_number":44,"context_line":"-----------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"One additional field will be required, `allowed_address_groups`, which will be"},{"line_number":47,"context_line":"handled identically to `allowed_cidrs` in the data model."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"015d92a0_0987f270","line":46,"updated":"2022-03-03 18:48:04.000000000","message":"We need to decide here how this will be persisted. Do you plan to create another DB table like allowed_cidrs did? (hint: says yes and add it to the spec).","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b732a4ebf4a61aa4f82e29b0e1e162cb88ff5244","unresolved":true,"context_lines":[{"line_number":43,"context_line":"Data model impact"},{"line_number":44,"context_line":"-----------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"One additional field will be required, `allowed_address_groups`, which will be"},{"line_number":47,"context_line":"handled identically to `allowed_cidrs` in the data model."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"00e08b3d_c5a27e6b","line":46,"in_reply_to":"015d92a0_0987f270","updated":"2022-03-03 20:13:16.000000000","message":"Right, I was hoping \"handled identically to allowed_cidrs\" would cover that, but I can go copy/paste the section from that spec here. :D","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":true,"context_lines":[{"line_number":53,"context_line":"**User API**:"},{"line_number":54,"context_line":"One additional field will be required, `allowed_address_groups`, which will be"},{"line_number":55,"context_line":"handled nearly identically to `allowed_cidrs` in the API (except as a list of"},{"line_number":56,"context_line":"UUIDs rather than a list of CIDRs)."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"**Provider API**:"},{"line_number":59,"context_line":"A new endpoint will be added, to allow providers to query for the full list of"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7419217f_fa3a3a5d","line":56,"updated":"2022-03-03 18:48:04.000000000","message":"Can you describe the intended API behavior if the user specifies both allowed_cidrs and allowed_address_groups?\nWill they merge in some way? can there be a conflict?","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"0b410ec165cb3e372aa78305bbd1e10bb85b3c28","unresolved":true,"context_lines":[{"line_number":53,"context_line":"**User API**:"},{"line_number":54,"context_line":"One additional field will be required, `allowed_address_groups`, which will be"},{"line_number":55,"context_line":"handled nearly identically to `allowed_cidrs` in the API (except as a list of"},{"line_number":56,"context_line":"UUIDs rather than a list of CIDRs)."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"**Provider API**:"},{"line_number":59,"context_line":"A new endpoint will be added, to allow providers to query for the full list of"}],"source_content_type":"text/x-rst","patch_set":2,"id":"de1e8d49_c64c9c04","line":56,"in_reply_to":"7419217f_fa3a3a5d","updated":"2022-03-03 19:27:56.000000000","message":"For amphora-provider which uses Neutron security groups, yes both should be supported. One security group can contain some rules with remote-cidr and others with remote-address-group. In the firewall driver backend (OVS for instance), cidrs will be merged to generate the firewall rules. There shouldn\u0027t be conflict as the final access rules will be the union of allowed_cidrs and allowed_address_groups.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b732a4ebf4a61aa4f82e29b0e1e162cb88ff5244","unresolved":true,"context_lines":[{"line_number":53,"context_line":"**User API**:"},{"line_number":54,"context_line":"One additional field will be required, `allowed_address_groups`, which will be"},{"line_number":55,"context_line":"handled nearly identically to `allowed_cidrs` in the API (except as a list of"},{"line_number":56,"context_line":"UUIDs rather than a list of CIDRs)."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"**Provider API**:"},{"line_number":59,"context_line":"A new endpoint will be added, to allow providers to query for the full list of"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ae31ab57_c295e4cc","line":56,"in_reply_to":"de1e8d49_c64c9c04","updated":"2022-03-03 20:13:16.000000000","message":"Right, they can very easily co-exist and will essentially just be merged together. Really, Address Groups are just a list of CIDRs stored elsewhere and linked in, so it\u0027s a union of the two things. I\u0027ll note this explicitly.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":true,"context_lines":[{"line_number":55,"context_line":"handled nearly identically to `allowed_cidrs` in the API (except as a list of"},{"line_number":56,"context_line":"UUIDs rather than a list of CIDRs)."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"**Provider API**:"},{"line_number":59,"context_line":"A new endpoint will be added, to allow providers to query for the full list of"},{"line_number":60,"context_line":"allowed CIDRs, given a list of Neutron Address Groups (for providers that don\u0027t"},{"line_number":61,"context_line":"have direct access to Neutron). Octavia will fetch these from Neutron and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4be73f0a_66d3f600","line":58,"updated":"2022-03-03 18:48:04.000000000","message":"This section should probably mention what data you will pass to the provider driver at API create time.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b732a4ebf4a61aa4f82e29b0e1e162cb88ff5244","unresolved":true,"context_lines":[{"line_number":55,"context_line":"handled nearly identically to `allowed_cidrs` in the API (except as a list of"},{"line_number":56,"context_line":"UUIDs rather than a list of CIDRs)."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"**Provider API**:"},{"line_number":59,"context_line":"A new endpoint will be added, to allow providers to query for the full list of"},{"line_number":60,"context_line":"allowed CIDRs, given a list of Neutron Address Groups (for providers that don\u0027t"},{"line_number":61,"context_line":"have direct access to Neutron). Octavia will fetch these from Neutron and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ce012121_1835065a","line":58,"in_reply_to":"4be73f0a_66d3f600","updated":"2022-03-03 20:13:16.000000000","message":"Yeah I guess this is a reasonable place for it.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":true,"context_lines":[{"line_number":60,"context_line":"allowed CIDRs, given a list of Neutron Address Groups (for providers that don\u0027t"},{"line_number":61,"context_line":"have direct access to Neutron). Octavia will fetch these from Neutron and"},{"line_number":62,"context_line":"return a full merged list of CIDRs for all requested Address Groups."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Security impact"},{"line_number":65,"context_line":"---------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4f22e3e8_05c3d7d2","line":63,"updated":"2022-03-03 18:48:04.000000000","message":"nit: Technically this isn\u0027t over REST, it\u0027s part of the octavia-lib library drivers get access to and works over a socket behind the scenes.\nhttps://github.com/openstack/octavia-lib/blob/master/octavia_lib/api/drivers/driver_lib.py#L164","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b732a4ebf4a61aa4f82e29b0e1e162cb88ff5244","unresolved":true,"context_lines":[{"line_number":60,"context_line":"allowed CIDRs, given a list of Neutron Address Groups (for providers that don\u0027t"},{"line_number":61,"context_line":"have direct access to Neutron). Octavia will fetch these from Neutron and"},{"line_number":62,"context_line":"return a full merged list of CIDRs for all requested Address Groups."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Security impact"},{"line_number":65,"context_line":"---------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5b3e1b60_0dc1849e","line":63,"in_reply_to":"4f22e3e8_05c3d7d2","updated":"2022-03-03 20:13:16.000000000","message":"Ah, shows how out of the loop I am. Maybe need to reorganize this then.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"71c1c120bbd1f51119e8279a291c15eed0f08ff7","unresolved":true,"context_lines":[{"line_number":82,"context_line":"Performance Impact"},{"line_number":83,"context_line":"------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"This will improve the underlying performance of the network in cases where many"},{"line_number":86,"context_line":"security group rules would have been created/duplicated."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ecb17740_8bdb7ce5","line":85,"updated":"2022-03-03 16:35:06.000000000","message":"It\u0027s worthy to note that one \"allowed address group\" will be bound to one security group rule. And one address group can contain multiple CIDRs and can be updated anytime by the user using the Neutron API.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":true,"context_lines":[{"line_number":85,"context_line":"This will improve the underlying performance of the network in cases where many"},{"line_number":86,"context_line":"security group rules would have been created/duplicated."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Other deployer impact"},{"line_number":89,"context_line":"---------------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"None."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3935f381_2bd94176","line":88,"updated":"2022-03-03 18:48:04.000000000","message":"For this feature, with the amphora provider, deployers will need to make sure the \"address_groups\" extension is enabled in neutron.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"0b410ec165cb3e372aa78305bbd1e10bb85b3c28","unresolved":true,"context_lines":[{"line_number":85,"context_line":"This will improve the underlying performance of the network in cases where many"},{"line_number":86,"context_line":"security group rules would have been created/duplicated."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Other deployer impact"},{"line_number":89,"context_line":"---------------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"None."}],"source_content_type":"text/x-rst","patch_set":2,"id":"d5a44037_106e79f1","line":88,"in_reply_to":"3935f381_2bd94176","updated":"2022-03-03 19:27:56.000000000","message":"yes, good call. And the exact Neutron API extension we want to check is \"security-groups-remote-address-group\" https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/security_groups_remote_address_group.py#L16","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b732a4ebf4a61aa4f82e29b0e1e162cb88ff5244","unresolved":true,"context_lines":[{"line_number":85,"context_line":"This will improve the underlying performance of the network in cases where many"},{"line_number":86,"context_line":"security group rules would have been created/duplicated."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Other deployer impact"},{"line_number":89,"context_line":"---------------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"None."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3563a976_c93f8bdf","line":88,"in_reply_to":"d5a44037_106e79f1","updated":"2022-03-03 20:13:16.000000000","message":"Ah good catch, thanks. I\u0027ll add that note.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":true,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"None."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Developer impact"},{"line_number":94,"context_line":"----------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"None."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fb89008f_ec228dad","line":93,"updated":"2022-03-03 18:48:04.000000000","message":"Somewhere in here, we need to talk about what the behavior will be if the address_group extension is missing or disabled in neutron.\nhttps://github.com/openstack/octavia/blob/master/octavia/network/drivers/neutron/base.py#L54\nI assume the Octavia API call will be rejected.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b732a4ebf4a61aa4f82e29b0e1e162cb88ff5244","unresolved":true,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"None."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Developer impact"},{"line_number":94,"context_line":"----------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"None."}],"source_content_type":"text/x-rst","patch_set":2,"id":"4b00299e_98f0fca0","line":93,"in_reply_to":"fb89008f_ec228dad","updated":"2022-03-03 20:13:16.000000000","message":"Yeah, I believe there is precedent for this, and I think you are correct. We would just reject the request with a useful error message.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":true,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Work Items"},{"line_number":108,"context_line":"----------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* Add Octavia REST API property and update data models/DB migration"},{"line_number":111,"context_line":"* Add Octavia Provider API endpoint to query Neutron for Address Group contents"},{"line_number":112,"context_line":"* Tempest testing for the new type of access control"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3d93efb3_504689be","line":109,"updated":"2022-03-03 18:48:04.000000000","message":"Update octavia-lib (needs to happen first)","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b732a4ebf4a61aa4f82e29b0e1e162cb88ff5244","unresolved":true,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Work Items"},{"line_number":108,"context_line":"----------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* Add Octavia REST API property and update data models/DB migration"},{"line_number":111,"context_line":"* Add Octavia Provider API endpoint to query Neutron for Address Group contents"},{"line_number":112,"context_line":"* Tempest testing for the new type of access control"}],"source_content_type":"text/x-rst","patch_set":2,"id":"15758888_eab08e39","line":109,"in_reply_to":"3d93efb3_504689be","updated":"2022-03-03 20:13:16.000000000","message":"Ah yes.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":true,"context_lines":[{"line_number":108,"context_line":"----------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* Add Octavia REST API property and update data models/DB migration"},{"line_number":111,"context_line":"* Add Octavia Provider API endpoint to query Neutron for Address Group contents"},{"line_number":112,"context_line":"* Tempest testing for the new type of access control"},{"line_number":113,"context_line":"* Update client to include the new Listener property `allowed_address_groups`"},{"line_number":114,"context_line":"* Update SDK to include the new Listener property `allowed_address_groups`"}],"source_content_type":"text/x-rst","patch_set":2,"id":"90b327e0_86d61bec","line":111,"updated":"2022-03-03 18:48:04.000000000","message":"library, but also update the provider driver data model and document for passing the initial create information.\nhttps://docs.openstack.org/octavia/latest/contributor/guides/providers.html#listener","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":true,"context_lines":[{"line_number":112,"context_line":"* Tempest testing for the new type of access control"},{"line_number":113,"context_line":"* Update client to include the new Listener property `allowed_address_groups`"},{"line_number":114,"context_line":"* Update SDK to include the new Listener property `allowed_address_groups`"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Dependencies"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8f064dbb_347f1d83","line":115,"updated":"2022-03-03 18:48:04.000000000","message":"Update dashboard to have the field.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b732a4ebf4a61aa4f82e29b0e1e162cb88ff5244","unresolved":true,"context_lines":[{"line_number":112,"context_line":"* Tempest testing for the new type of access control"},{"line_number":113,"context_line":"* Update client to include the new Listener property `allowed_address_groups`"},{"line_number":114,"context_line":"* Update SDK to include the new Listener property `allowed_address_groups`"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Dependencies"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b5a82fa6_19708679","line":115,"in_reply_to":"8f064dbb_347f1d83","updated":"2022-03-03 20:13:16.000000000","message":"Ack","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"27fac0e8c33478582855bb2beacb358aa3a40ca1","unresolved":true,"context_lines":[{"line_number":127,"context_line":"Documentation Impact"},{"line_number":128,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Documentation updates will be required for the additional property in the API."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"References"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2716ead5_19e94244","line":130,"updated":"2022-03-03 18:48:04.000000000","message":"Also update the provider driver development guide for the new library method and data model update.","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b732a4ebf4a61aa4f82e29b0e1e162cb88ff5244","unresolved":true,"context_lines":[{"line_number":127,"context_line":"Documentation Impact"},{"line_number":128,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Documentation updates will be required for the additional property in the API."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"References"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6d6588e7_4422238d","line":130,"in_reply_to":"2716ead5_19e94244","updated":"2022-03-03 20:13:16.000000000","message":"Ack","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"71c1c120bbd1f51119e8279a291c15eed0f08ff7","unresolved":true,"context_lines":[{"line_number":132,"context_line":"References"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. [#foot1] https://docs.openstack.org/api-ref/network/v2/index.html#address-groups"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e4707475_8fced5d5","line":135,"updated":"2022-03-03 16:35:06.000000000","message":"The address group Neutron spec: https://specs.openstack.org/openstack/neutron-specs/specs/victoria/address-groups-support-in-security-group-rule.html","commit_id":"498478d50c9ed0986ef99584dd143aa55e290ff0"}]}