)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"tag":"autogenerated:claude-review","change_message_id":"cf32adf5c531f0d3725b2dbba7a68743673801f2","unresolved":false,"context_lines":[{"line_number":487,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence keepalived-octavia\""},{"line_number":488,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence ipvsadmin\""},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"# Add frr element"},{"line_number":491,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence frr\""},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"# Add pip-cache element"},{"line_number":494,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence pip-cache\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"25265323_a95ac48b","line":491,"range":{"start_line":490,"start_character":0,"end_line":491,"end_character":0},"updated":"2026-06-04 09:54:39.000000000","message":"The `frr` element is unconditionally added to every amphora image. All other\n  optional features in this script have an `AMP_ENABLE_*` guard. FRR is a significant\n  routing daemon suite that may not be desired by all operators and increases image size and\n  attack surface.","commit_id":"9e7544468f3e556a49527d2215e5b3e22b3c4888"}],"elements/frr/package-installs.yaml":[{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"tag":"autogenerated:claude-review","change_message_id":"cf32adf5c531f0d3725b2dbba7a68743673801f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"frr:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b901b36e_f7cb40c2","line":1,"updated":"2026-06-04 09:54:39.000000000","message":"Single-line `frr:` with no distro filtering. On CentOS/RHEL/Rocky, FRR may\n  not be in the default repositories (requires EPEL or a custom repo). The build will fail\n  with a cryptic package-not-found error on those distros.","commit_id":"9e7544468f3e556a49527d2215e5b3e22b3c4888"}],"elements/frr/post-install.d/30-configure-frr":[{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"tag":"autogenerated:claude-review","change_message_id":"cf32adf5c531f0d3725b2dbba7a68743673801f2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -eu"},{"line_number":8,"context_line":"set -o pipefail"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"sed -i -e \u0027s/^bgpd\u003dno/bgpd\u003dyes/\u0027 \\"},{"line_number":11,"context_line":"       -e \u0027s/^bfdd\u003dno/bfdd\u003dyes/\u0027 /etc/frr/daemons"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"systemctl disable frr"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"abab0fd5_2a9f8c03","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":0},"updated":"2026-06-04 09:54:39.000000000","message":"The `sed` substitution silently succeeds even if no lines matching\n  `bgpd\u003dno` or `bfdd\u003dno` are found (e.g., if the distribution\u0027s default already has\n  `bgpd\u003dyes`, or uses a different format). There is no post-verification step.","commit_id":"9e7544468f3e556a49527d2215e5b3e22b3c4888"},{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"tag":"autogenerated:claude-review","change_message_id":"cf32adf5c531f0d3725b2dbba7a68743673801f2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"sed -i -e \u0027s/^bgpd\u003dno/bgpd\u003dyes/\u0027 \\"},{"line_number":11,"context_line":"       -e \u0027s/^bfdd\u003dno/bfdd\u003dyes/\u0027 /etc/frr/daemons"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"systemctl disable frr"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"48afc243_5fd0e525","line":13,"updated":"2026-06-04 09:54:39.000000000","message":"`systemctl disable frr` disables the service so it does not start at boot.\n  This is the correct approach since Octavia will manage the service at runtime. However,\n  there is no comment explaining this design decision, which may confuse future maintainers.","commit_id":"9e7544468f3e556a49527d2215e5b3e22b3c4888"}]}