)]}'
{"octavia/amphorae/drivers/bgp/jinja/templates/frr.conf.j2":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e7d943a0f36ba117ca1b98099222d95090346af5","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":"#}"},{"line_number":16,"context_line":"frr version 7.0"},{"line_number":17,"context_line":"frr defaults traditional"},{"line_number":18,"context_line":"log syslog debug"},{"line_number":19,"context_line":"!"},{"line_number":20,"context_line":"{% if debug %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"0e01334f_75a75a10","line":17,"updated":"2022-04-12 08:50:23.000000000","message":"Consider increasing timestamp precision\n    log timestamp precision 3\n\nhttps://docs.frrouting.org/en/latest/basic.html#clicmd-log-timestamp-precision-0-6","commit_id":"7ac87f5ff4b47ea70f982a83d10e2747cea9ee70"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e7d943a0f36ba117ca1b98099222d95090346af5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#}"},{"line_number":16,"context_line":"frr version 7.0"},{"line_number":17,"context_line":"frr defaults traditional"},{"line_number":18,"context_line":"log syslog debug"},{"line_number":19,"context_line":"!"},{"line_number":20,"context_line":"{% if debug %}"},{"line_number":21,"context_line":"debug bgp updates"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"f9c24d86_066f2a06","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":16},"updated":"2022-04-12 08:50:23.000000000","message":"Should this be in the \u0027if debug\u0027 clause below so debug logging is not always on?","commit_id":"7ac87f5ff4b47ea70f982a83d10e2747cea9ee70"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e7d943a0f36ba117ca1b98099222d95090346af5","unresolved":true,"context_lines":[{"line_number":18,"context_line":"log syslog debug"},{"line_number":19,"context_line":"!"},{"line_number":20,"context_line":"{% if debug %}"},{"line_number":21,"context_line":"debug bgp updates"},{"line_number":22,"context_line":"debug bfd peer"},{"line_number":23,"context_line":"debug bfd network"},{"line_number":24,"context_line":"!"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":"bfd"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"cf4df2f6_8b397a9b","line":23,"range":{"start_line":21,"start_character":0,"end_line":23,"end_character":17},"updated":"2022-04-12 08:50:23.000000000","message":"There are a few more that I found useful in multiple occasions:\n\ndebug zebra events\ndebug zebra nht\ndebug zebra kernel\ndebug zebra rib\ndebug zebra nexthop\ndebug bgp bfd\ndebug bgp neighbor-events\ndebug bgp updates\ndebug bgp keepalives\ndebug bgp nht\ndebug bgp zebra\ndebug bfd distributed\ndebug bfd network\ndebug bfd peer\ndebug bfd zebra","commit_id":"7ac87f5ff4b47ea70f982a83d10e2747cea9ee70"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e7d943a0f36ba117ca1b98099222d95090346af5","unresolved":true,"context_lines":[{"line_number":23,"context_line":"debug bfd network"},{"line_number":24,"context_line":"!"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":"bfd"},{"line_number":27,"context_line":"  peer {{ bgp_peer_ip }} local-address {{ amp_mgmt_ip }}"},{"line_number":28,"context_line":"    no shutdown"},{"line_number":29,"context_line":"  !"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c42b8df2_8849e103","line":26,"updated":"2022-04-12 08:50:23.000000000","message":"BFD appears to be a requirement. Is this intentional?\nFor sure I see how BFD can play an important role (sub-second failover as oppose to as low as 3-6 seconds with just BGP via timers).","commit_id":"7ac87f5ff4b47ea70f982a83d10e2747cea9ee70"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e7d943a0f36ba117ca1b98099222d95090346af5","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":"bfd"},{"line_number":27,"context_line":"  peer {{ bgp_peer_ip }} local-address {{ amp_mgmt_ip }}"},{"line_number":28,"context_line":"    no shutdown"},{"line_number":29,"context_line":"  !"},{"line_number":30,"context_line":"!"},{"line_number":31,"context_line":"router bgp {{ bgp_local_as }}"},{"line_number":32,"context_line":"  bgp router-id {{ amp_mgmt_ip }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"4f7a8884_35794645","line":29,"range":{"start_line":28,"start_character":4,"end_line":29,"end_character":3},"updated":"2022-04-12 08:50:23.000000000","message":"These two lines can be removed","commit_id":"7ac87f5ff4b47ea70f982a83d10e2747cea9ee70"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e7d943a0f36ba117ca1b98099222d95090346af5","unresolved":true,"context_lines":[{"line_number":29,"context_line":"  !"},{"line_number":30,"context_line":"!"},{"line_number":31,"context_line":"router bgp {{ bgp_local_as }}"},{"line_number":32,"context_line":"  bgp router-id {{ amp_mgmt_ip }}"},{"line_number":33,"context_line":"  neighbor {{ bgp_peer_ip }} remote-as {{ bgp_remote_as }}"},{"line_number":34,"context_line":"  {% if bgp_auth_type \u003d\u003d \"md5\" %}"},{"line_number":35,"context_line":"  neighbor {{ bgp_peer_ip }} password {{ bgp_auth_password }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d67f1894_385b2cf2","line":32,"updated":"2022-04-12 08:50:23.000000000","message":"This configuration won\u0027t work for eBGP sessions. You need to apply incoming and outgoing filters. It might be simpler to just not require policies at all:\n\n    no bgp ebgp-requires-policy\n\nSee more: https://docs.frrouting.org/en/latest/bgp.html#clicmd-bgp-ebgp-requires-policy","commit_id":"7ac87f5ff4b47ea70f982a83d10e2747cea9ee70"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e7d943a0f36ba117ca1b98099222d95090346af5","unresolved":true,"context_lines":[{"line_number":30,"context_line":"!"},{"line_number":31,"context_line":"router bgp {{ bgp_local_as }}"},{"line_number":32,"context_line":"  bgp router-id {{ amp_mgmt_ip }}"},{"line_number":33,"context_line":"  neighbor {{ bgp_peer_ip }} remote-as {{ bgp_remote_as }}"},{"line_number":34,"context_line":"  {% if bgp_auth_type \u003d\u003d \"md5\" %}"},{"line_number":35,"context_line":"  neighbor {{ bgp_peer_ip }} password {{ bgp_auth_password }}"},{"line_number":36,"context_line":"  {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"36aa9fd3_48e25227","line":33,"updated":"2022-04-12 08:50:23.000000000","message":"Would it make sense to allow peering with multiple neighbors?\nFor example, peering with two top-of-rack or provider edge routers.","commit_id":"7ac87f5ff4b47ea70f982a83d10e2747cea9ee70"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e7d943a0f36ba117ca1b98099222d95090346af5","unresolved":true,"context_lines":[{"line_number":31,"context_line":"router bgp {{ bgp_local_as }}"},{"line_number":32,"context_line":"  bgp router-id {{ amp_mgmt_ip }}"},{"line_number":33,"context_line":"  neighbor {{ bgp_peer_ip }} remote-as {{ bgp_remote_as }}"},{"line_number":34,"context_line":"  {% if bgp_auth_type \u003d\u003d \"md5\" %}"},{"line_number":35,"context_line":"  neighbor {{ bgp_peer_ip }} password {{ bgp_auth_password }}"},{"line_number":36,"context_line":"  {% endif %}"},{"line_number":37,"context_line":"  !"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5800a1e1_a17c3f0e","line":34,"updated":"2022-04-12 08:50:23.000000000","message":"Here you\u0027ve set a conditional that password may or may not be set. In the devstack plugin however it is always set to md5.","commit_id":"7ac87f5ff4b47ea70f982a83d10e2747cea9ee70"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e7d943a0f36ba117ca1b98099222d95090346af5","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  neighbor {{ bgp_peer_ip }} password {{ bgp_auth_password }}"},{"line_number":36,"context_line":"  {% endif %}"},{"line_number":37,"context_line":"  !"},{"line_number":38,"context_line":"  address-family ipv{% if vip_ipv6 %}6{% else %}4{% endif %} unicast"},{"line_number":39,"context_line":"   {% if vip_ipv6 %}"},{"line_number":40,"context_line":"   neighbor {{ bgp_peer_ip }} activate"},{"line_number":41,"context_line":"   {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"03832a9f_39d0a44c","line":38,"updated":"2022-04-12 08:50:23.000000000","message":"Note that IPv4 is on by default even if the address-family block is not defined.\nYou may want to add the following to disable IPv4 by default:\n\n    no bgp default ipv4-unicast","commit_id":"7ac87f5ff4b47ea70f982a83d10e2747cea9ee70"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e7d943a0f36ba117ca1b98099222d95090346af5","unresolved":true,"context_lines":[{"line_number":40,"context_line":"   neighbor {{ bgp_peer_ip }} activate"},{"line_number":41,"context_line":"   {% endif %}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"   neighbor {{ bgp_peer_ip }} route-map frontend out"},{"line_number":44,"context_line":"   network {{ vip_ip_address }}/{% if vip_ipv6 %}128{% else %}32{% endif %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  exit-address-family"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"561d71b9_761df375","line":43,"updated":"2022-04-12 08:50:23.000000000","message":"The local BGP daemon will accept any advertised IP prefixes from its neighbors and install them in the kernel routing table. This might likely pose a great security risk.\n\nConsider filtering all received routes. There are various ways to accomplish this such as via route-map or prefix-list.","commit_id":"7ac87f5ff4b47ea70f982a83d10e2747cea9ee70"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"aa207a6da2f91fb733e941f7042861f3a2879973","unresolved":true,"context_lines":[{"line_number":24,"context_line":"!"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":"bfd"},{"line_number":27,"context_line":"  peer {{ bgp_peer_ip }} local-address {{ amp_mgmt_ip }}"},{"line_number":28,"context_line":"    no shutdown"},{"line_number":29,"context_line":"  !"},{"line_number":30,"context_line":"!"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"6de9b4b2_684b78f6","line":27,"range":{"start_line":27,"start_character":25,"end_line":27,"end_character":56},"updated":"2025-05-16 12:03:29.000000000","message":"to fix: it shows \u0027local-address None\u0027 in the amphora","commit_id":"6f5449bba567ddaf41ff612ce1524feae6d8b65e"}]}