)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"40b8a486056346178ed0a59e6d0e1b2a74d344aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a3127542_02d290b7","updated":"2022-04-09 12:46:13.000000000","message":"recheck","commit_id":"f969d975b75a22b8d5d073a8d031b2933227dc77"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0bc6e9e47c59dcec69634d6b70861db08a2ad897","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a13121a5_e7610afd","updated":"2022-04-09 16:10:51.000000000","message":"recheck trying to reproduce a race condition in the CI","commit_id":"f969d975b75a22b8d5d073a8d031b2933227dc77"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"78aea0104688f80c55bf88a32f8ccf50a9cae806","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de42c1b7_09c91cc2","updated":"2022-04-09 14:08:24.000000000","message":"recheck trying to reproduce a race condition in the CI","commit_id":"f969d975b75a22b8d5d073a8d031b2933227dc77"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"7b6c7eca893da22e959fb4fe9f5c5cff6d2e3a6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"41703cfc_c0334537","updated":"2022-04-11 15:15:47.000000000","message":"recheck trying to reproduce bugs in the CI","commit_id":"340866a2deddbf79af56ccaf20e51a207a2ccefc"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"4fdef6be4a7847df88398f3859fcf836708ea560","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"910bc70e_4bc0fda5","updated":"2022-04-11 06:35:41.000000000","message":"recheck trying to reproduce bugs in the CI","commit_id":"340866a2deddbf79af56ccaf20e51a207a2ccefc"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"af0a8c88ba5601bd6ef88881cdf5b52228f7baca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"be2141e0_2728d2e1","updated":"2022-04-11 07:57:40.000000000","message":"recheck trying to reproduce bugs in the CI","commit_id":"340866a2deddbf79af56ccaf20e51a207a2ccefc"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"e1e6d9040c73d80837415fddca5fe630b7f2b29d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"585e76e0_dfa6eb47","updated":"2022-04-21 12:30:24.000000000","message":"recheck trying again","commit_id":"13bf184329e3aadf9a73341dae80d72f52672cd0"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"31e4de66e64c963b47662c8d31ff3e8659b63ffb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"07277f50_aaaec2a2","updated":"2022-04-15 14:28:27.000000000","message":"recheck trying to reproduce bugs in the CI","commit_id":"13bf184329e3aadf9a73341dae80d72f52672cd0"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"9565157690a4018a69f58b702d543d0a4e346c2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3212d462_469d95ec","updated":"2022-04-22 08:12:14.000000000","message":"recheck again","commit_id":"23b64b836594e8083fb26763da67511e9af47b8d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3e5fd915c1f3efa9b48da299a10a79770bb55b33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4ca56647_73b8c874","updated":"2022-04-22 09:21:59.000000000","message":"recheck again","commit_id":"23b64b836594e8083fb26763da67511e9af47b8d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a20c416d3c61d7021a49699f80fbfe0f272c25e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"96b253fa_ec192800","updated":"2022-04-22 13:52:28.000000000","message":"recheck looking for race conditions","commit_id":"23b64b836594e8083fb26763da67511e9af47b8d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"9b69f4ee42c0e8ab0a74f8781d76b6556041b3b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1d2e8df9_f1f5c227","updated":"2022-04-22 11:03:53.000000000","message":"recheck reason","commit_id":"23b64b836594e8083fb26763da67511e9af47b8d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"9f498d276e46c9882bb0c0966ac27e8554509321","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"202b5fab_e6185171","updated":"2022-04-22 12:53:28.000000000","message":"recheck reason?","commit_id":"23b64b836594e8083fb26763da67511e9af47b8d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"22b724000f5dbc39d0677779e8d20589f62a43e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5ca05800_f807d902","updated":"2022-04-22 05:37:36.000000000","message":"recheck trying again\n\n","commit_id":"23b64b836594e8083fb26763da67511e9af47b8d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a5bbcf28ef54b1968469e1986c8ce153dcef052c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0e7aa320_8c49ac25","updated":"2022-04-22 06:27:41.000000000","message":"recheck trying to reproduce a race condition in the CI","commit_id":"23b64b836594e8083fb26763da67511e9af47b8d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"aea9e599701b6b99ba6fd0d1acb89a003015c47a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a9df1483_ef3a6bb6","updated":"2022-04-22 07:18:45.000000000","message":"recheck verifying CI","commit_id":"23b64b836594e8083fb26763da67511e9af47b8d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"64b93e998a9ca071b0b569f7be964222c3667752","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"61098884_e6c75af6","updated":"2022-04-26 12:55:55.000000000","message":"recheck waiting for a FAILURE","commit_id":"23b64b836594e8083fb26763da67511e9af47b8d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"4b5cb4078b39f588f3ba68d603d5616a4aacbdd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1b4d63c2_5fd90d34","updated":"2022-04-26 16:43:45.000000000","message":"recheck checking CI","commit_id":"e9756444a888e6fc4107e5afd031e34b20519019"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f56f404dc282ba2d7c0f9b3e5a7d1f1bf7ca21c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2794af9e_d3719e6f","updated":"2022-04-26 20:00:17.000000000","message":"recheck still testing","commit_id":"e9756444a888e6fc4107e5afd031e34b20519019"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ebe4df300bda404506d410e7a481a9df78dd11d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"43c58369_87044969","updated":"2022-04-26 14:56:48.000000000","message":"recheck still testing","commit_id":"e9756444a888e6fc4107e5afd031e34b20519019"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"e019f07c034bfb6607fabeea8d713b3578f699e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"910e0f81_b0861334","updated":"2022-04-26 18:55:49.000000000","message":"recheck testing CI","commit_id":"e9756444a888e6fc4107e5afd031e34b20519019"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6498656d57cb4e4a8ed3343ad8c7402c608e2885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6a9b5ac2_311a3a20","updated":"2022-04-27 09:08:52.000000000","message":"recheck last(?) try before unWIPing the patch","commit_id":"8e3f1a5a70fd15758d5386209861d34149281c69"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2ead159bc04ec0b1b656e5a4ae2c9b5209b6437c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ae2a4ffc_70837afc","updated":"2022-04-27 07:52:17.000000000","message":"recheck verifying if the patch fixes the race conditions","commit_id":"8e3f1a5a70fd15758d5386209861d34149281c69"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"389b4b9e4a0fe38741e29b93e281d693a66c7a3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ca1591c8_86c2d384","updated":"2022-04-27 14:45:36.000000000","message":"LGTM","commit_id":"6042de759db557f421482d22185c5e5075511417"}],"octavia/controller/worker/v2/controller_worker.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"76075c08ac78d4b39bc1eece27ecdff0eadd5a5c","unresolved":true,"context_lines":[{"line_number":298,"context_line":"            db_lb \u003d self._get_db_obj_until_pending_update("},{"line_number":299,"context_line":"                self._lb_repo, listener[constants.LOADBALANCER_ID])"},{"line_number":300,"context_line":"        except tenacity.RetryError as e:"},{"line_number":301,"context_line":"            LOG.warning(\u0027Loadbalancer did not go into %s in 60 seconds. \u0027"},{"line_number":302,"context_line":"                        \u0027This either due to an in-progress Octavia upgrade \u0027"},{"line_number":303,"context_line":"                        \u0027or an overloaded and failing database. Assuming \u0027"},{"line_number":304,"context_line":"                        \u0027an upgrade is in progress and continuing.\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"6f51598d_cd176715","line":301,"range":{"start_line":301,"start_character":60,"end_line":301,"end_character":70},"updated":"2022-04-27 16:26:56.000000000","message":"I don\u0027t quite understand where the 60 seconds come from. It seems to be depend on configuration values api_db_commit_retry_max and api_db_commit_retry_attempts, They have default values of 5 and 15 respectively, so I\u0027d expect the timeout to be 5*15 seconds.","commit_id":"6042de759db557f421482d22185c5e5075511417"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"42870b83ad9537dc8a066e486b54f6e3ba8fb9a8","unresolved":true,"context_lines":[{"line_number":298,"context_line":"            db_lb \u003d self._get_db_obj_until_pending_update("},{"line_number":299,"context_line":"                self._lb_repo, listener[constants.LOADBALANCER_ID])"},{"line_number":300,"context_line":"        except tenacity.RetryError as e:"},{"line_number":301,"context_line":"            LOG.warning(\u0027Loadbalancer did not go into %s in 60 seconds. \u0027"},{"line_number":302,"context_line":"                        \u0027This either due to an in-progress Octavia upgrade \u0027"},{"line_number":303,"context_line":"                        \u0027or an overloaded and failing database. Assuming \u0027"},{"line_number":304,"context_line":"                        \u0027an upgrade is in progress and continuing.\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ec5a5564_7382980a","line":301,"range":{"start_line":301,"start_character":60,"end_line":301,"end_character":70},"in_reply_to":"6f51598d_cd176715","updated":"2022-04-27 16:37:33.000000000","message":"it comes from \n\nwait\u003dtenacity.wait_incrementing(\n            CONF.haproxy_amphora.api_db_commit_retry_initial_delay,\n            CONF.haproxy_amphora.api_db_commit_retry_backoff,\n            CONF.haproxy_amphora.api_db_commit_retry_max),\n\n(lines 87-90)\n\nthe initial delay is 1, then it is incremented after each try (but cannot exceed 5).\nduring my first run of the unit test, I didn\u0027t mock _lb_repo.get, so I reached the timeout, and it was 60sec ;-)","commit_id":"6042de759db557f421482d22185c5e5075511417"}]}