)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"59f5e1b02b883719eba6502431c0e4b5774d1c80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"306141ae_9f1f5c00","updated":"2022-05-05 16:56:02.000000000","message":"Marking -1 as I think we should at least have a non-voting python3.10 job if we declare it supported in the setup.cfg.","commit_id":"707ce12137427e2e0905fb5516c8d1c6d1222b43"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0929ddf2d4ff90fe06a4f78af2f1dae4ec05d50b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e0431cf1_ee44c527","updated":"2022-05-06 09:12:10.000000000","message":"Apparently openstack-tox-functional-py310 has not been defined yet: https://docs.openstack.org/infra/openstack-zuul-jobs/jobs.html#job-openstack-tox-functional-py39","commit_id":"2d4bdf2146be8c52473f8f555abbbe7a0301c320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6ce8167f1922a92c84240702513f910c87954e0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"32aadfef_0b197aa6","updated":"2022-05-06 16:55:08.000000000","message":"LGTM","commit_id":"737523f3bc8ab9dd71433a90411c3fc755e95f68"}],"octavia/cmd/prometheus_proxy.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"59f5e1b02b883719eba6502431c0e4b5774d1c80","unresolved":true,"context_lines":[{"line_number":785,"context_line":"    http.shutdown()"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"# TODO(johnsom) Remove and switch to ThreadingHTTPServer once python3.7 is"},{"line_number":789,"context_line":"# the minimum version supported."},{"line_number":790,"context_line":"class ThreadedHTTPServer(socketserver.ThreadingMixIn, HTTPServer):"},{"line_number":791,"context_line":"    daemon_threads \u003d True"}],"source_content_type":"text/x-python","patch_set":10,"id":"8d1ef754_2c91fa54","side":"PARENT","line":788,"updated":"2022-05-05 16:56:02.000000000","message":"Thanks for catching this!","commit_id":"2376f68bbaa48047167ce2167b19f3bf3b493e03"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"7982b321cf9768c0acd3bb08df2edb902d5fc052","unresolved":false,"context_lines":[{"line_number":785,"context_line":"    http.shutdown()"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"# TODO(johnsom) Remove and switch to ThreadingHTTPServer once python3.7 is"},{"line_number":789,"context_line":"# the minimum version supported."},{"line_number":790,"context_line":"class ThreadedHTTPServer(socketserver.ThreadingMixIn, HTTPServer):"},{"line_number":791,"context_line":"    daemon_threads \u003d True"}],"source_content_type":"text/x-python","patch_set":10,"id":"804ad30f_52eeedde","side":"PARENT","line":788,"in_reply_to":"8d1ef754_2c91fa54","updated":"2022-05-06 09:07:03.000000000","message":"sure 😊","commit_id":"2376f68bbaa48047167ce2167b19f3bf3b493e03"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"ef846844dad4e734f9008f68584873e083ca655b","unresolved":true,"context_lines":[{"line_number":805,"context_line":"                                                  args\u003d(httpd,))"},{"line_number":806,"context_line":"                shutdownthread.start()"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"                # TODO(johnsom) Uncomment this when we move to"},{"line_number":809,"context_line":"                #               ThreadingHTTPServer"},{"line_number":810,"context_line":"                # httpd.daemon_threads \u003d True"},{"line_number":811,"context_line":"                print(\"Now serving on port 9102\")"},{"line_number":812,"context_line":"                httpd.serve_forever()"},{"line_number":813,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":12,"id":"35ab86f9_1c3803e3","line":810,"range":{"start_line":808,"start_character":16,"end_line":810,"end_character":45},"updated":"2022-05-06 12:39:15.000000000","message":"These lines as well :)","commit_id":"670fa3bf58db2b01e12f4fdeb15976f19a133167"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"71ae8111485fa7046dad6cf3a0feb4d94d93d527","unresolved":false,"context_lines":[{"line_number":805,"context_line":"                                                  args\u003d(httpd,))"},{"line_number":806,"context_line":"                shutdownthread.start()"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"                # TODO(johnsom) Uncomment this when we move to"},{"line_number":809,"context_line":"                #               ThreadingHTTPServer"},{"line_number":810,"context_line":"                # httpd.daemon_threads \u003d True"},{"line_number":811,"context_line":"                print(\"Now serving on port 9102\")"},{"line_number":812,"context_line":"                httpd.serve_forever()"},{"line_number":813,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1d97e530_f8f654f7","line":810,"range":{"start_line":808,"start_character":16,"end_line":810,"end_character":45},"in_reply_to":"35ab86f9_1c3803e3","updated":"2022-05-06 13:05:33.000000000","message":"Good catch! Thanks","commit_id":"670fa3bf58db2b01e12f4fdeb15976f19a133167"}],"zuul.d/projects.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"59f5e1b02b883719eba6502431c0e4b5774d1c80","unresolved":true,"context_lines":[{"line_number":28,"context_line":"              - ^etc/.*$"},{"line_number":29,"context_line":"              - ^octavia/tests/unit/.*$"},{"line_number":30,"context_line":"              - ^releasenotes/.*$"},{"line_number":31,"context_line":"        - openstack-tox-functional-py39:"},{"line_number":32,"context_line":"            irrelevant-files:"},{"line_number":33,"context_line":"              - ^.*\\.rst$"},{"line_number":34,"context_line":"              - ^api-ref/.*$"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"62ec8407_2f17cead","line":31,"updated":"2022-05-05 16:56:02.000000000","message":"You added python310 to the setup.cfg list and tox.ini, I think we should have a py310 here as well. Non-voting is fine since it\u0027s not officially part of the PTI for zed. I just think we should have a test for it if it\u0027s in the setup.cfg.","commit_id":"707ce12137427e2e0905fb5516c8d1c6d1222b43"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"7982b321cf9768c0acd3bb08df2edb902d5fc052","unresolved":false,"context_lines":[{"line_number":28,"context_line":"              - ^etc/.*$"},{"line_number":29,"context_line":"              - ^octavia/tests/unit/.*$"},{"line_number":30,"context_line":"              - ^releasenotes/.*$"},{"line_number":31,"context_line":"        - openstack-tox-functional-py39:"},{"line_number":32,"context_line":"            irrelevant-files:"},{"line_number":33,"context_line":"              - ^.*\\.rst$"},{"line_number":34,"context_line":"              - ^api-ref/.*$"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"260492c5_61aea7a0","line":31,"in_reply_to":"62ec8407_2f17cead","updated":"2022-05-06 09:07:03.000000000","message":"Ack","commit_id":"707ce12137427e2e0905fb5516c8d1c6d1222b43"}]}
