)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"692369cd4c35652736fc0e7085d8365b5294bc2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e21f9be_19e9b627","updated":"2022-05-02 10:02:37.000000000","message":"LGTM but maybe we can go a step farther and update the devstack plugin to set this new [controller_worker]/amp_timesone setting to the TZ of the devstack host","commit_id":"924c14030c3d160d8815ce516656a17b6788d998"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6c8035241db91ad80df2e087d5a5af24e596395a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"83e1686c_feb4ba10","updated":"2022-05-05 23:00:59.000000000","message":"Just a comment to consider about the assumption that systemd timedatectl will be present and the output format will not change.","commit_id":"402e10d902e741442c9c4f19342acb9a43a72d1d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"aa8e767d5ea2987474e29909958df5acf232b329","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e2bfd0e7_88b917bd","updated":"2022-05-06 16:52:03.000000000","message":"LGTM","commit_id":"829e44acbd3b1d193ad0125c67b83ec5860a470f"}],"devstack/plugin.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6c8035241db91ad80df2e087d5a5af24e596395a","unresolved":true,"context_lines":[{"line_number":332,"context_line":"    iniset $OCTAVIA_CONF controller_worker network_driver ${OCTAVIA_NETWORK_DRIVER}"},{"line_number":333,"context_line":"    iniset $OCTAVIA_CONF controller_worker image_driver ${OCTAVIA_IMAGE_DRIVER}"},{"line_number":334,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_image_tag ${OCTAVIA_AMP_IMAGE_TAG}"},{"line_number":335,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_timezone $(timedatectl show --property\u003dTimezone | cut -d \"\u003d\" -f2)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    iniuncomment $OCTAVIA_CONF health_manager heartbeat_key"},{"line_number":338,"context_line":"    iniset $OCTAVIA_CONF health_manager heartbeat_key ${OCTAVIA_HEALTH_KEY}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"cc8abea1_f451981a","line":335,"updated":"2022-05-05 23:00:59.000000000","message":"This assumes the host is running systemd (for the timedatectl command) and that the output format won\u0027t change.\nConsider using /etc/timezone or parsing the /etc/localtime link?","commit_id":"402e10d902e741442c9c4f19342acb9a43a72d1d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"aa8e767d5ea2987474e29909958df5acf232b329","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    iniset $OCTAVIA_CONF controller_worker network_driver ${OCTAVIA_NETWORK_DRIVER}"},{"line_number":333,"context_line":"    iniset $OCTAVIA_CONF controller_worker image_driver ${OCTAVIA_IMAGE_DRIVER}"},{"line_number":334,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_image_tag ${OCTAVIA_AMP_IMAGE_TAG}"},{"line_number":335,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_timezone $(timedatectl show --property\u003dTimezone | cut -d \"\u003d\" -f2)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    iniuncomment $OCTAVIA_CONF health_manager heartbeat_key"},{"line_number":338,"context_line":"    iniset $OCTAVIA_CONF health_manager heartbeat_key ${OCTAVIA_HEALTH_KEY}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"2bce02ac_e459ca81","line":335,"in_reply_to":"267de271_290ebd5f","updated":"2022-05-06 16:52:03.000000000","message":"Hmm, I suspect there are going to be grumpy Java users. lol\nI raised the question about systemd partially because it\u0027s the third init system we have dealt with since the start of the project.","commit_id":"402e10d902e741442c9c4f19342acb9a43a72d1d"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"9eede76cdd87524cc2e50f68967b91c060575a75","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    iniset $OCTAVIA_CONF controller_worker network_driver ${OCTAVIA_NETWORK_DRIVER}"},{"line_number":333,"context_line":"    iniset $OCTAVIA_CONF controller_worker image_driver ${OCTAVIA_IMAGE_DRIVER}"},{"line_number":334,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_image_tag ${OCTAVIA_AMP_IMAGE_TAG}"},{"line_number":335,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_timezone $(timedatectl show --property\u003dTimezone | cut -d \"\u003d\" -f2)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    iniuncomment $OCTAVIA_CONF health_manager heartbeat_key"},{"line_number":338,"context_line":"    iniset $OCTAVIA_CONF health_manager heartbeat_key ${OCTAVIA_HEALTH_KEY}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"267de271_290ebd5f","line":335,"in_reply_to":"cc8abea1_f451981a","updated":"2022-05-06 10:04:00.000000000","message":"/etc/timezone does not exist on my CentOS 9 Stream test system. I did consider using the /etc/localtime link at first, but it\u0027s harder and also error prone.\n\nFor instance:\n\n$ readlink /etc/localtime | sed \"s/\\/usr\\/share\\/zoneinfo\\///\"\n\nmay give you \"America/New_York\" as it should, but only if the link uses the absolute path. In my C9S system I got \"..America/New_York\" because it uses a relative path. Handling both cases adds complexity.\n\nIt seems that all major Linux distributions that we want to support use SystemD nowadays[1]. I\u0027ll change the command to \"timedatectl show -p Timezone --value\" so output format changes of timedatectl won\u0027t break this.\n\n[1] https://en.wikipedia.org/wiki/Category:Linux_distributions_without_systemd","commit_id":"402e10d902e741442c9c4f19342acb9a43a72d1d"}]}