)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"18ce3a05cef4d62f737f5f04103d06ff3b5b54e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ed53e46d_0293f13d","updated":"2022-05-30 12:59:46.000000000","message":"diskimage-create/README.rst also needs updating.\n\nYou might also want to consider moving amphora focal-based jobs over or adding jammy-based jobs in zuul.d/jobs.yaml. Ideally, the switch to Jammy from Focal should be aligned with the documented tested runtimes for Zed which, at this point in time, do not include Jammy but Focal. See https://governance.openstack.org/tc/reference/runtimes/zed.html","commit_id":"f9e2716907e0b77e2db02035ad1117eaed599d96"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"953a31a5f0d2058fea007faae128b572ea578b61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8afcf368_2e60191c","in_reply_to":"ed53e46d_0293f13d","updated":"2022-05-30 14:04:23.000000000","message":"Thanks, you\u0027re right. I reverted my original change and changed the CentOS default instead. For CentOS the changes\n\n* https://review.opendev.org/c/openstack/octavia/+/831840\n* https://review.opendev.org/c/openstack/octavia/+/827330\n\nupdate the Zuul config already.","commit_id":"f9e2716907e0b77e2db02035ad1117eaed599d96"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"792e94bff62d0a41f9a110425d19f99f3674929e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4f120ac1_d021d693","updated":"2022-05-31 18:34:14.000000000","message":"Oh, this description is confusing. This isn\u0027t as big a change as I thought, just updating the centos default to 9, not changing the default base OS from Ubuntu.","commit_id":"6b18c22655f561f04fc6a14dfc485cef5594e2bc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6479908da1982f80fee436aec3b1df210e958755","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a9119d46_cc231eb3","updated":"2022-05-31 18:32:26.000000000","message":"This is a big change and should have a release note.","commit_id":"6b18c22655f561f04fc6a14dfc485cef5594e2bc"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"69e9b14f5154339f32cb978addb2420eb61c4eef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0e871be5_0c97b0cd","in_reply_to":"4f120ac1_d021d693","updated":"2022-06-01 07:09:14.000000000","message":"Sorry for the confusion. The change itself has changed completely since the beginning, but I also updated the description. Please let me know if you want me to change something specifically in the current version.","commit_id":"6b18c22655f561f04fc6a14dfc485cef5594e2bc"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"74dfd0f0422f8e074d0be8803024ea98dad00490","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6049e18e_98461305","updated":"2022-06-01 08:15:25.000000000","message":"I\u0027d recommend also adding test coverage, at least an amphora image build job similar to https://github.com/openstack/octavia/blob/6253560d22f255c499c91612ac4286dd0d8329e1/zuul.d/jobs.yaml#L166-L177","commit_id":"9b187042f48ecb385aa4c8e697c5760497798179"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"881fe3bc42007acee24e1a19955afd85bdf236ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f867353b_12bed54b","in_reply_to":"6049e18e_98461305","updated":"2022-06-01 08:26:54.000000000","message":"Done here https://review.opendev.org/c/openstack/octavia/+/827330","commit_id":"9b187042f48ecb385aa4c8e697c5760497798179"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"66d0e31fa034f1783e60c4a57ec2e6a07511365e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8e6f4df8_2baa8bd0","updated":"2022-06-02 20:03:33.000000000","message":"LGTM","commit_id":"f444fa7c4d4e946d41f6a03b9bc02eb05584ef79"}],"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"66d0e31fa034f1783e60c4a57ec2e6a07511365e","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    echo \"            [-a i386 | **amd64** | armhf | aarch64 | ppc64le]\""},{"line_number":24,"context_line":"    echo \"            [-b **haproxy** ]\""},{"line_number":25,"context_line":"    echo \"            [-c **~/.cache/image-create** | \u003ccache directory\u003e ]\""},{"line_number":26,"context_line":"    echo \"            [-d **focal**/**9-stream**/**9** | \u003cother release id\u003e ]\""},{"line_number":27,"context_line":"    echo \"            [-e]\""},{"line_number":28,"context_line":"    echo \"            [-f]\""},{"line_number":29,"context_line":"    echo \"            [-g **repository branch** | stable/train | stable/stein | ... ]\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"175d7ee6_7eee8f4c","line":26,"range":{"start_line":26,"start_character":49,"end_line":26,"end_character":55},"updated":"2022-06-02 20:03:33.000000000","message":"nit: the ** are getting confusing, sigh.","commit_id":"f444fa7c4d4e946d41f6a03b9bc02eb05584ef79"}]}
