)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ad709c9e9d3a064510a30af0fdaff392881b8363","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c4ba211_dc7a20db","updated":"2022-06-15 16:17:15.000000000","message":"I sure wish DIB had stable branches....\nLGTM, thanks!","commit_id":"633257bcd7b1e83894aa742e2e40e6d4e6768955"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fd08ff6653e218d4aa56fdfc57cba64717e52657","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a36d5f8a_76520e7c","updated":"2022-06-15 16:19:51.000000000","message":"Oh, that is a good point in the other comment.\nWe should align those.","commit_id":"633257bcd7b1e83894aa742e2e40e6d4e6768955"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"32973fb4f7d82fec544798878f6505e68d0df43d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6d22bced_13fedc98","updated":"2022-06-15 13:43:04.000000000","message":"Thanks. It looks like train and ussuri install DIB differently, and this patch will likely not work as is.","commit_id":"633257bcd7b1e83894aa742e2e40e6d4e6768955"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"dae861130b4232655a0d6a0de0774b4009a7313c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"682403c0_0eb60124","updated":"2022-06-16 16:04:58.000000000","message":"LGTM","commit_id":"efeb4da03e31770246a8e715133ce9153561c8a5"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"93688f02be60991064fd2833b54f9883f93e9bd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4793fbfa_8f4a332d","updated":"2022-06-21 11:55:46.000000000","message":"quick merge, would unblock the gates, affects only devstack deployments","commit_id":"efeb4da03e31770246a8e715133ce9153561c8a5"}],"devstack/plugin.sh":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"32973fb4f7d82fec544798878f6505e68d0df43d","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            if ! [ -d $DIB_GIT_DIR ]; then"},{"line_number":119,"context_line":"                git clone ${GITREPO[\"diskimage-builder\"]} $DIB_GIT_DIR"},{"line_number":120,"context_line":"                # Checkout the last commit that supports py36"},{"line_number":121,"context_line":"                (cd $DIB_GIT_DIR \u0026\u0026 git checkout 70e90e17551499b1f8d0c2d0bc36ee4698aa18a0)"},{"line_number":122,"context_line":"            fi"},{"line_number":123,"context_line":"            (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/stable/ussuri:upper-constraints.txt) | sed \u0027/diskimage-builder/d\u0027 \u003e $DIB_VENV_DIR/u-c.txt"},{"line_number":124,"context_line":"            pip install -c $DIB_VENV_DIR/u-c.txt $DIB_GIT_DIR"}],"source_content_type":"text/x-sh","patch_set":1,"id":"19fc86c2_3527fe82","line":121,"updated":"2022-06-15 13:43:04.000000000","message":"I wonder if that\u0027s enough for ussuri as we call the install_diskimage_builder function above on line 56.\nWe should also probably update the default for DISKIMAGE_BUILDER_REPO_REF.","commit_id":"633257bcd7b1e83894aa742e2e40e6d4e6768955"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"b6bac9161e768a7ca3cde8d02f148072a315c3b7","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            if ! [ -d $DIB_GIT_DIR ]; then"},{"line_number":119,"context_line":"                git clone ${GITREPO[\"diskimage-builder\"]} $DIB_GIT_DIR"},{"line_number":120,"context_line":"                # Checkout the last commit that supports py36"},{"line_number":121,"context_line":"                (cd $DIB_GIT_DIR \u0026\u0026 git checkout 70e90e17551499b1f8d0c2d0bc36ee4698aa18a0)"},{"line_number":122,"context_line":"            fi"},{"line_number":123,"context_line":"            (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/stable/ussuri:upper-constraints.txt) | sed \u0027/diskimage-builder/d\u0027 \u003e $DIB_VENV_DIR/u-c.txt"},{"line_number":124,"context_line":"            pip install -c $DIB_VENV_DIR/u-c.txt $DIB_GIT_DIR"}],"source_content_type":"text/x-sh","patch_set":1,"id":"8469102e_a1769c22","line":121,"in_reply_to":"19fc86c2_3527fe82","updated":"2022-06-16 11:31:54.000000000","message":"I think the call at line 56 is useless, because we are creating a new venv with a different dib release.\nI have updated DISKIMAGE_BUILDER_REPO_REF, and we are now using it to checkout the correct reference in DIB","commit_id":"633257bcd7b1e83894aa742e2e40e6d4e6768955"}]}