)]}'
{"id":"openstack%2Foctavia~846548","triplet_id":"openstack%2Foctavia~stable%2Fxena~Ic370e9edc3fb5548e9cf0d66b85df66e01c41e79","project":"openstack/octavia","branch":"stable/xena","topic":"3cf866-xena","attention_set":{},"removed_from_attention_set":{"34429":{"account":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"last_update":"2022-06-29 19:17:43.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic370e9edc3fb5548e9cf0d66b85df66e01c41e79","subject":"Validate L7Rule value and cookie name","status":"MERGED","created":"2022-06-20 06:42:19.000000000","updated":"2022-06-29 19:19:19.000000000","submitted":"2022-06-29 19:17:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"846548-3cf866-xena","meta_rev_id":"f5749d7c4ef8a1736e49a1722c771a1f018a7e88","_number":846548,"virtual_id_number":846548,"owner":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-06-29 19:17:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"all":[{"value":2,"date":"2022-06-20 11:59:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":2,"date":"2022-06-29 16:50:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":1,"date":"2022-06-29 16:50:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-20 08:59:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-20 11:59:38.000000000","updated_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"reviewer":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"state":"REVIEWER"},{"updated":"2022-06-29 16:50:06.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"}],"messages":[{"id":"2a6b85eecd4527ae32d80c665235b26869f45f5e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"date":"2022-06-20 06:42:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cebb6bc87d9df7730af2ad7b2b052e100af4012c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-20 08:59:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a564a90e69e84235a8610923ba80d278 : SUCCESS in 9m 14s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/73ab9ee1c5064fb89664ba03d1662b94 : SUCCESS in 9m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/29ee00a3100047e0b3d454a8ba446f8e : SUCCESS in 5m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b7e8991efd8943c9a25d57db0adb40d7 : SUCCESS in 5m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/35c9871e644c4a50ab7a43c1a58cbe36 : SUCCESS in 5m 09s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f8f03cf012c34e56b29669cad64a0412 : SUCCESS in 5m 32s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ddc44a383dbf4d999e601f2f406fff3e : SUCCESS in 14m 47s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8fa3484f75a84785b7ada74f0fc3a129 : SUCCESS in 5m 18s\n- octavia-tox-py37-tips https://zuul.opendev.org/t/openstack/build/a6863e8f97fc4f12878b3d233684bdf8 : SUCCESS in 5m 46s\n- octavia-tox-functional-py37-tips https://zuul.opendev.org/t/openstack/build/2aa7d7f47073464991b47db403479f66 : SUCCESS in 8m 56s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/a4f6c4d283cd4b948f1b0038f2d438f7 : SUCCESS in 5m 36s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/44bbc7d587a24375a103099cdb098f02 : SUCCESS in 8m 20s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/a6582e5e76694d5498abecf9ec57f50c : SUCCESS in 2h 15m 16s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/daf2c8dbe89c4d56b341b5d423386d4d : SUCCESS in 1h 44m 38s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/eb539c8fe6ea4049979406e54580d35d : SUCCESS in 35m 51s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/e9a444f9dc5349ed8cd306600fca04ba : SUCCESS in 49m 36s\n- octavia-v2-dsvm-tls-barbican-fips https://zuul.opendev.org/t/openstack/build/1bd33f4c9f844578a01f8b5943dbe43f : RETRY_LIMIT in 12m 16s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/c85eb33c4b86490d814d93343aa46968 : SUCCESS in 34m 34s (non-voting)\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/203a6956be33410999e1c460f9dbfcee : SUCCESS in 1h 20m 45s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/836201dfe2fb402990e7787536dcb529 : SUCCESS in 2h 02m 06s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/b225c5174251482a82e707d082ce58b7 : SUCCESS in 1h 28m 29s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2 https://zuul.opendev.org/t/openstack/build/262ac1b9c83842aaa663dc11efeccd8a : SUCCESS in 1h 36m 23s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2-no-jobboard https://zuul.opendev.org/t/openstack/build/60f7b86d6c4a44609ac63ffe5a5f2013 : SUCCESS in 1h 48m 03s (non-voting)\n- octavia-v2-dsvm-scenario-centos-8 https://zuul.opendev.org/t/openstack/build/79dc3fe257ca412f8fbba6190ed7ef15 : NODE_FAILURE in 0s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"15b8ae6fd32817f3cda33e964c168f7e5ae64fc9","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2022-06-20 11:59:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"19866c2e26abe22ff98af816bd11256273eec348","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2022-06-29 16:50:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f58882ea57825c62483403a66549fe6b6441b992","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-29 16:51:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9108c6c2195d1c3a87eb60c7e05c24122f679d85","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-29 19:17:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/44b1436d4c8647b19af7ba523636f4d6 : SUCCESS in 10m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/908f58fca51245df9246561c1b89e95f : SUCCESS in 5m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e95983c58cf246f6b8296cedcff0f5fc : SUCCESS in 5m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/feda7243f1bc45a8b1d0b119ea304661 : SUCCESS in 5m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a6bfdf166d0246fcaea574674f8fbe38 : SUCCESS in 14m 14s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e19b01bf549a45049674b879b2915582 : SUCCESS in 5m 22s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/9b8c094533c046d3b78f2643df05abc9 : SUCCESS in 7m 28s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/04dfe4c2bd55442a98bfb184054e5a40 : SUCCESS in 9m 29s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/cacda0914a0d46789be8c4b20ba7333f : SUCCESS in 2h 20m 48s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/81b1bc6a5ad54de49944f8926f3e79cb : SUCCESS in 1h 24m 38s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/c24104a37f534c24bceedd8d0385f641 : SUCCESS in 37m 02s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/b9e41ae47b4f4f65a8082ece1f7d1e48 : SUCCESS in 48m 42s","accounts_in_message":[],"_revision_number":1},{"id":"e14806a46d26eb6c745f6a39883f8d6d9a5dd8c0","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-29 19:17:43.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"f5749d7c4ef8a1736e49a1722c771a1f018a7e88","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-29 19:19:19.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b015367af29d4d3996f859db71c74757 : SUCCESS in 1m 11s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b1cd55cfff744a51af8989e1f5c96784 : SUCCESS in 50s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c30aa9df228548f30ff7609ee8f8f3cb36b5f89d","revisions":{"c30aa9df228548f30ff7609ee8f8f3cb36b5f89d":{"kind":"REWORK","_number":1,"created":"2022-06-20 06:42:19.000000000","uploader":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"ref":"refs/changes/48/846548/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/48/846548/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/48/846548/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/48/846548/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/48/846548/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/48/846548/1"}}},"commit":{"parents":[{"commit":"d668e1f2055e0124cce4a4b7abae06ade340e24a","subject":"Fix new pylint issues","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/d668e1f2055e0124cce4a4b7abae06ade340e24a"}]}],"author":{"name":"Tom Weininger","email":"tweining@redhat.com","date":"2022-03-25 13:49:38.000000000","tz":60},"committer":{"name":"Tom Weininger","email":"tweining@redhat.com","date":"2022-06-20 06:41:51.000000000","tz":120},"subject":"Validate L7Rule value and cookie name","message":"Validate L7Rule value and cookie name\n\nAdds validations in L7 rule and session cookie APIs in order to prevent\nauthenticated and authorized users to inject code into HAProxy\nconfiguration. CR and LF (\\r and \\n) are no longer allowed in L7\nrule keys and values. The session persistence cookie names must follow\nthe rules described in\nhttps://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie.\n\nStory: 2008994\nTask: 44859\nChange-Id: Ic370e9edc3fb5548e9cf0d66b85df66e01c41e79\n(cherry picked from commit 3cf866dbc096ff2b6136d1e06da3f668f6ffeaaa)\n(cherry picked from commit 133ec4763db7889179ee09b897f503eb68ccd42e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/c30aa9df228548f30ff7609ee8f8f3cb36b5f89d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/c30aa9df228548f30ff7609ee8f8f3cb36b5f89d"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[]}