)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"566d5c1547bc879a1addb78135fc6619ff2d3f4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ef4e0c03_c8b7775c","updated":"2022-07-25 10:38:06.000000000","message":"These are the results of my cpu pinning efforts as of Patchset 10: https://paste.opendev.org/show/bPQYrRV34WQ3IqXRJUkP/\nIt needs more testing though.","commit_id":"ca5355809164586d173901a11f99d031d4baef00"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"811056a28fc5c1f5fba45652dd52b96b77605756","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"640f527c_0b332380","updated":"2022-07-25 14:53:16.000000000","message":"recheck strange failure","commit_id":"ca5355809164586d173901a11f99d031d4baef00"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6bda57dbafac5e4dff3fe5bf43aba8f90a224936","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"524c8d87_0cf84ed7","updated":"2022-08-22 08:02:18.000000000","message":"LGTM","commit_id":"24ea898125a01b7f23f0f8a166e0a0cf522443c7"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"eca4c3630a3219b8c2b74bccac2f6b57dd2419a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"106dcba8_ba83303a","updated":"2022-08-25 10:27:20.000000000","message":"LGTM","commit_id":"9514f5b9db9de4cc9dc267a9de4891358c859013"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f7e8eec262e2aed5651c3cfce6bccea72bc1312d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"5e847b73_0283d881","updated":"2022-11-28 16:28:27.000000000","message":"LGTM","commit_id":"74b49e5aa7d139fce56c789a29fadf446ba68dcc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"49ecfd9705095e234e0f1feb79dfee4f05dccd92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"f5dc9539_7bd757a0","updated":"2022-12-07 20:16:58.000000000","message":"I think we have some debug comments left in some of the files.","commit_id":"97a2fbdeb764714b88a345c2892b84a4dd6ff263"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"312fab7963489d9e2613676a57017478913e7d00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"d361a6c9_80d31e2c","updated":"2022-12-07 12:26:29.000000000","message":"Thanks.","commit_id":"97a2fbdeb764714b88a345c2892b84a4dd6ff263"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"c13067c2d2fb00058c06b9c634a1fb348f935a0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"9949c540_038fa8e0","updated":"2022-12-09 17:54:23.000000000","message":"recheck tox issue should be resolved now","commit_id":"c1ebe18e2a4e144d9cf03568b43da91c9cbaa6f3"}],"diskimage-create/README.rst":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"be4fe43f35346417377cd9218e2160d8e1624d86","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            [-i **ubuntu-minimal** | fedora | centos-minimal | rhel ]"},{"line_number":111,"context_line":"            [-k \u003ckernel package name\u003e ]"},{"line_number":112,"context_line":"            [-l \u003clog file\u003e ]"},{"line_number":113,"context_line":"            [-m]"},{"line_number":114,"context_line":"            [-n]"},{"line_number":115,"context_line":"            [-o **amphora-x64-haproxy** | \u003cfilename\u003e ]"},{"line_number":116,"context_line":"            [-p]"}],"source_content_type":"text/x-rst","patch_set":38,"id":"96087e87_39da56bb","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":16},"updated":"2022-11-28 15:11:03.000000000","message":"nit: Can you add -m option before -n?","commit_id":"76743e238650b11eb54b146c429c7b925978b807"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f7e8eec262e2aed5651c3cfce6bccea72bc1312d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            [-i **ubuntu-minimal** | fedora | centos-minimal | rhel ]"},{"line_number":111,"context_line":"            [-k \u003ckernel package name\u003e ]"},{"line_number":112,"context_line":"            [-l \u003clog file\u003e ]"},{"line_number":113,"context_line":"            [-m]"},{"line_number":114,"context_line":"            [-n]"},{"line_number":115,"context_line":"            [-o **amphora-x64-haproxy** | \u003cfilename\u003e ]"},{"line_number":116,"context_line":"            [-p]"}],"source_content_type":"text/x-rst","patch_set":38,"id":"943a6112_bfcfd724","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":16},"in_reply_to":"96087e87_39da56bb","updated":"2022-11-28 16:28:27.000000000","message":"For some reason I thought this one had the wrong order too. Please ignore that comment.","commit_id":"76743e238650b11eb54b146c429c7b925978b807"}],"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6a9173ebf71b0789bd3a0ddc500f087d15d4b4cb","unresolved":true,"context_lines":[{"line_number":474,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence certs-ramfs\""},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"# Add cpu-pinning element"},{"line_number":477,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence cpu-pinning\""},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"# Disable SSHD if requested"},{"line_number":480,"context_line":"if [ \"$AMP_DISABLE_SSHD\" -eq 1 ]; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"f2150800_ce142a16","line":477,"range":{"start_line":477,"start_character":44,"end_line":477,"end_character":55},"updated":"2022-08-18 14:12:08.000000000","message":"maybe we should add a env var (and a getopt flag) that would disable it in case a user doesn\u0027t need it","commit_id":"326b7f19b39d8b16f85cbbdd17d088812cfd0972"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6bda57dbafac5e4dff3fe5bf43aba8f90a224936","unresolved":false,"context_lines":[{"line_number":474,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence certs-ramfs\""},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"# Add cpu-pinning element"},{"line_number":477,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence cpu-pinning\""},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"# Disable SSHD if requested"},{"line_number":480,"context_line":"if [ \"$AMP_DISABLE_SSHD\" -eq 1 ]; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"d81c7a94_289ced4f","line":477,"range":{"start_line":477,"start_character":44,"end_line":477,"end_character":55},"in_reply_to":"b28e4a61_faa71c5a","updated":"2022-08-22 08:02:18.000000000","message":"thanks LGTM","commit_id":"326b7f19b39d8b16f85cbbdd17d088812cfd0972"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0f66597513db395d8fbfcae90cbf3153f79d40a7","unresolved":false,"context_lines":[{"line_number":474,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence certs-ramfs\""},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"# Add cpu-pinning element"},{"line_number":477,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence cpu-pinning\""},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"# Disable SSHD if requested"},{"line_number":480,"context_line":"if [ \"$AMP_DISABLE_SSHD\" -eq 1 ]; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"b28e4a61_faa71c5a","line":477,"range":{"start_line":477,"start_character":44,"end_line":477,"end_character":55},"in_reply_to":"f2150800_ce142a16","updated":"2022-08-19 09:48:06.000000000","message":"Done","commit_id":"326b7f19b39d8b16f85cbbdd17d088812cfd0972"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2e615b4413bd9850ca3c74a2e81d8af2a109352e","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    echo \"            [-k \u003ckernel package name\u003e ]\""},{"line_number":33,"context_line":"    echo \"            [-l \u003clog file\u003e ]\""},{"line_number":34,"context_line":"    echo \"            [-n]\""},{"line_number":35,"context_line":"    echo \"            [-m]\""},{"line_number":36,"context_line":"    echo \"            [-o **amphora-x64-haproxy.qcow2** | \u003cfilename\u003e ]\""},{"line_number":37,"context_line":"    echo \"            [-p]\""},{"line_number":38,"context_line":"    echo \"            [-r \u003croot password\u003e ]\""}],"source_content_type":"text/x-sh","patch_set":38,"id":"9eb874db_4ea39ad5","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":27},"updated":"2022-11-28 15:10:03.000000000","message":"nit: Can you add -m option before -n?","commit_id":"76743e238650b11eb54b146c429c7b925978b807"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"d40ec785ad2c892b0fefe2b1295518101f76b40b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    echo \"            [-k \u003ckernel package name\u003e ]\""},{"line_number":33,"context_line":"    echo \"            [-l \u003clog file\u003e ]\""},{"line_number":34,"context_line":"    echo \"            [-n]\""},{"line_number":35,"context_line":"    echo \"            [-m]\""},{"line_number":36,"context_line":"    echo \"            [-o **amphora-x64-haproxy.qcow2** | \u003cfilename\u003e ]\""},{"line_number":37,"context_line":"    echo \"            [-p]\""},{"line_number":38,"context_line":"    echo \"            [-r \u003croot password\u003e ]\""}],"source_content_type":"text/x-sh","patch_set":38,"id":"087f5f30_91e117ad","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":27},"in_reply_to":"9eb874db_4ea39ad5","updated":"2022-11-28 15:47:46.000000000","message":"Done","commit_id":"76743e238650b11eb54b146c429c7b925978b807"}],"elements/cpu-pinning/environment.d/80-kernel-cpu-affinity":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"ae1adc1fbdc90e289a00b47a55a49aa2fa53ec13","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" irqaffinity\u003d0\""},{"line_number":28,"context_line":"        # This will be ignored on single vCPU systems"},{"line_number":29,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" isolcpus\u003d1-N\""},{"line_number":30,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" nohz_full\u003d1-N\""},{"line_number":31,"context_line":"        export DIB_BOOTLOADER_DEFAULT_CMDLINE"},{"line_number":32,"context_line":"    ;;"},{"line_number":33,"context_line":"    *)"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"171af330_df49f916","line":30,"range":{"start_line":30,"start_character":42,"end_line":30,"end_character":51},"updated":"2022-08-17 15:28:00.000000000","message":"Just to make sure: I read on RH downstream docs that the nohz parameter is required to activate the nohz_full parameter.\n\nhttps://access.redhat.com/documentation/en-us/red_hat_enterprise_linux_for_real_time/9/html/optimizing_rhel_9_for_real_time_for_low_latency_operation/con_isolating-cpus-using-the-nohz-and-nohz_full-parameters_optimizing-rhel9-for-real-time-for-low-latency-operation\n\nSo I am just adding this comment to make sure it was checked, I didn\u0027t test the feature yet and I am on PTO for a week from tomorrow.","commit_id":"326b7f19b39d8b16f85cbbdd17d088812cfd0972"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6a9173ebf71b0789bd3a0ddc500f087d15d4b4cb","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" irqaffinity\u003d0\""},{"line_number":28,"context_line":"        # This will be ignored on single vCPU systems"},{"line_number":29,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" isolcpus\u003d1-N\""},{"line_number":30,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" nohz_full\u003d1-N\""},{"line_number":31,"context_line":"        export DIB_BOOTLOADER_DEFAULT_CMDLINE"},{"line_number":32,"context_line":"    ;;"},{"line_number":33,"context_line":"    *)"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"2a5faa2c_39f56ee8","line":30,"range":{"start_line":30,"start_character":42,"end_line":30,"end_character":51},"in_reply_to":"171af330_df49f916","updated":"2022-08-18 14:12:08.000000000","message":"+1","commit_id":"326b7f19b39d8b16f85cbbdd17d088812cfd0972"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0f66597513db395d8fbfcae90cbf3153f79d40a7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" irqaffinity\u003d0\""},{"line_number":28,"context_line":"        # This will be ignored on single vCPU systems"},{"line_number":29,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" isolcpus\u003d1-N\""},{"line_number":30,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" nohz_full\u003d1-N\""},{"line_number":31,"context_line":"        export DIB_BOOTLOADER_DEFAULT_CMDLINE"},{"line_number":32,"context_line":"    ;;"},{"line_number":33,"context_line":"    *)"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"ebe4ea12_cb3d9112","line":30,"range":{"start_line":30,"start_character":42,"end_line":30,"end_character":51},"in_reply_to":"171af330_df49f916","updated":"2022-08-19 09:48:06.000000000","message":"The official Linux kernel documentation [1] says that nohz\u003don is the default, but I found no way to verify this at runtime. Fact is that in CentOS Stream 9 kernels CONFIG_NO_HZ_IDLE is not set and hence nohz might indeed not be active. Thanks for bringing this up.\n\nI was unsure if I should include this setting at all in this change. I added it because it makes sense to me as it moves as much kernel noise away from isolated CPUs as possible and should reduce latency. However, I am not sure if it is really worth it and it goes beyond the original scope of this RFE.\n\nThat said, and given the fact that there isn\u0027t a lot time left for integrating this into the Zed release, I decided to move nohz_full stuff to a separate change so it can be tested and reviewed independently.\n\nI only tested this change in my devstack environment so far, and when testing with nested VMs on a single host the performance results may differ a lot from a real production deployment. Hence I didn\u0027t post any measurement so far. However, I think that nohz_full in particular needs to be stress tested before it gets merged.\n\n[1] https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html?highlight\u003dnohz","commit_id":"326b7f19b39d8b16f85cbbdd17d088812cfd0972"}],"elements/cpu-pinning/pkg-map":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6bda57dbafac5e4dff3fe5bf43aba8f90a224936","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"740c6393_a56fc10f","line":14,"range":{"start_line":1,"start_character":0,"end_line":14,"end_character":0},"updated":"2022-08-22 08:02:18.000000000","message":"nit is it need? AFAIK this file is used when packages have different names in different distros, here it maps \"tuned\" to \"tuned\" for all distros","commit_id":"24ea898125a01b7f23f0f8a166e0a0cf522443c7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"49ecfd9705095e234e0f1feb79dfee4f05dccd92","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"680c689e_edd9fc95","line":14,"range":{"start_line":1,"start_character":0,"end_line":14,"end_character":0},"in_reply_to":"192682d8_1271cad2","updated":"2022-12-07 20:16:58.000000000","message":"Nit: If you need to do another spin, this and pkg-map dependency can be removed. As Greg mentioned, this is only needed if we need to map package names on the various distros.","commit_id":"24ea898125a01b7f23f0f8a166e0a0cf522443c7"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"335790426d4c949d185509c3f6f43262a2c36747","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"c5d5f784_c0d276f6","line":14,"range":{"start_line":1,"start_character":0,"end_line":14,"end_character":0},"in_reply_to":"680c689e_edd9fc95","updated":"2022-12-08 10:39:28.000000000","message":"Done","commit_id":"24ea898125a01b7f23f0f8a166e0a0cf522443c7"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"f80c065df85f1c005c1a098ec832c4eed035788f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"192682d8_1271cad2","line":14,"range":{"start_line":1,"start_character":0,"end_line":14,"end_character":0},"in_reply_to":"740c6393_a56fc10f","updated":"2022-11-15 09:56:47.000000000","message":"It is probably not needed in this case. It shouldn\u0027t really hurt to have it though.","commit_id":"24ea898125a01b7f23f0f8a166e0a0cf522443c7"}],"elements/cpu-pinning/static/etc/tuned/amphora/script.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"49ecfd9705095e234e0f1feb79dfee4f05dccd92","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# fails on the amp in this line"},{"line_number":4,"context_line":"# DISKS_SYS\u003d\"$(command ls -d1 /sys/block/{sd,cciss,dm-,vd,dasd,xvd}* 2\u003e/dev/null)\""},{"line_number":5,"context_line":"sed -i \u0027s/^DISKS_SYS\u003d/#\u0026/\u0027 /usr/lib/tuned/functions"},{"line_number":6,"context_line":". /usr/lib/tuned/functions"}],"source_content_type":"text/x-sh","patch_set":41,"id":"382263f3_299f7794","line":3,"updated":"2022-12-07 20:16:58.000000000","message":"Does this comment need to be here? It seems like it was a debugging comment.","commit_id":"97a2fbdeb764714b88a345c2892b84a4dd6ff263"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"335790426d4c949d185509c3f6f43262a2c36747","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# fails on the amp in this line"},{"line_number":4,"context_line":"# DISKS_SYS\u003d\"$(command ls -d1 /sys/block/{sd,cciss,dm-,vd,dasd,xvd}* 2\u003e/dev/null)\""},{"line_number":5,"context_line":"sed -i \u0027s/^DISKS_SYS\u003d/#\u0026/\u0027 /usr/lib/tuned/functions"},{"line_number":6,"context_line":". /usr/lib/tuned/functions"}],"source_content_type":"text/x-sh","patch_set":41,"id":"459e5372_4207b65f","line":3,"in_reply_to":"382263f3_299f7794","updated":"2022-12-08 10:39:28.000000000","message":"It explains why the sed command below is needed, so I think it is useful. I\u0027ll make it more clear though.","commit_id":"97a2fbdeb764714b88a345c2892b84a4dd6ff263"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"49ecfd9705095e234e0f1feb79dfee4f05dccd92","unresolved":true,"context_lines":[{"line_number":6,"context_line":". /usr/lib/tuned/functions"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"start() {"},{"line_number":9,"context_line":"    setup_kvm_mod_low_latency"},{"line_number":10,"context_line":"    disable_ksm"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    return \"$?\""}],"source_content_type":"text/x-sh","patch_set":41,"id":"c2b521a5_6d5a03de","line":9,"updated":"2022-12-07 20:16:58.000000000","message":"It would be nice to have a comment here explaining why. In six months, if we need to re-address this setting it would be nice to have a note that helps refresh our memories.","commit_id":"97a2fbdeb764714b88a345c2892b84a4dd6ff263"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f6370e7d5bfcb7ee1416a72404efd767e890be46","unresolved":true,"context_lines":[{"line_number":6,"context_line":". /usr/lib/tuned/functions"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"start() {"},{"line_number":9,"context_line":"    setup_kvm_mod_low_latency"},{"line_number":10,"context_line":"    disable_ksm"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    return \"$?\""}],"source_content_type":"text/x-sh","patch_set":41,"id":"7af231f6_d0a34a3d","line":9,"in_reply_to":"4b1ff296_7359a27c","updated":"2022-12-08 15:59:28.000000000","message":"I think they are fine, I was just a bit worried that with some of these settings we will have to go re-research why they are here again and that a comment might be nice to make that easier.","commit_id":"97a2fbdeb764714b88a345c2892b84a4dd6ff263"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"335790426d4c949d185509c3f6f43262a2c36747","unresolved":true,"context_lines":[{"line_number":6,"context_line":". /usr/lib/tuned/functions"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"start() {"},{"line_number":9,"context_line":"    setup_kvm_mod_low_latency"},{"line_number":10,"context_line":"    disable_ksm"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    return \"$?\""}],"source_content_type":"text/x-sh","patch_set":41,"id":"4b1ff296_7359a27c","line":9,"in_reply_to":"c2b521a5_6d5a03de","updated":"2022-12-08 10:39:28.000000000","message":"This script is almost an exact copy of [1]. I only modified it in order to fix some error. These two functions are defined in /usr/lib/tuned/functions.\n\nsetup_kvm_mod_low_latency sets some KVM settings in a modprobe file depending on some conditions [3]. I tried to find out what they do exactly, but they seem to be KVM internal settings that aren\u0027t well documented. disable_ksm disables Kernel Same-page Merging [2]. \n\nIf you prefer I can remove those two lines. I don\u0027t think that they do much on a KVM guest.\n\n[1]: https://github.com/redhat-performance/tuned/blob/master/profiles/cpu-partitioning/script.sh\n[2]: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/virtualization_tuning_and_optimization_guide/chap-ksm\n[3]: https://paste.opendev.org/show/bADJf4kbsXUHA1x2Cyo5/","commit_id":"97a2fbdeb764714b88a345c2892b84a4dd6ff263"}],"elements/cpu-pinning/static/etc/tuned/amphora/tuned.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"49ecfd9705095e234e0f1feb79dfee4f05dccd92","unresolved":true,"context_lines":[{"line_number":46,"context_line":"[sysctl]"},{"line_number":47,"context_line":"kernel.numa_balancing\u003d0"},{"line_number":48,"context_line":"kernel.hung_task_timeout_secs \u003d 600"},{"line_number":49,"context_line":"# ERROR    tuned.plugins.plugin_sysctl: Failed to set sysctl parameter \u0027kernel.nmi_watchdog\u0027 to \u00270\u0027: [Errno 524] Unknown error 524"},{"line_number":50,"context_line":"# kernel.nmi_watchdog \u003d 0"},{"line_number":51,"context_line":"vm.stat_interval \u003d 10"},{"line_number":52,"context_line":"# See https://bugzilla.redhat.com/show_bug.cgi?id\u003d1797629"}],"source_content_type":"text/plain","patch_set":41,"id":"99593dd9_423fd059","line":49,"updated":"2022-12-07 20:16:58.000000000","message":"Does this comment need to be here or was it debugging notes from developemnt?","commit_id":"97a2fbdeb764714b88a345c2892b84a4dd6ff263"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"335790426d4c949d185509c3f6f43262a2c36747","unresolved":false,"context_lines":[{"line_number":46,"context_line":"[sysctl]"},{"line_number":47,"context_line":"kernel.numa_balancing\u003d0"},{"line_number":48,"context_line":"kernel.hung_task_timeout_secs \u003d 600"},{"line_number":49,"context_line":"# ERROR    tuned.plugins.plugin_sysctl: Failed to set sysctl parameter \u0027kernel.nmi_watchdog\u0027 to \u00270\u0027: [Errno 524] Unknown error 524"},{"line_number":50,"context_line":"# kernel.nmi_watchdog \u003d 0"},{"line_number":51,"context_line":"vm.stat_interval \u003d 10"},{"line_number":52,"context_line":"# See https://bugzilla.redhat.com/show_bug.cgi?id\u003d1797629"}],"source_content_type":"text/plain","patch_set":41,"id":"2aac1e49_03788826","line":49,"in_reply_to":"99593dd9_423fd059","updated":"2022-12-08 10:39:28.000000000","message":"I removed it now. It was copied from [1], but it didn\u0027t seem to work due to this error.\n\n[1]: https://github.com/redhat-performance/tuned/blob/master/profiles/cpu-partitioning/tuned.conf","commit_id":"97a2fbdeb764714b88a345c2892b84a4dd6ff263"}],"elements/cpu-pinning/svc-map":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6bda57dbafac5e4dff3fe5bf43aba8f90a224936","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"a26e2c0d_5a874f7c","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":0},"updated":"2022-08-22 08:02:18.000000000","message":"same here, is it needed?\nupdate: it seems we have other similar files (like ipvsadmin), because it\u0027s worth it to keep it if in the future a distro changes the name of a package","commit_id":"24ea898125a01b7f23f0f8a166e0a0cf522443c7"}],"elements/tuned-tuna/environment.d/80-kernel-cpu-affinity":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"73a623c56aac9a616a5ebddd60009584184ace65","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        # bash-5.1# cat /sys/devices/system/cpu/nohz_full"},{"line_number":32,"context_line":"        # (null)"},{"line_number":33,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" irqaffinity\u003d0\""},{"line_number":34,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" isolcpus\u003d1-N\""},{"line_number":35,"context_line":"        DIB_BOOTLOADER_DEFAULT_CMDLINE+\u003d\" nohz_full\u003d1-N\""},{"line_number":36,"context_line":"        export DIB_BOOTLOADER_DEFAULT_CMDLINE"},{"line_number":37,"context_line":"    ;;"},{"line_number":38,"context_line":"    *)"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"83f235fa_16234d7d","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":56},"updated":"2022-08-10 16:21:56.000000000","message":"These lines will generate only a warning with an amphora with only a single vCPU.\n\nAug 01 11:33:06 localhost kernel: Housekeeping: nohz_full\u003d or isolcpus\u003d incorrect CPU range\nAug 01 11:33:06 localhost kernel: Housekeeping: nohz_full\u003d or isolcpus\u003d incorrect CPU range\nAug 01 11:33:06 localhost kernel: Unknown kernel command line parameters \"nofb BOOT_IMAGE\u003d(hd0,msdos1)/boot/vmlinuz-5.14.0-134.el9.x86_64 gfxpayload\u003dtext isolcpus\u003d1-N nohz_full\u003d1-N\", will be passed to user space.\n\nFor simplicity reasons I would like to keep it that way.","commit_id":"ca5355809164586d173901a11f99d031d4baef00"}],"elements/tuned-tuna/static/usr/lib/tuned/amphora/script.sh":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"566d5c1547bc879a1addb78135fc6619ff2d3f4f","unresolved":true,"context_lines":[{"line_number":6,"context_line":". /usr/lib/tuned/functions"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"start() {"},{"line_number":9,"context_line":"    mkdir -p \"${TUNED_tmpdir}/etc/systemd\""},{"line_number":10,"context_line":"    mkdir -p \"${TUNED_tmpdir}/usr/lib/dracut/hooks/pre-udev\""},{"line_number":11,"context_line":"    cp /etc/systemd/system.conf \"${TUNED_tmpdir}/etc/systemd/\""},{"line_number":12,"context_line":"    cp 00-tuned-pre-udev.sh \"${TUNED_tmpdir}/usr/lib/dracut/hooks/pre-udev/\""},{"line_number":13,"context_line":"    setup_kvm_mod_low_latency"},{"line_number":14,"context_line":"    disable_ksm"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    # Migrate irqs to CPU 0"},{"line_number":17,"context_line":"    # Commented because the element sets irqaffinity\u003d0 already"}],"source_content_type":"text/x-sh","patch_set":4,"id":"48bc8558_be517215","line":14,"range":{"start_line":9,"start_character":4,"end_line":14,"end_character":15},"updated":"2022-07-25 10:38:06.000000000","message":"all the dracut related things are probably not needed","commit_id":"20780fcb3050d6ed19e2f571300d61d1ed5845cd"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"401b9aaa1409dc1032d9d094d8448eb534884d3b","unresolved":false,"context_lines":[{"line_number":6,"context_line":". /usr/lib/tuned/functions"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"start() {"},{"line_number":9,"context_line":"    mkdir -p \"${TUNED_tmpdir}/etc/systemd\""},{"line_number":10,"context_line":"    mkdir -p \"${TUNED_tmpdir}/usr/lib/dracut/hooks/pre-udev\""},{"line_number":11,"context_line":"    cp /etc/systemd/system.conf \"${TUNED_tmpdir}/etc/systemd/\""},{"line_number":12,"context_line":"    cp 00-tuned-pre-udev.sh \"${TUNED_tmpdir}/usr/lib/dracut/hooks/pre-udev/\""},{"line_number":13,"context_line":"    setup_kvm_mod_low_latency"},{"line_number":14,"context_line":"    disable_ksm"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    # Migrate irqs to CPU 0"},{"line_number":17,"context_line":"    # Commented because the element sets irqaffinity\u003d0 already"}],"source_content_type":"text/x-sh","patch_set":4,"id":"b42eeb93_ff304483","line":14,"range":{"start_line":9,"start_character":4,"end_line":14,"end_character":15},"in_reply_to":"48bc8558_be517215","updated":"2022-08-19 13:22:23.000000000","message":"Done","commit_id":"20780fcb3050d6ed19e2f571300d61d1ed5845cd"}],"releasenotes/notes/add-cpu-pinning-element-86617303b720d5a9.yaml":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6a9173ebf71b0789bd3a0ddc500f087d15d4b4cb","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    for improving network latency."},{"line_number":12,"context_line":"upgrade:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    Amphora vertical scaling optimizations require an image rebuild in order"},{"line_number":15,"context_line":"    to become effective."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"49a9e078_6d2514c8","line":14,"range":{"start_line":14,"start_character":60,"end_line":14,"end_character":67},"updated":"2022-08-18 14:12:08.000000000","message":"I would rather say that it requires to update the image (of new load balancers and of existing load balancers).\nI would expect that the person who reads the release notes has already access to a new image.","commit_id":"326b7f19b39d8b16f85cbbdd17d088812cfd0972"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0f66597513db395d8fbfcae90cbf3153f79d40a7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    for improving network latency."},{"line_number":12,"context_line":"upgrade:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    Amphora vertical scaling optimizations require an image rebuild in order"},{"line_number":15,"context_line":"    to become effective."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7d355d82_6348f529","line":14,"range":{"start_line":14,"start_character":60,"end_line":14,"end_character":67},"in_reply_to":"49a9e078_6d2514c8","updated":"2022-08-19 09:48:06.000000000","message":"Done","commit_id":"326b7f19b39d8b16f85cbbdd17d088812cfd0972"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6a9173ebf71b0789bd3a0ddc500f087d15d4b4cb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d64a7b28_3fd2db56","line":16,"updated":"2022-08-18 14:12:08.000000000","message":"I think we should also mention that users with custom flavors (vcpus \u003e 1) will get a different behavior when updating.","commit_id":"326b7f19b39d8b16f85cbbdd17d088812cfd0972"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0f66597513db395d8fbfcae90cbf3153f79d40a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"16c6e95b_0d659a5d","line":16,"in_reply_to":"d64a7b28_3fd2db56","updated":"2022-08-19 09:48:06.000000000","message":"Done","commit_id":"326b7f19b39d8b16f85cbbdd17d088812cfd0972"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"e221f0493ca33758b029b580e76d1472ba6cab14","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    vertical scaling. When an amphora flavor with multiple vCPUs is configured"},{"line_number":6,"context_line":"    it will configure the kernel to isolate (isolcpus)"},{"line_number":7,"context_line":"    all vCPUs except the first one."},{"line_number":8,"context_line":"    Furthermore, it uninstalls irqbalance and sets the IRQ affinity to the "},{"line_number":9,"context_line":"    first CPU. That way the other CPUs are free to be used by HAProxy "},{"line_number":10,"context_line":"    exclusively. A new customized TuneD profile applies some more tweaks"},{"line_number":11,"context_line":"    for improving network latency."}],"source_content_type":"text/x-yaml","patch_set":39,"id":"e4c56304_caa6ea1c","line":8,"range":{"start_line":8,"start_character":74,"end_line":8,"end_character":75},"updated":"2022-12-07 12:06:21.000000000","message":"there are a few extra whitespaces in this file","commit_id":"74b49e5aa7d139fce56c789a29fadf446ba68dcc"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"312fab7963489d9e2613676a57017478913e7d00","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    vertical scaling. When an amphora flavor with multiple vCPUs is configured"},{"line_number":6,"context_line":"    it will configure the kernel to isolate (isolcpus)"},{"line_number":7,"context_line":"    all vCPUs except the first one."},{"line_number":8,"context_line":"    Furthermore, it uninstalls irqbalance and sets the IRQ affinity to the "},{"line_number":9,"context_line":"    first CPU. That way the other CPUs are free to be used by HAProxy "},{"line_number":10,"context_line":"    exclusively. A new customized TuneD profile applies some more tweaks"},{"line_number":11,"context_line":"    for improving network latency."}],"source_content_type":"text/x-yaml","patch_set":39,"id":"bce201a3_77dbe5d9","line":8,"range":{"start_line":8,"start_character":74,"end_line":8,"end_character":75},"in_reply_to":"e4c56304_caa6ea1c","updated":"2022-12-07 12:26:29.000000000","message":"Done","commit_id":"74b49e5aa7d139fce56c789a29fadf446ba68dcc"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"e221f0493ca33758b029b580e76d1472ba6cab14","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    first CPU. That way the other CPUs are free to be used by HAProxy "},{"line_number":10,"context_line":"    exclusively. A new customized TuneD profile applies some more tweaks"},{"line_number":11,"context_line":"    for improving network latency."},{"line_number":12,"context_line":"    This new feature is enabled by default, but can be disabled by running"},{"line_number":13,"context_line":"    `diskimage-create.sh` with the `-m` option or setting the"},{"line_number":14,"context_line":"    `AMP_DISABLE_SSHD` environment variable to 1 before running the script."},{"line_number":15,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"012a4483_4973acde","line":12,"range":{"start_line":12,"start_character":9,"end_line":12,"end_character":42},"updated":"2022-12-07 12:06:21.000000000","message":"it is now disabled by default","commit_id":"74b49e5aa7d139fce56c789a29fadf446ba68dcc"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"312fab7963489d9e2613676a57017478913e7d00","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    first CPU. That way the other CPUs are free to be used by HAProxy "},{"line_number":10,"context_line":"    exclusively. A new customized TuneD profile applies some more tweaks"},{"line_number":11,"context_line":"    for improving network latency."},{"line_number":12,"context_line":"    This new feature is enabled by default, but can be disabled by running"},{"line_number":13,"context_line":"    `diskimage-create.sh` with the `-m` option or setting the"},{"line_number":14,"context_line":"    `AMP_DISABLE_SSHD` environment variable to 1 before running the script."},{"line_number":15,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"8ea94d5f_5a46bcda","line":12,"range":{"start_line":12,"start_character":9,"end_line":12,"end_character":42},"in_reply_to":"012a4483_4973acde","updated":"2022-12-07 12:26:29.000000000","message":"Done","commit_id":"74b49e5aa7d139fce56c789a29fadf446ba68dcc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"49ecfd9705095e234e0f1feb79dfee4f05dccd92","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    `AMP_ENABLE_CPUPINNING` environment variable to 1 before running the script."},{"line_number":15,"context_line":"upgrade:"},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Amphora vertical scaling optimizations require an amphora image update"},{"line_number":18,"context_line":"    (of new load balancers and of existing load balancers) in order"},{"line_number":19,"context_line":"    to become effective. Users with custom flavors with more than a single"},{"line_number":20,"context_line":"    vCPU will get a different behavior after updating (see feature description)."}],"source_content_type":"text/x-yaml","patch_set":41,"id":"facbb8d7_60b51a88","line":17,"updated":"2022-12-07 20:16:58.000000000","message":"nit: It requires a new image with an optional setting enabled. Just a rebuild will not enable this.","commit_id":"97a2fbdeb764714b88a345c2892b84a4dd6ff263"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"335790426d4c949d185509c3f6f43262a2c36747","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    `AMP_ENABLE_CPUPINNING` environment variable to 1 before running the script."},{"line_number":15,"context_line":"upgrade:"},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Amphora vertical scaling optimizations require an amphora image update"},{"line_number":18,"context_line":"    (of new load balancers and of existing load balancers) in order"},{"line_number":19,"context_line":"    to become effective. Users with custom flavors with more than a single"},{"line_number":20,"context_line":"    vCPU will get a different behavior after updating (see feature description)."}],"source_content_type":"text/x-yaml","patch_set":41,"id":"a81e6d3c_9416fbf4","line":17,"in_reply_to":"facbb8d7_60b51a88","updated":"2022-12-08 10:39:28.000000000","message":"Done.","commit_id":"97a2fbdeb764714b88a345c2892b84a4dd6ff263"}]}