)]}'
{"id":"openstack%2Foctavia~855467","triplet_id":"openstack%2Foctavia~stable%2Fvictoria~I24ec7dc3b18111c126bcfdaa0780bfd7993020fb","project":"openstack/octavia","branch":"stable/victoria","topic":"catch_validation-stable/victoria","attention_set":{},"removed_from_attention_set":{"12404":{"account":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"last_update":"2022-11-17 13:03:17.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I24ec7dc3b18111c126bcfdaa0780bfd7993020fb","subject":"Cache subnets validation for batch member update","status":"MERGED","created":"2022-09-01 17:29:47.000000000","updated":"2022-11-17 13:05:45.000000000","submitted":"2022-11-17 13:03:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"855467-catch_validation-stable/victoria","cherry_pick_of_change":854680,"cherry_pick_of_patch_set":10,"meta_rev_id":"daf009588b466d07ea304d85c4dffbe8998cffbd","_number":855467,"virtual_id_number":855467,"owner":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-11-17 13:03:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":2,"date":"2022-11-16 17:49:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":2,"date":"2022-11-17 10:09:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":1,"date":"2022-11-17 10:09:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}],"CC":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-01 17:29:47.000000000","updated_by":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"CC"},{"updated":"2022-09-01 19:27:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-11-16 17:49:39.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2022-11-17 10:09:05.000000000","updated_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"reviewer":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"state":"REVIEWER"}],"messages":[{"id":"b07886b5b29dfa6eb89d5c14b0101e553344d9ac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"date":"2022-09-01 17:29:47.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"1781a7883520018ec9c97b27b5e7877b98534afd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-01 19:27:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/dbda80caca35433e8e32ab24ad8982d5\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/574822df4c9b47af98dd9227aa433c49 : SUCCESS in 11m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d5ed6527005f462ba117d7cf20954945 : SUCCESS in 5m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/061050e97eb54a9199ebd4b20ac9ad22 : SUCCESS in 4m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0d9115cc71664687b771b54fe48a5110 : SUCCESS in 5m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/79b186f4417540eb9990e8bfdc9d2317 : SUCCESS in 11m 30s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0829cbafbab74ee7acd75e6a93967c05 : SUCCESS in 5m 35s\n- octavia-tox-py37-tips https://zuul.opendev.org/t/openstack/build/865b9687aea84788bd8df8641a59917c : SUCCESS in 6m 09s\n- octavia-tox-functional-py37-tips https://zuul.opendev.org/t/openstack/build/aa9c0107626140bd8dcff83634bf3fc7 : SUCCESS in 8m 10s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/9c4c275846714b28a63292fb18af918f : SUCCESS in 5m 50s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/29140a5c5be34556b930cb8e36fd75ad : SUCCESS in 8m 15s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/e73299e84a1a405c850ba12ab9babca6 : SUCCESS in 1h 16m 28s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/6b58926da4c4428aab0fc749651208a1 : SUCCESS in 1h 46m 00s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/84e875cc678f4ed3b208f36731d1d7be : SUCCESS in 44m 23s\n- octavia-v2-dsvm-spare-pool https://zuul.opendev.org/t/openstack/build/4cae8cdc8d0c424a986f88d700d6a320 : SUCCESS in 39m 36s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/12e5c816df124e3aa13b7355a0465511 : SUCCESS in 40m 41s\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/53d637ae8a9841d7a5dc481e626e93ef : SUCCESS in 1h 51m 22s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/948b0c642a1945f38f9c283de6836ad7 : FAILURE in 35m 51s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/68da368b5a874d1597631178d4206db0 : SUCCESS in 1h 41m 57s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2 https://zuul.opendev.org/t/openstack/build/39cb949fa9b94c2aa33a8c5d911db2d7 : FAILURE in 1h 47m 23s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2-no-jobboard https://zuul.opendev.org/t/openstack/build/72c8d703614c4b73aa78b468ddbfa7f5 : FAILURE in 1h 43m 10s (non-voting)\n- octavia-v2-dsvm-scenario-centos-8 https://zuul.opendev.org/t/openstack/build/2a7cc4a49f8c4254829986577b629ee3 : NODE_FAILURE in 0s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"40df4b6d89df3f234edcc5f2dd3da356ff399d8e","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2022-11-16 17:49:39.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7214cef13c43ad90204877e5d25f81cf7a9f582b","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2022-11-17 10:09:05.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a963f941c05c107438b1fb6b8e6f8ec506f94e81","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-17 10:10:24.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"be3ca7a5c25425d9529e2102921807dc962f9a81","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-17 13:03:17.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/341f814862654e098af274f34bdab840\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/54f893c9cab14b91b7efd41738eb398c : SUCCESS in 5m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/823d15b2068e40b0a269df6162438fcd : SUCCESS in 5m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/14c9f7272a8b44729f4d51fe85658bd3 : SUCCESS in 4m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d1fe0a0e1aa1407bba3932867e5392e0 : SUCCESS in 13m 34s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/07ba9a8d99cc4f51ab58c4a97f8cbcbb : SUCCESS in 5m 12s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/4ebd3d754fc04dccaba51681fd79c4af : SUCCESS in 4m 52s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/a225e6640fcb4c0882ec18747f8ed30d : SUCCESS in 6m 46s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/98b2a2961a744ca689bddf3ea72d98a0 : SUCCESS in 1h 22m 13s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/bb100fcbabbf4bf1ac31fcb10b0c4549 : SUCCESS in 1h 54m 47s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/6968717d1e0f4ddfbcc6416a19aa9935 : SUCCESS in 37m 22s\n- octavia-v2-dsvm-spare-pool https://zuul.opendev.org/t/openstack/build/e4956bcd9dc14081a00e11b33e8c8741 : SUCCESS in 34m 17s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/87ff725ccb3047f987da17e53a3c53a8 : SUCCESS in 37m 23s","accounts_in_message":[],"_revision_number":1},{"id":"343723d36985f6b168002ac5bc727a86f8866b3d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-17 13:03:17.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"daf009588b466d07ea304d85c4dffbe8998cffbd","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-17 13:05:45.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ed5043b1daed4fcd85efc5d638e216de\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d312b4e00ae8430ba3a190ea4765530c : SUCCESS in 56s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f7300027ae3c4e6ab4ad5377a211a6fe : SUCCESS in 41s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b8fe15b6498efa38c260572e4c71971b830df73f","revisions":{"b8fe15b6498efa38c260572e4c71971b830df73f":{"kind":"REWORK","_number":1,"created":"2022-09-01 17:29:47.000000000","uploader":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"ref":"refs/changes/67/855467/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/67/855467/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/67/855467/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/67/855467/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/67/855467/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/67/855467/1"}}},"commit":{"parents":[{"commit":"7eb6bf1681fb8538521def0395835775a180f9bc","subject":"Merge \"Fix HealthMonitorToErrorOnRevertTask revert method\" into stable/victoria","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/7eb6bf1681fb8538521def0395835775a180f9bc"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2022-08-25 23:44:17.000000000","tz":-240},"committer":{"name":"Rico Lin","email":"ricolin@ricolky.com","date":"2022-09-01 17:29:47.000000000","tz":0},"subject":"Cache subnets validation for batch member update","message":"Cache subnets validation for batch member update\n\nAt the moment, we are actually going ahead and sending\nan API request for every single member when doing a batch\nupdate, this can be very expensive in large number of\nmembers and will cause a big hit against the Neutron API,\nit potentially also makes those API calls timeout.\n\nThis patch instead implements a simple cache (per batch\ncall) to simply store the subnets which are considered valid\nwhich means that it will make significantly less calls,\npotentially even one.\n\nIt also adjusts the behaviour so that it only runs this on newly\nadded members which should avoid running it for deleted and\nupdated members which won\u0027t have an effect in this change.\n\nChange-Id: I24ec7dc3b18111c126bcfdaa0780bfd7993020fb\n(cherry picked from commit e0a9ba1560bf38d07d7e03bc0f36195703884db1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/b8fe15b6498efa38c260572e4c71971b830df73f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/b8fe15b6498efa38c260572e4c71971b830df73f"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[]}