)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5349ad6667433df544c1644b01112f3b20a948a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"128f65f2_cc006b80","updated":"2022-09-19 09:59:59.000000000","message":"I see that h2 alpn protocol is added to listeners even when that parameter is not provided.","commit_id":"774d4fba7344a6bc9e008ee5ca6c9148b7e6cb56"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"cc283148b3d3289bcf4445ddedf306d28c1ea763","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b40e833d_87aca5e3","in_reply_to":"128f65f2_cc006b80","updated":"2022-09-19 10:01:15.000000000","message":"To TERMINATED_HTTPS listeners****\n\n\nopenstack loadbalancer listener create --wait --protocol-port 443 --protocol TERMINATED_HTTPS --name terminated_https_listener --default-tls-container\u003d$(openstack secret list | awk \u0027/ tls_secret1 / {print $2}\u0027) lb1\n+-----------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\n| Field                       | Value                                                                                                                                                                                                                                                                              |\n+-----------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\n| admin_state_up              | True                                                                                                                                                                                                                                                                               |\n| connection_limit            | -1                                                                                                                                                                                                                                                                                 |\n| created_at                  | 2022-09-19T09:53:58                                                                                                                                                                                                                                                                |\n| default_pool_id             | None                                                                                                                                                                                                                                                                               |\n| default_tls_container_ref   | http://192.168.122.153/key-manager/v1/secrets/1b05af58-58be-40a9-b0b3-5b9f15676ea6                                                                                                                                                                                                 |\n| description                 |                                                                                                                                                                                                                                                                                    |\n| id                          | 726e8072-77e2-4d8c-a1f5-bb4b8945230e                                                                                                                                                                                                                                               |\n| insert_headers              | None                                                                                                                                                                                                                                                                               |\n| l7policies                  |                                                                                                                                                                                                                                                                                    |\n| loadbalancers               | f30079f5-e182-47d2-a342-0d3c71dd818e                                                                                                                                                                                                                                               |\n| name                        | terminated_https_listener                                                                                                                                                                                                                                                          |\n| operating_status            | ONLINE                                                                                                                                                                                                                                                                             |\n| project_id                  | b869f49eb01e428982626669cf46795e                                                                                                                                                                                                                                                   |\n| protocol                    | TERMINATED_HTTPS                                                                                                                                                                                                                                                                   |\n| protocol_port               | 443                                                                                                                                                                                                                                                                                |\n| provisioning_status         | ACTIVE                                                                                                                                                                                                                                                                             |\n| sni_container_refs          | []                                                                                                                                                                                                                                                                                 |\n| timeout_client_data         | 50000                                                                                                                                                                                                                                                                              |\n| timeout_member_connect      | 5000                                                                                                                                                                                                                                                                               |\n| timeout_member_data         | 50000                                                                                                                                                                                                                                                                              |\n| timeout_tcp_inspect         | 0                                                                                                                                                                                                                                                                                  |\n| updated_at                  | 2022-09-19T09:54:02                                                                                                                                                                                                                                                                |\n| client_ca_tls_container_ref | None                                                                                                                                                                                                                                                                               |\n| client_authentication       | NONE                                                                                                                                                                                                                                                                               |\n| client_crl_container_ref    | None                                                                                                                                                                                                                                                                               |\n| allowed_cidrs               | None                                                                                                                                                                                                                                                                               |\n| tls_ciphers                 | TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256 |\n| tls_versions                | [\u0027TLSv1.2\u0027, \u0027TLSv1.3\u0027]                                                                                                                                                                                                                                                             |\n| alpn_protocols              | [\u0027h2\u0027, \u0027http/1.1\u0027, \u0027http/1.0\u0027]                                                                                                                                                                                                                                                     |\n| tags                        |                                                                                                                                                                                                                                                                                    |\n+-----------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+","commit_id":"774d4fba7344a6bc9e008ee5ca6c9148b7e6cb56"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"90a62e6e491c525019c71b5a9419d776fb8b84ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8dfc318d_b1460de5","updated":"2022-10-07 08:44:04.000000000","message":"Thanks Tom, done.","commit_id":"a2ed766b8c911f9e27355f19906e7c35a2367c70"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"212581c65a6364dc50e73661344517105c1afc28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f10d1a86_4149be43","updated":"2022-10-07 09:20:09.000000000","message":"Thanks Greg","commit_id":"8de673219ca73f77e2267fbc4a399a12465f4733"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a00607b1fd623625836da21850bbf904a24a9f09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4a3ddf41_60094090","updated":"2023-02-16 13:35:50.000000000","message":"I hope that I got ","commit_id":"4bf9fd09b623f8463f048458294d67d161c0b385"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"778884b64058ef2a1ff82b84facdb74bdb5ab1ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"21080ab8_5277b7af","updated":"2023-03-03 14:58:24.000000000","message":"recheck I don\u0027t think the failure is related to the patch","commit_id":"d0d45f7f10c1d0e33c86d8851a7553b3259e9ee4"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"59ba39a59874b76628536c89b9a3e7f12b3b5133","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"728294d5_66019f22","updated":"2023-03-15 10:10:12.000000000","message":"recheck octavia-v2-dsvm-scenario timed out","commit_id":"d0d45f7f10c1d0e33c86d8851a7553b3259e9ee4"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"530fbedcf0184e2d9c80ff4185921bc7c98126c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b0e5621c_84d49093","updated":"2024-08-19 13:57:49.000000000","message":"recheck fresh ci results","commit_id":"2c0a5ab8b20a7b87a9aa52c6d1793cc9938932f9"}],"octavia/api/v2/controllers/listener.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"060144a6e3e1c659e740f48df3ed990d7bb1f9e2","unresolved":true,"context_lines":[{"line_number":125,"context_line":"        return (listener_dict.get(\u0027tls_certificate_id\u0027) or"},{"line_number":126,"context_line":"                listener_dict.get(\u0027client_ca_tls_container_id\u0027) or"},{"line_number":127,"context_line":"                listener_dict.get(\u0027sni_containers\u0027) or"},{"line_number":128,"context_line":"                listener_dict.get(\u0027alpn_protocols\u0027))"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _is_tls_or_insert_header(self, listener_dict):"},{"line_number":131,"context_line":"        return (self._has_tls_container_refs(listener_dict) or"}],"source_content_type":"text/x-python","patch_set":6,"id":"ee826485_c9043d9e","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":52},"updated":"2022-10-07 09:06:33.000000000","message":"that looks confusing to me, _has_tls_container_refs now returns true if no container refs are provided but alpn_protocols is set.","commit_id":"8de673219ca73f77e2267fbc4a399a12465f4733"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"51134836bcf92353af18937b27ab43aaf0e9dddb","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return (listener_dict.get(\u0027tls_certificate_id\u0027) or"},{"line_number":126,"context_line":"                listener_dict.get(\u0027client_ca_tls_container_id\u0027) or"},{"line_number":127,"context_line":"                listener_dict.get(\u0027sni_containers\u0027) or"},{"line_number":128,"context_line":"                listener_dict.get(\u0027alpn_protocols\u0027))"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _is_tls_or_insert_header(self, listener_dict):"},{"line_number":131,"context_line":"        return (self._has_tls_container_refs(listener_dict) or"}],"source_content_type":"text/x-python","patch_set":6,"id":"51d52b4c_b4e56365","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":52},"in_reply_to":"2e3936a4_9dcee456","updated":"2022-10-10 10:24:06.000000000","message":"Done","commit_id":"8de673219ca73f77e2267fbc4a399a12465f4733"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"212581c65a6364dc50e73661344517105c1afc28","unresolved":true,"context_lines":[{"line_number":125,"context_line":"        return (listener_dict.get(\u0027tls_certificate_id\u0027) or"},{"line_number":126,"context_line":"                listener_dict.get(\u0027client_ca_tls_container_id\u0027) or"},{"line_number":127,"context_line":"                listener_dict.get(\u0027sni_containers\u0027) or"},{"line_number":128,"context_line":"                listener_dict.get(\u0027alpn_protocols\u0027))"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _is_tls_or_insert_header(self, listener_dict):"},{"line_number":131,"context_line":"        return (self._has_tls_container_refs(listener_dict) or"}],"source_content_type":"text/x-python","patch_set":6,"id":"2e3936a4_9dcee456","line":128,"range":{"start_line":128,"start_character":16,"end_line":128,"end_character":52},"in_reply_to":"ee826485_c9043d9e","updated":"2022-10-07 09:20:09.000000000","message":"Right, I will create another method which will check _is_tls_or_alpn_protocols.","commit_id":"8de673219ca73f77e2267fbc4a399a12465f4733"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b8bfcea33a849615d461c2a0c4d7cda3b20a708","unresolved":true,"context_lines":[{"line_number":187,"context_line":"                \u0027ALPN protocols are only allowed on listener protocol(s) \u0027"},{"line_number":188,"context_line":"                f\u0027{\" ,\".join(constants.LISTENER_PROTOCOLS_SUPPORTING_ALPN)}. \u0027"},{"line_number":189,"context_line":"                f\u0027Current listener protocol is {listener_protocol}.\u0027)"},{"line_number":190,"context_line":"            raise exceptions.ValidationException(detail\u003d_(err_msg))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        # Check for UDP/SCTP compatibility"},{"line_number":193,"context_line":"        if (listener_protocol in (constants.PROTOCOL_UDP,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3e4d8dca_9c7e3ff8","line":190,"range":{"start_line":190,"start_character":56,"end_line":190,"end_character":57},"updated":"2023-02-15 08:42:23.000000000","message":"here you are translating a string that was built from an fstring, it will not work.\nyou need to use the % operator (see line 197)","commit_id":"9b6502a710ad81705d8dfd17e9a7f5e3e89ccc09"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"45abfecde770f76eb1f61c26e7a8864077170bfd","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                \u0027ALPN protocols are only allowed on listener protocol(s) \u0027"},{"line_number":188,"context_line":"                f\u0027{\" ,\".join(constants.LISTENER_PROTOCOLS_SUPPORTING_ALPN)}. \u0027"},{"line_number":189,"context_line":"                f\u0027Current listener protocol is {listener_protocol}.\u0027)"},{"line_number":190,"context_line":"            raise exceptions.ValidationException(detail\u003d_(err_msg))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        # Check for UDP/SCTP compatibility"},{"line_number":193,"context_line":"        if (listener_protocol in (constants.PROTOCOL_UDP,"}],"source_content_type":"text/x-python","patch_set":7,"id":"635e8fdd_67cf826c","line":190,"range":{"start_line":190,"start_character":56,"end_line":190,"end_character":57},"in_reply_to":"3e4d8dca_9c7e3ff8","updated":"2023-02-15 14:04:00.000000000","message":"Done","commit_id":"9b6502a710ad81705d8dfd17e9a7f5e3e89ccc09"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b8bfcea33a849615d461c2a0c4d7cda3b20a708","unresolved":true,"context_lines":[{"line_number":509,"context_line":"                \u0027ALPN protocols are only allowed on listener protocol(s) \u0027"},{"line_number":510,"context_line":"                f\u0027{\" ,\".join(constants.LISTENER_PROTOCOLS_SUPPORTING_ALPN)}. \u0027"},{"line_number":511,"context_line":"                f\u0027Current listener protocol is {db_listener.protocol}.\u0027)"},{"line_number":512,"context_line":"            raise exceptions.ValidationException(detail\u003d_(err_msg))"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        sni_containers \u003d listener.sni_container_refs or []"},{"line_number":515,"context_line":"        tls_refs \u003d list(sni_containers)"}],"source_content_type":"text/x-python","patch_set":7,"id":"11e95341_79acf10c","line":512,"updated":"2023-02-15 08:42:23.000000000","message":"same here","commit_id":"9b6502a710ad81705d8dfd17e9a7f5e3e89ccc09"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"45abfecde770f76eb1f61c26e7a8864077170bfd","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                \u0027ALPN protocols are only allowed on listener protocol(s) \u0027"},{"line_number":510,"context_line":"                f\u0027{\" ,\".join(constants.LISTENER_PROTOCOLS_SUPPORTING_ALPN)}. \u0027"},{"line_number":511,"context_line":"                f\u0027Current listener protocol is {db_listener.protocol}.\u0027)"},{"line_number":512,"context_line":"            raise exceptions.ValidationException(detail\u003d_(err_msg))"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        sni_containers \u003d listener.sni_container_refs or []"},{"line_number":515,"context_line":"        tls_refs \u003d list(sni_containers)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7392ee63_0d6694f4","line":512,"in_reply_to":"11e95341_79acf10c","updated":"2023-02-15 14:04:00.000000000","message":"Done","commit_id":"9b6502a710ad81705d8dfd17e9a7f5e3e89ccc09"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3c8cc060595c3a13c40b2979435439857b5d3a34","unresolved":true,"context_lines":[{"line_number":187,"context_line":"                \u0027ALPN protocols are only allowed on listener protocol(s) \u0027"},{"line_number":188,"context_line":"                f\u0027{\" ,\".join(constants.LISTENER_PROTOCOLS_SUPPORTING_ALPN)}. \u0027"},{"line_number":189,"context_line":"                f\u0027Current listener protocol is {listener_protocol}.\u0027)"},{"line_number":190,"context_line":"            raise exceptions.ValidationException(detail\u003d_(\"%s\") % err_msg)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        # Check for UDP/SCTP compatibility"},{"line_number":193,"context_line":"        if (listener_protocol in (constants.PROTOCOL_UDP,"}],"source_content_type":"text/x-python","patch_set":8,"id":"4284d7ec_71dee33c","line":190,"range":{"start_line":190,"start_character":49,"end_line":190,"end_character":64},"updated":"2023-02-16 10:29:41.000000000","message":"this is still incorrect\nyou need to pass the translatable error message as a static string to _()\nhere you pass only \"%s\" so you expect that translators will translate \"%s\" into their languages.\n\nfor instance you can call\n_(\"ALPN protocols are only allowed on listener protocol(s) %s. blahblah\")\nthen apply the % operator on the result of the string\nthen people can translate \"ALPN protocol blahblah\" in their language, the string will be correctly interpreted","commit_id":"e199bb228ef3ac49c6d1093a8a7df88b510598a2"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a00607b1fd623625836da21850bbf904a24a9f09","unresolved":true,"context_lines":[{"line_number":187,"context_line":"                \u0027ALPN protocols are only allowed on listener protocol(s) \u0027"},{"line_number":188,"context_line":"                f\u0027{\" ,\".join(constants.LISTENER_PROTOCOLS_SUPPORTING_ALPN)}. \u0027"},{"line_number":189,"context_line":"                f\u0027Current listener protocol is {listener_protocol}.\u0027)"},{"line_number":190,"context_line":"            raise exceptions.ValidationException(detail\u003d_(\"%s\") % err_msg)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        # Check for UDP/SCTP compatibility"},{"line_number":193,"context_line":"        if (listener_protocol in (constants.PROTOCOL_UDP,"}],"source_content_type":"text/x-python","patch_set":8,"id":"50010d6e_9e2cf06a","line":190,"range":{"start_line":190,"start_character":49,"end_line":190,"end_character":64},"in_reply_to":"4284d7ec_71dee33c","updated":"2023-02-16 13:35:50.000000000","message":"I hope I fixed it this time","commit_id":"e199bb228ef3ac49c6d1093a8a7df88b510598a2"}],"octavia/api/v2/controllers/pool.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"088abf04df2b34705141d98dff71d0e07268a2c5","unresolved":true,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if pool_dict.get(\u0027alpn_protocols\u0027):"},{"line_number":136,"context_line":"            if pool_dict[\u0027protocol\u0027] not in ["},{"line_number":137,"context_line":"                    constants.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":138,"context_line":"                    constants.PROTOCOL_HTTP]:"},{"line_number":139,"context_line":"                raise exceptions.ValidationException(detail\u003d_("},{"line_number":140,"context_line":"                    \u0027alpn protocols are not allowed on %s protocol pools.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"88fb2288_6b4a91d9","line":137,"updated":"2022-09-15 16:45:07.000000000","message":"Can we define a constants list for the valid pool protocols for ALPN?\nhttps://github.com/openstack/octavia/blob/master/octavia/common/constants.py#L899\nThis would be more consistent and mean updating the list is only in one place in the code.","commit_id":"774d4fba7344a6bc9e008ee5ca6c9148b7e6cb56"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"238a35d580c91eb6d761569b8feaae2eda5309ec","unresolved":true,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if pool_dict.get(\u0027alpn_protocols\u0027):"},{"line_number":136,"context_line":"            if pool_dict[\u0027protocol\u0027] not in ["},{"line_number":137,"context_line":"                    constants.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":138,"context_line":"                    constants.PROTOCOL_HTTP]:"},{"line_number":139,"context_line":"                raise exceptions.ValidationException(detail\u003d_("},{"line_number":140,"context_line":"                    \u0027alpn protocols are not allowed on %s protocol pools.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e96eb16a_17e85032","line":137,"in_reply_to":"88fb2288_6b4a91d9","updated":"2022-09-19 09:17:59.000000000","message":"I agree, seems much better, I will use constants instead.","commit_id":"774d4fba7344a6bc9e008ee5ca6c9148b7e6cb56"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"90a62e6e491c525019c71b5a9419d776fb8b84ad","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if pool_dict.get(\u0027alpn_protocols\u0027):"},{"line_number":136,"context_line":"            if pool_dict[\u0027protocol\u0027] not in ["},{"line_number":137,"context_line":"                    constants.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":138,"context_line":"                    constants.PROTOCOL_HTTP]:"},{"line_number":139,"context_line":"                raise exceptions.ValidationException(detail\u003d_("},{"line_number":140,"context_line":"                    \u0027alpn protocols are not allowed on %s protocol pools.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"17651234_da144a74","line":137,"in_reply_to":"e96eb16a_17e85032","updated":"2022-10-07 08:44:04.000000000","message":"Done","commit_id":"774d4fba7344a6bc9e008ee5ca6c9148b7e6cb56"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"088abf04df2b34705141d98dff71d0e07268a2c5","unresolved":true,"context_lines":[{"line_number":135,"context_line":"        if pool_dict.get(\u0027alpn_protocols\u0027):"},{"line_number":136,"context_line":"            if pool_dict[\u0027protocol\u0027] not in ["},{"line_number":137,"context_line":"                    constants.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":138,"context_line":"                    constants.PROTOCOL_HTTP]:"},{"line_number":139,"context_line":"                raise exceptions.ValidationException(detail\u003d_("},{"line_number":140,"context_line":"                    \u0027alpn protocols are not allowed on %s protocol pools.\u0027)"},{"line_number":141,"context_line":"                    % pool_dict[\u0027protocol\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5490b0f0_df5df939","line":138,"updated":"2022-09-15 16:45:07.000000000","message":"ALPN is a TLS extension and only valid for TERMINATED_HTTPS connections.","commit_id":"774d4fba7344a6bc9e008ee5ca6c9148b7e6cb56"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"90a62e6e491c525019c71b5a9419d776fb8b84ad","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        if pool_dict.get(\u0027alpn_protocols\u0027):"},{"line_number":136,"context_line":"            if pool_dict[\u0027protocol\u0027] not in ["},{"line_number":137,"context_line":"                    constants.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":138,"context_line":"                    constants.PROTOCOL_HTTP]:"},{"line_number":139,"context_line":"                raise exceptions.ValidationException(detail\u003d_("},{"line_number":140,"context_line":"                    \u0027alpn protocols are not allowed on %s protocol pools.\u0027)"},{"line_number":141,"context_line":"                    % pool_dict[\u0027protocol\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"8e3b9044_ee7ec795","line":138,"in_reply_to":"5039846b_9cec99a9","updated":"2022-10-07 08:44:04.000000000","message":"Done","commit_id":"774d4fba7344a6bc9e008ee5ca6c9148b7e6cb56"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"238a35d580c91eb6d761569b8feaae2eda5309ec","unresolved":true,"context_lines":[{"line_number":135,"context_line":"        if pool_dict.get(\u0027alpn_protocols\u0027):"},{"line_number":136,"context_line":"            if pool_dict[\u0027protocol\u0027] not in ["},{"line_number":137,"context_line":"                    constants.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":138,"context_line":"                    constants.PROTOCOL_HTTP]:"},{"line_number":139,"context_line":"                raise exceptions.ValidationException(detail\u003d_("},{"line_number":140,"context_line":"                    \u0027alpn protocols are not allowed on %s protocol pools.\u0027)"},{"line_number":141,"context_line":"                    % pool_dict[\u0027protocol\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5039846b_9cec99a9","line":138,"in_reply_to":"5490b0f0_df5df939","updated":"2022-09-19 09:17:59.000000000","message":"Looking at it again, TERMINATED_HTTPS is not a supported protocol for pools.\nhttps://github.com/openstack/octavia-lib/blob/master/octavia_lib/common/constants.py#L150\n\n\nopenstack loadbalancer pool create --lb-algorithm ROUND_ROBIN --loadbalancer lb1 --protocol TERMINATED_HTTPS --wait       \nInvalid input for field/attribute protocol. Value: \u0027TERMINATED_HTTPS\u0027. Value should be one of: HTTPS, PROXYV2, UDP, PROXY, SCTP, HTTP, TCP (HTTP 400) (Request-ID: req-9f64bcec-03c1-4c66-bd9a-87366a975bc5)\n\n\nI also opened a BZ about the fact that the octavia client suggests it as an option but it is not supported \nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d2126726\n\nShould it be supported for pools?","commit_id":"774d4fba7344a6bc9e008ee5ca6c9148b7e6cb56"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"088abf04df2b34705141d98dff71d0e07268a2c5","unresolved":true,"context_lines":[{"line_number":438,"context_line":"            validate.check_alpn_protocols(pool.alpn_protocols)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        if pool.alpn_protocols:"},{"line_number":441,"context_line":"            if db_pool.protocol not in [constants.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":442,"context_line":"                                        constants.PROTOCOL_HTTP]:"},{"line_number":443,"context_line":"                raise exceptions.ValidationException(detail\u003d_("},{"line_number":444,"context_line":"                    \u0027alpn protocols are not allowed on %s protocol pools.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"93d6b040_0bea60e9","line":441,"updated":"2022-09-15 16:45:07.000000000","message":"Same, would be best to reference a constant for this list.\nAlso, HTTP is not valid.","commit_id":"774d4fba7344a6bc9e008ee5ca6c9148b7e6cb56"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"90a62e6e491c525019c71b5a9419d776fb8b84ad","unresolved":false,"context_lines":[{"line_number":438,"context_line":"            validate.check_alpn_protocols(pool.alpn_protocols)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        if pool.alpn_protocols:"},{"line_number":441,"context_line":"            if db_pool.protocol not in [constants.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":442,"context_line":"                                        constants.PROTOCOL_HTTP]:"},{"line_number":443,"context_line":"                raise exceptions.ValidationException(detail\u003d_("},{"line_number":444,"context_line":"                    \u0027alpn protocols are not allowed on %s protocol pools.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"82d2942f_f6bd3503","line":441,"in_reply_to":"93d6b040_0bea60e9","updated":"2022-10-07 08:44:04.000000000","message":"Done","commit_id":"774d4fba7344a6bc9e008ee5ca6c9148b7e6cb56"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"5cc7e9713aba9b996c1e1b0079b0ed811b6c5a1f","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            if not alpn_correct_protocol or not pool_dict[\u0027tls_enabled\u0027]:"},{"line_number":139,"context_line":"                has_tls_str \u003d \u0027out\u0027 if not pool_dict[\u0027tls_enabled\u0027] else \u0027\u0027"},{"line_number":140,"context_line":"                err_msg \u003d ("},{"line_number":141,"context_line":"                    \u0027alpn protocols are only allowed on pool protocol(s) \u0027"},{"line_number":142,"context_line":"                    f\u0027{\" ,\".join(constants.POOL_PROTOCOLS_SUPPORTING_ALPN)}, \u0027"},{"line_number":143,"context_line":"                    \u0027with tls enabled. Current pool protocol is \u0027"},{"line_number":144,"context_line":"                    f\u0027{pool_dict[\"protocol\"]} with{has_tls_str} tls enabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"829848d3_b9826f17","line":141,"range":{"start_line":141,"start_character":21,"end_line":141,"end_character":25},"updated":"2022-10-06 09:55:48.000000000","message":"I\u0027d suggest to put ALPN and TLS in capital letters for better readability, also below.","commit_id":"a2ed766b8c911f9e27355f19906e7c35a2367c70"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"90a62e6e491c525019c71b5a9419d776fb8b84ad","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            if not alpn_correct_protocol or not pool_dict[\u0027tls_enabled\u0027]:"},{"line_number":139,"context_line":"                has_tls_str \u003d \u0027out\u0027 if not pool_dict[\u0027tls_enabled\u0027] else \u0027\u0027"},{"line_number":140,"context_line":"                err_msg \u003d ("},{"line_number":141,"context_line":"                    \u0027alpn protocols are only allowed on pool protocol(s) \u0027"},{"line_number":142,"context_line":"                    f\u0027{\" ,\".join(constants.POOL_PROTOCOLS_SUPPORTING_ALPN)}, \u0027"},{"line_number":143,"context_line":"                    \u0027with tls enabled. Current pool protocol is \u0027"},{"line_number":144,"context_line":"                    f\u0027{pool_dict[\"protocol\"]} with{has_tls_str} tls enabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b2236fad_f1f851e4","line":141,"range":{"start_line":141,"start_character":21,"end_line":141,"end_character":25},"in_reply_to":"829848d3_b9826f17","updated":"2022-10-07 08:44:04.000000000","message":"Done","commit_id":"a2ed766b8c911f9e27355f19906e7c35a2367c70"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"5cc7e9713aba9b996c1e1b0079b0ed811b6c5a1f","unresolved":true,"context_lines":[{"line_number":441,"context_line":"            # Validate ALPN protocol list"},{"line_number":442,"context_line":"            validate.check_alpn_protocols(pool.alpn_protocols)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        if pool.alpn_protocols:"},{"line_number":445,"context_line":"            alpn_correct_protocol \u003d db_pool.protocol in ("},{"line_number":446,"context_line":"                constants.POOL_PROTOCOLS_SUPPORTING_ALPN)"},{"line_number":447,"context_line":"            if not alpn_correct_protocol or not db_pool.tls_enabled:"},{"line_number":448,"context_line":"                has_tls_str \u003d \u0027out\u0027 if not db_pool.tls_enabled else \u0027\u0027"},{"line_number":449,"context_line":"                err_msg \u003d ("},{"line_number":450,"context_line":"                    \u0027alpn protocols are only allowed on pool protocol(s) \u0027"},{"line_number":451,"context_line":"                    f\u0027{\" ,\".join(constants.POOL_PROTOCOLS_SUPPORTING_ALPN)}, \u0027"},{"line_number":452,"context_line":"                    \u0027with tls enabled. Current pool protocol is \u0027"},{"line_number":453,"context_line":"                    f\u0027{db_pool.protocol} with{has_tls_str} tls enabled.\u0027)"},{"line_number":454,"context_line":"                raise exceptions.ValidationException(detail\u003d_(err_msg))"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    @wsme_pecan.wsexpose(pool_types.PoolRootResponse, wtypes.text,"},{"line_number":457,"context_line":"                         body\u003dpool_types.PoolRootPut, status_code\u003d200)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dd7b1ef8_7d9864da","line":454,"range":{"start_line":444,"start_character":8,"end_line":454,"end_character":71},"updated":"2022-10-06 09:55:48.000000000","message":"Why don\u0027t you move this into octavia.common.validate.check_alpn_protocols? You could pass db_pool.tls_enabled as a function argument there if you need to. In order to catch cases where pool.alpn_protocols is wtypes.Unset and db_pool.tls_enabled is false the condition in line 440 would need to be adjusted as well.","commit_id":"a2ed766b8c911f9e27355f19906e7c35a2367c70"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"90a62e6e491c525019c71b5a9419d776fb8b84ad","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            # Validate ALPN protocol list"},{"line_number":442,"context_line":"            validate.check_alpn_protocols(pool.alpn_protocols)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        if pool.alpn_protocols:"},{"line_number":445,"context_line":"            alpn_correct_protocol \u003d db_pool.protocol in ("},{"line_number":446,"context_line":"                constants.POOL_PROTOCOLS_SUPPORTING_ALPN)"},{"line_number":447,"context_line":"            if not alpn_correct_protocol or not db_pool.tls_enabled:"},{"line_number":448,"context_line":"                has_tls_str \u003d \u0027out\u0027 if not db_pool.tls_enabled else \u0027\u0027"},{"line_number":449,"context_line":"                err_msg \u003d ("},{"line_number":450,"context_line":"                    \u0027alpn protocols are only allowed on pool protocol(s) \u0027"},{"line_number":451,"context_line":"                    f\u0027{\" ,\".join(constants.POOL_PROTOCOLS_SUPPORTING_ALPN)}, \u0027"},{"line_number":452,"context_line":"                    \u0027with tls enabled. Current pool protocol is \u0027"},{"line_number":453,"context_line":"                    f\u0027{db_pool.protocol} with{has_tls_str} tls enabled.\u0027)"},{"line_number":454,"context_line":"                raise exceptions.ValidationException(detail\u003d_(err_msg))"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    @wsme_pecan.wsexpose(pool_types.PoolRootResponse, wtypes.text,"},{"line_number":457,"context_line":"                         body\u003dpool_types.PoolRootPut, status_code\u003d200)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f3bedb1_f6e7c96b","line":454,"range":{"start_line":444,"start_character":8,"end_line":454,"end_character":71},"in_reply_to":"dd7b1ef8_7d9864da","updated":"2022-10-07 08:44:04.000000000","message":"Sounds like a good idea to me - done, thanks.","commit_id":"a2ed766b8c911f9e27355f19906e7c35a2367c70"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"96fb02abec5610d429f94755a932cb062d5526eb","unresolved":true,"context_lines":[{"line_number":133,"context_line":"                    \u0027administrator: \u0027 + \u0027, \u0027.join(rejected_ciphers)))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if pool_dict.get(\u0027alpn_protocols\u0027):"},{"line_number":136,"context_line":"            alpn_correct_protocol \u003d pool_dict[\u0027protocol\u0027] in ("},{"line_number":137,"context_line":"                constants.POOL_PROTOCOLS_SUPPORTING_ALPN)"},{"line_number":138,"context_line":"            if not alpn_correct_protocol or not pool_dict[\u0027tls_enabled\u0027]:"},{"line_number":139,"context_line":"                has_tls_str \u003d \u0027out\u0027 if not pool_dict[\u0027tls_enabled\u0027] else \u0027\u0027"},{"line_number":140,"context_line":"                err_msg \u003d ("},{"line_number":141,"context_line":"                    \u0027ALPN protocols are only allowed on pool protocol(s) \u0027"},{"line_number":142,"context_line":"                    f\u0027{\" ,\".join(constants.POOL_PROTOCOLS_SUPPORTING_ALPN)}, \u0027"},{"line_number":143,"context_line":"                    \u0027with TLS enabled. Current pool protocol is \u0027"},{"line_number":144,"context_line":"                    f\u0027{pool_dict[\"protocol\"]} with{has_tls_str} TLS enabled.\u0027)"},{"line_number":145,"context_line":"                raise exceptions.ValidationException(detail\u003d_(err_msg))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if pool_dict[\u0027tls_enabled\u0027]:"},{"line_number":148,"context_line":"            # Validate TLS version list"}],"source_content_type":"text/x-python","patch_set":7,"id":"00958fe3_de4e88d3","line":145,"range":{"start_line":136,"start_character":12,"end_line":145,"end_character":71},"updated":"2022-10-11 07:59:00.000000000","message":"Very minor issue: This looks almost exactly the same as what the new check_alpn_pool_protocols_and_tls_enabled() function does, except that here you\u0027re dealing with a dict instead of an object and its attributes. It should be pretty straightforward to make check_alpn_pool_protocols_and_tls_enabled() able to deal with both the dict and the object type argument.","commit_id":"9b6502a710ad81705d8dfd17e9a7f5e3e89ccc09"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b8bfcea33a849615d461c2a0c4d7cda3b20a708","unresolved":true,"context_lines":[{"line_number":142,"context_line":"                    f\u0027{\" ,\".join(constants.POOL_PROTOCOLS_SUPPORTING_ALPN)}, \u0027"},{"line_number":143,"context_line":"                    \u0027with TLS enabled. Current pool protocol is \u0027"},{"line_number":144,"context_line":"                    f\u0027{pool_dict[\"protocol\"]} with{has_tls_str} TLS enabled.\u0027)"},{"line_number":145,"context_line":"                raise exceptions.ValidationException(detail\u003d_(err_msg))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if pool_dict[\u0027tls_enabled\u0027]:"},{"line_number":148,"context_line":"            # Validate TLS version list"}],"source_content_type":"text/x-python","patch_set":7,"id":"cbd0f30d_e960051d","line":145,"range":{"start_line":145,"start_character":60,"end_line":145,"end_character":61},"updated":"2023-02-15 08:42:23.000000000","message":"same here","commit_id":"9b6502a710ad81705d8dfd17e9a7f5e3e89ccc09"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"45abfecde770f76eb1f61c26e7a8864077170bfd","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                    f\u0027{\" ,\".join(constants.POOL_PROTOCOLS_SUPPORTING_ALPN)}, \u0027"},{"line_number":143,"context_line":"                    \u0027with TLS enabled. Current pool protocol is \u0027"},{"line_number":144,"context_line":"                    f\u0027{pool_dict[\"protocol\"]} with{has_tls_str} TLS enabled.\u0027)"},{"line_number":145,"context_line":"                raise exceptions.ValidationException(detail\u003d_(err_msg))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if pool_dict[\u0027tls_enabled\u0027]:"},{"line_number":148,"context_line":"            # Validate TLS version list"}],"source_content_type":"text/x-python","patch_set":7,"id":"224b1311_b46133a4","line":145,"range":{"start_line":145,"start_character":60,"end_line":145,"end_character":61},"in_reply_to":"cbd0f30d_e960051d","updated":"2023-02-15 14:04:00.000000000","message":"Done","commit_id":"9b6502a710ad81705d8dfd17e9a7f5e3e89ccc09"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b8bfcea33a849615d461c2a0c4d7cda3b20a708","unresolved":true,"context_lines":[{"line_number":437,"context_line":"            # Validate TLS version against minimum"},{"line_number":438,"context_line":"            validate.check_tls_version_min(pool.tls_versions)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        if pool.alpn_protocols:"},{"line_number":441,"context_line":"            validate.check_alpn_pool_protocols_and_tls_enabled(db_pool)"},{"line_number":442,"context_line":"            if pool.alpn_protocols is not wtypes.Unset:"},{"line_number":443,"context_line":"                # Validate ALPN protocol list"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ac4e4b2_bcfbab71","line":440,"range":{"start_line":440,"start_character":0,"end_line":440,"end_character":31},"updated":"2023-02-15 08:42:23.000000000","message":"not sure about the 2 if blocks\nwhy not only \"if pool.alpn_protocols is not wtypes.Unset:\"?","commit_id":"9b6502a710ad81705d8dfd17e9a7f5e3e89ccc09"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"45abfecde770f76eb1f61c26e7a8864077170bfd","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            # Validate TLS version against minimum"},{"line_number":438,"context_line":"            validate.check_tls_version_min(pool.tls_versions)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        if pool.alpn_protocols:"},{"line_number":441,"context_line":"            validate.check_alpn_pool_protocols_and_tls_enabled(db_pool)"},{"line_number":442,"context_line":"            if pool.alpn_protocols is not wtypes.Unset:"},{"line_number":443,"context_line":"                # Validate ALPN protocol list"}],"source_content_type":"text/x-python","patch_set":7,"id":"04115c33_1ab99686","line":440,"range":{"start_line":440,"start_character":0,"end_line":440,"end_character":31},"in_reply_to":"5ac4e4b2_bcfbab71","updated":"2023-02-15 14:04:00.000000000","message":"I think only \"if pool.alpn_protocols is not wtypes.Unset:\" will be enough. I just tested it a little and it looks good to me, thanks.","commit_id":"9b6502a710ad81705d8dfd17e9a7f5e3e89ccc09"}],"octavia/common/validate.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b8bfcea33a849615d461c2a0c4d7cda3b20a708","unresolved":true,"context_lines":[{"line_number":543,"context_line":"            f\u0027{\" ,\".join(constants.POOL_PROTOCOLS_SUPPORTING_ALPN)}, \u0027"},{"line_number":544,"context_line":"            \u0027with TLS enabled. Current pool protocol is \u0027"},{"line_number":545,"context_line":"            f\u0027{db_pool.protocol} with{has_tls_str} TLS enabled.\u0027)"},{"line_number":546,"context_line":"        raise exceptions.ValidationException(detail\u003d_(err_msg))"}],"source_content_type":"text/x-python","patch_set":7,"id":"1dde64e3_c0c5ed77","line":546,"range":{"start_line":546,"start_character":53,"end_line":546,"end_character":54},"updated":"2023-02-15 08:42:23.000000000","message":"same","commit_id":"9b6502a710ad81705d8dfd17e9a7f5e3e89ccc09"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"45abfecde770f76eb1f61c26e7a8864077170bfd","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            f\u0027{\" ,\".join(constants.POOL_PROTOCOLS_SUPPORTING_ALPN)}, \u0027"},{"line_number":544,"context_line":"            \u0027with TLS enabled. Current pool protocol is \u0027"},{"line_number":545,"context_line":"            f\u0027{db_pool.protocol} with{has_tls_str} TLS enabled.\u0027)"},{"line_number":546,"context_line":"        raise exceptions.ValidationException(detail\u003d_(err_msg))"}],"source_content_type":"text/x-python","patch_set":7,"id":"55a18208_5512006c","line":546,"range":{"start_line":546,"start_character":53,"end_line":546,"end_character":54},"in_reply_to":"1dde64e3_c0c5ed77","updated":"2023-02-15 14:04:00.000000000","message":"Done","commit_id":"9b6502a710ad81705d8dfd17e9a7f5e3e89ccc09"}],"octavia/tests/functional/api/v2/test_listener.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"060144a6e3e1c659e740f48df3ed990d7bb1f9e2","unresolved":true,"context_lines":[{"line_number":2538,"context_line":"        resp \u003d self.test_create(response_status\u003d400, **optionals).json"},{"line_number":2539,"context_line":"        fault \u003d resp.get(\u0027faultstring\u0027)"},{"line_number":2540,"context_line":"        self.assertIn("},{"line_number":2541,"context_line":"            \u0027Certificate container references are not allowed on \u0027, fault)"},{"line_number":2542,"context_line":"        self.assertIn("},{"line_number":2543,"context_line":"            \u0027{} protocol listeners.\u0027.format(constants.PROTOCOL_TCP), fault)"},{"line_number":2544,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f8a74ac_9ce693ae","line":2541,"range":{"start_line":2541,"start_character":13,"end_line":2541,"end_character":64},"updated":"2022-10-07 09:06:33.000000000","message":"still confusing, we should get a clear message that would mention that setting alpn_protocols is lot allowed with TCP protocol listeners.","commit_id":"8de673219ca73f77e2267fbc4a399a12465f4733"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"51134836bcf92353af18937b27ab43aaf0e9dddb","unresolved":false,"context_lines":[{"line_number":2538,"context_line":"        resp \u003d self.test_create(response_status\u003d400, **optionals).json"},{"line_number":2539,"context_line":"        fault \u003d resp.get(\u0027faultstring\u0027)"},{"line_number":2540,"context_line":"        self.assertIn("},{"line_number":2541,"context_line":"            \u0027Certificate container references are not allowed on \u0027, fault)"},{"line_number":2542,"context_line":"        self.assertIn("},{"line_number":2543,"context_line":"            \u0027{} protocol listeners.\u0027.format(constants.PROTOCOL_TCP), fault)"},{"line_number":2544,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f180953_7921cc21","line":2541,"range":{"start_line":2541,"start_character":13,"end_line":2541,"end_character":64},"in_reply_to":"0731305e_4d0c3970","updated":"2022-10-10 10:24:06.000000000","message":"Done","commit_id":"8de673219ca73f77e2267fbc4a399a12465f4733"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"212581c65a6364dc50e73661344517105c1afc28","unresolved":true,"context_lines":[{"line_number":2538,"context_line":"        resp \u003d self.test_create(response_status\u003d400, **optionals).json"},{"line_number":2539,"context_line":"        fault \u003d resp.get(\u0027faultstring\u0027)"},{"line_number":2540,"context_line":"        self.assertIn("},{"line_number":2541,"context_line":"            \u0027Certificate container references are not allowed on \u0027, fault)"},{"line_number":2542,"context_line":"        self.assertIn("},{"line_number":2543,"context_line":"            \u0027{} protocol listeners.\u0027.format(constants.PROTOCOL_TCP), fault)"},{"line_number":2544,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"0731305e_4d0c3970","line":2541,"range":{"start_line":2541,"start_character":13,"end_line":2541,"end_character":64},"in_reply_to":"7f8a74ac_9ce693ae","updated":"2022-10-07 09:20:09.000000000","message":"Ack, I will return this kind of message.","commit_id":"8de673219ca73f77e2267fbc4a399a12465f4733"}],"releasenotes/notes/add-validation-h2-listener-pool-dfb0dcd4515067d5.yaml":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"5cc7e9713aba9b996c1e1b0079b0ed811b6c5a1f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added protocol validation on listener and pool creation and update."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7e58a285_7ee8cf8d","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":71},"updated":"2022-10-06 09:55:48.000000000","message":"I would add that the improved validation is about ALPN protocols.","commit_id":"a2ed766b8c911f9e27355f19906e7c35a2367c70"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"90a62e6e491c525019c71b5a9419d776fb8b84ad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added protocol validation on listener and pool creation and update."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0f38976f_8f36dbbb","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":71},"in_reply_to":"7e58a285_7ee8cf8d","updated":"2022-10-07 08:44:04.000000000","message":"Done","commit_id":"a2ed766b8c911f9e27355f19906e7c35a2367c70"}]}