)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b5a2975aea75a5796f3d4b99cf9422c99ec0da4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0414dc6f_b4898917","updated":"2022-12-05 12:25:58.000000000","message":"Thanks Greg","commit_id":"9a0b61eaab0f4ea9a55802dce2b74fa78bc7b72f"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"277144d8ea550d7ad41593ca10e424dacb583f77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f0e0fa23_a3e38411","updated":"2022-12-27 16:01:09.000000000","message":"Not sure what the point of the has_non_default_pools parameter is if it has no effect.","commit_id":"da96b6b99a3cdf4bc3919b9a118d038142e60a46"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a0b1a42526adc0ab525415ab5d3d2acdbe50b970","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"47912f11_9bfca796","updated":"2022-12-12 09:32:44.000000000","message":"recheck tox issue should be resolved now","commit_id":"da96b6b99a3cdf4bc3919b9a118d038142e60a46"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"93f3cfc5e7ac7efb908bf12200e73a93e6eb72b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e4f2c08f_149c7621","in_reply_to":"f0e0fa23_a3e38411","updated":"2023-01-04 13:54:11.000000000","message":"Yes, it was left between suggestions and patch-sets. Thanks, I will remove it.","commit_id":"da96b6b99a3cdf4bc3919b9a118d038142e60a46"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d4846ebd6c27719f1637920c75bab5e5c43e6ae6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c85ffeb2_329f6edc","updated":"2023-02-15 07:49:00.000000000","message":"-1 for the release note, I think we can improve it","commit_id":"d38ed827a5849732027139ba2b2496309165e7d6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"948aa476ccaca14349fccbed29ba14d58d2e5f7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"474681a2_843e4fd7","updated":"2023-02-07 17:45:13.000000000","message":"I had to rebase because of a merge conflict","commit_id":"d38ed827a5849732027139ba2b2496309165e7d6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"4cb303e0340077dbd0bf2e769d46853a3ab0a56b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"98aeaf42_73df711d","updated":"2023-02-15 16:06:45.000000000","message":"recheck timeout not related to patch","commit_id":"0ed96e6e0fac7563cc3290ffcb8ee57a0b8415cd"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"d9df79e282faaaa423cd25b5e8a62f04dff19f71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"25029404_8b75cadb","updated":"2023-03-14 13:01:47.000000000","message":"qq, the commit message says this patch is a cherry-pick but it doesn\u0027t appear to be?","commit_id":"5f85f89a1705fcdf93f17187d45447005bc37593"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f090097572b6517d9f85b31c7506bb4637add54d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c46bf4ca_693eb13d","in_reply_to":"25029404_8b75cadb","updated":"2023-03-14 13:05:20.000000000","message":"yeah I agree, this line should be removed.","commit_id":"5f85f89a1705fcdf93f17187d45447005bc37593"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"71fa416a21a694df431f5b2e2e363cb0a2d11b64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"98ec0c8f_62fcb0ac","updated":"2023-03-14 13:14:41.000000000","message":"Right, thanks","commit_id":"3a157c0216a4b9eca75978ce1e32790aeaa4ccab"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"915b5cb0e9728f4ee6b0f69ae81055f9fb793399","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8eb0b6b0_3fcfcc01","updated":"2023-03-27 18:25:04.000000000","message":"recheck grenade fixed","commit_id":"3a157c0216a4b9eca75978ce1e32790aeaa4ccab"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2a0a6c495103178ca8bda09c75b5f2264a0b9e71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"03d857b3_766635ab","updated":"2023-03-28 19:46:20.000000000","message":"recheck grenade is fixed","commit_id":"3a157c0216a4b9eca75978ce1e32790aeaa4ccab"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a4ccdc1aaba9ae58102f02c3a27169b1724c23a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a3c56e3f_ff0fb467","updated":"2023-03-23 14:48:46.000000000","message":"recheck grenade should be fixed now","commit_id":"3a157c0216a4b9eca75978ce1e32790aeaa4ccab"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"8ae2f9a0877a1a0621b003beb09f056e8371003e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"9e356997_3d6b187a","updated":"2023-03-14 16:32:51.000000000","message":"recheck, failure is not related to the patch","commit_id":"3a157c0216a4b9eca75978ce1e32790aeaa4ccab"}],"octavia/controller/worker/v1/flows/load_balancer_flows.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"277144d8ea550d7ad41593ca10e424dacb583f77","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        self.member_flows \u003d member_flows.MemberFlows()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_create_load_balancer_flow(self, topology, listeners\u003dNone,"},{"line_number":48,"context_line":"                                      has_non_default_pools: bool \u003d False):"},{"line_number":49,"context_line":"        \"\"\"Creates a conditional graph flow that allocates a loadbalancer."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        :raises InvalidTopology: Invalid topology specified"}],"source_content_type":"text/x-python","patch_set":10,"id":"3edaf430_ce4392ab","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":73},"updated":"2022-12-27 16:01:09.000000000","message":"This isn\u0027t used anywhere?","commit_id":"da96b6b99a3cdf4bc3919b9a118d038142e60a46"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"93f3cfc5e7ac7efb908bf12200e73a93e6eb72b9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.member_flows \u003d member_flows.MemberFlows()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_create_load_balancer_flow(self, topology, listeners\u003dNone,"},{"line_number":48,"context_line":"                                      has_non_default_pools: bool \u003d False):"},{"line_number":49,"context_line":"        \"\"\"Creates a conditional graph flow that allocates a loadbalancer."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        :raises InvalidTopology: Invalid topology specified"}],"source_content_type":"text/x-python","patch_set":10,"id":"c8687c85_c02988b6","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":73},"in_reply_to":"3edaf430_ce4392ab","updated":"2023-01-04 13:54:11.000000000","message":"Done","commit_id":"da96b6b99a3cdf4bc3919b9a118d038142e60a46"}],"octavia/controller/worker/v2/controller_worker.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3936c48e113fcccdecc54eb91ab4260dae06ab9c","unresolved":true,"context_lines":[{"line_number":356,"context_line":"                lb.listeners)"},{"line_number":357,"context_line":"        )"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        pools_dicts \u003d ("},{"line_number":360,"context_line":"            provider_utils.db_pools_to_provider_pools_list_of_dicts("},{"line_number":361,"context_line":"                lb.pools)"},{"line_number":362,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"58983164_080b3ecc","line":359,"range":{"start_line":359,"start_character":8,"end_line":359,"end_character":19},"updated":"2022-12-05 08:01:37.000000000","message":"we don\u0027t need the pool dicts in the controller code, I think we can safely use something like \"has_non_default_pools \u003d len(lb.pools) \u003e 0\"","commit_id":"9a0b61eaab0f4ea9a55802dce2b74fa78bc7b72f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b5a2975aea75a5796f3d4b99cf9422c99ec0da4a","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                lb.listeners)"},{"line_number":357,"context_line":"        )"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        pools_dicts \u003d ("},{"line_number":360,"context_line":"            provider_utils.db_pools_to_provider_pools_list_of_dicts("},{"line_number":361,"context_line":"                lb.pools)"},{"line_number":362,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"0f21278d_397bcc2e","line":359,"range":{"start_line":359,"start_character":8,"end_line":359,"end_character":19},"in_reply_to":"58983164_080b3ecc","updated":"2022-12-05 12:25:58.000000000","message":"Done","commit_id":"9a0b61eaab0f4ea9a55802dce2b74fa78bc7b72f"}],"octavia/controller/worker/v2/flows/load_balancer_flows.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"396f843182d5b167870c16072a88b2c44c7cc9e9","unresolved":true,"context_lines":[{"line_number":230,"context_line":"        )"},{"line_number":231,"context_line":"        return flows"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def _create_pools_flow(self):"},{"line_number":234,"context_line":"        flows \u003d []"},{"line_number":235,"context_line":"        flows.append("},{"line_number":236,"context_line":"            database_tasks.MarkLBActiveInDB("}],"source_content_type":"text/x-python","patch_set":6,"id":"0d6fe6a7_c9fa3958","line":233,"range":{"start_line":233,"start_character":4,"end_line":233,"end_character":33},"updated":"2022-11-14 16:10:01.000000000","message":"I am not sure if I should add anything else","commit_id":"91a55d69664cef56b37ea276bb96146ad63b1f32"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b5a2975aea75a5796f3d4b99cf9422c99ec0da4a","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        )"},{"line_number":231,"context_line":"        return flows"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def _create_pools_flow(self):"},{"line_number":234,"context_line":"        flows \u003d []"},{"line_number":235,"context_line":"        flows.append("},{"line_number":236,"context_line":"            database_tasks.MarkLBActiveInDB("}],"source_content_type":"text/x-python","patch_set":6,"id":"c8712e05_61a189a9","line":233,"range":{"start_line":233,"start_character":4,"end_line":233,"end_character":33},"in_reply_to":"0d6fe6a7_c9fa3958","updated":"2022-12-05 12:25:58.000000000","message":"Done","commit_id":"91a55d69664cef56b37ea276bb96146ad63b1f32"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3936c48e113fcccdecc54eb91ab4260dae06ab9c","unresolved":true,"context_lines":[{"line_number":233,"context_line":"    def _create_pools_flow(self, listeners\u003dNone):"},{"line_number":234,"context_line":"        flows \u003d []"},{"line_number":235,"context_line":"        # We avoid adding duplicate MarkLBActiveInDB tasks in the flow"},{"line_number":236,"context_line":"        if not listeners:"},{"line_number":237,"context_line":"            flows.append("},{"line_number":238,"context_line":"                database_tasks.MarkLBActiveInDB("},{"line_number":239,"context_line":"                    mark_subobjects\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"b46dff20_690bfa74","line":236,"range":{"start_line":236,"start_character":8,"end_line":236,"end_character":24},"updated":"2022-12-05 08:01:37.000000000","message":"I believe this could be evaluated in the caller","commit_id":"9a0b61eaab0f4ea9a55802dce2b74fa78bc7b72f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b5a2975aea75a5796f3d4b99cf9422c99ec0da4a","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    def _create_pools_flow(self, listeners\u003dNone):"},{"line_number":234,"context_line":"        flows \u003d []"},{"line_number":235,"context_line":"        # We avoid adding duplicate MarkLBActiveInDB tasks in the flow"},{"line_number":236,"context_line":"        if not listeners:"},{"line_number":237,"context_line":"            flows.append("},{"line_number":238,"context_line":"                database_tasks.MarkLBActiveInDB("},{"line_number":239,"context_line":"                    mark_subobjects\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f4a4c74_c28c25be","line":236,"range":{"start_line":236,"start_character":8,"end_line":236,"end_character":24},"in_reply_to":"b46dff20_690bfa74","updated":"2022-12-05 12:25:58.000000000","message":"Done","commit_id":"9a0b61eaab0f4ea9a55802dce2b74fa78bc7b72f"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"719726c06bd6ae2fcab807f5021c33d3c07e02c8","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        # the listeners, and we have non default pools"},{"line_number":104,"context_line":"        elif has_non_default_pools:"},{"line_number":105,"context_line":"            lb_create_flow.add("},{"line_number":106,"context_line":"                database_tasks.MarkLBActiveInDB("},{"line_number":107,"context_line":"                    mark_subobjects\u003dTrue,"},{"line_number":108,"context_line":"                    requires\u003dconstants.LOADBALANCER"},{"line_number":109,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":8,"id":"f79760df_1938ed48","line":106,"range":{"start_line":106,"start_character":31,"end_line":106,"end_character":47},"updated":"2022-12-05 13:25:44.000000000","message":"I\u0027m wondering if we can simplify this flow by removing MarkLBActiveInDB calls from the callees (get_port_lb_amp_association_flow and _create_listener_flow) and just call it from here without any condition.\nAny other thoughts?","commit_id":"5c7d19d967af34f082594a17f698b55906923f33"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"59bef0207bfc5aee51610bcd75f6b8279ca67df8","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        # the listeners, and we have non default pools"},{"line_number":104,"context_line":"        elif has_non_default_pools:"},{"line_number":105,"context_line":"            lb_create_flow.add("},{"line_number":106,"context_line":"                database_tasks.MarkLBActiveInDB("},{"line_number":107,"context_line":"                    mark_subobjects\u003dTrue,"},{"line_number":108,"context_line":"                    requires\u003dconstants.LOADBALANCER"},{"line_number":109,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":8,"id":"f85c1b3c_4c3c45a6","line":106,"range":{"start_line":106,"start_character":31,"end_line":106,"end_character":47},"in_reply_to":"f79760df_1938ed48","updated":"2022-12-05 18:23:46.000000000","message":"I think it will simplify the code.\n\nSo far we had the mark_active\u003d(not listeners), just like the if statement I assigned for MarkLBActiveInDB.\n\nIMO we could have done it before as well, but now that we want to assure non attached pools are ACTIVE as well, it looks to me like it is even more required.\n\nI tried your suggestion and ran some \"simple scenarios\" against it and it looks fine to me. If nobody opposes I will upload it here.","commit_id":"5c7d19d967af34f082594a17f698b55906923f33"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"277144d8ea550d7ad41593ca10e424dacb583f77","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        self.lb_repo \u003d repo.LoadBalancerRepository()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_create_load_balancer_flow(self, topology, listeners\u003dNone,"},{"line_number":51,"context_line":"                                      has_non_default_pools: bool \u003d False):"},{"line_number":52,"context_line":"        \"\"\"Creates a conditional graph flow that allocates a loadbalancer."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :raises InvalidTopology: Invalid topology specified"}],"source_content_type":"text/x-python","patch_set":10,"id":"ac3ec29d_eb31782d","line":51,"range":{"start_line":51,"start_character":38,"end_line":51,"end_character":73},"updated":"2022-12-27 16:01:09.000000000","message":"Also not used anywhere.","commit_id":"da96b6b99a3cdf4bc3919b9a118d038142e60a46"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"93f3cfc5e7ac7efb908bf12200e73a93e6eb72b9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.lb_repo \u003d repo.LoadBalancerRepository()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_create_load_balancer_flow(self, topology, listeners\u003dNone,"},{"line_number":51,"context_line":"                                      has_non_default_pools: bool \u003d False):"},{"line_number":52,"context_line":"        \"\"\"Creates a conditional graph flow that allocates a loadbalancer."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :raises InvalidTopology: Invalid topology specified"}],"source_content_type":"text/x-python","patch_set":10,"id":"212ea8af_4f7b5fbc","line":51,"range":{"start_line":51,"start_character":38,"end_line":51,"end_character":73},"in_reply_to":"ac3ec29d_eb31782d","updated":"2023-01-04 13:54:11.000000000","message":"Done","commit_id":"da96b6b99a3cdf4bc3919b9a118d038142e60a46"}],"octavia/db/prepare.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3936c48e113fcccdecc54eb91ab4260dae06ab9c","unresolved":true,"context_lines":[{"line_number":23,"context_line":"CONF \u003d cfg.CONF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def create_load_balancer_tree(lb_dict):"},{"line_number":27,"context_line":"    listeners \u003d lb_dict.pop(\u0027listeners\u0027) or []"},{"line_number":28,"context_line":"    pools \u003d lb_dict.pop(\u0027pools\u0027) or []"},{"line_number":29,"context_line":"    prepped_lb \u003d create_load_balancer(lb_dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"6adbf2fb_fd11585e","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":29},"updated":"2022-12-05 08:01:37.000000000","message":"I think this function is not used in Octavia","commit_id":"9a0b61eaab0f4ea9a55802dce2b74fa78bc7b72f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b5a2975aea75a5796f3d4b99cf9422c99ec0da4a","unresolved":true,"context_lines":[{"line_number":23,"context_line":"CONF \u003d cfg.CONF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def create_load_balancer_tree(lb_dict):"},{"line_number":27,"context_line":"    listeners \u003d lb_dict.pop(\u0027listeners\u0027) or []"},{"line_number":28,"context_line":"    pools \u003d lb_dict.pop(\u0027pools\u0027) or []"},{"line_number":29,"context_line":"    prepped_lb \u003d create_load_balancer(lb_dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"726ee568_e2fe720a","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":29},"in_reply_to":"6adbf2fb_fd11585e","updated":"2022-12-05 12:25:58.000000000","message":"Yes I see that it is not used in Octavia.\nI will delete the changes I made here, but I am not sure Whether we should delete the entire function.","commit_id":"9a0b61eaab0f4ea9a55802dce2b74fa78bc7b72f"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"719726c06bd6ae2fcab807f5021c33d3c07e02c8","unresolved":true,"context_lines":[{"line_number":23,"context_line":"CONF \u003d cfg.CONF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def create_load_balancer_tree(lb_dict):"},{"line_number":27,"context_line":"    listeners \u003d lb_dict.pop(\u0027listeners\u0027) or []"},{"line_number":28,"context_line":"    pools \u003d lb_dict.pop(\u0027pools\u0027) or []"},{"line_number":29,"context_line":"    prepped_lb \u003d create_load_balancer(lb_dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"83e5a749_5ffa99d8","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":29},"in_reply_to":"726ee568_e2fe720a","updated":"2022-12-05 13:25:44.000000000","message":"I don\u0027t know if this is unfinished work, but I guess that we should remove them if they are unused. It will clarify the code.","commit_id":"9a0b61eaab0f4ea9a55802dce2b74fa78bc7b72f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7b2c9f5ba9be94aaef8e4896f8aef789b08845d8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"CONF \u003d cfg.CONF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def create_load_balancer_tree(lb_dict):"},{"line_number":27,"context_line":"    listeners \u003d lb_dict.pop(\u0027listeners\u0027) or []"},{"line_number":28,"context_line":"    pools \u003d lb_dict.pop(\u0027pools\u0027) or []"},{"line_number":29,"context_line":"    prepped_lb \u003d create_load_balancer(lb_dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ec3bc27c_0d72dbc3","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":29},"in_reply_to":"83e5a749_5ffa99d8","updated":"2022-12-05 14:49:46.000000000","message":"ok then, I uploaded https://review.opendev.org/c/openstack/octavia/+/866585","commit_id":"9a0b61eaab0f4ea9a55802dce2b74fa78bc7b72f"}],"octavia/db/repositories.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3936c48e113fcccdecc54eb91ab4260dae06ab9c","unresolved":true,"context_lines":[{"line_number":667,"context_line":"                        {\u0027proj\u0027: project_id})"},{"line_number":668,"context_line":"            raise exceptions.ProjectBusyException() from e"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"    def create_load_balancer_tree(self, session, lock_session, lb_dict):"},{"line_number":671,"context_line":"        listener_dicts \u003d lb_dict.pop(\u0027listeners\u0027, [])"},{"line_number":672,"context_line":"        pool_dicts \u003d lb_dict.pop(\u0027pools\u0027, [])"},{"line_number":673,"context_line":"        vip_dict \u003d lb_dict.pop(\u0027vip\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"cb9cae62_66e2c733","line":670,"range":{"start_line":670,"start_character":8,"end_line":670,"end_character":33},"updated":"2022-12-05 08:01:37.000000000","message":"I think this function is not used in Octavia","commit_id":"9a0b61eaab0f4ea9a55802dce2b74fa78bc7b72f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b5a2975aea75a5796f3d4b99cf9422c99ec0da4a","unresolved":true,"context_lines":[{"line_number":667,"context_line":"                        {\u0027proj\u0027: project_id})"},{"line_number":668,"context_line":"            raise exceptions.ProjectBusyException() from e"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"    def create_load_balancer_tree(self, session, lock_session, lb_dict):"},{"line_number":671,"context_line":"        listener_dicts \u003d lb_dict.pop(\u0027listeners\u0027, [])"},{"line_number":672,"context_line":"        pool_dicts \u003d lb_dict.pop(\u0027pools\u0027, [])"},{"line_number":673,"context_line":"        vip_dict \u003d lb_dict.pop(\u0027vip\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"6183d35e_290c8db1","line":670,"range":{"start_line":670,"start_character":8,"end_line":670,"end_character":33},"in_reply_to":"cb9cae62_66e2c733","updated":"2022-12-05 12:25:58.000000000","message":"Yes I see that it is not used in Octavia.\nI will delete the changes I made here, but I am not sure Whether we should delete the entire function.","commit_id":"9a0b61eaab0f4ea9a55802dce2b74fa78bc7b72f"}],"releasenotes/notes/fix-pool-prov-status-on-lb-single-create-897070aee0a42da6.yaml":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"277144d8ea550d7ad41593ca10e424dacb583f77","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a step that sets non attached pools\u0027 provisioning status to be active on the DB task that is responsible for it."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c0a6d81e_3bc3a356","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":122},"updated":"2022-12-27 16:01:09.000000000","message":"I think this is too technical and our users might not understand what that means. You could write that the provisioning status of pools will now get updated to ACTIVE after the resources of a fully populated load balancer have been created successfully or something like that.","commit_id":"da96b6b99a3cdf4bc3919b9a118d038142e60a46"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"93f3cfc5e7ac7efb908bf12200e73a93e6eb72b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a step that sets non attached pools\u0027 provisioning status to be active on the DB task that is responsible for it."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"40f9d4d7_644b9bf6","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":122},"in_reply_to":"c0a6d81e_3bc3a356","updated":"2023-01-04 13:54:11.000000000","message":"I also think your suggestion is better and simpler, I will use it. Thanks","commit_id":"da96b6b99a3cdf4bc3919b9a118d038142e60a46"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d4846ebd6c27719f1637920c75bab5e5c43e6ae6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a task that will update the provisioning status of pools to ACTIVE after the resources of a fully populated load balancer have been created successfully."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1c0fda6e_efadb8af","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":149},"updated":"2023-02-15 07:49:00.000000000","message":"the 79-character column limit also applies to the release notes.\n \nThen I think that \"Added a task ...\" is not really helpful for end users, I would rather use something like \"Fixed a bug that didn\u0027t set the correct provisioning_status for unattached pools when creating a fully-populated load balancer.\"","commit_id":"d38ed827a5849732027139ba2b2496309165e7d6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c090a0be37cd61a146f13674e695b7c21b2a1df8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a task that will update the provisioning status of pools to ACTIVE after the resources of a fully populated load balancer have been created successfully."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"72e4f305_dad1a164","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":149},"in_reply_to":"1c0fda6e_efadb8af","updated":"2023-02-15 12:22:00.000000000","message":"Done, thanks.","commit_id":"d38ed827a5849732027139ba2b2496309165e7d6"}]}