)]}'
{"octavia/controller/worker/v2/tasks/network_tasks.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"2445e662df51c4712aaf84e2323980d6d6cc71bc","unresolved":true,"context_lines":[{"line_number":998,"context_line":"                 port_name, port.id, amphora_id)"},{"line_number":999,"context_line":"        return port.to_dict(recurse\u003dTrue)"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def revert(self, result, vip, vip_sg_id, amphora_id, additional_vips,"},{"line_number":1002,"context_line":"               *args, **kwargs):"},{"line_number":1003,"context_line":"        if isinstance(result, failure.Failure):"},{"line_number":1004,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"c2f5e81c_24662c4b","line":1001,"range":{"start_line":1001,"start_character":21,"end_line":1001,"end_character":73},"updated":"2022-12-27 12:57:50.000000000","message":"Can we please add typing information? This bug is a good example of how type checking could have helped, but it is also helpful for documentation. I don\u0027t care as much for v1 code because it will get removed soon.","commit_id":"65876c285436325ce8406c4514584a76ebc4b185"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a873224ec2d7b8cc5a0743ba9c5d76466e9adf49","unresolved":false,"context_lines":[{"line_number":998,"context_line":"                 port_name, port.id, amphora_id)"},{"line_number":999,"context_line":"        return port.to_dict(recurse\u003dTrue)"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def revert(self, result, vip, vip_sg_id, amphora_id, additional_vips,"},{"line_number":1002,"context_line":"               *args, **kwargs):"},{"line_number":1003,"context_line":"        if isinstance(result, failure.Failure):"},{"line_number":1004,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"216faa43_a7e0843f","line":1001,"range":{"start_line":1001,"start_character":21,"end_line":1001,"end_character":73},"in_reply_to":"c2f5e81c_24662c4b","updated":"2023-01-11 20:31:19.000000000","message":"Done","commit_id":"65876c285436325ce8406c4514584a76ebc4b185"}],"octavia/tests/unit/controller/worker/v2/tasks/test_network_tasks.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"bea9dee928de2877f2a198ebfd0ab30eaa168fb1","unresolved":true,"context_lines":[{"line_number":1726,"context_line":"        net_task.revert([port_mock], vip_dict, VIP_SG_ID, AMP_ID,"},{"line_number":1727,"context_line":"                        additional_vips)"},{"line_number":1728,"context_line":""},{"line_number":1729,"context_line":"        mock_driver.delete_port.assert_called_once_with(PORT_ID)"},{"line_number":1730,"context_line":""},{"line_number":1731,"context_line":"        # Test revert exception"},{"line_number":1732,"context_line":"        mock_driver.reset_mock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"15f3fd39_5a4a6d60","side":"PARENT","line":1729,"range":{"start_line":1729,"start_character":0,"end_line":1729,"end_character":64},"updated":"2022-12-22 15:04:29.000000000","message":"We can keep this one, no?","commit_id":"8d27bdb5462474dafc934d164f3a299bfca8dd89"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"2445e662df51c4712aaf84e2323980d6d6cc71bc","unresolved":true,"context_lines":[{"line_number":1726,"context_line":"        net_task.revert([port_mock], vip_dict, VIP_SG_ID, AMP_ID,"},{"line_number":1727,"context_line":"                        additional_vips)"},{"line_number":1728,"context_line":""},{"line_number":1729,"context_line":"        mock_driver.delete_port.assert_called_once_with(PORT_ID)"},{"line_number":1730,"context_line":""},{"line_number":1731,"context_line":"        # Test revert exception"},{"line_number":1732,"context_line":"        mock_driver.reset_mock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"6655d3aa_bb1d6b2b","side":"PARENT","line":1729,"range":{"start_line":1729,"start_character":0,"end_line":1729,"end_character":64},"in_reply_to":"15f3fd39_5a4a6d60","updated":"2022-12-27 12:57:50.000000000","message":"The old code called net_task.revert() twice and the new code calls it only once. Hence this line was removed. It seems fine.","commit_id":"8d27bdb5462474dafc934d164f3a299bfca8dd89"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c933ea63fcb1f11cb436f7b0c4fad3dbeb214a6b","unresolved":false,"context_lines":[{"line_number":1726,"context_line":"        net_task.revert([port_mock], vip_dict, VIP_SG_ID, AMP_ID,"},{"line_number":1727,"context_line":"                        additional_vips)"},{"line_number":1728,"context_line":""},{"line_number":1729,"context_line":"        mock_driver.delete_port.assert_called_once_with(PORT_ID)"},{"line_number":1730,"context_line":""},{"line_number":1731,"context_line":"        # Test revert exception"},{"line_number":1732,"context_line":"        mock_driver.reset_mock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f0f9371_61cd1a41","side":"PARENT","line":1729,"range":{"start_line":1729,"start_character":0,"end_line":1729,"end_character":64},"in_reply_to":"6655d3aa_bb1d6b2b","updated":"2023-01-03 14:24:04.000000000","message":"Right, thanks.","commit_id":"8d27bdb5462474dafc934d164f3a299bfca8dd89"}],"releasenotes/notes/fix-create-vip-base-port-revert-e1d6b8661bb095dd.yaml":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"2445e662df51c4712aaf84e2323980d6d6cc71bc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix the revert function of the CreateVIPBasePort task. The code was"},{"line_number":5,"context_line":"    incorrect and a error line appeared in the logs during reverts."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"18254bb2_a5ea275e","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"updated":"2022-12-27 12:57:50.000000000","message":"Release notes should use past tense, I think, because by the time this gets released this was fixed already.","commit_id":"65876c285436325ce8406c4514584a76ebc4b185"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a873224ec2d7b8cc5a0743ba9c5d76466e9adf49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix the revert function of the CreateVIPBasePort task. The code was"},{"line_number":5,"context_line":"    incorrect and a error line appeared in the logs during reverts."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0d06d238_41abaadb","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"in_reply_to":"18254bb2_a5ea275e","updated":"2023-01-11 20:31:19.000000000","message":"Done","commit_id":"65876c285436325ce8406c4514584a76ebc4b185"}]}