)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"62ae135415de53ede1a2dff336a00b18c4d8c08d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a8e0f7c9_1ee22012","updated":"2023-03-21 15:33:13.000000000","message":"LGTM","commit_id":"ba92aeb946343c045e8363a2aae78e0a17a6cb82"}],"octavia/amphorae/backends/health_daemon/health_daemon.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1fd43bd0f288e51e66b39c7cb8d58b0aa432d12c","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"def get_stats(stat_sock_file):"},{"line_number":160,"context_line":"    try:"},{"line_number":161,"context_line":"        stats_query \u003d haproxy_query.HAProxyQuery(stat_sock_file)"},{"line_number":162,"context_line":"    except Exception as e:"},{"line_number":163,"context_line":"        LOG.debug(\u0027Unable to query the HAProxy stats (%s) due to: %s\u0027,"},{"line_number":164,"context_line":"                  stat_sock_file, str(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"f59410fe_6bf81fcc","line":161,"range":{"start_line":161,"start_character":36,"end_line":161,"end_character":48},"updated":"2023-03-18 06:58:26.000000000","message":"HAProxyQuery doesn\u0027t raise an exception, but show_stat() does.\nI would enclose lines 167-168 in the try/except block too.","commit_id":"5f6cdc605011e8ca2ad2c9b92a41ab8f5fd9527b"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f6c83f1cdffff4bbab4d1ec3a56f9ad591bdddf0","unresolved":true,"context_lines":[{"line_number":160,"context_line":"    try:"},{"line_number":161,"context_line":"        stats_query \u003d haproxy_query.HAProxyQuery(stat_sock_file)"},{"line_number":162,"context_line":"    except Exception as e:"},{"line_number":163,"context_line":"        LOG.debug(\u0027Unable to query the HAProxy stats (%s) due to: %s\u0027,"},{"line_number":164,"context_line":"                  stat_sock_file, str(e))"},{"line_number":165,"context_line":"        # Return empty lists so that the heartbeat will still be sent"},{"line_number":166,"context_line":"        return [], []"}],"source_content_type":"text/x-python","patch_set":1,"id":"676893cf_9c922063","line":163,"range":{"start_line":163,"start_character":12,"end_line":163,"end_character":17},"updated":"2023-03-20 12:45:01.000000000","message":"I think the log level should be \"warning\", it could help troubleshooting issues on prod env.","commit_id":"5f6cdc605011e8ca2ad2c9b92a41ab8f5fd9527b"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1fd43bd0f288e51e66b39c7cb8d58b0aa432d12c","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        LOG.debug(\u0027Unable to query the HAProxy stats (%s) due to: %s\u0027,"},{"line_number":164,"context_line":"                  stat_sock_file, str(e))"},{"line_number":165,"context_line":"        # Return empty lists so that the heartbeat will still be sent"},{"line_number":166,"context_line":"        return [], []"},{"line_number":167,"context_line":"    stats \u003d stats_query.show_stat()"},{"line_number":168,"context_line":"    pool_status \u003d stats_query.get_pool_status()"},{"line_number":169,"context_line":"    return stats, pool_status"}],"source_content_type":"text/x-python","patch_set":1,"id":"41dfcc08_418cc90b","line":166,"range":{"start_line":166,"start_character":19,"end_line":166,"end_character":21},"updated":"2023-03-18 06:58:26.000000000","message":"it is expected that the 2nd return value is a dict\n\nso it should be \"return [], {}\"","commit_id":"5f6cdc605011e8ca2ad2c9b92a41ab8f5fd9527b"}]}