)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"dcdbd8dd258e2ef646b77af394fdf5646597a94b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c84bee5e_b919d695","updated":"2023-03-21 08:24:59.000000000","message":"Could you also add a release note? it\u0027s worth it to mention that this bug is fixed","commit_id":"5d61d2bcb4d33349a26c476411a3d746fbcdc0a0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"81590d5eb12c799c5f551ddf39285fe661e63d4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e1be369f_12271b80","updated":"2023-03-20 17:25:28.000000000","message":"Hi folks, can u please review this ? Let me know if some additional steps are required here, i will process it as soon as possible.","commit_id":"5d61d2bcb4d33349a26c476411a3d746fbcdc0a0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dc60bdcb19e6f6a6279590fa30ac674bf56ec3ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"adbe6bde_c8529a23","updated":"2023-03-21 10:31:15.000000000","message":"Done, sorry","commit_id":"24e574f7b5331ac315e216ed7cf050aae822ba5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dbcaa45bdb03a356a503e0061455855832200dc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"881a32ed_3a11e2d1","updated":"2023-03-24 09:17:50.000000000","message":"Ah, ok thanks for informations. Sorry.","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4efcd8d9a0d8f8eab68c97c669d2e71c4a85af6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d5b4c68f_b668223a","updated":"2023-03-21 14:26:58.000000000","message":"LGTM","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"9ffeae80e2bba92d979f487be2a9666615339e4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c3f71a95_a8e7c22b","updated":"2023-03-21 10:32:40.000000000","message":"LGTM, thanks","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d1bf723e63a35e62523cf4721e378455c6c819c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e594e277_0e509adf","updated":"2023-03-27 14:48:17.000000000","message":"Still something bad in grenade \n\n2023-03-27 12:54:38.029 | + /opt/stack/new/octavia/devstack/plugin.sh:octavia_stop:660 :   [[ ovn \u003d\u003d \\l\\i\\n\\u\\x\\b\\r\\i\\d\\g\\e ]]\n2023-03-27 12:54:38.032 | + /opt/stack/new/octavia/devstack/plugin.sh:octavia_stop:666 :   die \u0027Unknown network controller. Please define octavia_delete_network_interface_device\u0027\n2023-03-27 12:54:38.034 | + /opt/stack/new/devstack/functions-common:die:264 :   local exitcode\u003d1\n2023-03-27 12:54:38.037 | [Call Trace]\n2023-03-27 12:54:38.037 | /opt/stack/new/octavia/devstack/upgrade/shutdown.sh:21:octavia_stop\n2023-03-27 12:54:38.037 | /opt/stack/new/octavia/devstack/plugin.sh:666:die\n2023-03-27 12:54:38.041 | [ERROR] /opt/stack/new/octavia/devstack/plugin.sh:Unknown network\n2023-03-27 12:54:39.043 | 1 die /opt/stack/new/devstack/functions-common\n2023-03-27 12:54:39.043 | 666 octavia_stop /opt/stack/new/octavia/devstack/plugin.sh\n2023-03-27 12:54:39.043 | 21 main /opt/stack/new/octavia/devstack/upgrade/shutdown.sh\n2023-03-27 12:54:39.043 | Exit code: 1\n2023-03-27 12:54:40.991 | + inc/plugin:shutdown_services:87          :   die 87 \u0027Failed to shutdown octavia\u0027\n2023-03-27 12:54:40.993 | + /opt/stack/new/devstack/functions-common:die:264 :   local exitcode\u003d1\n2023-03-27 12:54:40.995 | [Call Trace]\n2023-03-27 12:54:40.996 | ./grenade.sh:352:shutdown_services\n2023-03-27 12:54:40.996 | /opt/stack/new/grenade/inc/plugin:87:die\n2023-03-27 12:54:40.999 | [ERROR] /opt/stack/new/grenade/inc/plugin:87 Failed to shutdown octavia\n2023-03-27 12:54:42.001 | 1 die /opt/stack/new/devstack/functions-common\n2023-03-27 12:54:42.001 | 87 shutdown_services /opt/stack/new/grenade/inc/plugin\n2023-03-27 12:54:42.001 | 352 main ./grenade.sh\n2023-03-27 12:54:42.001 | Exit code: 1\n\nIt looks like something missing for shell script ? ","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2cf3f9088af3c656f9099183f5aadac31ad78bc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"156b07d1_acf653d3","updated":"2023-03-22 07:31:20.000000000","message":"grenade failed with\n\n```\n2023-03-21 22:29:02.122 | E: You don\u0027t have enough free space in /var/cache/apt/archives/.\n```\n\nWe need the dib fix","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5ed1697fc40f72d958f5185aaee347a382ef70be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"917c98ee_28cd2de8","updated":"2023-03-24 09:13:04.000000000","message":"recheck","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4c86b66cd0fd5c79250f141909fe95fe3a9e0251","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c69896a0_e57481a6","updated":"2023-03-27 12:26:33.000000000","message":"recheck gate fix merged","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"7977af44da558d9133e1258e99ce0c7127f64c19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8665afcb_c4f7de23","updated":"2023-03-21 19:29:26.000000000","message":"recheck gate issue is fixed","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0b90e532e5539d3824467c93beb64ccb046443ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"18086386_f23dc7c4","updated":"2023-03-27 18:23:03.000000000","message":"recheck grenade \u0026 pep8 are fixed","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"4e35779328b6e3d347bdc7a5a6d0e9319e807733","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"befda642_f9fd2819","in_reply_to":"881a32ed_3a11e2d1","updated":"2023-03-24 09:23:21.000000000","message":"np, I proposed a backport to 2023.1: https://review.opendev.org/c/openstack/octavia/+/878518\nit could fix the gate on master","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"cd09c12d398f759cdef3916246b8bef2d6578ea7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ebfa02c4_7975e30b","in_reply_to":"917c98ee_28cd2de8","updated":"2023-03-24 09:17:04.000000000","message":"please don\u0027t use \"bare\" rechecks (rechecks without reason), there\u0027s a blame list for projects that do that (see https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures and https://etherpad.opendev.org/p/recheck-weekly-summary).\ngrenade is still broken, it requires a fix in diskimage-builder on 2023.1","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"cdd4e645012ea7d0998286fefd33a79ee873f06c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09d87922_299a2c53","in_reply_to":"e594e277_0e509adf","updated":"2023-03-27 14:51:02.000000000","message":"the grenade job is broken, we are trying to fix it in https://review.opendev.org/c/openstack/octavia/+/878583","commit_id":"a460698cd933112529d1eae27d483da6b3035eff"}],"octavia/amphorae/backends/health_daemon/health_sender.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"dcdbd8dd258e2ef646b77af394fdf5646597a94b","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        for ipport in CONF.health_manager.controller_ip_port_list:"},{"line_number":71,"context_line":"            try:"},{"line_number":72,"context_line":"                ip, port \u003d ipport.rsplit(\u0027:\u0027, 1)"},{"line_number":73,"context_line":"                if ip.startswith(\u0027[\u0027) and ip.endswith(\u0027]\u0027):"},{"line_number":74,"context_line":"                    ip \u003d ip.replace(\u0027[\u0027, \u0027\u0027).replace(\u0027]\u0027, \u0027\u0027)"},{"line_number":75,"context_line":"            except ValueError:"},{"line_number":76,"context_line":"                LOG.error(\"Invalid ip and port \u0027%s\u0027 in health_manager \""}],"source_content_type":"text/x-python","patch_set":1,"id":"82b4c31e_d90fad4e","line":73,"updated":"2023-03-21 08:24:59.000000000","message":"I think that calling string functions for a single character is a bit over-complicated.\n\nI would do\n```\nif ip and ip[0] \u003d\u003d \u0027[\u0027 and ip[-1] \u003d\u003d \u0027]\u0027:\n    ip \u003d ip[1:-1]\n```","commit_id":"5d61d2bcb4d33349a26c476411a3d746fbcdc0a0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"76b239d6da2e89fb6255bf695ee595e2d6ef62c0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        for ipport in CONF.health_manager.controller_ip_port_list:"},{"line_number":71,"context_line":"            try:"},{"line_number":72,"context_line":"                ip, port \u003d ipport.rsplit(\u0027:\u0027, 1)"},{"line_number":73,"context_line":"                if ip.startswith(\u0027[\u0027) and ip.endswith(\u0027]\u0027):"},{"line_number":74,"context_line":"                    ip \u003d ip.replace(\u0027[\u0027, \u0027\u0027).replace(\u0027]\u0027, \u0027\u0027)"},{"line_number":75,"context_line":"            except ValueError:"},{"line_number":76,"context_line":"                LOG.error(\"Invalid ip and port \u0027%s\u0027 in health_manager \""}],"source_content_type":"text/x-python","patch_set":1,"id":"854c1248_a7022b2a","line":73,"in_reply_to":"82b4c31e_d90fad4e","updated":"2023-03-21 09:45:29.000000000","message":"Done","commit_id":"5d61d2bcb4d33349a26c476411a3d746fbcdc0a0"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"dcdbd8dd258e2ef646b77af394fdf5646597a94b","unresolved":true,"context_lines":[{"line_number":71,"context_line":"            try:"},{"line_number":72,"context_line":"                ip, port \u003d ipport.rsplit(\u0027:\u0027, 1)"},{"line_number":73,"context_line":"                if ip.startswith(\u0027[\u0027) and ip.endswith(\u0027]\u0027):"},{"line_number":74,"context_line":"                    ip \u003d ip.replace(\u0027[\u0027, \u0027\u0027).replace(\u0027]\u0027, \u0027\u0027)"},{"line_number":75,"context_line":"            except ValueError:"},{"line_number":76,"context_line":"                LOG.error(\"Invalid ip and port \u0027%s\u0027 in health_manager \""},{"line_number":77,"context_line":"                          \"controller_ip_port_list\", ipport)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c719936e_b418ce78","line":74,"updated":"2023-03-21 08:24:59.000000000","message":"this block is not covered by the tests:\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_8ec/877959/1/check/openstack-tox-cover/8ec54e7/cover/d_e78e16e7439b1fd1_health_sender_py.html#t73\n\nCould you add a unit test in https://opendev.org/openstack/octavia/src/branch/master/octavia/tests/unit/amphorae/backends/health_daemon/test_health_sender.py ?","commit_id":"5d61d2bcb4d33349a26c476411a3d746fbcdc0a0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"76b239d6da2e89fb6255bf695ee595e2d6ef62c0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            try:"},{"line_number":72,"context_line":"                ip, port \u003d ipport.rsplit(\u0027:\u0027, 1)"},{"line_number":73,"context_line":"                if ip.startswith(\u0027[\u0027) and ip.endswith(\u0027]\u0027):"},{"line_number":74,"context_line":"                    ip \u003d ip.replace(\u0027[\u0027, \u0027\u0027).replace(\u0027]\u0027, \u0027\u0027)"},{"line_number":75,"context_line":"            except ValueError:"},{"line_number":76,"context_line":"                LOG.error(\"Invalid ip and port \u0027%s\u0027 in health_manager \""},{"line_number":77,"context_line":"                          \"controller_ip_port_list\", ipport)"}],"source_content_type":"text/x-python","patch_set":1,"id":"866956d9_bab27a4e","line":74,"in_reply_to":"c719936e_b418ce78","updated":"2023-03-21 09:45:29.000000000","message":"Done","commit_id":"5d61d2bcb4d33349a26c476411a3d746fbcdc0a0"}],"releasenotes/notes/fix-health-monitor-to-error-revert-task-feb38ba7641a4892.yaml":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"e9145ed49d038e27715d8be6dc2cd2d83fe29cd1","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix a bug that prevented the provisioning_state of a health-monitor to be"},{"line_number":5,"context_line":"    set to ERROR when an error occurred while creating, updating or deleting a"},{"line_number":6,"context_line":"    health-monitor."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cd953fae_ad1c5824","line":6,"range":{"start_line":6,"start_character":11,"end_line":6,"end_character":18},"updated":"2023-03-21 09:47:34.000000000","message":"it seems you added a new line here, can you remove it?","commit_id":"24e574f7b5331ac315e216ed7cf050aae822ba5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dc60bdcb19e6f6a6279590fa30ac674bf56ec3ee","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix a bug that prevented the provisioning_state of a health-monitor to be"},{"line_number":5,"context_line":"    set to ERROR when an error occurred while creating, updating or deleting a"},{"line_number":6,"context_line":"    health-monitor."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d17df476_ed6f08f7","line":6,"range":{"start_line":6,"start_character":11,"end_line":6,"end_character":18},"in_reply_to":"cd953fae_ad1c5824","updated":"2023-03-21 10:31:15.000000000","message":"Done","commit_id":"24e574f7b5331ac315e216ed7cf050aae822ba5f"}]}