)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7d22a39b514902422895e7d1169a27a74d719c5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"19d218a6_359c7b01","updated":"2023-04-17 16:41:16.000000000","message":"LGTM","commit_id":"18cd1f34c8a918ab6f969a3271ac74132c4ac736"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c5b459771e4d7d885d6d7d05b990f205a39c9f3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c7187e5_51616486","updated":"2023-04-17 15:32:39.000000000","message":"recheck random failures","commit_id":"18cd1f34c8a918ab6f969a3271ac74132c4ac736"}],"octavia/amphorae/backends/agent/api_server/plug.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"25e4bce846719f11ff71df1c17e00bd9740a440c","unresolved":true,"context_lines":[{"line_number":189,"context_line":"                    vrrp_info\u003dvrrp_info,"},{"line_number":190,"context_line":"                    fixed_ips\u003dfixed_ips)"},{"line_number":191,"context_line":"                self._osutils.bring_interface_up(existing_interface, \u0027vip\u0027)"},{"line_number":192,"context_line":"                util.send_member_advertisements(fixed_ips)"},{"line_number":193,"context_line":"            # Otherwise, we are just plugging a run-of-the-mill network"},{"line_number":194,"context_line":"            else:"},{"line_number":195,"context_line":"                # Write an updated config"}],"source_content_type":"text/x-python","patch_set":3,"id":"e51d0b5e_dfdd4a1a","line":192,"range":{"start_line":192,"start_character":16,"end_line":192,"end_character":58},"updated":"2023-04-13 06:28:45.000000000","message":"You do the same thing at the end of the if and the else clause. Why not simply move it right after the if/else?","commit_id":"3716eba9fa0d5ee1398cfedd5fc78ecdec050c59"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"693382dcb2295b9f21bb538b3f7e80b9a9164de2","unresolved":true,"context_lines":[{"line_number":189,"context_line":"                    vrrp_info\u003dvrrp_info,"},{"line_number":190,"context_line":"                    fixed_ips\u003dfixed_ips)"},{"line_number":191,"context_line":"                self._osutils.bring_interface_up(existing_interface, \u0027vip\u0027)"},{"line_number":192,"context_line":"                util.send_member_advertisements(fixed_ips)"},{"line_number":193,"context_line":"            # Otherwise, we are just plugging a run-of-the-mill network"},{"line_number":194,"context_line":"            else:"},{"line_number":195,"context_line":"                # Write an updated config"}],"source_content_type":"text/x-python","patch_set":3,"id":"05a63494_0918fd84","line":192,"range":{"start_line":192,"start_character":16,"end_line":192,"end_character":58},"in_reply_to":"e51d0b5e_dfdd4a1a","updated":"2023-04-13 06:46:49.000000000","message":"yeah you\u0027re right","commit_id":"3716eba9fa0d5ee1398cfedd5fc78ecdec050c59"}],"octavia/amphorae/backends/agent/api_server/util.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"8a04d7be40dec52d00f4942607601b4481ea71be","unresolved":true,"context_lines":[{"line_number":414,"context_line":"                  \u0027This amphora may not be the MASTER. Ignoring.\u0027, str(e))"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"def send_member_advertisements(fixed_ips):"},{"line_number":418,"context_line":"    try:"},{"line_number":419,"context_line":"        for fixed_ip in fixed_ips:"},{"line_number":420,"context_line":"            ip_address \u003d fixed_ip[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"36bc659e_24334432","line":417,"range":{"start_line":417,"start_character":31,"end_line":417,"end_character":40},"updated":"2023-04-11 17:00:20.000000000","message":"`fixed_ips: tp.Iterable[tp.Dict[str, str]]` seems correct.\n(with `import typing as tp`)","commit_id":"23fdf27be9ce343f52c9749a1386c3bb47a311b4"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"25e4bce846719f11ff71df1c17e00bd9740a440c","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                  \u0027This amphora may not be the MASTER. Ignoring.\u0027, str(e))"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"def send_member_advertisements(fixed_ips):"},{"line_number":418,"context_line":"    try:"},{"line_number":419,"context_line":"        for fixed_ip in fixed_ips:"},{"line_number":420,"context_line":"            ip_address \u003d fixed_ip[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"accfaf7e_98037255","line":417,"range":{"start_line":417,"start_character":31,"end_line":417,"end_character":40},"in_reply_to":"36bc659e_24334432","updated":"2023-04-13 06:28:45.000000000","message":"Done","commit_id":"23fdf27be9ce343f52c9749a1386c3bb47a311b4"}]}