)]}'
{"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"29fba24e8f2475ac3852143537913c47af64b983","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        address \u003d ipaddress.ip_address(ip)"},{"line_number":148,"context_line":"        return \u0027IPv6\u0027 if address.version \u003d\u003d 6 else \u0027IPv4\u0027"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _get_ethertype_for_cidr(self, cidr):"},{"line_number":151,"context_line":"        net \u003d ipaddress.ip_network(cidr)"},{"line_number":152,"context_line":"        return \u0027IPv6\u0027 if net.version \u003d\u003d 6 else \u0027IPv4\u0027"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f7c42cf3_de3b1b14","line":150,"updated":"2023-10-12 18:21:17.000000000","message":"We should be using the common utils for this.\nhttps://github.com/openstack/octavia/blob/master/octavia/common/utils.py#L74","commit_id":"5783c6767f682af25b2e4e8da560af98a3109913"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"b977ba445c09658519c153d650aa59dbb60a6a68","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        address \u003d ipaddress.ip_address(ip)"},{"line_number":148,"context_line":"        return \u0027IPv6\u0027 if address.version \u003d\u003d 6 else \u0027IPv4\u0027"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _get_ethertype_for_cidr(self, cidr):"},{"line_number":151,"context_line":"        net \u003d ipaddress.ip_network(cidr)"},{"line_number":152,"context_line":"        return \u0027IPv6\u0027 if net.version \u003d\u003d 6 else \u0027IPv4\u0027"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"faf4a857_7ac60828","line":150,"in_reply_to":"6123fd72_da08513d","updated":"2024-01-25 10:33:11.000000000","message":"He probably meant https://github.com/openstack/octavia/blob/master/octavia/common/utils.py#L91\n\nIt\u0027s a minor issue and as you said, this should be changed on master first. Feel free to propose a new patch for this. I don\u0027t think it is a must though.","commit_id":"5783c6767f682af25b2e4e8da560af98a3109913"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"37adfc192469c116272131191e42bbefa53d104b","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        address \u003d ipaddress.ip_address(ip)"},{"line_number":148,"context_line":"        return \u0027IPv6\u0027 if address.version \u003d\u003d 6 else \u0027IPv4\u0027"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _get_ethertype_for_cidr(self, cidr):"},{"line_number":151,"context_line":"        net \u003d ipaddress.ip_network(cidr)"},{"line_number":152,"context_line":"        return \u0027IPv6\u0027 if net.version \u003d\u003d 6 else \u0027IPv4\u0027"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6123fd72_da08513d","line":150,"in_reply_to":"f7c42cf3_de3b1b14","updated":"2023-10-26 09:25:43.000000000","message":"I don\u0027t understand what should be changed. The function you link is for `ip_address` and not `ip_network` objects and won\u0027t work as is here.\n\nThis is also a backport of a change already merged in master and it\u0027s unchanged in current master. So I think if this needs to be changed, it should first be changed in master and the change should also fix _get_ethertype_for_ip.","commit_id":"5783c6767f682af25b2e4e8da560af98a3109913"}]}