)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3eb71f735950cb3720e53df1616619f59322a9e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8ad88d2d_f0264e30","updated":"2023-05-31 08:37:49.000000000","message":"Looks good to me","commit_id":"c7f3f890dfa67845c38c30e1774ea1cd4643e0f8"}],"octavia/tests/functional/api/drivers/driver_agent/test_driver_agent.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0412dab8152bd9909c5233b2b1574dac2277937e","unresolved":true,"context_lines":[{"line_number":16,"context_line":"import multiprocessing"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from octavia_lib.api.drivers import driver_lib as octavia_driver_lib"},{"line_number":21,"context_line":"from octavia_lib.common import constants as lib_consts"},{"line_number":22,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":7,"id":"f1a5f6dc_b5610712","line":19,"updated":"2023-05-30 13:59:00.000000000","message":"Is that extra whitespace necessary to make pytest work? I wonder if it won\u0027t break other tox checks\n\nAlso, can you add that the \u0027Base\u0027 prefix is important to make pytest work in the commit message? (if it is important, I don\u0027t know)","commit_id":"9d751fa9512709b866d49465918b0e1e6b6d4fb5"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"a249a89a31395e7d18c91114459c06d85616cd20","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import multiprocessing"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from octavia_lib.api.drivers import driver_lib as octavia_driver_lib"},{"line_number":21,"context_line":"from octavia_lib.common import constants as lib_consts"},{"line_number":22,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":7,"id":"88db1ff2_2fc25466","line":19,"in_reply_to":"f1a5f6dc_b5610712","updated":"2023-05-30 16:28:44.000000000","message":"Good points. Thanks.","commit_id":"9d751fa9512709b866d49465918b0e1e6b6d4fb5"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d94ac47456575669f2057e8d4b919900fc6f30c4","unresolved":true,"context_lines":[{"line_number":35,"context_line":"CONF \u003d cfg.CONF"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"@pytest.mark.xfail(reason\u003d\"FIXME: all tests fail in the CI\")"},{"line_number":39,"context_line":"class DriverAgentTest(base.OctaviaDBTestBase):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _process_cleanup(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"d8efdc57_c488c8b8","line":38,"updated":"2023-08-23 17:08:07.000000000","message":"is it a leftover that you forgot to remove?","commit_id":"8d4be55b9ce59f9e9264edef5a21268601372e01"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"b96ab34131ff359eaa6d1c006940de79c2555446","unresolved":false,"context_lines":[{"line_number":35,"context_line":"CONF \u003d cfg.CONF"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"@pytest.mark.xfail(reason\u003d\"FIXME: all tests fail in the CI\")"},{"line_number":39,"context_line":"class DriverAgentTest(base.OctaviaDBTestBase):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _process_cleanup(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"f115bbb8_b853ec10","line":38,"in_reply_to":"d8efdc57_c488c8b8","updated":"2023-08-24 07:52:33.000000000","message":"No, they still fail and I don\u0027t know why. As these should be standard Python unittest type tests both stestr and pytest should come to the same result. It will need further investigation to find out why they fail. Till the issue is understood this will mark these tests as expected to fail with pytest. This should not block the integration of this patch.","commit_id":"8d4be55b9ce59f9e9264edef5a21268601372e01"}]}
