)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"b341cd7308f168de48405393f9895abbe6b94c8e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8abc9139_0f74f632","updated":"2023-05-08 10:54:47.000000000","message":"Need a nova flavor with huge pages enabled: `--property hw:mem_page_size\u003dlarge`","commit_id":"c9cf24137650145874c7b01fe937c45c04b681ee"}],"elements/dpdk/environment.d/81-hugepages":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"b5e334c1772b78a9300dcc9c6b51ed0799f22d5c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright Red Hat"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bef9e3d8_86b04143","line":1,"updated":"2023-05-16 16:06:45.000000000","message":"TODO: Deployment tools must configure a Nova flavor so that underlying memory uses huge pages as described in https://docs.openstack.org/nova/latest/admin/huge-pages.html#customizing-instance-huge-pages-allocations","commit_id":"b9d3a79a2eadf57466dc00b7a82a34e5b225488b"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"b8c6ab60ebd938728153bb61545fdad7fd9bb307","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright Red Hat"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"d779b251_4f6cd702","line":1,"in_reply_to":"bef9e3d8_86b04143","updated":"2023-05-16 16:07:29.000000000","message":"That is irrelevant for Octavia itself.","commit_id":"b9d3a79a2eadf57466dc00b7a82a34e5b225488b"}],"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dbb22aa974fd701d5df72951f40101de88638aef","unresolved":true,"context_lines":[{"line_number":915,"context_line":"                # FIXME: use constants"},{"line_number":916,"context_line":"                # Create a DPDK vNIC that allows direct access to the physical"},{"line_number":917,"context_line":"                # NIC in order to improve performance"},{"line_number":918,"context_line":"                port[\u0027binding_vnic_type\u0027] \u003d constants.DIRECT"},{"line_number":919,"context_line":"                # This is read-only"},{"line_number":920,"context_line":"                # port[\u0027binding_vif_type\u0027] \u003d \u0027vhostuser\u0027"},{"line_number":921,"context_line":"                port[constants.BINDING_PROFILE] \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"bd7df316_7e8709b9","line":918,"updated":"2023-05-16 10:51:16.000000000","message":"direct is for an sriov vf not dpdk","commit_id":"b9d3a79a2eadf57466dc00b7a82a34e5b225488b"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"b5e334c1772b78a9300dcc9c6b51ed0799f22d5c","unresolved":false,"context_lines":[{"line_number":915,"context_line":"                # FIXME: use constants"},{"line_number":916,"context_line":"                # Create a DPDK vNIC that allows direct access to the physical"},{"line_number":917,"context_line":"                # NIC in order to improve performance"},{"line_number":918,"context_line":"                port[\u0027binding_vnic_type\u0027] \u003d constants.DIRECT"},{"line_number":919,"context_line":"                # This is read-only"},{"line_number":920,"context_line":"                # port[\u0027binding_vif_type\u0027] \u003d \u0027vhostuser\u0027"},{"line_number":921,"context_line":"                port[constants.BINDING_PROFILE] \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"1d93b2e6_c090a069","line":918,"in_reply_to":"bd7df316_7e8709b9","updated":"2023-05-16 16:06:45.000000000","message":"Ack","commit_id":"b9d3a79a2eadf57466dc00b7a82a34e5b225488b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dbb22aa974fd701d5df72951f40101de88638aef","unresolved":true,"context_lines":[{"line_number":924,"context_line":"                        # that offloads network functions, such as packet"},{"line_number":925,"context_line":"                        # processing and filtering, to the hardware"},{"line_number":926,"context_line":"                        # switch ASIC."},{"line_number":927,"context_line":"                        {constants.SWITCHDEV: True},"},{"line_number":928,"context_line":"                        # \u0027server\u0027 mode is used by the application that"},{"line_number":929,"context_line":"                        # receives the network traffic."},{"line_number":930,"context_line":"                        {constants.VHOST_USER_MODE: constants.SERVER},"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fc56afb_10a432d1","line":927,"updated":"2023-05-16 10:51:16.000000000","message":"switchdev true is for hardwar offloaded ovs and it is not something you shoudl be setting. we are trying to fix this this cycle but\n\nthe BINDING_PROFILE is not a user setabel field its for nova to pass information to neutron \nor ironic or zun. i.e. the hypervior passing infor to the network backend.\noctavia should not be setting info in it.","commit_id":"b9d3a79a2eadf57466dc00b7a82a34e5b225488b"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"b5e334c1772b78a9300dcc9c6b51ed0799f22d5c","unresolved":false,"context_lines":[{"line_number":924,"context_line":"                        # that offloads network functions, such as packet"},{"line_number":925,"context_line":"                        # processing and filtering, to the hardware"},{"line_number":926,"context_line":"                        # switch ASIC."},{"line_number":927,"context_line":"                        {constants.SWITCHDEV: True},"},{"line_number":928,"context_line":"                        # \u0027server\u0027 mode is used by the application that"},{"line_number":929,"context_line":"                        # receives the network traffic."},{"line_number":930,"context_line":"                        {constants.VHOST_USER_MODE: constants.SERVER},"}],"source_content_type":"text/x-python","patch_set":3,"id":"42d5bf89_ee9b282a","line":927,"in_reply_to":"9fc56afb_10a432d1","updated":"2023-05-16 16:06:45.000000000","message":"Ack","commit_id":"b9d3a79a2eadf57466dc00b7a82a34e5b225488b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dbb22aa974fd701d5df72951f40101de88638aef","unresolved":true,"context_lines":[{"line_number":927,"context_line":"                        {constants.SWITCHDEV: True},"},{"line_number":928,"context_line":"                        # \u0027server\u0027 mode is used by the application that"},{"line_number":929,"context_line":"                        # receives the network traffic."},{"line_number":930,"context_line":"                        {constants.VHOST_USER_MODE: constants.SERVER},"},{"line_number":931,"context_line":"                        # The vhost user socket is used to exchange network"},{"line_number":932,"context_line":"                        # packets between the DPDK application and the Linux"},{"line_number":933,"context_line":"                        # kernel."},{"line_number":934,"context_line":"                        # FIXME: socket path"},{"line_number":935,"context_line":"                        {constants.VHOST_USER_SOCKET: \u0027/tmp/vhu.sock\u0027},"},{"line_number":936,"context_line":"                    ],"},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":3,"id":"745f5058_a7d528b1","line":935,"range":{"start_line":930,"start_character":0,"end_line":935,"end_character":71},"updated":"2023-05-16 10:51:16.000000000","message":"you should not be settin this \n\nfirst this is set in the  port bidning detail  not the port binding profile\nsecond its set bey the ml2 driver to pass info to nova about how to generate the xml octavia cant know this info","commit_id":"b9d3a79a2eadf57466dc00b7a82a34e5b225488b"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"b5e334c1772b78a9300dcc9c6b51ed0799f22d5c","unresolved":false,"context_lines":[{"line_number":927,"context_line":"                        {constants.SWITCHDEV: True},"},{"line_number":928,"context_line":"                        # \u0027server\u0027 mode is used by the application that"},{"line_number":929,"context_line":"                        # receives the network traffic."},{"line_number":930,"context_line":"                        {constants.VHOST_USER_MODE: constants.SERVER},"},{"line_number":931,"context_line":"                        # The vhost user socket is used to exchange network"},{"line_number":932,"context_line":"                        # packets between the DPDK application and the Linux"},{"line_number":933,"context_line":"                        # kernel."},{"line_number":934,"context_line":"                        # FIXME: socket path"},{"line_number":935,"context_line":"                        {constants.VHOST_USER_SOCKET: \u0027/tmp/vhu.sock\u0027},"},{"line_number":936,"context_line":"                    ],"},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":3,"id":"4e784dd7_9a006e8e","line":935,"range":{"start_line":930,"start_character":0,"end_line":935,"end_character":71},"in_reply_to":"745f5058_a7d528b1","updated":"2023-05-16 16:06:45.000000000","message":"Thanks for the review.","commit_id":"b9d3a79a2eadf57466dc00b7a82a34e5b225488b"}]}