)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"b5d33eb51597f2be83fe0be8dc73bad54b095a96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c718f321_97ef86aa","updated":"2023-08-21 13:23:21.000000000","message":"patch works, but we can improve some details (use constants.)\none question too about the tests.","commit_id":"dfe9a16532c5026dc6f29873044f38a5e456eeb3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"12285af6f2f0d417520cc26f8dc92d7f6beea34d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8acb1e22_a3369876","updated":"2023-06-21 08:14:56.000000000","message":"recheck looks like check pipelines are working now","commit_id":"dfe9a16532c5026dc6f29873044f38a5e456eeb3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"36e07b3d8a17592500f8379eb9551bb2caa262bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b71f15a5_7e42f307","updated":"2023-06-21 11:20:23.000000000","message":"recheck openstack-tox-docs timout","commit_id":"dfe9a16532c5026dc6f29873044f38a5e456eeb3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"73fd160512e4708c2da0e5c8292a9e08b91eb02d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0e423384_c51dafb1","updated":"2023-12-19 12:59:47.000000000","message":"recheck u/s jobs were fixed","commit_id":"2fbff5c4303630d8127a9ff84fbf1f2cb77be478"}],"octavia/api/v2/controllers/load_balancer.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"b5d33eb51597f2be83fe0be8dc73bad54b095a96","unresolved":true,"context_lines":[{"line_number":671,"context_line":"                if constants.L7POLICIES in li:"},{"line_number":672,"context_line":"                    num_of_l7policies +\u003d len(li[constants.L7POLICIES])"},{"line_number":673,"context_line":"                    for l7p in li[constants.L7POLICIES]:"},{"line_number":674,"context_line":"                        if \u0027rules\u0027 in l7p:"},{"line_number":675,"context_line":"                            num_of_l7rules +\u003d len(l7p[\u0027rules\u0027])"},{"line_number":676,"context_line":"            if num_of_l7policies \u003e 0 and self.repositories.check_quota_met("},{"line_number":677,"context_line":"                    session, lock_session,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4aa31b8a_92457bb2","line":674,"range":{"start_line":674,"start_character":27,"end_line":674,"end_character":34},"updated":"2023-08-21 13:23:21.000000000","message":"it seems that constants.RULES exists I suggest to use it (even if it exists for a different purpose)","commit_id":"dfe9a16532c5026dc6f29873044f38a5e456eeb3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b318a40a796a6562f7995d84013916a555a88297","unresolved":false,"context_lines":[{"line_number":671,"context_line":"                if constants.L7POLICIES in li:"},{"line_number":672,"context_line":"                    num_of_l7policies +\u003d len(li[constants.L7POLICIES])"},{"line_number":673,"context_line":"                    for l7p in li[constants.L7POLICIES]:"},{"line_number":674,"context_line":"                        if \u0027rules\u0027 in l7p:"},{"line_number":675,"context_line":"                            num_of_l7rules +\u003d len(l7p[\u0027rules\u0027])"},{"line_number":676,"context_line":"            if num_of_l7policies \u003e 0 and self.repositories.check_quota_met("},{"line_number":677,"context_line":"                    session, lock_session,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1c2cf960_69bdc41a","line":674,"range":{"start_line":674,"start_character":27,"end_line":674,"end_character":34},"in_reply_to":"4aa31b8a_92457bb2","updated":"2023-08-23 15:30:05.000000000","message":"Done","commit_id":"dfe9a16532c5026dc6f29873044f38a5e456eeb3"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"b5d33eb51597f2be83fe0be8dc73bad54b095a96","unresolved":true,"context_lines":[{"line_number":672,"context_line":"                    num_of_l7policies +\u003d len(li[constants.L7POLICIES])"},{"line_number":673,"context_line":"                    for l7p in li[constants.L7POLICIES]:"},{"line_number":674,"context_line":"                        if \u0027rules\u0027 in l7p:"},{"line_number":675,"context_line":"                            num_of_l7rules +\u003d len(l7p[\u0027rules\u0027])"},{"line_number":676,"context_line":"            if num_of_l7policies \u003e 0 and self.repositories.check_quota_met("},{"line_number":677,"context_line":"                    session, lock_session,"},{"line_number":678,"context_line":"                    data_models.L7Policy, db_lb.project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"149d42e8_8c04e461","line":675,"range":{"start_line":675,"start_character":54,"end_line":675,"end_character":61},"updated":"2023-08-21 13:23:21.000000000","message":"same","commit_id":"dfe9a16532c5026dc6f29873044f38a5e456eeb3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b318a40a796a6562f7995d84013916a555a88297","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                    num_of_l7policies +\u003d len(li[constants.L7POLICIES])"},{"line_number":673,"context_line":"                    for l7p in li[constants.L7POLICIES]:"},{"line_number":674,"context_line":"                        if \u0027rules\u0027 in l7p:"},{"line_number":675,"context_line":"                            num_of_l7rules +\u003d len(l7p[\u0027rules\u0027])"},{"line_number":676,"context_line":"            if num_of_l7policies \u003e 0 and self.repositories.check_quota_met("},{"line_number":677,"context_line":"                    session, lock_session,"},{"line_number":678,"context_line":"                    data_models.L7Policy, db_lb.project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb1fe24b_3850c671","line":675,"range":{"start_line":675,"start_character":54,"end_line":675,"end_character":61},"in_reply_to":"149d42e8_8c04e461","updated":"2023-08-23 15:30:05.000000000","message":"Done","commit_id":"dfe9a16532c5026dc6f29873044f38a5e456eeb3"}],"octavia/tests/functional/api/v2/test_load_balancer.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"b5d33eb51597f2be83fe0be8dc73bad54b095a96","unresolved":true,"context_lines":[{"line_number":3699,"context_line":"                                       \u0027sni_certs\u0027: [cert2, cert3]}"},{"line_number":3700,"context_line":"        # This one should create, as we don\u0027t check quotas on L7Policies"},{"line_number":3701,"context_line":"        body, _ \u003d self._test_with_one_of_everything_helper()"},{"line_number":3702,"context_line":"        self.start_quota_mock(data_models.L7Policy)"},{"line_number":3703,"context_line":"        self.post(self.LBS_PATH, body)"},{"line_number":3704,"context_line":""},{"line_number":3705,"context_line":"    def _getStatus(self, lb_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f5a52b7e_e0811a52","side":"PARENT","line":3702,"range":{"start_line":3702,"start_character":13,"end_line":3702,"end_character":29},"updated":"2023-08-21 13:23:21.000000000","message":"hmm why do you remove this line?","commit_id":"e2bc07222f40ce5c6ba73a0e4bf79af9f5ebde11"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b318a40a796a6562f7995d84013916a555a88297","unresolved":true,"context_lines":[{"line_number":3699,"context_line":"                                       \u0027sni_certs\u0027: [cert2, cert3]}"},{"line_number":3700,"context_line":"        # This one should create, as we don\u0027t check quotas on L7Policies"},{"line_number":3701,"context_line":"        body, _ \u003d self._test_with_one_of_everything_helper()"},{"line_number":3702,"context_line":"        self.start_quota_mock(data_models.L7Policy)"},{"line_number":3703,"context_line":"        self.post(self.LBS_PATH, body)"},{"line_number":3704,"context_line":""},{"line_number":3705,"context_line":"    def _getStatus(self, lb_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"127d3544_5aef83f5","side":"PARENT","line":3702,"range":{"start_line":3702,"start_character":13,"end_line":3702,"end_character":29},"in_reply_to":"f5a52b7e_e0811a52","updated":"2023-08-23 15:30:05.000000000","message":"tbh I don\u0027t understand this test, it creates one of \"everything\", and then it mocks the L7Policy quota to make repositories.check_quota_met return true (only to L7Policy), and it seems like adding that check - as I did here\nhttps://review.opendev.org/c/openstack/octavia/+/886263/1/octavia/api/v2/controllers/load_balancer.py#676\nresults in a QuotaException.\n\nline #3703 creates the resources and expects a 201.","commit_id":"e2bc07222f40ce5c6ba73a0e4bf79af9f5ebde11"}]}