)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5948eefa0a6aa0fdef619eb9103fca6c523cba0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"32b8fc65_c3f15eed","updated":"2023-08-16 21:04:59.000000000","message":"LGTM","commit_id":"72f59a34fe85921e67c53011bd5894f07c97dca0"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"33d83d5a10ddce1213f4377c27d4902f08c4bd0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a76be0c7_99242726","updated":"2023-08-30 15:30:32.000000000","message":"The complaint in my comment should not block this fix. I agree that the function should be reworked in another patch.","commit_id":"72f59a34fe85921e67c53011bd5894f07c97dca0"}],"octavia/amphorae/backends/utils/keepalivedlvs_query.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"e82b397d1dd4c4c4cc4e6587780f59a9f363435f","unresolved":true,"context_lines":[{"line_number":460,"context_line":"        status \u003d constants.OPEN"},{"line_number":461,"context_line":"        # Get scur"},{"line_number":462,"context_line":"        for listener_ipport in listener_ipports:"},{"line_number":463,"context_line":"            if listener_ipport not in scur_res:"},{"line_number":464,"context_line":"                continue"},{"line_number":465,"context_line":"            for m in scur_res[listener_ipport][\u0027Members\u0027]:"},{"line_number":466,"context_line":"                for item in m:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3fd7b8_f6177192","line":463,"range":{"start_line":463,"start_character":12,"end_line":463,"end_character":46},"updated":"2023-08-29 14:03:03.000000000","message":"According to the comment about `scur_res` \"contains bout, bin, scur, stot, ereq, status\". No sign of a key related to an listener_ipport, whatever that is, because that is not obvious either.\n\nI\u0027m not saying it is wrong, but the lack of annotations and explanations make it difficult to understand what this is about and whether it is correct. Basically it requires the reviewer to read and understand what the code of this function, and get_ipvsadmin_info() does exactly, which in turn depends on that \"ipvsadm -Ln\" outputs, which is also not obvious.\n\nA better description of what get_ipvsadm_info() actually returns is needed, and also what listener_ipports is (presumably a List[str]?).","commit_id":"72f59a34fe85921e67c53011bd5894f07c97dca0"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ca947ac603b42f20b80fee437428f73cfcce49e3","unresolved":true,"context_lines":[{"line_number":460,"context_line":"        status \u003d constants.OPEN"},{"line_number":461,"context_line":"        # Get scur"},{"line_number":462,"context_line":"        for listener_ipport in listener_ipports:"},{"line_number":463,"context_line":"            if listener_ipport not in scur_res:"},{"line_number":464,"context_line":"                continue"},{"line_number":465,"context_line":"            for m in scur_res[listener_ipport][\u0027Members\u0027]:"},{"line_number":466,"context_line":"                for item in m:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d97fdc6d_ff54ee14","line":463,"range":{"start_line":463,"start_character":12,"end_line":463,"end_character":46},"in_reply_to":"ba3fd7b8_f6177192","updated":"2023-08-30 14:37:59.000000000","message":"this code is really bad, I think it needs to be rewritten with better practices and better clarity (I don\u0027t understand the meaning of these functions, each time I had to update it, I had to guess what was happening there).\n\nThen I think the report shows clearly that listener_ipport doesn\u0027t exist in scur_res (used line 465), it\u0027s pretty safe to avoid the exception by checking that the key exists","commit_id":"72f59a34fe85921e67c53011bd5894f07c97dca0"}]}