)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"48d9df14fa4229fd59c540a9ff10574e64378c6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9756fae_d9c5ab8b","updated":"2023-08-24 06:48:14.000000000","message":"LGTM, a few questions about this new network driver","commit_id":"e3eb42fb7da95830713f56632ee2b73ae64c1e96"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"75eb302fb7a5264860a44bdadcbeba646cb4cf7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"62ab8392_f1548aa5","updated":"2023-10-25 15:16:38.000000000","message":"Looks good to me. There is that typo Tom mentioned before","commit_id":"e3eb42fb7da95830713f56632ee2b73ae64c1e96"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"16e0f35d509d4c109a4c203fbfed788607566a3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"69e67769_2131b225","updated":"2023-11-17 10:01:57.000000000","message":"LGTM!","commit_id":"fbd7d9ffec99ff8335c01cd2fecd02f0208c2742"}],"specs/version13.0/SRIOV.rst":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"48d9df14fa4229fd59c540a9ff10574e64378c6a","unresolved":true,"context_lines":[{"line_number":48,"context_line":"The Amphora driver for the Octavia API will need to be updated to properly"},{"line_number":49,"context_line":"create SR-IOV ports for the VIP if one is not provided by the user."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new network driver will need to be created to accommodate that SR-IOV ports"},{"line_number":52,"context_line":"do not support neutron security groups. Unfortunately the current Allowed"},{"line_number":53,"context_line":"Address Pair (AAP) network driver overloads many methods with multiple"},{"line_number":54,"context_line":"configuration task including the manipulating the security groups."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7fbc9c42_2aecf804","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":38},"updated":"2023-08-24 06:48:14.000000000","message":"does it mean that people will have to choose between SR-IOV amphorae and \"regular\" amphorae? can they mix both types of amp in the same cloud?","commit_id":"e3eb42fb7da95830713f56632ee2b73ae64c1e96"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fca9de46cb98cf13d1bfcd1eb481d6422f012b01","unresolved":false,"context_lines":[{"line_number":48,"context_line":"The Amphora driver for the Octavia API will need to be updated to properly"},{"line_number":49,"context_line":"create SR-IOV ports for the VIP if one is not provided by the user."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new network driver will need to be created to accommodate that SR-IOV ports"},{"line_number":52,"context_line":"do not support neutron security groups. Unfortunately the current Allowed"},{"line_number":53,"context_line":"Address Pair (AAP) network driver overloads many methods with multiple"},{"line_number":54,"context_line":"configuration task including the manipulating the security groups."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e6935e1c_e12bd48c","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":38},"in_reply_to":"7fbc9c42_2aecf804","updated":"2023-08-28 21:35:09.000000000","message":"My intent is that it will all be handled by the Octavia controller based on the Octavia flavor and the port/network information.\nBoth can co-exist in the cloud, but the code paths will be different.","commit_id":"e3eb42fb7da95830713f56632ee2b73ae64c1e96"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"630d81d30df37aa8d9ad6f0fd00a2b53214ad215","unresolved":false,"context_lines":[{"line_number":48,"context_line":"The Amphora driver for the Octavia API will need to be updated to properly"},{"line_number":49,"context_line":"create SR-IOV ports for the VIP if one is not provided by the user."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new network driver will need to be created to accommodate that SR-IOV ports"},{"line_number":52,"context_line":"do not support neutron security groups. Unfortunately the current Allowed"},{"line_number":53,"context_line":"Address Pair (AAP) network driver overloads many methods with multiple"},{"line_number":54,"context_line":"configuration task including the manipulating the security groups."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f5e6fbc0_3d3d3d1f","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":38},"in_reply_to":"e6935e1c_e12bd48c","updated":"2023-08-29 06:32:05.000000000","message":"ack I see, does it mean that for instance octavia.common.utils.get_network_driver() will return different plugins based on an input parameter (which may be passed by the flavor)?","commit_id":"e3eb42fb7da95830713f56632ee2b73ae64c1e96"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bccdb1c8f8ba9c186506a15f42b68e96e88f3724","unresolved":false,"context_lines":[{"line_number":48,"context_line":"The Amphora driver for the Octavia API will need to be updated to properly"},{"line_number":49,"context_line":"create SR-IOV ports for the VIP if one is not provided by the user."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new network driver will need to be created to accommodate that SR-IOV ports"},{"line_number":52,"context_line":"do not support neutron security groups. Unfortunately the current Allowed"},{"line_number":53,"context_line":"Address Pair (AAP) network driver overloads many methods with multiple"},{"line_number":54,"context_line":"configuration task including the manipulating the security groups."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"2db491e2_fc260735","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":38},"in_reply_to":"f5e6fbc0_3d3d3d1f","updated":"2023-09-01 22:41:54.000000000","message":"Yes, this will need to change. I am not sure I need a new flavor parameter for this yet, I may be able to simply key off of the port information. That would be simpler than adding flavor paramaters.","commit_id":"e3eb42fb7da95830713f56632ee2b73ae64c1e96"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"48d9df14fa4229fd59c540a9ff10574e64378c6a","unresolved":true,"context_lines":[{"line_number":70,"context_line":"engines are already managing state for the flows, so there is no reason to also"},{"line_number":71,"context_line":"have state management in the firewall."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"I am proposing we only support nftables inside the Amphora as most"},{"line_number":74,"context_line":"distributions are moving away from iptables towards nftables."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"If placement/nova scheduling fail to find an appropriate host or the SR-IOV VF"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bd0365cd_1598ecbd","line":73,"range":{"start_line":73,"start_character":15,"end_line":73,"end_character":58},"updated":"2023-08-24 06:48:14.000000000","message":"+1","commit_id":"e3eb42fb7da95830713f56632ee2b73ae64c1e96"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0498e537a3b6707b577e4da197de8e8b98849e17","unresolved":true,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"There are no Octavia API changes anticipated by this proposal."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The Amphora API will need to be expanded to have a security group endpoint."},{"line_number":106,"context_line":"This endpoint will accept POST calls that contain the: allowed_cidrs, protocol,"},{"line_number":107,"context_line":"and port information required to configure the appropriate nftable rules."},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e4333cad_2bc709f3","line":105,"range":{"start_line":105,"start_character":32,"end_line":105,"end_character":74},"updated":"2023-10-24 10:12:00.000000000","message":"This new endpoint will be needed for new SR-IOV type amphorae only if I understand the spec correctly. If that is correct, I guess the amphora type will need to be checked in a verification step.","commit_id":"e3eb42fb7da95830713f56632ee2b73ae64c1e96"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d8865a4efd817d525412218416c4711338ac2f8","unresolved":true,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"There are no Octavia API changes anticipated by this proposal."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The Amphora API will need to be expanded to have a security group endpoint."},{"line_number":106,"context_line":"This endpoint will accept POST calls that contain the: allowed_cidrs, protocol,"},{"line_number":107,"context_line":"and port information required to configure the appropriate nftable rules."},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b973ee09_db789682","line":105,"range":{"start_line":105,"start_character":32,"end_line":105,"end_character":74},"in_reply_to":"e4333cad_2bc709f3","updated":"2023-11-03 21:16:58.000000000","message":"The amphora agent will need to be a current version to have the endpoint. I will capture the error if an old amphora image is used and simply move the load balancer to error. This is a pretty standard pattern for expanding the amphora agent API.","commit_id":"e3eb42fb7da95830713f56632ee2b73ae64c1e96"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0498e537a3b6707b577e4da197de8e8b98849e17","unresolved":true,"context_lines":[{"line_number":145,"context_line":"Other deployer impact"},{"line_number":146,"context_line":"---------------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"If deployers what SR-IOV interface support at deployment time, they will need"},{"line_number":149,"context_line":"to configure the required compute host aggregates, compute flavors, and"},{"line_number":150,"context_line":"octavia flavor supporting the SR-IOV enabled hosts and networks."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"318db47e_a957ffd7","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":17},"updated":"2023-10-24 10:12:00.000000000","message":"typo? want?","commit_id":"e3eb42fb7da95830713f56632ee2b73ae64c1e96"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"7befd55dd9ee55a8b9b5d118125673c4f599f6d8","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Other deployer impact"},{"line_number":146,"context_line":"---------------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"If deployers what SR-IOV interface support at deployment time, they will need"},{"line_number":149,"context_line":"to configure the required compute host aggregates, compute flavors, and"},{"line_number":150,"context_line":"octavia flavor supporting the SR-IOV enabled hosts and networks."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"684fc1e8_23c1def9","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":17},"in_reply_to":"318db47e_a957ffd7","updated":"2023-12-06 16:34:16.000000000","message":"Done","commit_id":"e3eb42fb7da95830713f56632ee2b73ae64c1e96"}]}