)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b6c6d4a7040f235318cb5089053fc25a756986bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2b7b74af_896562b0","updated":"2023-10-02 22:02:23.000000000","message":"I wonder if we shouldn\u0027t have a documentation section in the admin guide about this?","commit_id":"e5b122883c6970f4b3b8eb5b306506144befa56c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"04220e512eff1be13e6834576f85373d375fe015","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bdbf2bb0_b2147db5","in_reply_to":"2b7b74af_896562b0","updated":"2023-10-03 06:18:39.000000000","message":"ack I will work on that","commit_id":"e5b122883c6970f4b3b8eb5b306506144befa56c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"560c90e7d6b3f59521e2f3c5b25611ed6048cbd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ea1c3dcf_61ee3699","updated":"2023-10-03 13:53:04.000000000","message":"LGTM","commit_id":"be91493332786365b8e997fcf88779a12d1ae130"}],"octavia/controller/worker/task_utils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b6c6d4a7040f235318cb5089053fc25a756986bd","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            CONF.controller_worker.db_commit_retry_max),"},{"line_number":39,"context_line":"        stop\u003dtenacity.stop_after_attempt("},{"line_number":40,"context_line":"            CONF.controller_worker.db_commit_retry_attempts),"},{"line_number":41,"context_line":"        after\u003dtenacity.after_log(LOG, logging.DEBUG))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, **kwargs):"},{"line_number":44,"context_line":"        self.amphora_repo \u003d repo.AmphoraRepository()"}],"source_content_type":"text/x-python","patch_set":2,"id":"0efe1f08_f395e060","line":41,"updated":"2023-10-02 22:02:23.000000000","message":"I might argue that this is critical enough to warrant a WARNING or ERROR level log.","commit_id":"e5b122883c6970f4b3b8eb5b306506144befa56c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"04220e512eff1be13e6834576f85373d375fe015","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            CONF.controller_worker.db_commit_retry_max),"},{"line_number":39,"context_line":"        stop\u003dtenacity.stop_after_attempt("},{"line_number":40,"context_line":"            CONF.controller_worker.db_commit_retry_attempts),"},{"line_number":41,"context_line":"        after\u003dtenacity.after_log(LOG, logging.DEBUG))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, **kwargs):"},{"line_number":44,"context_line":"        self.amphora_repo \u003d repo.AmphoraRepository()"}],"source_content_type":"text/x-python","patch_set":2,"id":"b6fef85e_115d3ab7","line":41,"in_reply_to":"0efe1f08_f395e060","updated":"2023-10-03 06:18:39.000000000","message":"the after function is only for debugging purpose, errors are already loggeed by the task_utils functions.\n\nWhen a DB outage occurs, the logs are:\n\n```\nOct 03 02:13:35 gthiemon-devstack octavia-worker[2156002]: DEBUG octavia.common.base_taskflow [-] Task \u0027octavia.controller.worker.v2.tasks.lifecycle_tasks.LoadBalancerIDToErrorOnRevertTask\u0027 (daa48c61-d407-488e-999a-7cb4a0c4d269) transitioned into state \u0027REVERTING\u0027 from state \u0027SUCCESS\u0027 {{(pid\u003d2156002) _task_receiver /opt/stack/taskflow/taskflow/listeners/logging.py:190}}\nOct 03 02:13:35 gthiemon-devstack octavia-worker[2156002]: ERROR octavia.controller.worker.task_utils [-] Failed to update load balancer 630c42a7-0c5c-46e3-8a4d-d8e8350290bd provisioning status to ERROR due to: (pymysql.err.OperationalError) (2003, \"Can\u0027t connect to MySQL server on \u0027127.0.0.1\u0027 ([Errno 111] Connection refused)\")\nOct 03 02:13:35 gthiemon-devstack octavia-worker[2156002]: (Background on this error at: https://sqlalche.me/e/14/e3q8): oslo_db.exception.DBConnectionError: (pymysql.err.OperationalError) (2003, \"Can\u0027t connect to MySQL server on \u0027127.0.0.1\u0027 ([Errno 111] Connection refused)\")\nOct 03 02:13:35 gthiemon-devstack octavia-worker[2156002]: DEBUG octavia.controller.worker.task_utils [-] Finished call to \u0027octavia.controller.worker.task_utils.TaskUtils.mark_loadbalancer_prov_status_error\u0027 after 0.002(s), this was the 1st time calling it. {{(pid\u003d2156002) log_it /usr/local/lib/python3.9/site-packages/tenacity/after.py:30}}\nOct 03 02:13:36 gthiemon-devstack octavia-worker[2156002]: ERROR octavia.controller.worker.task_utils [-] Failed to update load balancer 630c42a7-0c5c-46e3-8a4d-d8e8350290bd provisioning status to ERROR due to: (pymysql.err.OperationalError) (2003, \"Can\u0027t connect to MySQL server on \u0027127.0.0.1\u0027 ([Errno 111] Connection refused)\")\nOct 03 02:13:36 gthiemon-devstack octavia-worker[2156002]: (Background on this error at: https://sqlalche.me/e/14/e3q8): oslo_db.exception.DBConnectionError: (pymysql.err.OperationalError) (2003, \"Can\u0027t connect to MySQL server on \u0027127.0.0.1\u0027 ([Errno 111] Connection refused)\")\nOct 03 02:13:36 gthiemon-devstack octavia-worker[2156002]: DEBUG octavia.controller.worker.task_utils [-] Finished call to \u0027octavia.controller.worker.task_utils.TaskUtils.mark_loadbalancer_prov_status_error\u0027 after 1.005(s), this was the 2nd time calling it. {{(pid\u003d2156002) log_it /usr/local/lib/python3.9/site-packages/tenacity/after.py:30}}\nOct 03 02:13:38 gthiemon-devstack octavia-worker[2156002]: ERROR octavia.controller.worker.task_utils [-] Failed to update load balancer 630c42a7-0c5c-46e3-8a4d-d8e8350290bd provisioning status to ERROR due to: (pymysql.err.OperationalError) (2003, \"Can\u0027t connect to MySQL server on \u0027127.0.0.1\u0027 ([Errno 111] Connection refused)\")\nOct 03 02:13:38 gthiemon-devstack octavia-worker[2156002]: (Background on this error at: https://sqlalche.me/e/14/e3q8): oslo_db.exception.DBConnectionError: (pymysql.err.OperationalError) (2003, \"Can\u0027t connect to MySQL server on \u0027127.0.0.1\u0027 ([Errno 111] Connection refused)\")\nOct 03 02:13:38 gthiemon-devstack octavia-worker[2156002]: DEBUG octavia.controller.worker.task_utils [-] Finished call to \u0027octavia.controller.worker.task_utils.TaskUtils.mark_loadbalancer_prov_status_error\u0027 after 3.008(s), this was the 3rd time calling it. {{(pid\u003d2156002) log_it /usr/local/lib/python3.9/site-packages/tenacity/after.py:30}}\nOct 03 02:13:41 gthiemon-devstack octavia-worker[2156002]: ERROR octavia.controller.worker.task_utils [-] Failed to update load balancer 630c42a7-0c5c-46e3-8a4d-d8e8350290bd provisioning status to ERROR due to: (pymysql.err.OperationalError) (2003, \"Can\u0027t connect to MySQL server on \u0027127.0.0.1\u0027 ([Errno 111] Connection refused)\")\nOct 03 02:13:41 gthiemon-devstack octavia-worker[2156002]: (Background on this error at: https://sqlalche.me/e/14/e3q8): oslo_db.exception.DBConnectionError: (pymysql.err.OperationalError) (2003, \"Can\u0027t connect to MySQL server on \u0027127.0.0.1\u0027 ([Errno 111] Connection refused)\")\nOct 03 02:13:41 gthiemon-devstack octavia-worker[2156002]: DEBUG octavia.controller.worker.task_utils [-] Finished call to \u0027octavia.controller.worker.task_utils.TaskUtils.mark_loadbalancer_prov_status_error\u0027 after 6.014(s), this was the 4th time calling it. {{(pid\u003d2156002) log_it /usr/local/lib/python3.9/site-packages/tenacity/after.py:30}}\n```\n\nDo you think the DEBUG line should be a WARNING?","commit_id":"e5b122883c6970f4b3b8eb5b306506144befa56c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"560c90e7d6b3f59521e2f3c5b25611ed6048cbd0","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            CONF.controller_worker.db_commit_retry_max),"},{"line_number":39,"context_line":"        stop\u003dtenacity.stop_after_attempt("},{"line_number":40,"context_line":"            CONF.controller_worker.db_commit_retry_attempts),"},{"line_number":41,"context_line":"        after\u003dtenacity.after_log(LOG, logging.DEBUG))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, **kwargs):"},{"line_number":44,"context_line":"        self.amphora_repo \u003d repo.AmphoraRepository()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dcb3a96c_3d93cb24","line":41,"in_reply_to":"b6fef85e_115d3ab7","updated":"2023-10-03 13:53:04.000000000","message":"With those other ERROR messages I think we are ok. I just wanted to make sure there was a WARNING or ERROR level message that the DB was down.","commit_id":"e5b122883c6970f4b3b8eb5b306506144befa56c"}]}