)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f8286e2eaf6ab0aa9fb359e3d0c8f9f2409090e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1f76d699_4ad7b205","updated":"2023-10-12 11:41:14.000000000","message":"almost looks good\nthanks for adding the release note and the tests!\nI only have a small concern with an assert.","commit_id":"84ee34a0e0f65c4cbc7be5b24c23890088dcc7e1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"93f5c270b32f00432d07ceb5abf20ff245bd304f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9e52d632_acd7c9c2","updated":"2023-10-13 09:52:17.000000000","message":"LGTM Thanks for your contribution","commit_id":"7261730dffce4bd7cac4f3f0bfe1f97a43599e0b"}],"octavia/tests/unit/api/v2/types/test_pool.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f8286e2eaf6ab0aa9fb359e3d0c8f9f2409090e4","unresolved":true,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_pool_full_response_without_children(self):"},{"line_number":296,"context_line":"        pool \u003d self._type.from_data_model(data_model\u003ddata_models.Pool())"},{"line_number":297,"context_line":"        self.assertTrue(hasattr(pool, \u0027loadbalancers\u0027))"},{"line_number":298,"context_line":"        self.assertIsNone(pool.healthmonitor)"}],"source_content_type":"text/x-python","patch_set":4,"id":"761cde7a_0cdc9fe6","line":297,"range":{"start_line":297,"start_character":8,"end_line":297,"end_character":55},"updated":"2023-10-12 11:41:14.000000000","message":"I\u0027m not sure if this assert is relevant.\npool\u0027s type is PoolFullResponse, it always has a loadbalancers attribute","commit_id":"84ee34a0e0f65c4cbc7be5b24c23890088dcc7e1"},{"author":{"_account_id":36379,"name":"Nguyễn Ngọc Hiếu","display_name":"ZiTechDev","email":"hieunn23@fpt.com","username":"zitechdev201"},"change_message_id":"2561bf4808f7240b5884f591abcb50359ae20998","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_pool_full_response_without_children(self):"},{"line_number":296,"context_line":"        pool \u003d self._type.from_data_model(data_model\u003ddata_models.Pool())"},{"line_number":297,"context_line":"        self.assertTrue(hasattr(pool, \u0027loadbalancers\u0027))"},{"line_number":298,"context_line":"        self.assertIsNone(pool.healthmonitor)"}],"source_content_type":"text/x-python","patch_set":4,"id":"621012dc_fd30fbc6","line":297,"range":{"start_line":297,"start_character":8,"end_line":297,"end_character":55},"in_reply_to":"5295114b_70b47ead","updated":"2023-10-13 10:08:01.000000000","message":"Tks for reviewing","commit_id":"84ee34a0e0f65c4cbc7be5b24c23890088dcc7e1"},{"author":{"_account_id":36379,"name":"Nguyễn Ngọc Hiếu","display_name":"ZiTechDev","email":"hieunn23@fpt.com","username":"zitechdev201"},"change_message_id":"63ecefd81415bc47233f2bacaf78b8ea620f6a99","unresolved":true,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_pool_full_response_without_children(self):"},{"line_number":296,"context_line":"        pool \u003d self._type.from_data_model(data_model\u003ddata_models.Pool())"},{"line_number":297,"context_line":"        self.assertTrue(hasattr(pool, \u0027loadbalancers\u0027))"},{"line_number":298,"context_line":"        self.assertIsNone(pool.healthmonitor)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dcbe4fee_d1dc10cb","line":297,"range":{"start_line":297,"start_character":8,"end_line":297,"end_character":55},"in_reply_to":"761cde7a_0cdc9fe6","updated":"2023-10-12 13:48:00.000000000","message":"You are correct, the \"loadbalancers\" attribute always exists in the \"pool\" object, so this assert is redundant. \n\nHowever, from the observation, I see that the line `del pool.loadbalancers` (line 107 in /octavia/api/v2/types/pool.py) doesn\u0027t seem to be working as expected. I\u0027m not sure about the author\u0027s intention, so should I delete it?","commit_id":"84ee34a0e0f65c4cbc7be5b24c23890088dcc7e1"},{"author":{"_account_id":36379,"name":"Nguyễn Ngọc Hiếu","display_name":"ZiTechDev","email":"hieunn23@fpt.com","username":"zitechdev201"},"change_message_id":"e775c7216d05ea47409d72d60cf62d3136932482","unresolved":true,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_pool_full_response_without_children(self):"},{"line_number":296,"context_line":"        pool \u003d self._type.from_data_model(data_model\u003ddata_models.Pool())"},{"line_number":297,"context_line":"        self.assertTrue(hasattr(pool, \u0027loadbalancers\u0027))"},{"line_number":298,"context_line":"        self.assertIsNone(pool.healthmonitor)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5295114b_70b47ead","line":297,"range":{"start_line":297,"start_character":8,"end_line":297,"end_character":55},"in_reply_to":"dcbe4fee_d1dc10cb","updated":"2023-10-13 09:44:12.000000000","message":"Done","commit_id":"84ee34a0e0f65c4cbc7be5b24c23890088dcc7e1"}]}