)]}'
{"octavia/api/v2/controllers/listener.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"b755944fc6a930934396504e4a916d193a90c800","unresolved":true,"context_lines":[{"line_number":266,"context_line":"        tls_refs \u003d [sni[\u0027tls_container_id\u0027] for sni in sni_containers]"},{"line_number":267,"context_line":"        if listener_dict.get(\u0027tls_certificate_id\u0027):"},{"line_number":268,"context_line":"            tls_refs.append(listener_dict.get(\u0027tls_certificate_id\u0027))"},{"line_number":269,"context_line":"        if listener_dict.get(\u0027default_tls_container_ref\u0027):"},{"line_number":270,"context_line":"            tls_refs.append(listener_dict.get(\u0027default_tls_container_ref\u0027))"},{"line_number":271,"context_line":"        self._validate_tls_refs(tls_refs)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1e9154e9_372b4686","line":269,"updated":"2023-12-19 14:28:45.000000000","message":"\u0027default_tls_container_ref\u0027 is not correct, the correct attribute is tls_certificate_id","commit_id":"564f78300dfb84e8867f689ed113249acaf2fe1c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"b755944fc6a930934396504e4a916d193a90c800","unresolved":true,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        sni_containers \u003d listener.sni_container_refs or []"},{"line_number":512,"context_line":"        tls_refs \u003d list(sni_containers)"},{"line_number":513,"context_line":"        if listener.tls_certificate_id:"},{"line_number":514,"context_line":"            tls_refs.append(listener.tls_certificate_id)"},{"line_number":515,"context_line":"        if listener.default_tls_container_ref:"},{"line_number":516,"context_line":"            tls_refs.append(listener.default_tls_container_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8cbc9c4a_082016b1","line":513,"updated":"2023-12-19 14:28:45.000000000","message":"the correct attribute is default_tls_container_ref here\n\n(when the object is converted to a dict, listener.default_tls_container_ref is translated to listener_dict[\u0027tls_certificate_id\u0027])\n\nI checked both API calls, the TLS refs are validated by _validate_tls_refs\n\nthe current code looks ok to me.\n\nCould barbican have had a failure and returned broken data?","commit_id":"564f78300dfb84e8867f689ed113249acaf2fe1c"}]}