)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"274fd950b0f576da5c6b23b60da83bf86897685e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5fa0485a_1e07b0fb","updated":"2024-02-23 01:15:35.000000000","message":"Some nits, but looks good in general","commit_id":"7a32ced80386eeb8981154781d3bcf94b06176ed"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0024293ce057a364bccdfd88466234b6054e43b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2432c891_c3a0a592","updated":"2024-04-15 07:45:58.000000000","message":"Approving because the change was mostly tool-generated, and I manually reviewed it.","commit_id":"3d3360953ba31b6bcafe79f3f2f88ad722fdc121"}],"octavia/certificates/generator/local.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"274fd950b0f576da5c6b23b60da83bf86897685e","unresolved":true,"context_lines":[{"line_number":59,"context_line":"                    fp.read()"},{"line_number":60,"context_line":"            except OSError as e:"},{"line_number":61,"context_line":"                raise exceptions.CertificateGenerationException("},{"line_number":62,"context_line":"                    msg\u003d\"Failed to load CA Private Key {}.\""},{"line_number":63,"context_line":"                        .format(CONF.certificates.ca_private_key)"},{"line_number":64,"context_line":"                ) from e"},{"line_number":65,"context_line":"        if not ca_key_pass:"}],"source_content_type":"text/x-python","patch_set":1,"id":"242b120f_e4aed3c0","line":62,"updated":"2024-02-23 01:15:35.000000000","message":"nit: This could be an f-string too","commit_id":"7a32ced80386eeb8981154781d3bcf94b06176ed"}],"octavia/common/base_taskflow.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"274fd950b0f576da5c6b23b60da83bf86897685e","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        # filter out private information from details"},{"line_number":76,"context_line":"        cls_name \u003d type(self).__name__"},{"line_number":77,"context_line":"        details \u003d _details_filter(self.details)"},{"line_number":78,"context_line":"        return \"{}: {} (priority\u003d{}, uuid\u003d{}, details\u003d{})\".format("},{"line_number":79,"context_line":"            cls_name, self.name, self.priority,"},{"line_number":80,"context_line":"            self.uuid, details)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6a25391a_c89ac7c3","line":78,"updated":"2024-02-23 01:15:35.000000000","message":"nit: This could be an f-string too","commit_id":"7a32ced80386eeb8981154781d3bcf94b06176ed"}],"octavia/common/constants.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"274fd950b0f576da5c6b23b60da83bf86897685e","unresolved":true,"context_lines":[{"line_number":772,"context_line":"RBAC_FLAVOR \u003d f\u0027{LOADBALANCER_API}:flavor:\u0027"},{"line_number":773,"context_line":"RBAC_FLAVOR_PROFILE \u003d f\u0027{LOADBALANCER_API}:flavor-profile:\u0027"},{"line_number":774,"context_line":"RBAC_AVAILABILITY_ZONE \u003d f\u0027{LOADBALANCER_API}:availability-zone:\u0027"},{"line_number":775,"context_line":"RBAC_AVAILABILITY_ZONE_PROFILE \u003d \u0027{}:availability-zone-profile:\u0027.format("},{"line_number":776,"context_line":"    LOADBALANCER_API)"},{"line_number":777,"context_line":""},{"line_number":778,"context_line":"RBAC_POST \u003d \u0027post\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"958461b8_18137f14","line":775,"updated":"2024-02-23 01:15:35.000000000","message":"nit: This could be an f-string too","commit_id":"7a32ced80386eeb8981154781d3bcf94b06176ed"}],"octavia/common/data_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"274fd950b0f576da5c6b23b60da83bf86897685e","unresolved":true,"context_lines":[{"line_number":228,"context_line":"            self.total_connections +\u003d other.total_connections"},{"line_number":229,"context_line":"        else:"},{"line_number":230,"context_line":"            raise TypeError(  # noqa: O342"},{"line_number":231,"context_line":"                \"unsupported operand type(s) for +\u003d: \u0027{}\u0027 and \u0027{}\u0027\".format("},{"line_number":232,"context_line":"                    type(self), type(other)))"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":1,"id":"b73bb152_bc01ea82","line":231,"updated":"2024-02-23 01:15:35.000000000","message":"nit: This could be an f-string too","commit_id":"7a32ced80386eeb8981154781d3bcf94b06176ed"}],"octavia/common/jinja/haproxy/combined_listeners/jinja_cfg.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"274fd950b0f576da5c6b23b60da83bf86897685e","unresolved":true,"context_lines":[{"line_number":175,"context_line":"            tls_certs,"},{"line_number":176,"context_line":"            feature_compatibility)"},{"line_number":177,"context_line":"        if not socket_path:"},{"line_number":178,"context_line":"            socket_path \u003d \u0027{}/{}.sock\u0027.format(self.base_amp_path,"},{"line_number":179,"context_line":"                                              listeners[0].load_balancer.id)"},{"line_number":180,"context_line":"        state_file_path \u003d \u0027{}/{}/servers-state\u0027.format("},{"line_number":181,"context_line":"            self.base_amp_path,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fc5732c_e74f4d02","line":178,"updated":"2024-02-23 01:15:35.000000000","message":"nit: This could be an f-string too","commit_id":"7a32ced80386eeb8981154781d3bcf94b06176ed"}],"octavia/common/validate.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"274fd950b0f576da5c6b23b60da83bf86897685e","unresolved":true,"context_lines":[{"line_number":198,"context_line":"        # key and value are not allowed"},{"line_number":199,"context_line":"        if req_key:"},{"line_number":200,"context_line":"            # log error or raise"},{"line_number":201,"context_line":"            msg \u003d \u0027L7rule type {} does not use the \"key\" field.\u0027.format("},{"line_number":202,"context_line":"                rule_type)"},{"line_number":203,"context_line":"        elif req_value.lower() !\u003d \u0027true\u0027:"},{"line_number":204,"context_line":"            msg \u003d \u0027L7rule value {} is not a boolean True string.\u0027.format("}],"source_content_type":"text/x-python","patch_set":1,"id":"8f0c7726_ec31ddb5","line":201,"updated":"2024-02-23 01:15:35.000000000","message":"nit: These could be f-strings","commit_id":"7a32ced80386eeb8981154781d3bcf94b06176ed"}]}