)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e4898b02fbcdc512ddcd7bb9f616340fcabb6279","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d734ff7_844c727f","updated":"2024-03-05 22:59:10.000000000","message":"This patch needs to be updated to also handle SR-IOV VIP ports.\nhttps://github.com/openstack/octavia/blob/master/octavia/amphorae/backends/utils/nftable_utils.py#L40","commit_id":"08cda2c59ace7d5a231feef4a6216662872dd5ab"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"2633166c14e9a3777f6c561c1029f4e212b1e476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d21d4367_1a2a9fad","updated":"2024-03-05 08:30:20.000000000","message":"recheck","commit_id":"08cda2c59ace7d5a231feef4a6216662872dd5ab"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0e95194f0a7ed1e55056e606ecd3116dd6fea115","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f386da33_971caf01","updated":"2024-06-06 14:22:58.000000000","message":"I\u0027m ok with this feature, the code is fine, LGTM\nI have some concerns with the documentation.\n\nFor instance, in Active-Standby, the VIP is down until a listener is created, it means that an A/S LB without listener cannot be pinged - I think we need to write it (maybe a section in the release note is enough?) because people will report that the feature doesn\u0027t work.","commit_id":"f174e3e19b9828442897609954afa403bf8a6a10"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"f61391230e88bd7a148afb654594ea5af17a0115","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bd7b0c8a_aa1dcdd7","in_reply_to":"f386da33_971caf01","updated":"2024-06-09 20:32:10.000000000","message":"I added some more documentation for the option. I\u0027m open to improvements if you think something is missing or unclear.","commit_id":"f174e3e19b9828442897609954afa403bf8a6a10"}],"octavia/common/config.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0e95194f0a7ed1e55056e606ecd3116dd6fea115","unresolved":true,"context_lines":[{"line_number":272,"context_line":"    cfg.BoolOpt(\u0027allow_vip_ping\u0027, default\u003dFalse,"},{"line_number":273,"context_line":"                help\u003d_(\u0027Answer ICMP echo messages on VIP ports. If this is \u0027"},{"line_number":274,"context_line":"                       \u0027set, all ICMP echo requests will be answered \u0027"},{"line_number":275,"context_line":"                       \u0027regardless of allowed_cidrs set on listeners.\u0027)),"},{"line_number":276,"context_line":"]"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"health_manager_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"c3541a16_4a921503","line":275,"range":{"start_line":275,"start_character":24,"end_line":275,"end_character":68},"updated":"2024-06-06 14:22:58.000000000","message":"this point is important, it could be a security concern for users.","commit_id":"f174e3e19b9828442897609954afa403bf8a6a10"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"f61391230e88bd7a148afb654594ea5af17a0115","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    cfg.BoolOpt(\u0027allow_vip_ping\u0027, default\u003dFalse,"},{"line_number":273,"context_line":"                help\u003d_(\u0027Answer ICMP echo messages on VIP ports. If this is \u0027"},{"line_number":274,"context_line":"                       \u0027set, all ICMP echo requests will be answered \u0027"},{"line_number":275,"context_line":"                       \u0027regardless of allowed_cidrs set on listeners.\u0027)),"},{"line_number":276,"context_line":"]"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"health_manager_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7b1ff6_0efd6222","line":275,"range":{"start_line":275,"start_character":24,"end_line":275,"end_character":68},"in_reply_to":"c3541a16_4a921503","updated":"2024-06-09 20:32:10.000000000","message":"Acknowledged","commit_id":"f174e3e19b9828442897609954afa403bf8a6a10"}],"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0e95194f0a7ed1e55056e606ecd3116dd6fea115","unresolved":true,"context_lines":[{"line_number":264,"context_line":"        if CONF.networking.allow_vip_ping:"},{"line_number":265,"context_line":"            for ethertype in ethertypes:"},{"line_number":266,"context_line":"                try:"},{"line_number":267,"context_line":"                    self._create_security_group_rule("},{"line_number":268,"context_line":"                        sec_grp_id,"},{"line_number":269,"context_line":"                        (ethertype \u003d\u003d \u0027IPv4\u0027 and"},{"line_number":270,"context_line":"                         constants.IPV4_ICMP or constants.IPV6_ICMP),"}],"source_content_type":"text/x-python","patch_set":2,"id":"e6e56534_87d7ba39","line":267,"range":{"start_line":267,"start_character":25,"end_line":267,"end_character":52},"updated":"2024-06-06 14:22:58.000000000","message":"another important point: with this rule, the VRRP IP also responds to the pings.","commit_id":"f174e3e19b9828442897609954afa403bf8a6a10"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"f61391230e88bd7a148afb654594ea5af17a0115","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        if CONF.networking.allow_vip_ping:"},{"line_number":265,"context_line":"            for ethertype in ethertypes:"},{"line_number":266,"context_line":"                try:"},{"line_number":267,"context_line":"                    self._create_security_group_rule("},{"line_number":268,"context_line":"                        sec_grp_id,"},{"line_number":269,"context_line":"                        (ethertype \u003d\u003d \u0027IPv4\u0027 and"},{"line_number":270,"context_line":"                         constants.IPV4_ICMP or constants.IPV6_ICMP),"}],"source_content_type":"text/x-python","patch_set":2,"id":"aec1246d_7b4add6e","line":267,"range":{"start_line":267,"start_character":25,"end_line":267,"end_character":52},"in_reply_to":"e6e56534_87d7ba39","updated":"2024-06-09 20:32:10.000000000","message":"As far as I know this can\u0027t be avoided using security groups as it\u0027s not possible to restrict the destination IP. I added a note about this to the documentation.","commit_id":"f174e3e19b9828442897609954afa403bf8a6a10"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"7f5c8292699452fb86597c851a3d5ea2590a704f","unresolved":true,"context_lines":[{"line_number":266,"context_line":"                try:"},{"line_number":267,"context_line":"                    self._create_security_group_rule("},{"line_number":268,"context_line":"                        sec_grp_id,"},{"line_number":269,"context_line":"                        (ethertype \u003d\u003d \u0027IPv4\u0027 and"},{"line_number":270,"context_line":"                         constants.IPV4_ICMP or constants.IPV6_ICMP),"},{"line_number":271,"context_line":"                        direction\u003d\u0027ingress\u0027,"},{"line_number":272,"context_line":"                        ethertype\u003dethertype,"},{"line_number":273,"context_line":"                        # For ICMP this is the ICMP type. See Neutron API docs."}],"source_content_type":"text/x-python","patch_set":3,"id":"c2e3e099_792a9278","line":270,"range":{"start_line":269,"start_character":25,"end_line":270,"end_character":67},"updated":"2024-07-17 15:12:43.000000000","message":"`constants.IPV4_ICMP if ethertype \u003d\u003d \u0027IPv4\u0027 else constants.IPV6_ICMP` should do the same and is a lot clearer. Same in line 275 below.","commit_id":"ba44281354e11c269ae23b658117ab4440cabde9"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"d0cb02e23a7b4809535d10ab0368ecb02a1fd11b","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                try:"},{"line_number":267,"context_line":"                    self._create_security_group_rule("},{"line_number":268,"context_line":"                        sec_grp_id,"},{"line_number":269,"context_line":"                        (ethertype \u003d\u003d \u0027IPv4\u0027 and"},{"line_number":270,"context_line":"                         constants.IPV4_ICMP or constants.IPV6_ICMP),"},{"line_number":271,"context_line":"                        direction\u003d\u0027ingress\u0027,"},{"line_number":272,"context_line":"                        ethertype\u003dethertype,"},{"line_number":273,"context_line":"                        # For ICMP this is the ICMP type. See Neutron API docs."}],"source_content_type":"text/x-python","patch_set":3,"id":"0cc403be_cc40f5a0","line":270,"range":{"start_line":269,"start_character":25,"end_line":270,"end_character":67},"in_reply_to":"c2e3e099_792a9278","updated":"2024-07-18 21:53:06.000000000","message":"Done","commit_id":"ba44281354e11c269ae23b658117ab4440cabde9"}],"releasenotes/notes/add-allow-vip-ping-option-7c3d9386f07fc357.yaml":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0e95194f0a7ed1e55056e606ecd3116dd6fea115","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Amphora based load balancers can now be configured to respond to"},{"line_number":5,"context_line":"    ICMP echo requests (ping) packets. This feature is off by default"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0236cb2b_f7246461","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2024-06-06 14:22:58.000000000","message":"Can you add an \"upgrade\" section for this feature (something like \"You must update the amphora image to support the allow_vip_ping feature with SR-IOV load balancers)?","commit_id":"f174e3e19b9828442897609954afa403bf8a6a10"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"f61391230e88bd7a148afb654594ea5af17a0115","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Amphora based load balancers can now be configured to respond to"},{"line_number":5,"context_line":"    ICMP echo requests (ping) packets. This feature is off by default"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e9412a3f_83883815","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"0236cb2b_f7246461","updated":"2024-06-09 20:32:10.000000000","message":"Done","commit_id":"f174e3e19b9828442897609954afa403bf8a6a10"}]}