)]}'
{"id":"openstack%2Foctavia~915536","triplet_id":"openstack%2Foctavia~stable%2Fzed~I9bb45a1aca6b7b18644752a3dccc3ebfb7c106ef","project":"openstack/octavia","branch":"stable/zed","attention_set":{},"removed_from_attention_set":{"6577":{"account":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"last_update":"2024-04-15 12:00:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9bb45a1aca6b7b18644752a3dccc3ebfb7c106ef","subject":"Fix negative or 0 limit parameter in pagination","status":"MERGED","created":"2024-04-13 12:53:58.000000000","updated":"2024-04-15 12:02:03.000000000","submitted":"2024-04-15 12:00:47.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"915536","cherry_pick_of_change":910464,"cherry_pick_of_patch_set":5,"meta_rev_id":"4664f2748b504591dad99c951a0c3a83a3644bb4","_number":915536,"virtual_id_number":915536,"owner":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-04-15 12:00:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"all":[{"value":2,"date":"2024-04-15 08:58:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-04-15 09:46:42.000000000","_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"all":[{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-04-15 09:46:42.000000000","_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-13 16:01:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-04-15 08:58:00.000000000","updated_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"reviewer":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"state":"REVIEWER"},{"updated":"2024-04-15 09:46:42.000000000","updated_by":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"reviewer":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"state":"REVIEWER"}],"messages":[{"id":"82bf9067a3568fa3fd63ad51379616ad3124d8fe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"date":"2024-04-13 12:53:58.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"0ead181a8f215ecd716e8e3db0333c708979ab95","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-13 16:01:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e46b31a37eeb40aba0c45457067e879e\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/27dde2f6cb0848f1b9ced0ed699fc74d : SUCCESS in 8m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f604f0a985bb499098d4cdbbe286e5f5 : SUCCESS in 4m 41s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bee6f3032eb4460dad089ac6fcad0f3c : SUCCESS in 4m 01s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ecaab986f82a4ee984513002f0bbac62 : SUCCESS in 3m 58s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/e1bf0f0eb6444968968baad95180c236 : SUCCESS in 4m 02s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/63a65e93e7aa420f8273c898d61dc979 : SUCCESS in 11m 57s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/15570193cd2f4de3a54a9441843fde0c : SUCCESS in 5m 58s\n- octavia-tox-py39-tips https://zuul.opendev.org/t/openstack/build/f0238253319f487899cb4c1d94694652 : SUCCESS in 5m 36s\n- octavia-tox-functional-py39-tips https://zuul.opendev.org/t/openstack/build/54ed090b0e60461d84174606a3312d7d : SUCCESS in 8m 41s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/dca9767ca367456bbdd93c9b4a3df30b : SUCCESS in 4m 50s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/5f9acb272e5843b293089322800f2d34 : SUCCESS in 7m 04s\n- openstack-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/df4ac2f57fc343bc87e074409c8a66d1 : SUCCESS in 8m 27s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/485b4dd9e83742a3bb8ad23ebd0b22e3 : SUCCESS in 8m 04s (non-voting)\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/15f9b41fb62841a19491c033988ad689 : SUCCESS in 2h 09m 16s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/d4e59196fdcf47beaf40bdb55dc36d0d : SUCCESS in 1h 51m 06s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/3397565f184649a3bcef046e59b52d20 : SUCCESS in 33m 54s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/3a67cfe5bf434dbb86e3c2b92287a3f6 : SUCCESS in 38m 56s\n- octavia-v2-dsvm-tls-barbican-fips https://zuul.opendev.org/t/openstack/build/3e6ced8bddb0499ab16c3f70b9db2354 : SUCCESS in 57m 01s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/8a531ab319d74fa281891bf03974b88f : SUCCESS in 31m 32s (non-voting)\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/f0b866b2ecaa4231b4a4f15850a49ddf : SUCCESS in 1h 45m 51s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/8bc25caa3bc6401dbcf18956e6b13b60 : SUCCESS in 2h 14m 55s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/15891ada82484f9b81791c21b6a78bcf : FAILURE in 24m 28s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2 https://zuul.opendev.org/t/openstack/build/89e3103bec824f71801f37af42054855 : SUCCESS in 1h 54m 02s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2-no-jobboard https://zuul.opendev.org/t/openstack/build/21912d98ce3e4c24a89474df13ac02a9 : SUCCESS in 1h 33m 05s (non-voting)\n- octavia-v2-dsvm-scenario-centos-9-stream https://zuul.opendev.org/t/openstack/build/2967373005c447aca1a415900dbe094b : TIMED_OUT in 2h 35m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"582d5f2c43825d82517a31b7307efdaa96a73197","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2024-04-15 08:58:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"53f0ec6c748720870582ae2914160c2fed4c2d45","author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"date":"2024-04-15 09:46:42.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"197a447edd421bef96ce92d2926f6049c5d0c2e7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-15 09:47:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e860be4fe38e2a29735072aebebe4a5d85279207","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-15 12:00:47.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/75fca14bcc184a03bcd107a36d06ee4c\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f6b9ff74368c4003b4a69e8ebd139e21 : SUCCESS in 4m 52s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b5eb79b2582844ed8395cd063beaf08a : SUCCESS in 4m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8902a15032e2476ba5adaaec17e4bf8b : SUCCESS in 5m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ecebf47bea444bb9a7f482eeb664b0a8 : SUCCESS in 11m 02s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9f51855a6b404ddc8fdfddc8d612e71f : SUCCESS in 5m 06s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/b3b58865a67a44d5b52f56aec99cfe3c : SUCCESS in 4m 59s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/8b9866ce348e427387781dae42fe37bf : SUCCESS in 7m 22s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/0637d08e6816469fa8a060a6493040ff : SUCCESS in 1h 43m 24s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/69f69631c84c41de9f4239b818d09995 : SUCCESS in 1h 43m 44s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/0db8cfe173ab43eeb456d5fa4afd1771 : SUCCESS in 36m 15s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/4f9e7d81c5074ce3b4073022a522da88 : SUCCESS in 53m 10s","accounts_in_message":[],"_revision_number":1},{"id":"a3e35e3c9ff99c066a2e3802753ba998e7ad3c07","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-15 12:00:47.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"4664f2748b504591dad99c951a0c3a83a3644bb4","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-15 12:02:03.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7c7075e0ba2c4346aa9281737224234f\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/91a382feb986464d949e964863516926 : SUCCESS in 57s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/bcc3a39fe87d424d8638791975bdcc01 : SUCCESS in 51s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"944b6b1a44f3c83fccec5263189deff7fa47051d","revisions":{"944b6b1a44f3c83fccec5263189deff7fa47051d":{"kind":"REWORK","_number":1,"created":"2024-04-13 12:53:58.000000000","uploader":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"ref":"refs/changes/36/915536/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/36/915536/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/36/915536/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/36/915536/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/36/915536/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/36/915536/1"}}},"commit":{"parents":[{"commit":"dda3e4a1a764164919c634bcca523f9de69d385b","subject":"Fix the issue of losing nf_conntrace* values after a reboot.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/dda3e4a1a764164919c634bcca523f9de69d385b"}]}],"author":{"name":"Sergey Kraynev","email":"sergejyit@gmail.com","date":"2024-04-11 07:38:05.000000000","tz":240},"committer":{"name":"Sergey Kraynev","email":"sergejyit@gmail.com","date":"2024-04-13 12:53:58.000000000","tz":0},"subject":"Fix negative or 0 limit parameter in pagination","message":"Fix negative or 0 limit parameter in pagination\n\nOctavia replace \"limit\" with None when it is less 1. (for example 0, -1)\nHowever the further code failed to compare None and int values.\nThis patch fixes it by validation, that limit is None.\n\nCo-Authored-By: Roman Goncharov \u003cgadzhet007@gmail.com\u003e\n\nCloses-Bug: #2060917\nChange-Id: I9bb45a1aca6b7b18644752a3dccc3ebfb7c106ef\n(cherry picked from commit 85cfb6c2ae974d110712b5ea673cdafcfecb9e69)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/944b6b1a44f3c83fccec5263189deff7fa47051d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/944b6b1a44f3c83fccec5263189deff7fa47051d"}]},"branch":"refs/heads/stable/zed"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
