)]}'
{"id":"openstack%2Foctavia~915539","triplet_id":"openstack%2Foctavia~stable%2F2024.1~I9bb45a1aca6b7b18644752a3dccc3ebfb7c106ef","project":"openstack/octavia","branch":"stable/2024.1","attention_set":{},"removed_from_attention_set":{"6577":{"account":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"last_update":"2024-04-15 11:37:49.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9bb45a1aca6b7b18644752a3dccc3ebfb7c106ef","subject":"Fix negative or 0 limit parameter in pagination","status":"MERGED","created":"2024-04-13 12:55:38.000000000","updated":"2024-04-15 11:38:56.000000000","submitted":"2024-04-15 11:37:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"915539","cherry_pick_of_change":910464,"cherry_pick_of_patch_set":5,"meta_rev_id":"596c49e879b6bed2a95789b6b4fb2a0ca4c218cc","_number":915539,"virtual_id_number":915539,"owner":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-04-15 11:37:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"all":[{"value":2,"date":"2024-04-15 08:57:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-04-15 09:46:20.000000000","_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"all":[{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-04-15 09:46:20.000000000","_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-13 16:27:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-04-15 08:57:05.000000000","updated_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"reviewer":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"state":"REVIEWER"},{"updated":"2024-04-15 09:46:20.000000000","updated_by":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"reviewer":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"state":"REVIEWER"}],"messages":[{"id":"418e1f4df31c9169d69b562bf9ef501ef2a0c477","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"date":"2024-04-13 12:55:38.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"20097a44bbab44b77f14fead353e7ec98258ccfc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-13 16:27:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2f64300bb71046228f4a49748c6343e8\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6a376832b6dc475d9d9d122d2e3cd17c : SUCCESS in 9m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3645e316123544328002dfde55b1337d : SUCCESS in 4m 33s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e3b1b8889324456c87afa223a93aa87d : SUCCESS in 5m 05s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/b49432bb4bb646498142293773196c38 : SUCCESS in 7m 25s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ec85bdec596747b2b49b86b0cd3d35a4 : SUCCESS in 12m 01s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/813ccc9d513547b69c5018043745a3a7 : SUCCESS in 6m 00s\n- octavia-tox-py39-tips https://zuul.opendev.org/t/openstack/build/fcac3c3530ee44309c8ef1bb25ac4bff : SUCCESS in 4m 15s\n- octavia-tox-functional-py39-tips https://zuul.opendev.org/t/openstack/build/6a436adf801f43a2851c9fc7a9dde79a : SUCCESS in 10m 32s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/4c01e1d6ddb74179aaaf942f2ea29a64 : SUCCESS in 4m 41s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/b47474328fff412e922045844e66cbbd : SUCCESS in 7m 01s\n- openstack-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/d6eb20ef79db4320b4979bc9535572f1 : SUCCESS in 6m 46s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/00bd81427b4d47dbb9010b3cccad821d : SUCCESS in 5m 37s (non-voting)\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/ecd92b8ad003448aad35b33e50cab724 : SUCCESS in 1h 31m 14s\n- octavia-v2-dsvm-scenario-traffic-ops https://zuul.opendev.org/t/openstack/build/105a876482a042a28506405336bb706a : SUCCESS in 1h 47m 39s\n- octavia-v2-dsvm-scenario-non-traffic-ops https://zuul.opendev.org/t/openstack/build/6a7cbad98db046ba8433c85aa857da51 : SUCCESS in 1h 24m 09s\n- octavia-v2-dsvm-scenario-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/ae80f57f46504b1ea325bf36054f40e2 : SUCCESS in 1h 51m 40s\n- octavia-v2-dsvm-scenario-non-traffic-ops-jobboard https://zuul.opendev.org/t/openstack/build/03b0a1e6e3a443b1b4613f7765ca4bdd : SUCCESS in 1h 26m 20s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/f73f373cb6f64a73936ded2398ec7cfe : SUCCESS in 37m 04s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/2fa0a6259f6f4b8aace9f95ef1ce9f50 : SUCCESS in 57m 27s\n- octavia-grenade-skip-level https://zuul.opendev.org/t/openstack/build/1c70308be8934bbe97245e372d600d86 : SUCCESS in 48m 24s (non-voting)\n- octavia-v2-dsvm-tls-barbican-fips https://zuul.opendev.org/t/openstack/build/9189d7047dec4962b43c61dd4fd91627 : FAILURE in 16m 08s (non-voting)\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/443cd91a30e542728b90fef3b5f67ecd : SUCCESS in 42m 03s (non-voting)\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/3b47ab7fcaf04788a0ba5296f2baef6e : SUCCESS in 2h 30m 23s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/0e241c5e25b345ac9e4e4203d13fbe32 : TIMED_OUT in 3h 04m 41s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/875ec9c42eed4cfeaf5de88fb5687f86 : FAILURE in 23m 01s (non-voting)\n- octavia-v2-dsvm-scenario-centos-9-stream https://zuul.opendev.org/t/openstack/build/82e8bba674c54011a2a4748dc3c75490 : FAILURE in 11m 10s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f588bcac1e44330592fedf08a28fbd79f9beb996","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2024-04-15 08:57:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6b63477420ec441c7d1c4a71cfd9bc83b17f648a","author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"date":"2024-04-15 09:46:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5255c2efa822899debd76eb7217cf95c9c382923","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-15 09:47:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b9c54e1d8e5439311e1705d6ba32df98bd095ca0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-15 11:37:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7a99861845f54b6c9c79191d4fdb2b26\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6d0921ef6e6c4d15bb701a5e95360d1a : SUCCESS in 4m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b9b6dcda993f40218be81a24d2d0d313 : SUCCESS in 4m 34s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/9c00bf72a9534b439a90c29b9cdfdd99 : SUCCESS in 4m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3b7f199d214d4353a24302a207f97255 : SUCCESS in 12m 00s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8ab790b9da434f2fafe4d7c93815cf40 : SUCCESS in 5m 14s\n- openstack-tox-pip-check-reqs https://zuul.opendev.org/t/openstack/build/b5cfa51ceb9142749e5fee9808fe67af : SUCCESS in 5m 00s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/288ed0fce3e64303997e6c0ebb2d6f05 : SUCCESS in 8m 13s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/c0a579e0c7224901aa4fa10bc847c1ec : SUCCESS in 1h 40m 54s\n- octavia-v2-dsvm-scenario-traffic-ops https://zuul.opendev.org/t/openstack/build/167727f781fb4fafa0d1725f9636801d : SUCCESS in 1h 40m 43s\n- octavia-v2-dsvm-scenario-non-traffic-ops https://zuul.opendev.org/t/openstack/build/472e939af3ef4a08be83d9d6304088d2 : SUCCESS in 56m 02s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/ba00aa7e73aa45b6b2c8eac414fe6d41 : SUCCESS in 39m 03s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/60a48b7029924c4f89cf1d3cc0e99e58 : SUCCESS in 42m 31s","accounts_in_message":[],"_revision_number":1},{"id":"a060a32c46c3eeb2d121dcac3d798e7940deef74","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-15 11:37:49.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"596c49e879b6bed2a95789b6b4fb2a0ca4c218cc","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-15 11:38:56.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c81534f6ab6c4754a8649ec11a75ed35\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1375719efb234b33b643edb88967e8c6 : SUCCESS in 46s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4e2c73c78cc6409ab405e50ffba8ec5e : SUCCESS in 44s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1945df32d73d68489b9972e188fda8436b36fefc","revisions":{"1945df32d73d68489b9972e188fda8436b36fefc":{"kind":"REWORK","_number":1,"created":"2024-04-13 12:55:38.000000000","uploader":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"ref":"refs/changes/39/915539/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/39/915539/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/39/915539/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/39/915539/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/39/915539/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/39/915539/1"}}},"commit":{"parents":[{"commit":"894023ec95a413b5a615a8f6b8b80c69059fc7ce","subject":"Update .gitreview for stable/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/894023ec95a413b5a615a8f6b8b80c69059fc7ce"}]}],"author":{"name":"Sergey Kraynev","email":"sergejyit@gmail.com","date":"2024-04-11 07:38:05.000000000","tz":240},"committer":{"name":"Sergey Kraynev","email":"sergejyit@gmail.com","date":"2024-04-13 12:55:38.000000000","tz":0},"subject":"Fix negative or 0 limit parameter in pagination","message":"Fix negative or 0 limit parameter in pagination\n\nOctavia replace \"limit\" with None when it is less 1. (for example 0, -1)\nHowever the further code failed to compare None and int values.\nThis patch fixes it by validation, that limit is None.\n\nCo-Authored-By: Roman Goncharov \u003cgadzhet007@gmail.com\u003e\n\nCloses-Bug: #2060917\nChange-Id: I9bb45a1aca6b7b18644752a3dccc3ebfb7c106ef\n(cherry picked from commit 85cfb6c2ae974d110712b5ea673cdafcfecb9e69)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/1945df32d73d68489b9972e188fda8436b36fefc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/1945df32d73d68489b9972e188fda8436b36fefc"}]},"branch":"refs/heads/stable/2024.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}