)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7ac6bfe3ad968cdecfa3ddd459683fe70fc74df8","unresolved":true,"context_lines":[{"line_number":10,"context_line":"the autoload_with argument should be passed."},{"line_number":11,"context_line":"The fallback is added to keep the compatibility with SQLAlchemy \u003c 2.0,"},{"line_number":12,"context_line":"but it should be removed once the SQLAlchemy in upper constraints is"},{"line_number":13,"context_line":"bumped to 2.0+."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/sqlalchemy/sqlalchemy/commit/c932123bacad9bf047d160b85e3f95d396c513ae"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8706e7bd_4a0962d8","line":13,"updated":"2024-04-15 05:51:11.000000000","message":"This should not depend on *upper*-constraints. If the code no longer works with sqla\u003c2, then octavia should force sqla \u003e\u003d 2 in its own requirements.txt","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe687d1a1b4e764f8e9dcbbce5023941e3cfe5de","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the autoload_with argument should be passed."},{"line_number":11,"context_line":"The fallback is added to keep the compatibility with SQLAlchemy \u003c 2.0,"},{"line_number":12,"context_line":"but it should be removed once the SQLAlchemy in upper constraints is"},{"line_number":13,"context_line":"bumped to 2.0+."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/sqlalchemy/sqlalchemy/commit/c932123bacad9bf047d160b85e3f95d396c513ae"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"85551a20_18886e5d","line":13,"in_reply_to":"26602b20_69584864","updated":"2024-04-15 09:06:57.000000000","message":"Done","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b106837c1ab6195ed6e69d4fa0dc9e20363095d0","unresolved":true,"context_lines":[{"line_number":10,"context_line":"the autoload_with argument should be passed."},{"line_number":11,"context_line":"The fallback is added to keep the compatibility with SQLAlchemy \u003c 2.0,"},{"line_number":12,"context_line":"but it should be removed once the SQLAlchemy in upper constraints is"},{"line_number":13,"context_line":"bumped to 2.0+."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/sqlalchemy/sqlalchemy/commit/c932123bacad9bf047d160b85e3f95d396c513ae"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"26602b20_69584864","line":13,"in_reply_to":"8706e7bd_4a0962d8","updated":"2024-04-15 05:58:02.000000000","message":"Can we force sqla \u003e\u003d 2 until we bump the version in upper constraints ?","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7ac6bfe3ad968cdecfa3ddd459683fe70fc74df8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0b403a0a_d6a1842a","updated":"2024-04-15 05:51:11.000000000","message":"I wonder why this wasn\u0027t detected by the sqla-master job before, is there some coverage missing?","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b106837c1ab6195ed6e69d4fa0dc9e20363095d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c396370a_4d55b639","in_reply_to":"0b403a0a_d6a1842a","updated":"2024-04-15 05:58:02.000000000","message":"Octavia has run only unit tests It seems even functional tests do not cover db migration, though.","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c07829f06743193e335829e8d5d53c822e8f732b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7345721a_5ba0279a","updated":"2024-04-15 12:21:06.000000000","message":"recheck show_listener provisioning_status updated to an invalid state of ERROR","commit_id":"d0c29009e68a28f46b5ac962449746ca87011fa3"}],"octavia/db/migration/alembic_migrations/versions/3b199c848b96_create_no_monitor_operational_status.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"56763f40a43e2fffa48b5fc73a4a857d2c76a9cc","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        # TODO(tkajinam): Remove this once SQLAlchemy in u-c is bumped to 2.0"},{"line_number":35,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":36,"context_line":"    except TypeError:"},{"line_number":37,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload_with\u003dbind)"},{"line_number":38,"context_line":"    op.bulk_insert(md.tables[\u0027operating_status\u0027], [{\u0027name\u0027: \u0027NO_MONITOR\u0027}])"}],"source_content_type":"text/x-python","patch_set":3,"id":"d0cafa9e_07dbb898","line":37,"updated":"2024-04-15 08:30:34.000000000","message":"You should be able to just use this. `autoload_with` is the replacement for `autoload`.","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6a9223ad720afd14da227cd341309ff2e7b014bc","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        # TODO(tkajinam): Remove this once SQLAlchemy in u-c is bumped to 2.0"},{"line_number":35,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":36,"context_line":"    except TypeError:"},{"line_number":37,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload_with\u003dbind)"},{"line_number":38,"context_line":"    op.bulk_insert(md.tables[\u0027operating_status\u0027], [{\u0027name\u0027: \u0027NO_MONITOR\u0027}])"}],"source_content_type":"text/x-python","patch_set":3,"id":"468f6871_caa44337","line":37,"in_reply_to":"1b2460c5_8e5cb768","updated":"2024-04-15 09:02:49.000000000","message":"OK I overlooked this line.\n\nhttps://github.com/sqlalchemy/sqlalchemy/blob/rel_1_4/lib/sqlalchemy/sql/schema.py#L660\n\nLet me update the patch","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe687d1a1b4e764f8e9dcbbce5023941e3cfe5de","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # TODO(tkajinam): Remove this once SQLAlchemy in u-c is bumped to 2.0"},{"line_number":35,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":36,"context_line":"    except TypeError:"},{"line_number":37,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload_with\u003dbind)"},{"line_number":38,"context_line":"    op.bulk_insert(md.tables[\u0027operating_status\u0027], [{\u0027name\u0027: \u0027NO_MONITOR\u0027}])"}],"source_content_type":"text/x-python","patch_set":3,"id":"0ac49fdd_ec543f95","line":37,"in_reply_to":"468f6871_caa44337","updated":"2024-04-15 09:06:57.000000000","message":"Done","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7215121d6d6e9956abfb65702c48364ca4e5e644","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        # TODO(tkajinam): Remove this once SQLAlchemy in u-c is bumped to 2.0"},{"line_number":35,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":36,"context_line":"    except TypeError:"},{"line_number":37,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload_with\u003dbind)"},{"line_number":38,"context_line":"    op.bulk_insert(md.tables[\u0027operating_status\u0027], [{\u0027name\u0027: \u0027NO_MONITOR\u0027}])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1b2460c5_8e5cb768","line":37,"in_reply_to":"953169b4_c2c3d4dd","updated":"2024-04-15 09:01:11.000000000","message":"Ah yeah, the docs say:\n\n\u003e autoload –\n\u003e\n\u003e Defaults to `False`, unless `Table.autoload_with` is set in which case it defaults to `True`; ...","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d88c81684d14a811f0f5c6f55c079fd9d241bf49","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        # TODO(tkajinam): Remove this once SQLAlchemy in u-c is bumped to 2.0"},{"line_number":35,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":36,"context_line":"    except TypeError:"},{"line_number":37,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload_with\u003dbind)"},{"line_number":38,"context_line":"    op.bulk_insert(md.tables[\u0027operating_status\u0027], [{\u0027name\u0027: \u0027NO_MONITOR\u0027}])"}],"source_content_type":"text/x-python","patch_set":3,"id":"953169b4_c2c3d4dd","line":37,"in_reply_to":"c6716765_ad5aa14c","updated":"2024-04-15 08:59:25.000000000","message":"I haven\u0027t looked at the code, but the docs calls it out as a near-direct replacement https://docs.sqlalchemy.org/en/14/core/metadata.html#sqlalchemy.schema.Table.params.autoload Certainly I\u0027ve just done 1:1 replacements in other projects and things have \"just worked(TM)\"","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ef64684202286c7b7d56e7d8130ab9a5e3f5064","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        # TODO(tkajinam): Remove this once SQLAlchemy in u-c is bumped to 2.0"},{"line_number":35,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":36,"context_line":"    except TypeError:"},{"line_number":37,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload_with\u003dbind)"},{"line_number":38,"context_line":"    op.bulk_insert(md.tables[\u0027operating_status\u0027], [{\u0027name\u0027: \u0027NO_MONITOR\u0027}])"}],"source_content_type":"text/x-python","patch_set":3,"id":"c6716765_ad5aa14c","line":37,"in_reply_to":"d0cafa9e_07dbb898","updated":"2024-04-15 08:41:41.000000000","message":"But doesn\u0027t it break sqlalchemy 1.4 ? I checked the sqlalchemy 1.4 code but it doesn\u0027t enable autoload only with autoload_with, IIUC.","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"}],"octavia/db/migration/alembic_migrations/versions/4aeb9e23ad43_add_draining_operating_status.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"56763f40a43e2fffa48b5fc73a4a857d2c76a9cc","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        # TODO(tkajinam): Remove this once SQLAlchemy in u-c is bumped to 2.0"},{"line_number":35,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":36,"context_line":"    except TypeError:"},{"line_number":37,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload_with\u003dbind)"},{"line_number":38,"context_line":"    op.bulk_insert(md.tables[\u0027operating_status\u0027], [{\u0027name\u0027: \u0027DRAINING\u0027}])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fe2105a_f72da942","line":37,"updated":"2024-04-15 08:30:34.000000000","message":"Ditto. We just need this.","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe687d1a1b4e764f8e9dcbbce5023941e3cfe5de","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # TODO(tkajinam): Remove this once SQLAlchemy in u-c is bumped to 2.0"},{"line_number":35,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":36,"context_line":"    except TypeError:"},{"line_number":37,"context_line":"        sa.Table(\u0027operating_status\u0027, md, autoload_with\u003dbind)"},{"line_number":38,"context_line":"    op.bulk_insert(md.tables[\u0027operating_status\u0027], [{\u0027name\u0027: \u0027DRAINING\u0027}])"}],"source_content_type":"text/x-python","patch_set":3,"id":"fc3ea0b2_3c46bd22","line":37,"in_reply_to":"3fe2105a_f72da942","updated":"2024-04-15 09:06:57.000000000","message":"Done","commit_id":"c3aa6363d7f5eabcdb0601bbb85d69c0ff9e9d91"}]}