)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"8adfe919f36a83c7ae28ca598780fba38dee3b03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ead1d3fb_555459d3","updated":"2024-05-14 11:31:15.000000000","message":"I think we should call `check_output(text\u003dTrue)` as it would read the process output as Python string already.","commit_id":"b6bd1e88a4cb170e46e8a0abba0b07f869c699d5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3583001f22b3630bbcb5b77562fc35604e218ce5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"acaadde2_394a2a4c","updated":"2024-05-05 05:51:34.000000000","message":"recheck requirements-check has been fixed.","commit_id":"b6bd1e88a4cb170e46e8a0abba0b07f869c699d5"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"ae6654ae935253271fc2c05cc443267b88c4fd0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6e9c26c9_32bcf911","updated":"2024-05-21 08:36:43.000000000","message":"Thanks.","commit_id":"42bfac519b6d753b1b49c5749e7a9c69ddb7622a"}],"octavia/amphorae/backends/agent/api_server/amphora_info.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0216dbef56a7cdfc5b20e7164781adf8712e6cef","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    def _get_version_of_installed_package(self, name):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        cmd \u003d self._osutils.cmd_get_version_of_installed_package(name)"},{"line_number":108,"context_line":"        version \u003d subprocess.check_output(cmd.split())"},{"line_number":109,"context_line":"        return version.decode(\u0027utf-8\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _count_haproxy_processes(self, lb_list):"}],"source_content_type":"text/x-python","patch_set":7,"id":"561a49fe_35a2fbac","line":108,"range":{"start_line":108,"start_character":29,"end_line":108,"end_character":54},"updated":"2024-05-14 11:27:00.000000000","message":"I\u0027d prefer to call with `text\u003dTrue` here. It was added in Python 3.7, so it seems we can use it. Then version becomes a string already.","commit_id":"b6bd1e88a4cb170e46e8a0abba0b07f869c699d5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9098205bcf8e27ad644cad1a04f6ab6916290d37","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def _get_version_of_installed_package(self, name):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        cmd \u003d self._osutils.cmd_get_version_of_installed_package(name)"},{"line_number":108,"context_line":"        version \u003d subprocess.check_output(cmd.split())"},{"line_number":109,"context_line":"        return version.decode(\u0027utf-8\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _count_haproxy_processes(self, lb_list):"}],"source_content_type":"text/x-python","patch_set":7,"id":"d04b43de_79709dd0","line":108,"range":{"start_line":108,"start_character":29,"end_line":108,"end_character":54},"in_reply_to":"561a49fe_35a2fbac","updated":"2024-05-14 14:05:22.000000000","message":"That\u0027s a good idea. According to the python doc, I think we can use encoding\u003d\u0027utf-8\u0027 instead to use the specific encoding (I suspect the default is ascii).","commit_id":"b6bd1e88a4cb170e46e8a0abba0b07f869c699d5"}],"octavia/amphorae/backends/agent/api_server/osutils.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0216dbef56a7cdfc5b20e7164781adf8712e6cef","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            raise exceptions.HTTPException("},{"line_number":99,"context_line":"                response\u003dwebob.Response(json\u003d{"},{"line_number":100,"context_line":"                    \u0027message\u0027: f\u0027Error plugging {name}\u0027,"},{"line_number":101,"context_line":"                    \u0027details\u0027: (None if e.output is None"},{"line_number":102,"context_line":"                                else e.output.decode(\u0027utf-8\u0027))"},{"line_number":103,"context_line":"                }, status\u003d500)"},{"line_number":104,"context_line":"            )"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"904c6bdd_ffeda19f","line":102,"range":{"start_line":101,"start_character":31,"end_line":102,"end_character":62},"updated":"2024-05-14 11:27:00.000000000","message":"Nit: I think we don\u0027t need this line change if we use `text\u003dTrue` in line 92. However, then we need to remove the `.decode(\u0027utf-8\u0027)` call in line 93.","commit_id":"b6bd1e88a4cb170e46e8a0abba0b07f869c699d5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9098205bcf8e27ad644cad1a04f6ab6916290d37","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            raise exceptions.HTTPException("},{"line_number":99,"context_line":"                response\u003dwebob.Response(json\u003d{"},{"line_number":100,"context_line":"                    \u0027message\u0027: f\u0027Error plugging {name}\u0027,"},{"line_number":101,"context_line":"                    \u0027details\u0027: (None if e.output is None"},{"line_number":102,"context_line":"                                else e.output.decode(\u0027utf-8\u0027))"},{"line_number":103,"context_line":"                }, status\u003d500)"},{"line_number":104,"context_line":"            )"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7425f315_9c12637c","line":102,"range":{"start_line":101,"start_character":31,"end_line":102,"end_character":62},"in_reply_to":"904c6bdd_ffeda19f","updated":"2024-05-14 14:05:22.000000000","message":"Done","commit_id":"b6bd1e88a4cb170e46e8a0abba0b07f869c699d5"}]}