)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f484e346753dad12628a3447a294df952248b489","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"039889a4_39737773","updated":"2025-02-19 01:19:59.000000000","message":"Two minor comments","commit_id":"3fc7f5e7260d73b750d068880651d872a9e73d51"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4e8e64abd99decc72a05e1b7fe004fe6045e09e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"aae7529d_ab211d90","updated":"2025-02-19 01:05:56.000000000","message":"recheck\nI want fresh logs","commit_id":"3fc7f5e7260d73b750d068880651d872a9e73d51"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f89f4725b55b1d21ee5f41e0ca18fc6ca9d63fe2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"82156ef2_6f0fbe9f","updated":"2025-02-19 18:37:58.000000000","message":"LGTM","commit_id":"0e440c9e7b79c45959e1d857ea7077922b0a0237"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"716b375832b4771b42cc67ab1e8fad07139aa8b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e621b6f3_58da2bfe","updated":"2025-02-26 13:06:06.000000000","message":"recheck doc job disabled","commit_id":"0e440c9e7b79c45959e1d857ea7077922b0a0237"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"f6436cfdb1d31d0eb6e9fcaa89802461c5085507","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"cd89ee08_64a93fd7","updated":"2025-02-24 13:09:47.000000000","message":"recheck not sure why grenade failed","commit_id":"0e440c9e7b79c45959e1d857ea7077922b0a0237"}],"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f484e346753dad12628a3447a294df952248b489","unresolved":true,"context_lines":[{"line_number":425,"context_line":"            return sec_grp.get(constants.ID)"},{"line_number":426,"context_line":"        return None"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def update_aap_port_sg(self,"},{"line_number":429,"context_line":"                           load_balancer: data_models.LoadBalancer,"},{"line_number":430,"context_line":"                           amphora: data_models.Amphora,"},{"line_number":431,"context_line":"                           vip: data_models.Vip):"}],"source_content_type":"text/x-python","patch_set":9,"id":"aba1cd73_168adaf9","line":428,"updated":"2025-02-19 01:19:59.000000000","message":"This new method does not have unit test coverage.","commit_id":"3fc7f5e7260d73b750d068880651d872a9e73d51"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"716b375832b4771b42cc67ab1e8fad07139aa8b7","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            return sec_grp.get(constants.ID)"},{"line_number":426,"context_line":"        return None"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def update_aap_port_sg(self,"},{"line_number":429,"context_line":"                           load_balancer: data_models.LoadBalancer,"},{"line_number":430,"context_line":"                           amphora: data_models.Amphora,"},{"line_number":431,"context_line":"                           vip: data_models.Vip):"}],"source_content_type":"text/x-python","patch_set":9,"id":"8702f158_9b0a1758","line":428,"in_reply_to":"aba1cd73_168adaf9","updated":"2025-02-26 13:06:06.000000000","message":"Done","commit_id":"3fc7f5e7260d73b750d068880651d872a9e73d51"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"12c7eaa42a9043bd0523e416e99c94cb359cbbcd","unresolved":true,"context_lines":[{"line_number":431,"context_line":"                           vip: data_models.Vip):"},{"line_number":432,"context_line":"        if self.sec_grp_enabled:"},{"line_number":433,"context_line":"            sec_grp \u003d self._get_lb_security_group(load_balancer.id)"},{"line_number":434,"context_line":"            if not sec_grp:"},{"line_number":435,"context_line":"                return"},{"line_number":436,"context_line":"            self._add_vip_security_group_to_port(load_balancer.id,"},{"line_number":437,"context_line":"                                                 amphora.vrrp_port_id,"},{"line_number":438,"context_line":"                                                 sec_grp.get(constants.ID),"}],"source_content_type":"text/x-python","patch_set":9,"id":"8b1243b1_1d582b4e","line":435,"range":{"start_line":434,"start_character":12,"end_line":435,"end_character":22},"updated":"2025-02-05 11:35:25.000000000","message":"you can leave it like this. However, I wonder why you don\u0027t do `if sec_grp` and get rid of the explicit return here.","commit_id":"3fc7f5e7260d73b750d068880651d872a9e73d51"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"716b375832b4771b42cc67ab1e8fad07139aa8b7","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                           vip: data_models.Vip):"},{"line_number":432,"context_line":"        if self.sec_grp_enabled:"},{"line_number":433,"context_line":"            sec_grp \u003d self._get_lb_security_group(load_balancer.id)"},{"line_number":434,"context_line":"            if not sec_grp:"},{"line_number":435,"context_line":"                return"},{"line_number":436,"context_line":"            self._add_vip_security_group_to_port(load_balancer.id,"},{"line_number":437,"context_line":"                                                 amphora.vrrp_port_id,"},{"line_number":438,"context_line":"                                                 sec_grp.get(constants.ID),"}],"source_content_type":"text/x-python","patch_set":9,"id":"afd64c04_287bb4cf","line":435,"range":{"start_line":434,"start_character":12,"end_line":435,"end_character":22},"in_reply_to":"8b1243b1_1d582b4e","updated":"2025-02-26 13:06:06.000000000","message":"Done","commit_id":"3fc7f5e7260d73b750d068880651d872a9e73d51"}],"releasenotes/notes/add_vip_sg_ids_amphora_driver-8b8078aa674ff60a.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f484e346753dad12628a3447a294df952248b489","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add the vip_sg_ids parameter to the Amphora driver, a list of Neutron"},{"line_number":5,"context_line":"    Security Groups. When set, the Amphora driver applies the Security Groups to"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa324b2c_d5440fda","line":2,"updated":"2025-02-19 01:19:59.000000000","message":"We should have a note here pointing out that this feature will not work with SR-IOV ports as neutron does not support security groups on SR-IOV ports.","commit_id":"3fc7f5e7260d73b750d068880651d872a9e73d51"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"716b375832b4771b42cc67ab1e8fad07139aa8b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add the vip_sg_ids parameter to the Amphora driver, a list of Neutron"},{"line_number":5,"context_line":"    Security Groups. When set, the Amphora driver applies the Security Groups to"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dd5a2533_3ad6f6bf","line":2,"in_reply_to":"fa324b2c_d5440fda","updated":"2025-02-26 13:06:06.000000000","message":"Done","commit_id":"3fc7f5e7260d73b750d068880651d872a9e73d51"}]}