)]}'
{"octavia/amphorae/backends/agent/api_server/keepalivedlvs.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"14fff2e9083cb4de52b4a058606f3a7e0f47798c","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            util.run_systemctl_command("},{"line_number":125,"context_line":"                consts.ENABLE,"},{"line_number":126,"context_line":"                consts.KEEPALIVEDLVS_SYSTEMD % str(listener_id),"},{"line_number":127,"context_line":"                raise_error\u003dTrue)"},{"line_number":128,"context_line":"        except subprocess.CalledProcessError as e:"},{"line_number":129,"context_line":"            return webob.Response(json\u003d{"}],"source_content_type":"text/x-python","patch_set":8,"id":"a4a22007_8c73b046","line":126,"range":{"start_line":126,"start_character":47,"end_line":126,"end_character":63},"updated":"2024-06-11 09:49:56.000000000","message":"Nit, that explicit `str()` is redundant. The `%s` in the constant does that already.","commit_id":"f41c6d19b232bf63e2619fee66827ff4a46e0951"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7114c90ce2cacffb36e976e30b959985ff31bce3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            util.run_systemctl_command("},{"line_number":125,"context_line":"                consts.ENABLE,"},{"line_number":126,"context_line":"                consts.KEEPALIVEDLVS_SYSTEMD % str(listener_id),"},{"line_number":127,"context_line":"                raise_error\u003dTrue)"},{"line_number":128,"context_line":"        except subprocess.CalledProcessError as e:"},{"line_number":129,"context_line":"            return webob.Response(json\u003d{"}],"source_content_type":"text/x-python","patch_set":8,"id":"a40289d4_bb5986bd","line":126,"range":{"start_line":126,"start_character":47,"end_line":126,"end_character":63},"in_reply_to":"a4a22007_8c73b046","updated":"2024-06-11 10:00:55.000000000","message":"Done","commit_id":"f41c6d19b232bf63e2619fee66827ff4a46e0951"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"14fff2e9083cb4de52b4a058606f3a7e0f47798c","unresolved":true,"context_lines":[{"line_number":287,"context_line":"            return webob.Response(json\u003d{"},{"line_number":288,"context_line":"                \u0027message\u0027: ("},{"line_number":289,"context_line":"                    \"Error disabling octavia-keepalivedlvs-\""},{"line_number":290,"context_line":"                    \"{} service\".format(listener_id)),"},{"line_number":291,"context_line":"                \u0027details\u0027: e.output}, status\u003d500)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        # delete init script ,config file and log file for that listener"}],"source_content_type":"text/x-python","patch_set":8,"id":"d44bd680_df3ca128","line":290,"updated":"2024-06-11 09:49:56.000000000","message":"We want to get away from \"\".format(), so please use a f-string instead.","commit_id":"f41c6d19b232bf63e2619fee66827ff4a46e0951"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7114c90ce2cacffb36e976e30b959985ff31bce3","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            return webob.Response(json\u003d{"},{"line_number":288,"context_line":"                \u0027message\u0027: ("},{"line_number":289,"context_line":"                    \"Error disabling octavia-keepalivedlvs-\""},{"line_number":290,"context_line":"                    \"{} service\".format(listener_id)),"},{"line_number":291,"context_line":"                \u0027details\u0027: e.output}, status\u003d500)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        # delete init script ,config file and log file for that listener"}],"source_content_type":"text/x-python","patch_set":8,"id":"5102758d_b1af4ba7","line":290,"in_reply_to":"d44bd680_df3ca128","updated":"2024-06-11 10:00:55.000000000","message":"Done","commit_id":"f41c6d19b232bf63e2619fee66827ff4a46e0951"}],"octavia/amphorae/backends/agent/api_server/util.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"14fff2e9083cb4de52b4a058606f3a7e0f47798c","unresolved":true,"context_lines":[{"line_number":219,"context_line":"            text_file.write(text)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"def run_systemctl_command(command, service, raise_error\u003dFalse):"},{"line_number":223,"context_line":"    cmd \u003d f\"systemctl {command} {service}\""},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT,"}],"source_content_type":"text/x-python","patch_set":8,"id":"737f8a71_f4989f9a","line":222,"range":{"start_line":222,"start_character":44,"end_line":222,"end_character":61},"updated":"2024-06-11 09:49:56.000000000","message":"I like the idea that it re-raises errors now, but I would change the default to `True` because that is what should be used in most cases IMO.","commit_id":"f41c6d19b232bf63e2619fee66827ff4a46e0951"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7114c90ce2cacffb36e976e30b959985ff31bce3","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            text_file.write(text)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"def run_systemctl_command(command, service, raise_error\u003dFalse):"},{"line_number":223,"context_line":"    cmd \u003d f\"systemctl {command} {service}\""},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT,"}],"source_content_type":"text/x-python","patch_set":8,"id":"c2b75965_a2ff8b9d","line":222,"range":{"start_line":222,"start_character":44,"end_line":222,"end_character":61},"in_reply_to":"737f8a71_f4989f9a","updated":"2024-06-11 10:00:55.000000000","message":"Done. We probably have to handle erorrs which are currently ignored but I\u0027d leave it now. We can probably address these in follow-up.","commit_id":"f41c6d19b232bf63e2619fee66827ff4a46e0951"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6943a2cd92046d2d844810c55c767456c9a6452c","unresolved":true,"context_lines":[{"line_number":225,"context_line":"        subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT,"},{"line_number":226,"context_line":"                                encoding\u003d\u0027utf-8\u0027)"},{"line_number":227,"context_line":"    except subprocess.CalledProcessError as e:"},{"line_number":228,"context_line":"        LOG.debug(\"Failed to %(cmd)s %(srvc)s service: \""},{"line_number":229,"context_line":"                  \"%(err)s %(out)s\", {\u0027cmd\u0027: command, \u0027srvc\u0027: service,"},{"line_number":230,"context_line":"                                      \u0027err\u0027: e, \u0027out\u0027: e.output})"},{"line_number":231,"context_line":"        if raise_error:"}],"source_content_type":"text/x-python","patch_set":10,"id":"c5165d7a_8a22eafa","line":228,"range":{"start_line":228,"start_character":12,"end_line":228,"end_character":17},"updated":"2024-08-13 06:31:34.000000000","message":"I\u0027m wondering if we shouldn\u0027t keep the error level here","commit_id":"991e0da01e315a7ac91f7bd654ba188757c79008"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"09edbe2c18cc105f79243223d0f70290c201717c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT,"},{"line_number":226,"context_line":"                                encoding\u003d\u0027utf-8\u0027)"},{"line_number":227,"context_line":"    except subprocess.CalledProcessError as e:"},{"line_number":228,"context_line":"        LOG.debug(\"Failed to %(cmd)s %(srvc)s service: \""},{"line_number":229,"context_line":"                  \"%(err)s %(out)s\", {\u0027cmd\u0027: command, \u0027srvc\u0027: service,"},{"line_number":230,"context_line":"                                      \u0027err\u0027: e, \u0027out\u0027: e.output})"},{"line_number":231,"context_line":"        if raise_error:"}],"source_content_type":"text/x-python","patch_set":10,"id":"86d5de4b_fed65f39","line":228,"range":{"start_line":228,"start_character":12,"end_line":228,"end_character":17},"in_reply_to":"a684723f_76ecf6e5","updated":"2024-08-13 15:34:19.000000000","message":"ack, thanks for the clarification","commit_id":"991e0da01e315a7ac91f7bd654ba188757c79008"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3f39e09138ef93a3e1f90165cc178d91bb26611b","unresolved":true,"context_lines":[{"line_number":225,"context_line":"        subprocess.check_output(cmd.split(), stderr\u003dsubprocess.STDOUT,"},{"line_number":226,"context_line":"                                encoding\u003d\u0027utf-8\u0027)"},{"line_number":227,"context_line":"    except subprocess.CalledProcessError as e:"},{"line_number":228,"context_line":"        LOG.debug(\"Failed to %(cmd)s %(srvc)s service: \""},{"line_number":229,"context_line":"                  \"%(err)s %(out)s\", {\u0027cmd\u0027: command, \u0027srvc\u0027: service,"},{"line_number":230,"context_line":"                                      \u0027err\u0027: e, \u0027out\u0027: e.output})"},{"line_number":231,"context_line":"        if raise_error:"}],"source_content_type":"text/x-python","patch_set":10,"id":"a684723f_76ecf6e5","line":228,"range":{"start_line":228,"start_character":12,"end_line":228,"end_character":17},"in_reply_to":"c5165d7a_8a22eafa","updated":"2024-08-13 09:43:11.000000000","message":"When raise_error is True then the exception is re-raised so the equivalent error log (or probably traceback log) is generated by logic in an upper layer.\n\nWhen raise_error is False then the error can be ignored and we don\u0027t require immediate action from operators. So debug level should be enough.","commit_id":"991e0da01e315a7ac91f7bd654ba188757c79008"}]}