)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3538e67e0617c3a59d3ad1ba22504ea88e2f8d84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b735c414_125c41c5","updated":"2024-07-16 16:04:29.000000000","message":"I have just tested the patch and it works for me, thanks!","commit_id":"1c027c840c57c425519542218898fd2d33fda064"}],"devstack/plugin.sh":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2402241457df30eb49f8cbaec61fb5fc10092269","unresolved":true,"context_lines":[{"line_number":18,"context_line":"        if ! [ \"$DISABLE_AMP_IMAGE_BUILD\" \u003d\u003d \u0027True\u0027 ]; then"},{"line_number":19,"context_line":"            if [[ ${DISTRO} \u003d~ (rhel|centos) ]]; then"},{"line_number":20,"context_line":"                install_package qemu-kvm"},{"line_number":21,"context_line":"                if [[ \"$OCTAVIA_AMP_BASE_OS\" \u003d\u003d \"rocky\" ]]; then"},{"line_number":22,"context_line":"                    # DIB requires podman for building rockylinux images."},{"line_number":23,"context_line":"                    install_package podman"},{"line_number":24,"context_line":"                fi"},{"line_number":25,"context_line":"            else"},{"line_number":26,"context_line":"                install_package qemu"},{"line_number":27,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"a98dbbf1_c97a6fcb","side":"PARENT","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":18},"updated":"2024-07-09 20:35:06.000000000","message":"I think we should keep this part that is specific to the rockylinux image","commit_id":"7974e755e18bed376ea5b1bce2a927eeb34494b2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"936a861d7fca92251ca2590f368add713105ad66","unresolved":true,"context_lines":[{"line_number":18,"context_line":"        if ! [ \"$DISABLE_AMP_IMAGE_BUILD\" \u003d\u003d \u0027True\u0027 ]; then"},{"line_number":19,"context_line":"            if [[ ${DISTRO} \u003d~ (rhel|centos) ]]; then"},{"line_number":20,"context_line":"                install_package qemu-kvm"},{"line_number":21,"context_line":"                if [[ \"$OCTAVIA_AMP_BASE_OS\" \u003d\u003d \"rocky\" ]]; then"},{"line_number":22,"context_line":"                    # DIB requires podman for building rockylinux images."},{"line_number":23,"context_line":"                    install_package podman"},{"line_number":24,"context_line":"                fi"},{"line_number":25,"context_line":"            else"},{"line_number":26,"context_line":"                install_package qemu"},{"line_number":27,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"cc1d0a4d_d2ef147b","side":"PARENT","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":18},"in_reply_to":"a98dbbf1_c97a6fcb","updated":"2024-07-09 23:11:18.000000000","message":"If diskimage-builder needs it, it should declare it in it\u0027s bindep.txt\n\nhttps://github.com/openstack/diskimage-builder/blob/master/bindep.txt","commit_id":"7974e755e18bed376ea5b1bce2a927eeb34494b2"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0ed2f85f034651e91d8d51a1016c8f34ce6ea2e3","unresolved":true,"context_lines":[{"line_number":18,"context_line":"        if ! [ \"$DISABLE_AMP_IMAGE_BUILD\" \u003d\u003d \u0027True\u0027 ]; then"},{"line_number":19,"context_line":"            if [[ ${DISTRO} \u003d~ (rhel|centos) ]]; then"},{"line_number":20,"context_line":"                install_package qemu-kvm"},{"line_number":21,"context_line":"                if [[ \"$OCTAVIA_AMP_BASE_OS\" \u003d\u003d \"rocky\" ]]; then"},{"line_number":22,"context_line":"                    # DIB requires podman for building rockylinux images."},{"line_number":23,"context_line":"                    install_package podman"},{"line_number":24,"context_line":"                fi"},{"line_number":25,"context_line":"            else"},{"line_number":26,"context_line":"                install_package qemu"},{"line_number":27,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"f6641934_a91c4267","side":"PARENT","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":18},"in_reply_to":"cc1d0a4d_d2ef147b","updated":"2024-07-10 06:33:13.000000000","message":"I just proposed https://review.opendev.org/c/openstack/diskimage-builder/+/923815","commit_id":"7974e755e18bed376ea5b1bce2a927eeb34494b2"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4ace82e06fdec87d2ece052a50b857f99c6ed43c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        if ! [ \"$DISABLE_AMP_IMAGE_BUILD\" \u003d\u003d \u0027True\u0027 ]; then"},{"line_number":19,"context_line":"            if [[ ${DISTRO} \u003d~ (rhel|centos) ]]; then"},{"line_number":20,"context_line":"                install_package qemu-kvm"},{"line_number":21,"context_line":"                if [[ \"$OCTAVIA_AMP_BASE_OS\" \u003d\u003d \"rocky\" ]]; then"},{"line_number":22,"context_line":"                    # DIB requires podman for building rockylinux images."},{"line_number":23,"context_line":"                    install_package podman"},{"line_number":24,"context_line":"                fi"},{"line_number":25,"context_line":"            else"},{"line_number":26,"context_line":"                install_package qemu"},{"line_number":27,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"be3cb5b0_09e40a3c","side":"PARENT","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":18},"in_reply_to":"f6641934_a91c4267","updated":"2024-07-11 17:06:13.000000000","message":"Excellent, thank you!","commit_id":"7974e755e18bed376ea5b1bce2a927eeb34494b2"}]}
